svn commit: r1198623 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/valves/RequestFilterValve.java java/org/apache/catalina/valves/mbeans-descriptors.xml webapps/docs/changelog.xml

2011-11-06 Thread kkolinko
Author: kkolinko Date: Mon Nov 7 04:54:38 2011 New Revision: 1198623 URL: http://svn.apache.org/viewvc?rev=1198623&view=rev Log: Merged revision 1198622 from tomcat/trunk: RequestFilterValve (RemoteAddrValve, RemoteHostValve): - Refactor process() method separating value testing logic into a new

svn commit: r1198622 - in /tomcat/trunk/java/org/apache/catalina/valves: RequestFilterValve.java mbeans-descriptors.xml

2011-11-06 Thread kkolinko
Author: kkolinko Date: Mon Nov 7 04:42:42 2011 New Revision: 1198622 URL: http://svn.apache.org/viewvc?rev=1198622&view=rev Log: RequestFilterValve (RemoteAddrValve, RemoteHostValve): - Refactor process() method separating value testing logic into a new method, isAllowed(String) - Expose isAllow

svn commit: r1198609 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-11-06 Thread kkolinko
Author: kkolinko Date: Mon Nov 7 02:51:25 2011 New Revision: 1198609 URL: http://svn.apache.org/viewvc?rev=1198609&view=rev Log: proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?re

DO NOT REPLY [Bug 52121] corrupt gzip output when compression=on in server.xml

2011-11-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52121 --- Comment #9 from Konstantin Kolinko 2011-11-07 02:45:47 UTC --- Created attachment 27905 --> https://issues.apache.org/bugzilla/attachment.cgi?id=27905 2011-11-07_tc6_FlushableGZIPOutputStream.patch Patch for Tomcat 6.0 -- Configur

svn commit: r1198608 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/http11/filters/FlushableGZIPOutputStream.java

2011-11-06 Thread kkolinko
Author: kkolinko Date: Mon Nov 7 02:43:00 2011 New Revision: 1198608 URL: http://svn.apache.org/viewvc?rev=1198608&view=rev Log: Merged revision 1198607 from tomcat/trunk: Add synchronization to close() Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apac

svn commit: r1198607 - /tomcat/trunk/java/org/apache/coyote/http11/filters/FlushableGZIPOutputStream.java

2011-11-06 Thread kkolinko
Author: kkolinko Date: Mon Nov 7 02:40:26 2011 New Revision: 1198607 URL: http://svn.apache.org/viewvc?rev=1198607&view=rev Log: Add synchronization to close() Modified: tomcat/trunk/java/org/apache/coyote/http11/filters/FlushableGZIPOutputStream.java Modified: tomcat/trunk/java/org/apach

svn commit: r1198605 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/http11/filters/FlushableGZIPOutputStream.java

2011-11-06 Thread kkolinko
Author: kkolinko Date: Mon Nov 7 02:30:43 2011 New Revision: 1198605 URL: http://svn.apache.org/viewvc?rev=1198605&view=rev Log: Merged revision 1198604 from tomcat/trunk: Remove synchronization from write(byte[]), because it is not needed there, as write(byte[],int,int) that it delegates to is s

svn commit: r1198604 - /tomcat/trunk/java/org/apache/coyote/http11/filters/FlushableGZIPOutputStream.java

2011-11-06 Thread kkolinko
Author: kkolinko Date: Mon Nov 7 02:29:19 2011 New Revision: 1198604 URL: http://svn.apache.org/viewvc?rev=1198604&view=rev Log: Remove synchronization from write(byte[]), because it is not needed there, as write(byte[],int,int) that it delegates to is synchronized. Modified: tomcat/trunk/j

svn commit: r1198603 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/http11/filters/FlushableGZIPOutputStream.java test/org/apache/coyote/http11/filters/TestFlushableGZIPOutputStream.java webapp

2011-11-06 Thread kkolinko
Author: kkolinko Date: Mon Nov 7 02:22:06 2011 New Revision: 1198603 URL: http://svn.apache.org/viewvc?rev=1198603&view=rev Log: Merged revision 1198602 from tomcat/trunk: Add test for FlushableGZIPOutputStream.write(int). Remove unneeded &0xff in int->byte conversion from the method. According t

svn commit: r1198602 - in /tomcat/trunk: java/org/apache/coyote/http11/filters/FlushableGZIPOutputStream.java test/org/apache/coyote/http11/filters/TestFlushableGZIPOutputStream.java

2011-11-06 Thread kkolinko
Author: kkolinko Date: Mon Nov 7 02:16:17 2011 New Revision: 1198602 URL: http://svn.apache.org/viewvc?rev=1198602&view=rev Log: Add test for FlushableGZIPOutputStream.write(int). Remove unneeded &0xff in int->byte conversion from the method. According to JLS 3rd ed ch.5.1.3, narrowing of int to

[jira] [Commented] (MTOMCAT-100) support war overlay to add war external dependencies in tomcat run

2011-11-06 Thread Olivier Lamy (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145153#comment-13145153 ] Olivier Lamy commented on MTOMCAT-100: -- http://svn.apache.org/viewvc?view=revision&r

svn commit: r1198575 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/tribes/group/TestGroupChannelSenderConnections.java webapps/docs/changelog.xml

2011-11-06 Thread kkolinko
Author: kkolinko Date: Sun Nov 6 21:51:58 2011 New Revision: 1198575 URL: http://svn.apache.org/viewvc?rev=1198575&view=rev Log: Merged revisions r1197263 r1197305 from tomcat/trunk: Clean up code and use logging framework instead of System.out. Remove 15s wait after each test. I do not understan

svn commit: r1198572 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/startup/LoggingBaseTest.java test/org/apache/catalina/startup/TomcatBaseTest.java webapps/docs/changelog.xml

2011-11-06 Thread kkolinko
Author: kkolinko Date: Sun Nov 6 21:43:45 2011 New Revision: 1198572 URL: http://svn.apache.org/viewvc?rev=1198572&view=rev Log: Merged revision 1197261 from tomcat/trunk: Introduce a new class LoggingBaseTest and move the following features from TomcatBaseTest there: setting up logging, creatin

DO NOT REPLY [Bug 52138] global web.xml servlet-mappings are not used when additional mappings are defined in app web.xml

2011-11-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52138 Konstantin Kolinko changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|

DO NOT REPLY [Bug 52138] global web.xml servlet-mappings are not used when additional mappings are defined in app web.xml

2011-11-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52138 James DeFelice changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVAL

svn commit: r1198569 - in /tomcat/tc7.0.x/trunk: ./ test/webapp-2.3/WEB-INF/ test/webapp-2.4/WEB-INF/ test/webapp-2.5/WEB-INF/ test/webapp-3.0-fragments/WEB-INF/ test/webapp-3.0-servletsecurity/WEB-IN

2011-11-06 Thread kkolinko
Author: kkolinko Date: Sun Nov 6 21:29:08 2011 New Revision: 1198569 URL: http://svn.apache.org/viewvc?rev=1198569&view=rev Log: Porting r1187806 - whitespace cleanup in /test Last portion - xml, jsp, tld files. Update mergeinfo on the tc7.0.x\trunk folder. Modified: tomcat/tc7.0.x/trunk/

svn commit: r1198568 - in /tomcat/tc7.0.x/trunk/test/org/apache/tomcat/util: http/ net/ net/jsse/ res/ threads/

2011-11-06 Thread kkolinko
Author: kkolinko Date: Sun Nov 6 21:25:23 2011 New Revision: 1198568 URL: http://svn.apache.org/viewvc?rev=1198568&view=rev Log: Porting r1187806 - whitespace cleanup in /test Modified: tomcat/tc7.0.x/trunk/test/org/apache/tomcat/util/http/TestBug49158.java tomcat/tc7.0.x/trunk/test/org/

svn commit: r1198567 - in /tomcat/tc7.0.x/trunk/test/org/apache: jasper/compiler/ tomcat/util/buf/ tomcat/util/http/ tomcat/util/http/mapper/

2011-11-06 Thread kkolinko
Author: kkolinko Date: Sun Nov 6 21:23:36 2011 New Revision: 1198567 URL: http://svn.apache.org/viewvc?rev=1198567&view=rev Log: Porting r1187806 - whitespace cleanup in /test Modified: tomcat/tc7.0.x/trunk/test/org/apache/jasper/compiler/TestAttributeParser.java tomcat/tc7.0.x/trunk/te

svn commit: r1198564 - in /tomcat/tc7.0.x/trunk/test/org/apache/el: ./ lang/ parser/

2011-11-06 Thread kkolinko
Author: kkolinko Date: Sun Nov 6 21:21:23 2011 New Revision: 1198564 URL: http://svn.apache.org/viewvc?rev=1198564&view=rev Log: Porting r1187806 - whitespace cleanup in /test Modified: tomcat/tc7.0.x/trunk/test/org/apache/el/TestELEvaluation.java tomcat/tc7.0.x/trunk/test/org/apache/el/

svn commit: r1198562 - in /tomcat/tc7.0.x/trunk/test/org/apache: coyote/ajp/ coyote/http11/ coyote/http11/filters/ naming/resources/

2011-11-06 Thread kkolinko
Author: kkolinko Date: Sun Nov 6 21:19:43 2011 New Revision: 1198562 URL: http://svn.apache.org/viewvc?rev=1198562&view=rev Log: Porting r1187806 - whitespace cleanup in /test Modified: tomcat/tc7.0.x/trunk/test/org/apache/coyote/ajp/SimpleAjpClient.java tomcat/tc7.0.x/trunk/test/org/ap

svn commit: r1198561 - in /tomcat/tc7.0.x/trunk/test/org/apache/catalina/tribes/test: ./ channel/ transport/

2011-11-06 Thread kkolinko
Author: kkolinko Date: Sun Nov 6 21:16:52 2011 New Revision: 1198561 URL: http://svn.apache.org/viewvc?rev=1198561&view=rev Log: Porting r1187806 - whitespace cleanup in /test Modified: tomcat/tc7.0.x/trunk/test/org/apache/catalina/tribes/test/NioSenderTest.java tomcat/tc7.0.x/trunk/tes

svn commit: r1198560 - in /tomcat/tc7.0.x/trunk/test/org/apache/catalina/tribes: demos/ group/ group/interceptors/ membership/

2011-11-06 Thread kkolinko
Author: kkolinko Date: Sun Nov 6 21:15:08 2011 New Revision: 1198560 URL: http://svn.apache.org/viewvc?rev=1198560&view=rev Log: Porting r1187806 - whitespace cleanup in /test Modified: tomcat/tc7.0.x/trunk/test/org/apache/catalina/tribes/demos/ChannelCreator.java tomcat/tc7.0.x/trunk/

buildbot success in ASF Buildbot on tomcat-trunk

2011-11-06 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/2468 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

svn commit: r1198558 - /tomcat/tc7.0.x/trunk/test/org/apache/catalina/startup/

2011-11-06 Thread kkolinko
Author: kkolinko Date: Sun Nov 6 21:12:12 2011 New Revision: 1198558 URL: http://svn.apache.org/viewvc?rev=1198558&view=rev Log: Porting r1187806 - whitespace cleanup in /test Modified: tomcat/tc7.0.x/trunk/test/org/apache/catalina/startup/DuplicateMappingParamFilter.java tomcat/tc7.0.

svn commit: r1198555 - in /tomcat/tc7.0.x/trunk/test/org/apache/catalina: core/ deploy/ filters/

2011-11-06 Thread kkolinko
Author: kkolinko Date: Sun Nov 6 21:06:45 2011 New Revision: 1198555 URL: http://svn.apache.org/viewvc?rev=1198555&view=rev Log: Porting r1187806 - whitespace cleanup in /test Modified: tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TestDefaultInstanceManager.java tomcat/tc7.0.x/tr

svn commit: r1198554 - in /tomcat/tc7.0.x/trunk/test: javax/el/ javax/servlet/jsp/ org/apache/catalina/authenticator/ org/apache/catalina/connector/

2011-11-06 Thread kkolinko
Author: kkolinko Date: Sun Nov 6 21:04:49 2011 New Revision: 1198554 URL: http://svn.apache.org/viewvc?rev=1198554&view=rev Log: Porting r1187806 - whitespace cleanup in /test Modified: tomcat/tc7.0.x/trunk/test/javax/el/TestBeanELResolverVarargsInvocation.java tomcat/tc7.0.x/trunk/test/

svn commit: r1198553 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/net/AbstractEndpoint.java test/org/apache/catalina/startup/TomcatBaseTest.java webapps/docs/changelog.xml webapps/docs/c

2011-11-06 Thread kkolinko
Author: kkolinko Date: Sun Nov 6 20:52:33 2011 New Revision: 1198553 URL: http://svn.apache.org/viewvc?rev=1198553&view=rev Log: Merged revisions r1197158, r1198552 from tomcat/trunk: Add new attribute to AbstractEndpoint and use it to speed up Tomcat tests. If the attribute "fastShutdown" is set

svn commit: r1198552 - in /tomcat/trunk/webapps/docs/config: ajp.xml http.xml

2011-11-06 Thread kkolinko
Author: kkolinko Date: Sun Nov 6 20:46:44 2011 New Revision: 1198552 URL: http://svn.apache.org/viewvc?rev=1198552&view=rev Log: Document fastShutdown attribute of AbstractEndpoint, that was added in r1197158 Modified: tomcat/trunk/webapps/docs/config/ajp.xml tomcat/trunk/webapps/docs/co

[jira] [Commented] (MTOMCAT-100) support war overlay to add war external dependencies in tomcat run

2011-11-06 Thread Olivier Bazoud (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145096#comment-13145096 ] Olivier Bazoud commented on MTOMCAT-100: a small fix in response to previous comm

buildbot failure in ASF Buildbot on tomcat-trunk

2011-11-06 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/2467 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source St

svn commit: r1198531 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/coyote/http11/filters/TestFlushableGZIPOutputStream.java

2011-11-06 Thread kkolinko
Author: kkolinko Date: Sun Nov 6 18:56:26 2011 New Revision: 1198531 URL: http://svn.apache.org/viewvc?rev=1198531&view=rev Log: Merged revision 1198528 from tomcat/trunk: svn:eol-style=native Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/test/org/apache/coyote/

svn commit: r1198528 - /tomcat/trunk/test/org/apache/coyote/http11/filters/TestFlushableGZIPOutputStream.java

2011-11-06 Thread kkolinko
Author: kkolinko Date: Sun Nov 6 18:53:53 2011 New Revision: 1198528 URL: http://svn.apache.org/viewvc?rev=1198528&view=rev Log: svn:eol-style=native Modified: tomcat/trunk/test/org/apache/coyote/http11/filters/TestFlushableGZIPOutputStream.java (contents, props changed) Modified: tomc

Re: svn commit: r1198376 - /tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/run/DefaultClassLoaderEntriesCalculator.java

2011-11-06 Thread Francis Galiegue
On Sun, Nov 6, 2011 at 19:31, Olivier Lamy wrote: > 2011/11/6 Francis Galiegue : >> On Sun, Nov 6, 2011 at 15:13,   wrote: >> [...] >>> >>> +                    tmpDir.mkdirs(); >> >> Why isn't the return code checked? Are you sure at this point that you >> can actually create the directories? Wha

Re: svn commit: r1198376 - /tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/run/DefaultClassLoaderEntriesCalculator.java

2011-11-06 Thread Olivier Lamy
2011/11/6 Francis Galiegue : > On Sun, Nov 6, 2011 at 15:13,   wrote: > [...] >> >> +                    tmpDir.mkdirs(); > > Why isn't the return code checked? Are you sure at this point that you > can actually create the directories? What about ENOSPC? Sure why not. But as it's a subdirectory of

svn commit: r1198525 - /tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/run/DefaultClassLoaderEntriesCalculator.java

2011-11-06 Thread olamy
Author: olamy Date: Sun Nov 6 18:24:34 2011 New Revision: 1198525 URL: http://svn.apache.org/viewvc?rev=1198525&view=rev Log: remove unused import Modified: tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/run/DefaultClassLoaderEntriesCalcula

svn commit: r1198507 - in /tomcat/tc7.0.x/trunk: ./ build.properties.default webapps/docs/changelog.xml

2011-11-06 Thread kkolinko
Author: kkolinko Date: Sun Nov 6 17:46:18 2011 New Revision: 1198507 URL: http://svn.apache.org/viewvc?rev=1198507&view=rev Log: Merged revision 1198497 from tomcat/trunk: Update to Checkstyle 5.5 Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/build.properties.def

svn commit: r1198497 - /tomcat/trunk/build.properties.default

2011-11-06 Thread kkolinko
Author: kkolinko Date: Sun Nov 6 17:41:11 2011 New Revision: 1198497 URL: http://svn.apache.org/viewvc?rev=1198497&view=rev Log: Update to Checkstyle 5.5 Modified: tomcat/trunk/build.properties.default Modified: tomcat/trunk/build.properties.default URL: http://svn.apache.org/viewvc/tomcat

Re: svn commit: r1198376 - /tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/run/DefaultClassLoaderEntriesCalculator.java

2011-11-06 Thread Francis Galiegue
On Sun, Nov 6, 2011 at 15:13, wrote: [...] > > +                    tmpDir.mkdirs(); Why isn't the return code checked? Are you sure at this point that you can actually create the directories? What about ENOSPC? -- Francis Galiegue, fgalie...@gmail.com "It seems obvious [...] that at least som

Re: svn commit: r1198376 - /tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/run/DefaultClassLoaderEntriesCalculator.java

2011-11-06 Thread Konstantin Kolinko
2011/11/6 : > Author: olamy > Date: Sun Nov  6 14:13:09 2011 > New Revision: 1198376 > > URL: http://svn.apache.org/viewvc?rev=1198376&view=rev > Log: > [MTOMCAT-100] support war overlay to add war external dependencies in tomcat > run > fix extraction of war overlay content files was extracted i

[jira] [Commented] (MTOMCAT-100) support war overlay to add war external dependencies in tomcat run

2011-11-06 Thread Hudson (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145011#comment-13145011 ] Hudson commented on MTOMCAT-100: Integrated in TomcatMavenPlugin #60 (See [https://build

svn commit: r1198376 - /tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/run/DefaultClassLoaderEntriesCalculator.java

2011-11-06 Thread olamy
Author: olamy Date: Sun Nov 6 14:13:09 2011 New Revision: 1198376 URL: http://svn.apache.org/viewvc?rev=1198376&view=rev Log: [MTOMCAT-100] support war overlay to add war external dependencies in tomcat run fix extraction of war overlay content files was extracted in . Modified: tomcat/mave