svn commit: r1197387 - in /tomcat/trunk/test/org/apache/coyote/http11/filters: TestFlushableGZIPOutputStream.java TesterFlushableGZIPOutputStream.java bug52121-part1 bug52121-part2

2011-11-03 Thread kkolinko
Author: kkolinko Date: Fri Nov 4 01:52:34 2011 New Revision: 1197387 URL: http://svn.apache.org/viewvc?rev=1197387&view=rev Log: Explicitly mark the two test data files as binary, as a reminder that they should not be treated as mere text. Rename the test class so that it is included into test s

[jira] [Commented] (MTOMCAT-105) creating executable war failed

2011-11-03 Thread albert kam (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143678#comment-13143678 ] albert kam commented on MTOMCAT-105: Thanks for the fast response ! I added that in

svn commit: r1197386 - /tomcat/trunk/test/org/apache/coyote/http11/filters/TesterFlushableGZIPOutputStream.java

2011-11-03 Thread kkolinko
Author: kkolinko Date: Fri Nov 4 01:44:15 2011 New Revision: 1197386 URL: http://svn.apache.org/viewvc?rev=1197386&view=rev Log: Fixed a bug in the test case: it could not find the resources because they are not copied when tests are compiled. Use a file stream, reading the resource from the so

DO NOT REPLY [Bug 52121] corrupt gzip output when compression=on in server.xml

2011-11-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52121 --- Comment #4 from Konstantin Kolinko 2011-11-04 01:35:22 UTC --- I think I fixed it with r1197382. Regarding the NPE when testing with Ant: it is a fault in the test case. The resources are not copied when compiling the test classes. T

svn commit: r1197382 - /tomcat/trunk/java/org/apache/coyote/http11/filters/FlushableGZIPOutputStream.java

2011-11-03 Thread kkolinko
Author: kkolinko Date: Fri Nov 4 01:29:44 2011 New Revision: 1197382 URL: http://svn.apache.org/viewvc?rev=1197382&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52121 FlushableGZIPOutputStream produces corrupted output on some input sequences The fix is to do not restore co

DO NOT REPLY [Bug 52121] corrupt gzip output when compression=on in server.xml

2011-11-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52121 --- Comment #3 from Konstantin Kolinko 2011-11-03 23:53:23 UTC --- Note that you can run the test by adding the following line to the build.properties file: test.entry=org.apache.coyote.http11.filters.TesterFlushableGZIPOutputStream Just

DO NOT REPLY [Bug 52121] corrupt gzip output when compression=on in server.xml

2011-11-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52121 --- Comment #2 from Mark Thomas 2011-11-03 23:14:00 UTC --- Many thanks for the excellent test case. It looks like it was very difficult to track down. We really do appreciate your efforts on this. I have converted the stand-alone reproduc

svn commit: r1197343 [1/3] - in /tomcat/trunk/test/org/apache/coyote/http11/filters: TesterFlushableGZIPOutputStream.java bug52121-part1 bug52121-part2

2011-11-03 Thread markt
Author: markt Date: Thu Nov 3 23:05:46 2011 New Revision: 1197343 URL: http://svn.apache.org/viewvc?rev=1197343&view=rev Log: Test case for bug 52121 Added: tomcat/trunk/test/org/apache/coyote/http11/filters/TesterFlushableGZIPOutputStream.java tomcat/trunk/test/org/apache/coyote/http11

Re: Redeploy on context.xml changes (Was: Tagging 7.0.23)

2011-11-03 Thread Mark Thomas
On 03/11/2011 17:08, Mark Thomas wrote: > I'm still looking at: > - recovery after fixing the broken file > - not deploying an expanded dir if the context.xml in > conf/Catalina/localhost is broken. OK. Here is a patch for review. There are so many combinations deployment and ways to create a dodg

svn commit: r1197341 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/ContextConfig.java java/org/apache/catalina/startup/HostConfig.java

2011-11-03 Thread markt
Author: markt Date: Thu Nov 3 22:53:18 2011 New Revision: 1197341 URL: http://svn.apache.org/viewvc?rev=1197341&view=rev Log: Casting clean-up Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/ContextConfig.java tomcat/tc7.0.x/tru

svn commit: r1197340 - /tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java

2011-11-03 Thread markt
Author: markt Date: Thu Nov 3 22:51:30 2011 New Revision: 1197340 URL: http://svn.apache.org/viewvc?rev=1197340&view=rev Log: Use Container interface rather than an implementation of it. Modified: tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java Modified: tomcat/trunk/java/org/

svn commit: r1197339 - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

2011-11-03 Thread markt
Author: markt Date: Thu Nov 3 22:50:50 2011 New Revision: 1197339 URL: http://svn.apache.org/viewvc?rev=1197339&view=rev Log: Check cast is safe Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.j

DO NOT REPLY [Bug 51872] request.getRemoteAddr() sometimes returning IP address from the previous request

2011-11-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51872 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|

DO NOT REPLY [Bug 51872] request.getRemoteAddr() sometimes returning IP address from the previous request

2011-11-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51872 Bart Hanlon changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

Re: svn commit: r1197310 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/valves/RequestFilterValve.java

2011-11-03 Thread Konstantin Kolinko
2011/11/4 : > Author: markt > Date: Thu Nov  3 21:10:04 2011 > New Revision: 1197310 > > URL: http://svn.apache.org/viewvc?rev=1197310&view=rev > Log: > Ensure that subsequent attempts to start the Valves will not succeed until > valid configuration is provided. > > Modified: >    tomcat/tc7.0.x/

buildbot success in ASF Buildbot on tomcat-trunk

2011-11-03 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/2458 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

svn commit: r1197310 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/valves/RequestFilterValve.java

2011-11-03 Thread markt
Author: markt Date: Thu Nov 3 21:10:04 2011 New Revision: 1197310 URL: http://svn.apache.org/viewvc?rev=1197310&view=rev Log: Ensure that subsequent attempts to start the Valves will not succeed until valid configuration is provided. Modified: tomcat/tc7.0.x/trunk/ (props changed) tom

buildbot failure in ASF Buildbot on tomcat-trunk

2011-11-03 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/2457 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source St

svn commit: r1197305 - /tomcat/trunk/test/org/apache/catalina/tribes/group/TestGroupChannelSenderConnections.java

2011-11-03 Thread kkolinko
Author: kkolinko Date: Thu Nov 3 20:54:52 2011 New Revision: 1197305 URL: http://svn.apache.org/viewvc?rev=1197305&view=rev Log: Remove 15s wait after each test. I do not understand why that 15s wait with "inspect connections" message was there. Nothing was checked after the wait. Replaced it wi

svn commit: r1197302 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/valves/mbeans-descriptors.xml

2011-11-03 Thread markt
Author: markt Date: Thu Nov 3 20:47:44 2011 New Revision: 1197302 URL: http://svn.apache.org/viewvc?rev=1197302&view=rev Log: Correct descriptions Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml Propchange: to

svn commit: r1197300 - /tomcat/trunk/java/org/apache/catalina/valves/RequestFilterValve.java

2011-11-03 Thread markt
Author: markt Date: Thu Nov 3 20:37:26 2011 New Revision: 1197300 URL: http://svn.apache.org/viewvc?rev=1197300&view=rev Log: Ensure that subsequent attempts to start the Valves will not succeed until valid configuration is provided. Modified: tomcat/trunk/java/org/apache/catalina/valves/Req

svn commit: r1197299 - /tomcat/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml

2011-11-03 Thread markt
Author: markt Date: Thu Nov 3 20:36:48 2011 New Revision: 1197299 URL: http://svn.apache.org/viewvc?rev=1197299&view=rev Log: Correct descriptions Modified: tomcat/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml Modified: tomcat/trunk/java/org/apache/catalina/valves/mbeans-desc

svn commit: r1197263 - /tomcat/trunk/test/org/apache/catalina/tribes/group/TestGroupChannelSenderConnections.java

2011-11-03 Thread kkolinko
Author: kkolinko Date: Thu Nov 3 18:43:09 2011 New Revision: 1197263 URL: http://svn.apache.org/viewvc?rev=1197263&view=rev Log: Clean up code and use logging framework instead of System.out. Modified: tomcat/trunk/test/org/apache/catalina/tribes/group/TestGroupChannelSenderConnections.java

svn commit: r1197261 - in /tomcat/trunk/test/org/apache/catalina/startup: LoggingBaseTest.java TomcatBaseTest.java

2011-11-03 Thread kkolinko
Author: kkolinko Date: Thu Nov 3 18:41:39 2011 New Revision: 1197261 URL: http://svn.apache.org/viewvc?rev=1197261&view=rev Log: Introduce a new class LoggingBaseTest and move the following features from TomcatBaseTest there: setting up logging, creating temporary directory, deleting files on te

[Taglibs] Is anyone looking after taglibs?

2011-11-03 Thread sebb
The Jakarta TLP is about to retire to the attic; however the taglibs site still refers to non-existent jakarta pages for the downloads. A bug [1] was raised for this for this some while ago, but there appears to be no-one interested in fixing the issue. [1] https://issues.apache.org/bugzilla/show

[jira] [Commented] (MTOMCAT-105) creating executable war failed

2011-11-03 Thread Olivier Lamy (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143326#comment-13143326 ] Olivier Lamy commented on MTOMCAT-105: -- can you try with enabling naming: {code:xml}

Re: Redeploy on context.xml changes (Was: Tagging 7.0.23)

2011-11-03 Thread Mark Thomas
On 02/11/2011 15:35, Konstantin Kolinko wrote: > 2011/11/2 : > Also s/redploy/redeploy/ in some Javadoc. Fixed for next iteration of the patch. > The removeWatchedResource() method in the patch is NOOP instead of > calling renamed method. Also fixed. > The following in StandardContext.java does

Re: [patch] Speed up Tomcat shutdown during test runs

2011-11-03 Thread Konstantin Kolinko
2011/11/3 Konstantin Kolinko : > Hi! > > The patch: > http://people.apache.org/~kkolinko/patches/2011-11-03_tc8_fastShutdown.patch > > It saves 1 second for each Tomcat shutdown during tests, > by skipping a sleep in AbstractEndpoint.pause(). > > I think it is worth doing, but maybe there are other

svn commit: r1197158 - in /tomcat/trunk: java/org/apache/tomcat/util/net/AbstractEndpoint.java test/org/apache/catalina/startup/TomcatBaseTest.java

2011-11-03 Thread kkolinko
Author: kkolinko Date: Thu Nov 3 14:40:21 2011 New Revision: 1197158 URL: http://svn.apache.org/viewvc?rev=1197158&view=rev Log: Add new attribute to AbstractEndpoint and use it to speed up Tomcat tests. If the attribute "fastShutdown" is set on the endpoint, the usual wait of 1 sec during pause(

svn commit: r1197125 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/net/NioEndpoint.java

2011-11-03 Thread kkolinko
Author: kkolinko Date: Thu Nov 3 14:05:24 2011 New Revision: 1197125 URL: http://svn.apache.org/viewvc?rev=1197125&view=rev Log: Merged revisions r1196825 r1196827 from tomcat/trunk: Wrap and format long lines. No functional change. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomca

DO NOT REPLY [Bug 52127] java.lang.IncompatibleClassChangeError

2011-11-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52127 Konstantin Kolinko changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[jira] [Issue Comment Edited] (MTOMCAT-105) creating executable war failed

2011-11-03 Thread albert kam (Issue Comment Edited) (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143026#comment-13143026 ] albert kam edited comment on MTOMCAT-105 at 11/3/11 10:14 AM: -

[jira] [Issue Comment Edited] (MTOMCAT-105) creating executable war failed

2011-11-03 Thread albert kam (Issue Comment Edited) (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143026#comment-13143026 ] albert kam edited comment on MTOMCAT-105 at 11/3/11 10:14 AM: -

[jira] [Updated] (MTOMCAT-105) creating executable war failed

2011-11-03 Thread albert kam (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] albert kam updated MTOMCAT-105: --- Attachment: BasicSetup.zip The simple app, whose executable war runs wrongly, with the error of jav

[jira] [Commented] (MTOMCAT-105) creating executable war failed

2011-11-03 Thread Olivier Lamy (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143009#comment-13143009 ] Olivier Lamy commented on MTOMCAT-105: -- see http://tomcat.apache.org/maven-plugin-2.

[jira] [Commented] (MTOMCAT-105) creating executable war failed

2011-11-03 Thread albert kam (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142995#comment-13142995 ] albert kam commented on MTOMCAT-105: Aha, i see ! Yes, it's just like you said, now t

[jira] [Commented] (MTOMCAT-105) creating executable war failed

2011-11-03 Thread Olivier Lamy (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142940#comment-13142940 ] Olivier Lamy commented on MTOMCAT-105: -- It looks the war generated by your project i