svn commit: r1181291 - /tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java

2011-10-10 Thread markt
Author: markt Date: Mon Oct 10 23:09:35 2011 New Revision: 1181291 URL: http://svn.apache.org/viewvc?rev=1181291&view=rev Log: Minor clean-up Modified: tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java Modified: tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java URL:

Re: Make the InetAddress object available via ServletRequest?

2011-10-10 Thread Christopher Schultz
Francis, On 10/9/2011 10:57 AM, Francis Galiegue wrote: > I have my CIDR matching valve/filter ready (still struggling to write > unit tests, but it works in real-world situations), and there is > something I find quite unoptimized: you have getRemoteHost() and > getRemoteAddr() to get the remote

DO NOT REPLY [Bug 51940] Form Authentication Valve should restore request body on PUT method

2011-10-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51940 --- Comment #8 from Mark Thomas 2011-10-10 18:58:14 UTC --- Thanks for the review. Those issues have been fixed. Any proposal for back-port needs a minimum of 3 +1 votes from committers. Once it has the votes, a committer (usually the prop

svn commit: r1181137 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/authenticator/FormAuthenticator.java

2011-10-10 Thread markt
Author: markt Date: Mon Oct 10 18:57:45 2011 New Revision: 1181137 URL: http://svn.apache.org/viewvc?rev=1181137&view=rev Log: Address review comments for r1181030 Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/authenticator/FormAuthentica

svn commit: r1181136 - /tomcat/trunk/java/org/apache/catalina/authenticator/FormAuthenticator.java

2011-10-10 Thread markt
Author: markt Date: Mon Oct 10 18:56:29 2011 New Revision: 1181136 URL: http://svn.apache.org/viewvc?rev=1181136&view=rev Log: Address review comments for r1181028 Modified: tomcat/trunk/java/org/apache/catalina/authenticator/FormAuthenticator.java Modified: tomcat/trunk/java/org/apache/cat

svn commit: r1181135 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/bcel/classfile/ webapps/docs/

2011-10-10 Thread markt
Author: markt Date: Mon Oct 10 18:51:44 2011 New Revision: 1181135 URL: http://svn.apache.org/viewvc?rev=1181135&view=rev Log: Remove unused code Removed: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/bcel/classfile/ConstantObject.java Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1181133 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/bcel/classfile/ java/org/apache/tomcat/util/bcel/util/ webapps/docs/

2011-10-10 Thread markt
Author: markt Date: Mon Oct 10 18:49:14 2011 New Revision: 1181133 URL: http://svn.apache.org/viewvc?rev=1181133&view=rev Log: Update copy of Commons BCEL to latest code from Commons BCEL trunk Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/tomcat/

svn commit: r1181125 - in /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile: ConstantClass.java ConstantDouble.java ConstantFloat.java ConstantInteger.java ConstantLong.java ConstantObject.java

2011-10-10 Thread markt
Author: markt Date: Mon Oct 10 18:39:06 2011 New Revision: 1181125 URL: http://svn.apache.org/viewvc?rev=1181125&view=rev Log: Remove unused ConstantObject interface and associated references Removed: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ConstantObject.java Modified: to

svn commit: r1181123 - in /tomcat/trunk/java/org/apache/tomcat/util/bcel: ./ classfile/ util/

2011-10-10 Thread markt
Author: markt Date: Mon Oct 10 18:37:14 2011 New Revision: 1181123 URL: http://svn.apache.org/viewvc?rev=1181123&view=rev Log: Sync with Commons BCEL (moved from Jakarta) Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/ (props changed) tomcat/trunk/java/org/apache/tomcat/util/b

[RFC] Netmask-based filter and valve

2011-10-10 Thread Francis Galiegue
Hello list, Frustrated by the limitations of existing Remote{Addr,Host}{Filter,Valve}, I have coded an implementation of a Filter and Valve doing netmask-based matching. These valves can also do IP-based matching (just don't specify a netmask). Having quite some difficulties writing unit tests fo

DO NOT REPLY [Bug 46264] Shutting down tomcat with large number of contexts is slow

2011-10-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46264 --- Comment #7 from Rainer Jung 2011-10-10 18:05:29 UTC --- Hi Felix, don't want to split hairs or paint bikesheds but the attribute name seems problematic: in TC 7 we call "parallel deployment" the possibility to serve multiple versions

DO NOT REPLY [Bug 46264] Shutting down tomcat with large number of contexts is slow

2011-10-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46264 --- Comment #6 from Felix Schumacher 2011-10-10 17:42:06 UTC --- Created attachment 27755 --> https://issues.apache.org/bugzilla/attachment.cgi?id=27755 starting contexts in parallel using an executor While this patch is not really for

DO NOT REPLY [Bug 51940] Form Authentication Valve should restore request body on PUT method

2011-10-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51940 --- Comment #7 from Nicholas Sushkin 2011-10-10 17:29:14 UTC --- BTW, in your change to 7.0, there seems to be a slight inconsistency in the log message. In other log messages, when you say "context [{n}]", you pass context.getName(). In t

DO NOT REPLY [Bug 51940] Form Authentication Valve should restore request body on PUT method

2011-10-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51940 --- Comment #6 from Nicholas Sushkin 2011-10-10 17:08:25 UTC --- Perfect. I am glad Roy Fielding clarified the usage of request body in HTTP and REST. It makes sense and the code is now simpler and more generic. How does that request for

svn commit: r1181038 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

2011-10-10 Thread markt
Author: markt Date: Mon Oct 10 15:50:32 2011 New Revision: 1181038 URL: http://svn.apache.org/viewvc?rev=1181038&view=rev Log: Correction. Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/to

DO NOT REPLY [Bug 51940] Form Authentication Valve should restore request body on PUT method

2011-10-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51940 --- Comment #5 from Mark Thomas 2011-10-10 15:48:59 UTC --- Thanks for the patch. I used it as the basis for the fox that has been committed. The fix has been applied to trunk and 7.0.x and will be included in 7.0.23 onwards. The fix has

svn commit: r1181034 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-10-10 Thread markt
Author: markt Date: Mon Oct 10 15:48:14 2011 New Revision: 1181034 URL: http://svn.apache.org/viewvc?rev=1181034&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1

svn commit: r1181030 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/authenticator/FormAuthenticator.java java/org/apache/catalina/authenticator/LocalStrings.properties webapps/docs/changelog.

2011-10-10 Thread markt
Author: markt Date: Mon Oct 10 15:46:51 2011 New Revision: 1181030 URL: http://svn.apache.org/viewvc?rev=1181030&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51940 Don't limit saving of request bodies during FORM authentication to POST requests since any HTTP method may in

svn commit: r1181028 - in /tomcat/trunk/java/org/apache/catalina/authenticator: FormAuthenticator.java LocalStrings.properties

2011-10-10 Thread markt
Author: markt Date: Mon Oct 10 15:44:14 2011 New Revision: 1181028 URL: http://svn.apache.org/viewvc?rev=1181028&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51940 Don't limit saving of request bodies during FORM authentication to POST requests since any HTTP method may in

svn commit: r1181026 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

2011-10-10 Thread markt
Author: markt Date: Mon Oct 10 15:39:48 2011 New Revision: 1181026 URL: http://svn.apache.org/viewvc?rev=1181026&view=rev Log: Update changelog Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/view

DO NOT REPLY [Bug 51940] Form Authentication Valve should restore request body on PUT method

2011-10-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51940 --- Comment #4 from Mark Thomas 2011-10-10 15:17:37 UTC --- Try again, this time with the full message. RFC 2616 explicitly discusses OPTIONS and a request body. However, any HTTP request method may use a request body [1] although in many

DO NOT REPLY [Bug 51940] Form Authentication Valve should restore request body on PUT method

2011-10-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51940 --- Comment #3 from Mark Thomas 2011-10-10 15:13:20 UTC --- POST and PUT are not the only methods that may have a request body. Request bodies are described in RFC2616 for OPTION re -- Configure bugmail: https://issues.apache.org/bugzilla

DO NOT REPLY [Bug 52002] New: Pool re-opens and re-issues closed connection

2011-10-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52002 Bug #: 52002 Summary: Pool re-opens and re-issues closed connection Product: Tomcat Modules Version: unspecified Platform: PC Status: NEW Severity: normal

DO NOT REPLY [Bug 51972] sendRedirect does not support protocol relative URLs

2011-10-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51972 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 51972] sendRedirect does not support protocol relative URLs

2011-10-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51972 --- Comment #6 from Mark Thomas 2011-10-10 12:22:04 UTC --- The amount of time spend in the sendRedirect code is likely to be only a small proportion of the overall request time but there are lots of places where URIs are manipulated in the

svn commit: r1180914 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/connector/Response.java

2011-10-10 Thread markt
Author: markt Date: Mon Oct 10 12:17:23 2011 New Revision: 1180914 URL: http://svn.apache.org/viewvc?rev=1180914&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51972 Add support for handling scheme/protocol relative URLs for redirects Modified: tomcat/tc7.0.x/trunk/ (p

DO NOT REPLY [Bug 51972] sendRedirect does not support protocol relative URLs

2011-10-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51972 --- Comment #5 from Heikki Vesalainen 2011-10-10 12:13:11 UTC --- 100% difference sounds dramatic, but how many percent of the total response time is spent in this code? How bad would it make things if the slower (but more reliable) versio

svn commit: r1180907 - /tomcat/trunk/java/org/apache/catalina/connector/Response.java

2011-10-10 Thread markt
Author: markt Date: Mon Oct 10 12:10:53 2011 New Revision: 1180907 URL: http://svn.apache.org/viewvc?rev=1180907&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51972 Add support for handling scheme/protocol relative URLs for redirects Modified: tomcat/trunk/java/org/apac

svn commit: r1180894 - /tomcat/trunk/java/org/apache/catalina/connector/Response.java

2011-10-10 Thread markt
Author: markt Date: Mon Oct 10 11:58:37 2011 New Revision: 1180894 URL: http://svn.apache.org/viewvc?rev=1180894&view=rev Log: Make protected to it is visible to unit tests Modified: tomcat/trunk/java/org/apache/catalina/connector/Response.java Modified: tomcat/trunk/java/org/apache/catalina

DO NOT REPLY [Bug 51972] sendRedirect does not support protocol relative URLs

2011-10-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51972 --- Comment #4 from Mark Thomas 2011-10-10 11:56:08 UTC --- The home-brew code is used for a good reason - performance. It is currently ~2x faster than the alternative proposed. -- Configure bugmail: https://issues.apache.org/bugzilla/use

svn commit: r1180891 - /tomcat/trunk/test/org/apache/catalina/connector/TestResponsePerformance.java

2011-10-10 Thread markt
Author: markt Date: Mon Oct 10 11:56:02 2011 New Revision: 1180891 URL: http://svn.apache.org/viewvc?rev=1180891&view=rev Log: Add a performance test that demonstrates why using URI is currently poor for performance Added: tomcat/trunk/test/org/apache/catalina/connector/TestResponsePerforma

svn commit: r1180877 - /tomcat/trunk/java/org/apache/catalina/util/MsgDigest.java

2011-10-10 Thread markt
Author: markt Date: Mon Oct 10 11:21:52 2011 New Revision: 1180877 URL: http://svn.apache.org/viewvc?rev=1180877&view=rev Log: After some testing with DIGEST auth, this approach is slower Removed: tomcat/trunk/java/org/apache/catalina/util/MsgDigest.java

buildbot success in ASF Buildbot on tomcat-trunk

2011-10-10 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/2353 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

svn commit: r1180870 - /tomcat/trunk/java/org/apache/catalina/util/MsgDigest.java

2011-10-10 Thread markt
Author: markt Date: Mon Oct 10 10:45:17 2011 New Revision: 1180870 URL: http://svn.apache.org/viewvc?rev=1180870&view=rev Log: Add initial implementation of a thread safe MessageDigest helper class Added: tomcat/trunk/java/org/apache/catalina/util/MsgDigest.java Added: tomcat/trunk/java/org/

svn commit: r1180865 - /tomcat/trunk/test/org/apache/catalina/authenticator/TesterDigestAuthenticatorPerformance.java

2011-10-10 Thread markt
Author: markt Date: Mon Oct 10 10:37:20 2011 New Revision: 1180865 URL: http://svn.apache.org/viewvc?rev=1180865&view=rev Log: Focus DIGEST auth performance test on authentication process. Modified: tomcat/trunk/test/org/apache/catalina/authenticator/TesterDigestAuthenticatorPerformance.java

svn commit: r1180853 - in /tomcat/maven-plugin/trunk: BUILD.TXT README.txt pom.xml tomcat7-maven-plugin/pom.xml

2011-10-10 Thread olamy
Author: olamy Date: Mon Oct 10 09:59:45 2011 New Revision: 1180853 URL: http://svn.apache.org/viewvc?rev=1180853&view=rev Log: enable rat plugin and fix missing license header Added: tomcat/maven-plugin/trunk/README.txt (contents, props changed) - copied, changed from r1180852, tomcat

svn commit: r1180852 - in /tomcat/maven-plugin/trunk: ./ common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/messages/ common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/ma

2011-10-10 Thread olamy
Author: olamy Date: Mon Oct 10 09:59:17 2011 New Revision: 1180852 URL: http://svn.apache.org/viewvc?rev=1180852&view=rev Log: fix some checkstyle issues Modified: tomcat/maven-plugin/trunk/BUILD.TXT tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/ma

svn commit: r1180851 - in /tomcat/maven-plugin/trunk: pom.xml tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/AbstractRunMojo.java tomcat7-maven-plugin/src/main/java/org/apac

2011-10-10 Thread olamy
Author: olamy Date: Mon Oct 10 09:58:41 2011 New Revision: 1180851 URL: http://svn.apache.org/viewvc?rev=1180851&view=rev Log: move analysis report maven plugins to a reporting profile add some links for javadocs to tomcat javadoc Modified: tomcat/maven-plugin/trunk/pom.xml tomcat/maven-

svn commit: r1180850 - in /tomcat/maven-plugin/trunk: pom.xml tomcat6-maven-plugin/src/site/site.xml tomcat7-maven-plugin/src/site/ tomcat7-maven-plugin/src/site/site.xml

2011-10-10 Thread olamy
Author: olamy Date: Mon Oct 10 09:57:46 2011 New Revision: 1180850 URL: http://svn.apache.org/viewvc?rev=1180850&view=rev Log: add site.xml for tomcat7 module, add javadoc in default report Added: tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/site/ tomcat/maven-plugin/trunk/tomcat7-m

svn commit: r1180812 - /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java

2011-10-10 Thread olamy
Author: olamy Date: Mon Oct 10 07:54:57 2011 New Revision: 1180812 URL: http://svn.apache.org/viewvc?rev=1180812&view=rev Log: add javadoc on possible values for ajp protocol Modified: tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/Abs

svn commit: r1180810 - in /tomcat/maven-plugin/trunk: ./ tomcat-maven-plugin-it/src/main/java/org/codehaus/mojo/tomcat/it/ tomcat6-maven-plugin/ tomcat6-maven-plugin/src/test/java/org/codehaus/mojo/to

2011-10-10 Thread olamy
Author: olamy Date: Mon Oct 10 07:48:38 2011 New Revision: 1180810 URL: http://svn.apache.org/viewvc?rev=1180810&view=rev Log: add it tests configuration to ensure ajp port can be started too Modified: tomcat/maven-plugin/trunk/BUILD.TXT tomcat/maven-plugin/trunk/pom.xml tomcat/maven

svn commit: r1180809 - in /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/test: java/org/apache/tomcat/maven/plugin/tomcat7/ resources/tomcat-run-multi-config/ resources/tomcat-run-multi-config/sr

2011-10-10 Thread olamy
Author: olamy Date: Mon Oct 10 07:47:51 2011 New Revision: 1180809 URL: http://svn.apache.org/viewvc?rev=1180809&view=rev Log: add an other integration test for tomcat7 plugin Added: tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/test/java/org/apache/tomcat/maven/plugin/tomcat7/Tomcat7Ru

svn commit: r1180807 - in /tomcat/maven-plugin/trunk: ./ tomcat-maven-plugin-it/src/main/java/org/codehaus/mojo/tomcat/it/ tomcat6-maven-plugin/ tomcat6-maven-plugin/src/test/java/org/codehaus/mojo/to

2011-10-10 Thread olamy
Author: olamy Date: Mon Oct 10 07:47:01 2011 New Revision: 1180807 URL: http://svn.apache.org/viewvc?rev=1180807&view=rev Log: add a pom property to override http port used for integration tests: default is 1973. Modified: tomcat/maven-plugin/trunk/BUILD.TXT tomcat/maven-plugin/trunk/pom