Re: svn commit: r1163855 - in /tomcat: tc7.0.x/trunk/ trunk/

2011-08-31 Thread Sylvain Laurent
Would it really hurt to keep those properties? Le 1 sept. 2011 à 00:45, kkoli...@apache.org a écrit : > Author: kkolinko > Date: Wed Aug 31 22:45:23 2011 > New Revision: 1163855 > > URL: http://svn.apache.org/viewvc?rev=1163855&view=rev > Log: > Revert r1163807: > Remove subclipse:tags property

Re: svn commit: r1163802 - in /tomcat: tc7.0.x/trunk/java/org/apache/catalina/loader/WebappClassLoader.java trunk/java/org/apache/catalina/loader/WebappClassLoader.java

2011-08-31 Thread Sylvain Laurent
I'm using subclipse which contains a 1.6 svn client. I'm not an svn expert, I'll try to do as Mark recommends, I see the point of performing the merge after so that svn can keep track of things. Sylvain Le 1 sept. 2011 à 00:34, Konstantin Kolinko a écrit : > 2011/9/1 Mark Thomas : >> On 31/08

Re: svn commit: r1163807 - in /tomcat: tc7.0.x/trunk/ trunk/

2011-08-31 Thread Sylvain Laurent
Le 31 août 2011 à 23:13, Mark Thomas a écrit : > On 31/08/2011 21:38, slaur...@apache.org wrote: >> --- subclipse:tags (added) >> +++ subclipse:tags Wed Aug 31 20:38:53 2011 >> @@ -0,0 +1,2 @@ >> +932358,branches,/tomcat/tc7.0.x/branches,branch >> +1162976,TOMCAT_7_0_21,/tomcat/tc7.0.x/tags/TOM

Re: svn commit: r1163804 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

2011-08-31 Thread Sylvain Laurent
Le 31 août 2011 à 23:12, Mark Thomas a écrit : > On 31/08/2011 21:37, slaur...@apache.org wrote: >> + > > You left out the (markt) > I thought it represented the person who finalized the release, so I left it out. >> + >> + >> + >> +51744: Prevent application code from cl

DO NOT REPLY [Bug 51745] getLastModified of compilation context returns 0 on Android and it issues all time recompilation

2011-08-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51745 --- Comment #3 from d rogatkin 2011-09-01 01:15:24 UTC --- I have checked with Android team, and it looks like Harmony bug was fixed for Android 2.3 (Gingerbread), however still exists for earlier Androids. Perhaps this problem can be clos

svn commit: r1163879 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-08-31 Thread kfujino
Author: kfujino Date: Thu Sep 1 00:45:00 2011 New Revision: 1163879 URL: http://svn.apache.org/viewvc?rev=1163879&view=rev Log: my vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=

svn commit: r1163855 - in /tomcat: tc7.0.x/trunk/ trunk/

2011-08-31 Thread kkolinko
Author: kkolinko Date: Wed Aug 31 22:45:23 2011 New Revision: 1163855 URL: http://svn.apache.org/viewvc?rev=1163855&view=rev Log: Revert r1163807: Remove subclipse:tags property. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/trunk/ (props changed) Propchange: tomcat/tc7.0.x/

Re: svn commit: r1163802 - in /tomcat: tc7.0.x/trunk/java/org/apache/catalina/loader/WebappClassLoader.java trunk/java/org/apache/catalina/loader/WebappClassLoader.java

2011-08-31 Thread Konstantin Kolinko
2011/9/1 Mark Thomas : > On 31/08/2011 22:57, Konstantin Kolinko wrote: >> 2011/9/1 Mark Thomas : >>> On 31/08/2011 21:35, slaur...@apache.org wrote: Author: slaurent Date: Wed Aug 31 20:35:22 2011 New Revision: 1163802 URL: http://svn.apache.org/viewvc?rev=1163802&view=rev

Re: svn commit: r1163802 - in /tomcat: tc7.0.x/trunk/java/org/apache/catalina/loader/WebappClassLoader.java trunk/java/org/apache/catalina/loader/WebappClassLoader.java

2011-08-31 Thread Mark Thomas
On 31/08/2011 22:57, Konstantin Kolinko wrote: > 2011/9/1 Mark Thomas : >> On 31/08/2011 21:35, slaur...@apache.org wrote: >>> Author: slaurent >>> Date: Wed Aug 31 20:35:22 2011 >>> New Revision: 1163802 >>> >>> URL: http://svn.apache.org/viewvc?rev=1163802&view=rev >>> Log: >>> Fix https://issues

Re: svn commit: r1163802 - in /tomcat: tc7.0.x/trunk/java/org/apache/catalina/loader/WebappClassLoader.java trunk/java/org/apache/catalina/loader/WebappClassLoader.java

2011-08-31 Thread Konstantin Kolinko
2011/9/1 Mark Thomas : > On 31/08/2011 21:35, slaur...@apache.org wrote: >> Author: slaurent >> Date: Wed Aug 31 20:35:22 2011 >> New Revision: 1163802 >> >> URL: http://svn.apache.org/viewvc?rev=1163802&view=rev >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51741 >> bug 51741:

Re: svn commit: r1163807 - in /tomcat: tc7.0.x/trunk/ trunk/

2011-08-31 Thread Mark Thomas
On 31/08/2011 21:38, slaur...@apache.org wrote: > Author: slaurent > Date: Wed Aug 31 20:38:53 2011 > New Revision: 1163807 > > URL: http://svn.apache.org/viewvc?rev=1163807&view=rev > Log: > bug 51741: Eclipse WTP "Serve modules without publishing" broken with tc7, > needs patch in tomcat > htt

Re: svn commit: r1163804 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

2011-08-31 Thread Mark Thomas
On 31/08/2011 21:37, slaur...@apache.org wrote: > Author: slaurent > Date: Wed Aug 31 20:37:38 2011 > New Revision: 1163804 > > URL: http://svn.apache.org/viewvc?rev=1163804&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51741 > bug 51741: Eclipse WTP "Serve modules witho

Re: svn commit: r1163802 - in /tomcat: tc7.0.x/trunk/java/org/apache/catalina/loader/WebappClassLoader.java trunk/java/org/apache/catalina/loader/WebappClassLoader.java

2011-08-31 Thread Mark Thomas
On 31/08/2011 21:35, slaur...@apache.org wrote: > Author: slaurent > Date: Wed Aug 31 20:35:22 2011 > New Revision: 1163802 > > URL: http://svn.apache.org/viewvc?rev=1163802&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51741 > bug 51741: Eclipse WTP "Serve modules witho

DO NOT REPLY [Bug 51741] Eclipse WTP "Serve modules without publishing" broken with tc7, needs patch in tomcat

2011-08-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51741 Sylvain Laurent changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1163807 - in /tomcat: tc7.0.x/trunk/ trunk/

2011-08-31 Thread slaurent
Author: slaurent Date: Wed Aug 31 20:38:53 2011 New Revision: 1163807 URL: http://svn.apache.org/viewvc?rev=1163807&view=rev Log: bug 51741: Eclipse WTP "Serve modules without publishing" broken with tc7, needs patch in tomcat https://issues.apache.org/bugzilla/show_bug.cgi?id=51741 Modified:

svn commit: r1163804 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

2011-08-31 Thread slaurent
Author: slaurent Date: Wed Aug 31 20:37:38 2011 New Revision: 1163804 URL: http://svn.apache.org/viewvc?rev=1163804&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51741 bug 51741: Eclipse WTP "Serve modules without publishing" broken with tc7, needs patch in tomcat added se

svn commit: r1163802 - in /tomcat: tc7.0.x/trunk/java/org/apache/catalina/loader/WebappClassLoader.java trunk/java/org/apache/catalina/loader/WebappClassLoader.java

2011-08-31 Thread slaurent
Author: slaurent Date: Wed Aug 31 20:35:22 2011 New Revision: 1163802 URL: http://svn.apache.org/viewvc?rev=1163802&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51741 bug 51741: Eclipse WTP "Serve modules without publishing" broken with tc7, needs patch in tomcat Modified

DO NOT REPLY [Bug 51745] getLastModified of compilation context returns 0 on Android and it issues all time recompilation

2011-08-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51745 --- Comment #2 from d rogatkin 2011-08-31 18:16:32 UTC --- I agree that the proposed solution is a workaround of the bug in connection implementation. However it works for both mobile and desktop platforms (validated) and can be consider l

svn commit: r1163717 - /tomcat/trunk/java/org/apache/jasper/JspCompilationContext.java

2011-08-31 Thread markt
Author: markt Date: Wed Aug 31 17:46:22 2011 New Revision: 1163717 URL: http://svn.apache.org/viewvc?rev=1163717&view=rev Log: As per the comment, remove the deprecated code Modified: tomcat/trunk/java/org/apache/jasper/JspCompilationContext.java Modified: tomcat/trunk/java/org/apache/jasper

svn commit: r1163716 - /tomcat/tc7.0.x/trunk/java/org/apache/jasper/JspCompilationContext.java

2011-08-31 Thread markt
Author: markt Date: Wed Aug 31 17:45:45 2011 New Revision: 1163716 URL: http://svn.apache.org/viewvc?rev=1163716&view=rev Log: Revert r1163643 Modified: tomcat/tc7.0.x/trunk/java/org/apache/jasper/JspCompilationContext.java Modified: tomcat/tc7.0.x/trunk/java/org/apache/jasper/JspCompilation

Re: svn commit: r1163643 - /tomcat/tc7.0.x/trunk/java/org/apache/jasper/JspCompilationContext.java

2011-08-31 Thread Mark Thomas
On 31/08/2011 18:39, Tim Funk wrote: > /me confused - should this be removed from trunk instead of tc7.0.x? Yes. Got my checkouts mixed up. I'll fix this shortly. Thanks for the catch. Mark - To unsubscribe, e-mail: dev-unsubscr

Re: svn commit: r1163643 - /tomcat/tc7.0.x/trunk/java/org/apache/jasper/JspCompilationContext.java

2011-08-31 Thread Tim Funk
/me confused - should this be removed from trunk instead of tc7.0.x? -Tim On Wed, Aug 31, 2011 at 10:31 AM, wrote: > Author: markt > Date: Wed Aug 31 14:31:13 2011 > New Revision: 1163643 > > URL: http://svn.apache.org/viewvc?rev=1163643&view=rev > Log: > As per the comment, remove the deprecat

DO NOT REPLY [Bug 51744] JNDI Lookup Error after a Context is closed

2011-08-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51744 --- Comment #8 from Anjana Fernando 2011-08-31 15:57:33 UTC --- Mark, You could have used all those words to give me a simple explanation, I gave the comments and reported the bug to my ability, I explained the issue as I understood it, a

DO NOT REPLY [Bug 51744] JNDI Lookup Error after a Context is closed

2011-08-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51744 --- Comment #7 from Mark Thomas 2011-08-31 15:37:20 UTC --- I'll repeat: "You might also want to investigate when the JNDI context is writeable." I really do not appreciate code reviews based on guess work. If you are going to comment on t

DO NOT REPLY [Bug 51744] JNDI Lookup Error after a Context is closed

2011-08-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51744 --- Comment #6 from Anjana Fernando 2011-08-31 15:32:13 UTC --- Hi Mark, OK, sorry, I should have looked at the code before. I just didn't know where the svn for this was (yeah it was a simple looking around the tomcat project page), I th

DO NOT REPLY [Bug 51745] getLastModified of compilation context returns 0 on Android and it issues all time recompilation

2011-08-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51745 --- Comment #1 from Mark Thomas 2011-08-31 15:28:08 UTC --- Created attachment 27447 --> https://issues.apache.org/bugzilla/attachment.cgi?id=27447 Possible patch I'm not a fan of adding workarounds in Tomcat for bugs in any third-party

DO NOT REPLY [Bug 51744] JNDI Lookup Error after a Context is closed

2011-08-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51744 --- Comment #5 from Mark Thomas 2011-08-31 14:48:59 UTC --- Rather than guessing why don't you look at the source code and see what it actually does? You might also want to investigate when the JNDI context is writeable. -- Configure bugm

DO NOT REPLY [Bug 51744] JNDI Lookup Error after a Context is closed

2011-08-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51744 --- Comment #4 from Anjana Fernando 2011-08-31 14:43:14 UTC --- Hi Mark, Sorry, maybe I misunderstood, I guessed the modified version would be something like the following, public void close() throws NamingException { if (checkWritea

DO NOT REPLY [Bug 51730] Exception while trying to use "is" prefixed boolean property inherited from package private base class

2011-08-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51730 --- Comment #2 from Irina Marudina 2011-08-31 14:38:52 UTC --- It seems to be an issue in the java.beans.Introspector. I have produced a simple test program and reported the bug to Oracle: http://bugs.sun.com/bugdatabase/view_bug.do?bug_i

DO NOT REPLY [Bug 51744] JNDI Lookup Error after a Context is closed

2011-08-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51744 --- Comment #3 from Mark Thomas 2011-08-31 14:35:00 UTC --- No. The attempt to use the close() method will fail. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because:

DO NOT REPLY [Bug 51744] JNDI Lookup Error after a Context is closed

2011-08-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51744 --- Comment #2 from Anjana Fernando 2011-08-31 14:33:31 UTC --- Hi Mark, So for the situation I'm facing, in the close method, if the environment is cleared, will this be removed from "ContextBindings" also? .. Since that was the problem

svn commit: r1163643 - /tomcat/tc7.0.x/trunk/java/org/apache/jasper/JspCompilationContext.java

2011-08-31 Thread markt
Author: markt Date: Wed Aug 31 14:31:13 2011 New Revision: 1163643 URL: http://svn.apache.org/viewvc?rev=1163643&view=rev Log: As per the comment, remove the deprecated code Modified: tomcat/tc7.0.x/trunk/java/org/apache/jasper/JspCompilationContext.java Modified: tomcat/tc7.0.x/trunk/java/o

svn commit: r1163633 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/naming/NamingContext.java test/org/apache/naming/resources/TestNamingContext.java webapps/docs/changelog.xml

2011-08-31 Thread markt
Author: markt Date: Wed Aug 31 14:20:17 2011 New Revision: 1163633 URL: http://svn.apache.org/viewvc?rev=1163633&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51744 Don't allow user code to close the JNDI context while a web app is running Modified: tomcat/tc7.0.x/trunk

DO NOT REPLY [Bug 51744] JNDI Lookup Error after a Context is closed

2011-08-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51744 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1163630 - in /tomcat/trunk: java/org/apache/naming/NamingContext.java test/org/apache/naming/resources/TestNamingContext.java

2011-08-31 Thread markt
Author: markt Date: Wed Aug 31 14:17:41 2011 New Revision: 1163630 URL: http://svn.apache.org/viewvc?rev=1163630&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51744 Don't allow user code to close the JNDI context while a web app is running Modified: tomcat/trunk/java/or

Re: [VOTE] Release Apache Tomcat 7.0.21

2011-08-31 Thread Rainer Jung
On 29.08.2011 23:01, Mark Thomas wrote: > The proposed Apache Tomcat 7.0.21 release is now available for voting. > > It can be obtained from: > http://people.apache.org/~markt/dev/tomcat-7/v7.0.21/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_21/ > > The prop