svn commit: r1140390 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-06-27 Thread kkolinko
Author: kkolinko Date: Tue Jun 28 00:38:32 2011 New Revision: 1140390 URL: http://svn.apache.org/viewvc?rev=1140390&view=rev Log: replace v3 patch for BZ 51400 with v4 patch and vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.o

DO NOT REPLY [Bug 36362] missing check for Java reserved keywords in tag file processing

2011-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=36362 --- Comment #6 from Konstantin Kolinko 2011-06-28 00:16:37 UTC --- Created attachment 27216 --> https://issues.apache.org/bugzilla/attachment.cgi?id=27216 webapps/examples/WEB-INF/tags/helloWorld.tag This change in TC7 - r1138950 - brok

svn commit: r1140383 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

2011-06-27 Thread kkolinko
Author: kkolinko Date: Tue Jun 28 00:08:55 2011 New Revision: 1140383 URL: http://svn.apache.org/viewvc?rev=1140383&view=rev Log: veto Modified: tomcat/tc5.5.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/to

svn commit: r1140371 - in /tomcat/site/trunk: docs/doap_Tomcat.rdf xdocs/doap_Tomcat.rdf

2011-06-27 Thread kkolinko
Author: kkolinko Date: Mon Jun 27 23:31:07 2011 New Revision: 1140371 URL: http://svn.apache.org/viewvc?rev=1140371&view=rev Log: Updated version number and date in DOAP file. Modified: tomcat/site/trunk/docs/doap_Tomcat.rdf tomcat/site/trunk/xdocs/doap_Tomcat.rdf Modified: tomcat/site/t

svn commit: r1140370 - in /tomcat/site/trunk: docs/migration.html xdocs/migration.xml

2011-06-27 Thread kkolinko
Author: kkolinko Date: Mon Jun 27 23:29:04 2011 New Revision: 1140370 URL: http://svn.apache.org/viewvc?rev=1140370&view=rev Log: migration.html: 1) preselect the last and next-to-last versions in configuration comparison form 2) added HEAD revision to the list of versions, placed both version fie

svn commit: r1140361 - /tomcat/trunk/webapps/docs/changelog.xml

2011-06-27 Thread markt
Author: markt Date: Mon Jun 27 23:12:10 2011 New Revision: 1140361 URL: http://svn.apache.org/viewvc?rev=1140361&view=rev Log: Update for recent changes Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomc

Re: svn commit: r1140347 - in /tomcat/trunk/java/org/apache/catalina/valves: CrawlerSessionManagerValve.java mbeans-descriptors.xml

2011-06-27 Thread Mark Thomas
On 27/06/2011 23:15, Mark Thomas wrote: > On 27/06/2011 23:13, ma...@apache.org wrote: >> Author: markt >> Date: Mon Jun 27 22:13:39 2011 >> New Revision: 1140347 >> >> URL: http://svn.apache.org/viewvc?rev=1140347&view=rev >> Log: >> Use a more reliable method to expire sessions. > > This is a wo

Re: svn commit: r1140347 - in /tomcat/trunk/java/org/apache/catalina/valves: CrawlerSessionManagerValve.java mbeans-descriptors.xml

2011-06-27 Thread Mark Thomas
On 27/06/2011 23:13, ma...@apache.org wrote: > Author: markt > Date: Mon Jun 27 22:13:39 2011 > New Revision: 1140347 > > URL: http://svn.apache.org/viewvc?rev=1140347&view=rev > Log: > Use a more reliable method to expire sessions. This is a work in progress. I'll be testing with issues.a.o as I

svn commit: r1140347 - in /tomcat/trunk/java/org/apache/catalina/valves: CrawlerSessionManagerValve.java mbeans-descriptors.xml

2011-06-27 Thread markt
Author: markt Date: Mon Jun 27 22:13:39 2011 New Revision: 1140347 URL: http://svn.apache.org/viewvc?rev=1140347&view=rev Log: Use a more reliable method to expire sessions. Modified: tomcat/trunk/java/org/apache/catalina/valves/CrawlerSessionManagerValve.java tomcat/trunk/java/org/apache

Re: JK 1.2.32 release kick

2011-06-27 Thread Tim Whittington
+1 from me. On Tue, Jun 28, 2011 at 7:17 AM, Konstantin Kolinko wrote: > 2011/6/27 Mladen Turk : >> Hi, >> >> I have a time slot available so I volunteer as a 1.2.32 RM. >> Think we are good for a new release. >> >> Comments, objections? > > Sounds good. +1. > > Best regards, > Konstantin Kolinko

Re: JK 1.2.32 release kick

2011-06-27 Thread Konstantin Kolinko
2011/6/27 Mladen Turk : > Hi, > > I have a time slot available so I volunteer as a 1.2.32 RM. > Think we are good for a new release. > > Comments, objections? Sounds good. +1. Best regards, Konstantin Kolinko - To unsubscribe, e

JK 1.2.32 release kick

2011-06-27 Thread Mladen Turk
Hi, I have a time slot available so I volunteer as a 1.2.32 RM. Think we are good for a new release. Comments, objections? Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-

DO NOT REPLY [Bug 51400] Use of "new String(byte[] b, String enc)" hits Sun JVM bottleneck

2011-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51400 Mark Thomas changed: What|Removed |Added Attachment #27212|0 |1 is obsolete|

DO NOT REPLY [Bug 51400] Use of "new String(byte[] b, String enc)" hits Sun JVM bottleneck

2011-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51400 --- Comment #21 from Konstantin Preißer 2011-06-27 16:06:52 UTC --- Created attachment 27213 --> https://issues.apache.org/bugzilla/attachment.cgi?id=27213 Small patch to update C2BConverter Hi Mark, (In reply to comment #19) > My bad.

svn commit: r1140219 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2011-06-27 Thread markt
Author: markt Date: Mon Jun 27 16:01:32 2011 New Revision: 1140219 URL: http://svn.apache.org/viewvc?rev=1140219&view=rev Log: Simplify. Covert aliases to lower case too. Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java Modified: tomcat/trunk/java/org/apache/tomcat/ut

Re: svn commit: r1140204 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2011-06-27 Thread Tim Funk
The javadocs say it can be an "expensive" operation. But considering the alternatives [and this is only done once], this seems to be reasonable. What could be worrisome is the JDK does allow for more charsets to be added at run-time. In which case - a user could be out of luck. If we were scared

Re: svn commit: r1140204 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2011-06-27 Thread Konstantin Kolinko
2011/6/27 : > Author: markt > Date: Mon Jun 27 15:19:22 2011 > New Revision: 1140204 > > URL: http://svn.apache.org/viewvc?rev=1140204&view=rev > Log: > Need to include aliases in charset cache > > Modified: >    tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java > 15:19:22 2011 > @@

svn commit: r1140205 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-06-27 Thread markt
Author: markt Date: Mon Jun 27 15:21:54 2011 New Revision: 1140205 URL: http://svn.apache.org/viewvc?rev=1140205&view=rev Log: Updated patch Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?

DO NOT REPLY [Bug 51400] Use of "new String(byte[] b, String enc)" hits Sun JVM bottleneck

2011-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51400 Mark Thomas changed: What|Removed |Added Attachment #27211|0 |1 is obsolete|

svn commit: r1140204 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2011-06-27 Thread markt
Author: markt Date: Mon Jun 27 15:19:22 2011 New Revision: 1140204 URL: http://svn.apache.org/viewvc?rev=1140204&view=rev Log: Need to include aliases in charset cache Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java Modified: tomcat/trunk/java/org/apache/tomcat/util/

svn commit: r1140202 - in /tomcat/site/trunk: docs/migration.html xdocs/migration.xml

2011-06-27 Thread markt
Author: markt Date: Mon Jun 27 15:15:40 2011 New Revision: 1140202 URL: http://svn.apache.org/viewvc?rev=1140202&view=rev Log: Add config file diffs for 6.0.x Modified: tomcat/site/trunk/docs/migration.html tomcat/site/trunk/xdocs/migration.xml Modified: tomcat/site/trunk/docs/migration.

svn commit: r1140201 - in /tomcat/trunk/webapps/docs: changelog.xml project.xml upgrading.xml

2011-06-27 Thread markt
Author: markt Date: Mon Jun 27 15:11:45 2011 New Revision: 1140201 URL: http://svn.apache.org/viewvc?rev=1140201&view=rev Log: Remove upgrading info - it has been added to the site Removed: tomcat/trunk/webapps/docs/upgrading.xml Modified: tomcat/trunk/webapps/docs/changelog.xml tomca

svn commit: r1140190 - in /tomcat/site/trunk: docs/migration.html xdocs/migration.xml

2011-06-27 Thread markt
Author: markt Date: Mon Jun 27 14:57:38 2011 New Revision: 1140190 URL: http://svn.apache.org/viewvc?rev=1140190&view=rev Log: Add config file diff to the migration page Modified: tomcat/site/trunk/docs/migration.html tomcat/site/trunk/xdocs/migration.xml Modified: tomcat/site/trunk/docs

svn commit: r1140184 - in /tomcat/site/trunk: docs/migration.html xdocs/migration.xml

2011-06-27 Thread markt
Author: markt Date: Mon Jun 27 14:47:44 2011 New Revision: 1140184 URL: http://svn.apache.org/viewvc?rev=1140184&view=rev Log: Prep before moving the new upgrade info from the Tomcat 7 docs to the website Modified: tomcat/site/trunk/docs/migration.html tomcat/site/trunk/xdocs/migration.xm

DO NOT REPLY [Bug 51400] Use of "new String(byte[] b, String enc)" hits Sun JVM bottleneck

2011-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51400 --- Comment #19 from Mark Thomas 2011-06-27 14:46:55 UTC --- (In reply to comment #18) > Hi Mark, > > does the patch not correctly address DoS and charset misses because I didn't > use Locale.US? My bad. I mis-read the patch (too much ti

DO NOT REPLY [Bug 51400] Use of "new String(byte[] b, String enc)" hits Sun JVM bottleneck

2011-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51400 --- Comment #18 from Konstantin Preißer 2011-06-27 14:40:57 UTC --- Hi Mark, does the patch not correctly address DoS and charset misses because I didn't use Locale.US? (Nothing would be added to the Map after initialization, so I can't s

svn commit: r1140180 - in /tomcat/site/trunk: docs/migration.html xdocs/migration.xml

2011-06-27 Thread markt
Author: markt Date: Mon Jun 27 14:39:19 2011 New Revision: 1140180 URL: http://svn.apache.org/viewvc?rev=1140180&view=rev Log: Tweak text Modified: tomcat/site/trunk/docs/migration.html tomcat/site/trunk/xdocs/migration.xml Modified: tomcat/site/trunk/docs/migration.html URL: http://svn

svn commit: r1140169 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-06-27 Thread markt
Author: markt Date: Mon Jun 27 14:07:59 2011 New Revision: 1140169 URL: http://svn.apache.org/viewvc?rev=1140169&view=rev Log: Updated patch Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?

DO NOT REPLY [Bug 51400] Use of "new String(byte[] b, String enc)" hits Sun JVM bottleneck

2011-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51400 Mark Thomas changed: What|Removed |Added Attachment #27189|0 |1 is obsolete|

svn commit: r1140162 - /tomcat/trunk/java/org/apache/tomcat/util/buf/res/

2011-06-27 Thread markt
Author: markt Date: Mon Jun 27 13:57:23 2011 New Revision: 1140162 URL: http://svn.apache.org/viewvc?rev=1140162&view=rev Log: Remove unused files Removed: tomcat/trunk/java/org/apache/tomcat/util/buf/res/ - To unsubscribe,

DO NOT REPLY [Bug 51400] Use of "new String(byte[] b, String enc)" hits Sun JVM bottleneck

2011-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51400 --- Comment #16 from Mark Thomas 2011-06-27 13:51:46 UTC --- I've updated the 7.0.x code to: - address the DOS concerns - pre-populate the cache - ensure cache misses are efficient I'll create a patch for 6.0.x shortly. -- Configure bugm

svn commit: r1140156 - in /tomcat/trunk/java/org/apache/tomcat/util/buf: B2CConverter.java Constants.java LocalStrings.properties

2011-06-27 Thread markt
Author: markt Date: Mon Jun 27 13:39:13 2011 New Revision: 1140156 URL: http://svn.apache.org/viewvc?rev=1140156&view=rev Log: Pre-populate Charset cache. Since cache is pre-populated, no need to look up non-matching values which effectively caches misses too. Added: tomcat/trunk/java/org/ap

svn commit: r1140153 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2011-06-27 Thread markt
Author: markt Date: Mon Jun 27 13:23:28 2011 New Revision: 1140153 URL: http://svn.apache.org/viewvc?rev=1140153&view=rev Log: Prevent multiple variations of the same sncoding filling up the cache Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java Modified: tomcat/trunk

DO NOT REPLY [Bug 51400] Use of "new String(byte[] b, String enc)" hits Sun JVM bottleneck

2011-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51400 --- Comment #15 from Mark Thomas 2011-06-27 13:18:35 UTC --- The patch doesn't correctly address the DOS concerns, neither does it cache misses. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You

DO NOT REPLY [Bug 49711] HttpServletRequest#getParts() does not work in a Filter

2011-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49711 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|

DO NOT REPLY [Bug 49711] HttpServletRequest#getParts() does not work in a Filter

2011-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49711 nsnosp...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|F

DO NOT REPLY [Bug 51437] New: JVM crash when SSL connector is enabled

2011-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51437 Bug #: 51437 Summary: JVM crash when SSL connector is enabled Product: Tomcat Native Version: 1.1.20 Platform: Other OS/Version: Windows Server 2003 Status: NEW

[SECURITY] CVE-2011-2204 - Apache Tomcat information disclosure

2011-06-27 Thread Mark Thomas
CVE-2011-2204 Apache Tomcat information disclosure Severity: Low Vendor: The Apache Software Foundation Versions Affected: - Tomcat 7.0.0 to 7.0.16 - Tomcat 6.0.0 to 6.0.32 - Tomcat 5.5.0 to 5.5.33 Earlier, unsupported versions may also be affected Description: When using the MemoryUserDatabase

svn commit: r1140086 - /tomcat/trunk/webapps/docs/changelog.xml

2011-06-27 Thread markt
Author: markt Date: Mon Jun 27 10:23:45 2011 New Revision: 1140086 URL: http://svn.apache.org/viewvc?rev=1140086&view=rev Log: Fix typo Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/

DO NOT REPLY [Bug 51436] New: ServletRequestListener fails to access request parameters when an Expect-Header is sent

2011-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51436 Bug #: 51436 Summary: ServletRequestListener fails to access request parameters when an Expect-Header is sent Product: Tomcat 7 Version: trunk Platform: PC O

svn commit: r1140074 - in /tomcat/site/trunk: docs/security-5.html docs/security-6.html docs/security-7.html xdocs/security-5.xml xdocs/security-6.xml xdocs/security-7.xml

2011-06-27 Thread markt
Author: markt Date: Mon Jun 27 09:30:59 2011 New Revision: 1140074 URL: http://svn.apache.org/viewvc?rev=1140074&view=rev Log: Updates for CVE-2011-2204 Modified: tomcat/site/trunk/docs/security-5.html tomcat/site/trunk/docs/security-6.html tomcat/site/trunk/docs/security-7.html t

svn commit: r1140072 - in /tomcat/tc5.5.x/trunk/container: catalina/src/share/org/apache/catalina/mbeans/ catalina/src/share/org/apache/catalina/users/ webapps/docs/

2011-06-27 Thread markt
Author: markt Date: Mon Jun 27 09:28:44 2011 New Revision: 1140072 URL: http://svn.apache.org/viewvc?rev=1140072&view=rev Log: Fix CVE-2011-2204. Prevent user passwords appearing in log files if a runtime exception (e.g. OOME) occurs while creating a new user for a MemoryUserDatabase via JMX. Mo

svn commit: r1140071 - in /tomcat/tc6.0.x/trunk: java/org/apache/catalina/mbeans/MemoryUserDatabaseMBean.java java/org/apache/catalina/users/MemoryUser.java java/org/apache/catalina/users/MemoryUserDa

2011-06-27 Thread markt
Author: markt Date: Mon Jun 27 09:27:20 2011 New Revision: 1140071 URL: http://svn.apache.org/viewvc?rev=1140071&view=rev Log: Fix CVE-2011-2204. Prevent user passwords appearing in log files if a runtime exception (e.g. OOME) occurs while creating a new user for a MemoryUserDatabase via JMX. Mo

svn commit: r1140070 - in /tomcat/trunk: java/org/apache/catalina/mbeans/MemoryUserDatabaseMBean.java java/org/apache/catalina/users/MemoryUser.java java/org/apache/catalina/users/MemoryUserDatabase.j

2011-06-27 Thread markt
Author: markt Date: Mon Jun 27 09:27:06 2011 New Revision: 1140070 URL: http://svn.apache.org/viewvc?rev=1140070&view=rev Log: Fix CVE-2011-2204. Prevent user passwords appearing in log files if a runtime exception (e.g. OOME) occurs while creating a new user for a MemoryUserDatabase via JMX. Mo

Re: svn commit: r1139576 - in /tomcat/trunk/webapps/docs: changelog.xml project.xml upgrading.xml

2011-06-27 Thread Mark Thomas
On 27/06/2011 07:27, Konstantin Kolinko wrote: > 2011/6/25 : >> Author: markt >> Date: Sat Jun 25 17:47:46 2011 >> New Revision: 1139576 >> >> URL: http://svn.apache.org/viewvc?rev=1139576&view=rev >> Log: >> Add an upgrade page to the documentation that can be used to determine the >> changes in