Proposal for the system information displayed by the default error handling of Tomcat

Hi, Currently the Tomcat security documentation says that the server information displayed in the default error pages can be configured through the ‘CATALINA_HOME/lib/org/apache/catalina/util/ SystemInfo.properties’ file. I think it makes sense, to use the server attribute value of HTTP connector

[Tomcat Wiki] Update of "LocalBadContent" by ChuckCaldarale

Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "LocalBadContent" page has been changed by ChuckCaldarale: http://wiki.apache.org/tomcat/LocalBadContent?action=diff&rev1=19&rev2=20 o-f\.com paisi\.com paisidesign\.com + pay

[Tomcat Wiki] Update of "FAQ" by babayaga

Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "FAQ" page has been changed by babayaga: http://wiki.apache.org/tomcat/FAQ?action=diff&rev1=50&rev2=51 * Read the docs. Most answers are already documented. * Know the [

DO NOT REPLY [Bug 51408] String.getBytes() and new String(byte[]) use default charset - may cause problems in some Locales

https://issues.apache.org/bugzilla/show_bug.cgi?id=51408 --- Comment #5 from Sebb 2011-06-22 00:19:06 UTC --- Sorry, I see now that the subject was misleading. I was actually referring to the calls to getBytes(Charset.defaultCharset()) which were added recently in r1138019. There are lots more

DO NOT REPLY [Bug 51400] Use of "new String(byte[] b, String enc)" hits Sun JVM bottleneck

https://issues.apache.org/bugzilla/show_bug.cgi?id=51400 --- Comment #8 from Konstantin Kolinko 2011-06-22 00:18:40 UTC --- Maybe we could cache not only found charsets, but charset misses as well. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are

DO NOT REPLY [Bug 51408] String.getBytes() and new String(byte[]) use default charset - may cause problems in some Locales

https://issues.apache.org/bugzilla/show_bug.cgi?id=51408 --- Comment #4 from Konstantin Kolinko 2011-06-21 23:57:20 UTC --- (In reply to comment #0) > There seem to be rather a lot of instances where Strings and bytes are > cconverted using the default charset. Please be specific! Searching th

svn commit: r1138207 - /tomcat/tc6.0.x/trunk/STATUS.txt

Author: kfujino Date: Tue Jun 21 21:55:47 2011 New Revision: 1138207 URL: http://svn.apache.org/viewvc?rev=1138207&view=rev Log: BZ51306 already fixed. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/

DO NOT REPLY [Bug 51400] Use of "new String(byte[] b, String enc)" hits Sun JVM bottleneck

https://issues.apache.org/bugzilla/show_bug.cgi?id=51400 --- Comment #7 from Konstantin Preißer 2011-06-21 19:25:02 UTC --- Hi, could/should this also be fixed for calls to new OutputStreamWriter(OutputStream out, String charsetName)? For example, org.apache.tomcat.util.buf.WriteConvertor (in

svn commit: r1138132 - in /tomcat/trunk/java/org/apache/catalina/valves: SemaphoreValve.java StuckThreadDetectionValve.java

Author: markt Date: Tue Jun 21 18:44:58 2011 New Revision: 1138132 URL: http://svn.apache.org/viewvc?rev=1138132&view=rev Log: Fix Eclipse warnings in Valves Modified: tomcat/trunk/java/org/apache/catalina/valves/SemaphoreValve.java tomcat/trunk/java/org/apache/catalina/valves/StuckThread

svn commit: r1138126 - /tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java

Author: markt Date: Tue Jun 21 18:41:42 2011 New Revision: 1138126 URL: http://svn.apache.org/viewvc?rev=1138126&view=rev Log: Fix Eclipse warnings / remove unused code Modified: tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java Modified: tomcat/trunk/java/org/apache/catalina/

svn commit: r1138123 - /tomcat/trunk/res/findbugs/filter-false-positives.xml

Author: markt Date: Tue Jun 21 18:34:46 2011 New Revision: 1138123 URL: http://svn.apache.org/viewvc?rev=1138123&view=rev Log: Another fp Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml URL: http://svn.apache.org/

svn commit: r1138121 - in /tomcat/trunk/java/org/apache/catalina/ssi: SSIConditional.java SSIConfig.java SSIEcho.java SSIExec.java SSIFilter.java SSIFlastmod.java SSIFsize.java SSIInclude.java SSIPrin

Author: markt Date: Tue Jun 21 18:32:41 2011 New Revision: 1138121 URL: http://svn.apache.org/viewvc?rev=1138121&view=rev Log: Fix warnings in SSI package Modified: tomcat/trunk/java/org/apache/catalina/ssi/SSIConditional.java tomcat/trunk/java/org/apache/catalina/ssi/SSIConfig.java t

svn commit: r1138115 - /tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

Author: markt Date: Tue Jun 21 18:15:56 2011 New Revision: 1138115 URL: http://svn.apache.org/viewvc?rev=1138115&view=rev Log: Remove unused code Modified: tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java Modified: tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapt

DO NOT REPLY [Bug 51408] String.getBytes() and new String(byte[]) use default charset - may cause problems in some Locales

https://issues.apache.org/bugzilla/show_bug.cgi?id=51408 Mark Thomas changed: What|Removed |Added Severity|normal |enhancement --- Comment #3 from Mark

DO NOT REPLY [Bug 51408] String.getBytes() and new String(byte[]) use default charset - may cause problems in some Locales

https://issues.apache.org/bugzilla/show_bug.cgi?id=51408 Christopher Schultz changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|

DO NOT REPLY [Bug 51400] Use of "new String(byte[] b, String enc)" hits Sun JVM bottleneck

https://issues.apache.org/bugzilla/show_bug.cgi?id=51400 --- Comment #6 from Mark Thomas 2011-06-21 16:13:44 UTC --- Proposed for 6.0.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for

svn commit: r1138073 - /tomcat/tc6.0.x/trunk/STATUS.txt

Author: markt Date: Tue Jun 21 16:13:34 2011 New Revision: 1138073 URL: http://svn.apache.org/viewvc?rev=1138073&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1

DO NOT REPLY [Bug 51400] Use of "new String(byte[] b, String enc)" hits Sun JVM bottleneck

https://issues.apache.org/bugzilla/show_bug.cgi?id=51400 Mark Thomas changed: What|Removed |Added Attachment #27186|0 |1 is obsolete|

DO NOT REPLY [Bug 51407] B2CConverter constructor calls overridable reset() method

https://issues.apache.org/bugzilla/show_bug.cgi?id=51407 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 51408] String.getBytes() and new String(byte[]) use default charset - may cause problems in some Locales

https://issues.apache.org/bugzilla/show_bug.cgi?id=51408 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 51408] New: String.getBytes() and new String(byte[]) use default charset - may cause problems in some Locales

https://issues.apache.org/bugzilla/show_bug.cgi?id=51408 Bug #: 51408 Summary: String.getBytes() and new String(byte[]) use default charset - may cause problems in some Locales Product: Tomcat 7 Version: trunk Platform: PC

DO NOT REPLY [Bug 51407] New: B2CConverter constructor calls overridable reset() method

https://issues.apache.org/bugzilla/show_bug.cgi?id=51407 Bug #: 51407 Summary: B2CConverter constructor calls overridable reset() method Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP

DO NOT REPLY [Bug 51400] Use of "new String(byte[] b, String enc)" hits Sun JVM bottleneck

https://issues.apache.org/bugzilla/show_bug.cgi?id=51400 --- Comment #4 from Mark Thomas 2011-06-21 15:10:00 UTC --- Unfortunately, Tomcat 6 implements Servlet 2.5 and that requires Java 1.5 support. That means we can't use any of the String method that use Charset. http://halfbottle.blogspot.co

DO NOT REPLY [Bug 51400] Use of "new String(byte[] b, String enc)" hits Sun JVM bottleneck

https://issues.apache.org/bugzilla/show_bug.cgi?id=51400 --- Comment #3 from Konstantin Preißer 2011-06-21 15:05:53 UTC --- Hello, please note that String.getBytes(Charset charset), new String(byte[] bytes, Charset charset) etc. are available since Java 1.6 only, so these probably can't be used

svn commit: r1138022 - /tomcat/trunk/java/org/apache/catalina/tribes/membership/Constants.java

Author: markt Date: Tue Jun 21 14:39:17 2011 New Revision: 1138022 URL: http://svn.apache.org/viewvc?rev=1138022&view=rev Log: Revert to previous, no need for Charset here. Modified: tomcat/trunk/java/org/apache/catalina/tribes/membership/Constants.java Modified: tomcat/trunk/java/org/apache

DO NOT REPLY [Bug 51400] Use of "new String(byte[] b, String enc)" hits Sun JVM bottleneck

https://issues.apache.org/bugzilla/show_bug.cgi?id=51400 --- Comment #2 from Mark Thomas 2011-06-21 14:32:27 UTC --- Thanks for the report and the patch. I've gone through the 7.0.x codebase and changed almost all of the calls to: new String(byte[] b, String encoding) String.getBytes()

svn commit: r1138019 - in /tomcat/trunk: java/org/apache/catalina/ant/ java/org/apache/catalina/authenticator/ java/org/apache/catalina/connector/ java/org/apache/catalina/ha/backend/ java/org/apache/

Author: markt Date: Tue Jun 21 14:29:49 2011 New Revision: 1138019 URL: http://svn.apache.org/viewvc?rev=1138019&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51400 Avoid known bottleneck in JVM when converting between Strings and bytes by always providing a Charset rather

DO NOT REPLY [Bug 51403] Avoid NullPointerException in JULI FileHandler if formatter is misconfigured

https://issues.apache.org/bugzilla/show_bug.cgi?id=51403 Konstantin Kolinko changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1137998 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

Author: kkolinko Date: Tue Jun 21 13:27:07 2011 New Revision: 1137998 URL: http://svn.apache.org/viewvc?rev=1137998&view=rev Log: proposal Modified: tomcat/tc5.5.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewv

svn commit: r1137996 - in /tomcat/trunk: java/org/apache/juli/FileHandler.java webapps/docs/changelog.xml

Author: kkolinko Date: Tue Jun 21 13:24:44 2011 New Revision: 1137996 URL: http://svn.apache.org/viewvc?rev=1137996&view=rev Log: Avoid NullPointerException in JULI FileHandler if formatter is misconfigured Fixes https://issues.apache.org/bugzilla/post_bug.cgi Modified: tomcat/trunk/java/org/

DO NOT REPLY [Bug 51403] New: Avoid NullPointerException in JULI FileHandler if formatter is misconfigured

https://issues.apache.org/bugzilla/show_bug.cgi?id=51403 Bug #: 51403 Summary: Avoid NullPointerException in JULI FileHandler if formatter is misconfigured Product: Tomcat 7 Version: 7.0.16 Platform: PC OS/Version:

Re: svn commit: r1137638 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java Http11AprProtocol.java

2011/6/21 Mark Thomas : > On 21/06/2011 13:00, Konstantin Kolinko wrote: >> Why setting socket reference in InputBuffer and OutputBuffer is >> "unnecessary" here in async processing, but is still present for the >> non-async case. > > Because during the processing of a request, asyncDispatch() can

Re: svn commit: r1137638 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java Http11AprProtocol.java

On 21/06/2011 13:00, Konstantin Kolinko wrote: > Why setting socket reference in InputBuffer and OutputBuffer is > "unnecessary" here in async processing, but is still present for the > non-async case. Because during the processing of a request, asyncDispatch() can only ever be called after proces

Re: svn commit: r1137638 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java Http11AprProtocol.java

Why setting socket reference in InputBuffer and OutputBuffer is "unnecessary" here in async processing, but is still present for the non-async case. I do not understand why you removed the code. 2011/6/20 : > Author: markt > Date: Mon Jun 20 14:24:19 2011 > New Revision: 1137638 > > URL: http:/

svn propchange: r1137646 - svn:log

Author: kkolinko Revision: 1137646 Modified property: svn:log Modified: svn:log at Tue Jun 21 11:51:52 2011 -- --- svn:log (original) +++ svn:log Tue Jun 21 11:51:52 2011 @@ -1 +1 @@ -Packages tag files have jndi URLs not

DO NOT REPLY [Bug 51306] NPE in DeltaRequest.writeExternal(DeltaRequest.java:267) when handling remote session expiration

https://issues.apache.org/bugzilla/show_bug.cgi?id=51306 Keiichi Fujino changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1137962 - in /tomcat/tc6.0.x/trunk: java/org/apache/catalina/ha/session/DeltaManager.java java/org/apache/catalina/ha/session/DeltaSession.java webapps/docs/changelog.xml

Author: kfujino Date: Tue Jun 21 11:33:03 2011 New Revision: 1137962 URL: http://svn.apache.org/viewvc?rev=1137962&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51306. Avoid NPE when handleSESSION_EXPIRED is processed while handleSESSION_CREATED is being processed. Modifie

DO NOT REPLY [Bug 51400] Use of "new String(byte[] b, String enc)" hits Sun JVM bottleneck

https://issues.apache.org/bugzilla/show_bug.cgi?id=51400 Mark Thomas changed: What|Removed |Added Attachment #27186|0 |1 is patch|

DO NOT REPLY [Bug 51401] java.lang.IllegalArgumentException: element is limited to 1 occurrence

https://issues.apache.org/bugzilla/show_bug.cgi?id=51401 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1137957 - in /tomcat/trunk: java/org/apache/catalina/startup/WebRuleSet.java webapps/docs/changelog.xml

Author: markt Date: Tue Jun 21 11:10:47 2011 New Revision: 1137957 URL: http://svn.apache.org/viewvc?rev=1137957&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51401 Correctly initialise shared WebRuleSet instance used by the digesters that parse web.xml and prevent incorrec

DO NOT REPLY [Bug 51401] java.lang.IllegalArgumentException: element is limited to 1 occurrence

https://issues.apache.org/bugzilla/show_bug.cgi?id=51401 --- Comment #2 from Mark Thomas 2011-06-21 10:52:03 UTC --- Thanks for the report. The unit tests picked up a similar issue. The problem was caused by r1137753. Investigating now... -- Configure bugmail: https://issues.apache.org/bugzilla

svn commit: r1137932 - /tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java

Author: kkolinko Date: Tue Jun 21 10:20:28 2011 New Revision: 1137932 URL: http://svn.apache.org/viewvc?rev=1137932&view=rev Log: Add missing comma Modified: tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java Modified: tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTe

svn commit: r1137931 - in /tomcat/trunk: conf/catalina.properties test/org/apache/catalina/startup/TomcatBaseTest.java

Author: kkolinko Date: Tue Jun 21 10:17:17 2011 New Revision: 1137931 URL: http://svn.apache.org/viewvc?rev=1137931&view=rev Log: Align tomcat.util.scan.DefaultJarScanner.jarsToSkip value in TomcatBaseTest. Add junit and ant-launcher to the value in catalina.properties Modified: tomcat/trunk/

svn commit: r1137925 - /tomcat/trunk/java/org/apache/juli/OneLineFormatter.java

Author: kkolinko Date: Tue Jun 21 10:02:56 2011 New Revision: 1137925 URL: http://svn.apache.org/viewvc?rev=1137925&view=rev Log: Add @Override Use buf.add(char) when there is a single character string Modified: tomcat/trunk/java/org/apache/juli/OneLineFormatter.java Modified: tomcat/trunk/j

Re: Overhauling setclasspath.(bat|sh)?

2011/6/20 Rainer Jung : > 1) Renaming > > Since quite some time now the setclasspath script doesn't have anything > to do with setting a class path. It only searches for JRE / JDK and sets > up the path to the Java or JDB binary plus JAVA_ENDORSED_DIRS. > > So it would be more correct to call it ch

[GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test has an issue affecting its community integration. This i

svn commit: r1137914 - /tomcat/trunk/webapps/docs/changelog.xml

Author: kkolinko Date: Tue Jun 21 08:58:19 2011 New Revision: 1137914 URL: http://svn.apache.org/viewvc?rev=1137914&view=rev Log: Fix typos in committer ids Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/

Re: Hosting the current Tomcat Maven Plugin from mojo codehaus

On 24/01/2011 13:39, Olivier Lamy wrote: > Ok sounds reasonnable. > I will inform mojo community and at least start a vote in the mojo dev ml. > > Thanks, Ping. Any progress? Mark - To unsubscribe, e-mail: dev-unsubscr...@tom

svn commit: r1137909 - /tomcat/trunk/webapps/docs/changelog.xml

Author: rjung Date: Tue Jun 21 08:42:13 2011 New Revision: 1137909 URL: http://svn.apache.org/viewvc?rev=1137909&view=rev Log: Add comment on item ordering, update one entry, add one entry. Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml UR

Re: DO NOT REPLY [Bug 51206] CATALINA_BASE is not visible to setenv.sh

On 21.06.2011 09:54, bugzi...@apache.org wrote: > Rainer implemented this in 7.0.x and it will be included in 7.0.17 onwards. Sorry, this BZ slipped my attention. Thanks. Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.

svn commit: r1137900 - in /tomcat/site/trunk: docs/index.html xdocs/index.xml xdocs/stylesheets/tomcat-site.xsl

Author: kkolinko Date: Tue Jun 21 08:01:20 2011 New Revision: 1137900 URL: http://svn.apache.org/viewvc?rev=1137900&view=rev Log: Implement support for Google's site verification token. Mark is using one. Modified: tomcat/site/trunk/docs/index.html tomcat/site/trunk/xdocs/index.xml to

DO NOT REPLY [Bug 51206] CATALINA_BASE is not visible to setenv.sh

https://issues.apache.org/bugzilla/show_bug.cgi?id=51206 --- Comment #2 from Mark Thomas 2011-06-21 07:54:23 UTC --- Rainer implemented this in 7.0.x and it will be included in 7.0.17 onwards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are recei

Re: svn commit: r1137803 - /tomcat/trunk/webapps/docs/changelog.xml

On 21/06/2011 07:21, Konstantin Kolinko wrote: > 2011/6/21 Rainer Jung : >> On 21.06.2011 00:28, ma...@apache.org wrote: >>> Author: markt >>> Date: Mon Jun 20 22:28:57 2011 >>> New Revision: 1137803 >>> >>> URL: http://svn.apache.org/viewvc?rev=1137803&view=rev >>> Log: >>> Ordering >>> >>> Modifi

svn commit: r1137892 - in /tomcat/trunk/bin: catalina.bat catalina.sh

Author: rjung Date: Tue Jun 21 07:39:44 2011 New Revision: 1137892 URL: http://svn.apache.org/viewvc?rev=1137892&view=rev Log: Fix typo and more clarification about CATALINA_OPTS vs. JAVA_OPTS. Thanks to Rainer Frey. Modified: tomcat/trunk/bin/catalina.bat tomcat/trunk/bin/catalina.sh M

Re: svn commit: r1137866 - in /tomcat/trunk/bin: catalina.bat catalina.sh

On 21.06.2011, at 08:13, rj...@apache.org wrote: > rem JAVA_OPTS (Optional) Java runtime options used when the "start", > rem "stop", or "run" command is executed. This still sounds like JAVA_OPTS is not applied for version or configtest ... Maybe just remove the list of