DO NOT REPLY [Bug 51283] Session Fixation is solved without an invalidating of an existing HTTP session

2011-06-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51283 --- Comment #5 from Christopher Schultz 2011-06-04 04:40:14 UTC --- Mark was suggesting that if a plausible use-case were to be presented where an application should need the container to protect users from itself, he might consider such a

DO NOT REPLY [Bug 51283] Session Fixation is solved without an invalidating of an existing HTTP session

2011-06-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51283 --- Comment #4 from Michael 2011-06-04 03:45:53 UTC --- (In reply to comment #3) > As per my previous comment. Hi! Why you do not want to solve at as you suggested in the previous comment? I think session fixation configurable (do nothing

svn commit: r1131303 - /tomcat/jk/trunk/HOWTO-RELEASE.txt

2011-06-03 Thread timw
Author: timw Date: Sat Jun 4 01:45:14 2011 New Revision: 1131303 URL: http://svn.apache.org/viewvc?rev=1131303&view=rev Log: Updating JK release instructions - some files have changed, and some servers have moved. Modified: tomcat/jk/trunk/HOWTO-RELEASE.txt Modified: tomcat/jk/trunk/HOWTO-

Re: svn commit: r1131263 - in /tomcat/trunk: java/org/apache/catalina/session/JDBCStore.java java/org/apache/catalina/session/LocalStrings.properties webapps/docs/changelog.xml webapps/docs/config/man

2011-06-03 Thread Mark Thomas
On 03/06/2011 23:41, Tim Funk wrote: > If NamingExceptionOccurs - should this instead rethrow a SqlException > instead of letting the logic keep going? Otherwise wouldn't a SqlException > be thrown later in the method? Don't think so. If the lookup is invalid dataSource will be null so it should f

Re: svn commit: r1131263 - in /tomcat/trunk: java/org/apache/catalina/session/JDBCStore.java java/org/apache/catalina/session/LocalStrings.properties webapps/docs/changelog.xml webapps/docs/config/man

2011-06-03 Thread Tim Funk
If NamingExceptionOccurs - should this instead rethrow a SqlException instead of letting the logic keep going? Otherwise wouldn't a SqlException be thrown later in the method? -Tim On Fri, Jun 3, 2011 at 6:13 PM, wrote: > Author: markt > Date: Fri Jun 3 22:13:09 2011 > New Revision: 1131263 >

DO NOT REPLY [Bug 51142] Offer possible resolution of StringIndexOutOfBoundsException in Request.updateCounters when AJP packetSize is too small.

2011-06-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51142 --- Comment #4 from Mark Thomas 2011-06-03 22:35:11 UTC --- No, you missed the key point in my review comment. Putting a try/catch around the point where the error is first seen is the wrong approach. The right approach is detecting when th

DO NOT REPLY [Bug 51251] Patch to add version parameter to ant task

2011-06-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51251 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1131267 - in /tomcat/trunk: java/org/apache/catalina/ant/ webapps/docs/

2011-06-03 Thread markt
Author: markt Date: Fri Jun 3 22:22:35 2011 New Revision: 1131267 URL: http://svn.apache.org/viewvc?rev=1131267&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51251 Add web application version support to the Ant tasks. Based on a patch provided by Eiji Takahashi. Added:

DO NOT REPLY [Bug 51251] Patch to add version parameter to ant task

2011-06-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51251 Mark Thomas changed: What|Removed |Added Attachment #27049|0 |1 is patch|

DO NOT REPLY [Bug 51264] Context/Manager/Store configuration proposal

2011-06-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51264 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1131263 - in /tomcat/trunk: java/org/apache/catalina/session/JDBCStore.java java/org/apache/catalina/session/LocalStrings.properties webapps/docs/changelog.xml webapps/docs/config/manager

2011-06-03 Thread markt
Author: markt Date: Fri Jun 3 22:13:09 2011 New Revision: 1131263 URL: http://svn.apache.org/viewvc?rev=1131263&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51264 Allow the JDBC persistent session store to use a JNDI datasource to define the database in which sessions are

DO NOT REPLY [Bug 51316] Tomcat does not redirect to configured http 500 error-page

2011-06-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51316 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 51315] Removing Valve from StandardContext causes IllegalArgumentException

2011-06-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51315 Mark Thomas changed: What|Removed |Added OS/Version||All --- Comment #1 from Mark Thomas

svn commit: r1131132 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-06-03 Thread markt
Author: markt Date: Fri Jun 3 18:15:29 2011 New Revision: 1131132 URL: http://svn.apache.org/viewvc?rev=1131132&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1

svn commit: r1131126 - /tomcat/trunk/java/org/apache/catalina/deploy/WebXml.java

2011-06-03 Thread markt
Author: markt Date: Fri Jun 3 18:07:24 2011 New Revision: 1131126 URL: http://svn.apache.org/viewvc?rev=1131126&view=rev Log: Fix TCK failure exposed by the fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=51278 A previous change to ensure web.xml had precedence over fragments and ann

Re: Plan for 7.0.15

2011-06-03 Thread Filip Hanik - Dev Lists
On 6/3/2011 10:13 AM, Mark Thomas wrote: On 03/06/2011 17:07, Filip Hanik - Dev Lists wrote: I'd like to suggest that we include tomcat-jdbc.jar in the 7.0.15 release. DBCP will still be the default, but allows users to configure an alternative fairly easily without downloading separate librarie

Re: Plan for 7.0.15

2011-06-03 Thread Mark Thomas
On 03/06/2011 17:07, Filip Hanik - Dev Lists wrote: > I'd like to suggest that we include tomcat-jdbc.jar in the 7.0.15 release. > DBCP will still be the default, but allows users to configure an > alternative fairly easily without downloading separate libraries. > > It's easy to include in the bu

Re: Plan for 7.0.15

2011-06-03 Thread Filip Hanik - Dev Lists
I'd like to suggest that we include tomcat-jdbc.jar in the 7.0.15 release. DBCP will still be the default, but allows users to configure an alternative fairly easily without downloading separate libraries. It's easy to include in the build process, the jar is very small, so it doesn't bloat the

DO NOT REPLY [Bug 51316] New: Tomcat does not redirect to configured http 500 error-page

2011-06-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51316 Bug #: 51316 Summary: Tomcat does not redirect to configured http 500 error-page Product: Tomcat 5 Version: 5.5.27 Platform: PC OS/Version: Linux

DO NOT REPLY [Bug 51309] Patch to better stop support with CATALINA_PID

2011-06-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51309 --- Comment #2 from Caio Cezar 2011-06-03 10:55:10 UTC --- (In reply to comment #1) > Thanks for the patch. > > For future reference patches work best as attachments the lines are likely to > get wrapped if you paste them in the comments b

DO NOT REPLY [Bug 51315] Removing Valve from StandardContext causes IllegalArgumentException

2011-06-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51315 violet...@apache.org changed: What|Removed |Added OS/Version||Windows 7 -- Configure bugm

DO NOT REPLY [Bug 51315] Removing Valve from StandardContext causes IllegalArgumentException

2011-06-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51315 violet...@apache.org changed: What|Removed |Added OS/Version||Windows 7 -- Configure bugm

DO NOT REPLY [Bug 51315] New: Removing Valve from StandardContext causes IllegalArgumentException

2011-06-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51315 Bug #: 51315 Summary: Removing Valve from StandardContext causes IllegalArgumentException Product: Tomcat 6 Version: 6.0.32 Platform: PC Status: NEW

DO NOT REPLY [Bug 47880] Lack of +x permissions on script files results cryptic and confusing error messages

2011-06-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47880 --- Comment #6 from Mark Thomas 2011-06-03 08:27:07 UTC --- Fixed in 6.0.x and will be included in 6.0.33 onwards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail becaus

svn commit: r1130937 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt bin/digest.sh bin/shutdown.sh bin/startup.sh bin/version.sh webapps/docs/changelog.xml

2011-06-03 Thread markt
Author: markt Date: Fri Jun 3 08:27:13 2011 New Revision: 1130937 URL: http://svn.apache.org/viewvc?rev=1130937&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47880 Clarify error messages in *.sh files to mention that if a script is not found it might be because execute per

DO NOT REPLY [Bug 50887] Enhancement to set security-provider within AjpAprProcessor

2011-06-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50887 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1130936 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/catalina/valves/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ webapps/docs/ webapps/docs/config/

2011-06-03 Thread markt
Author: markt Date: Fri Jun 3 08:17:02 2011 New Revision: 1130936 URL: http://svn.apache.org/viewvc?rev=1130936&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50887 Enable the provider to be configured when generating SSL certs Based on a patch by pknopp Modified: tomca

svn commit: r1130935 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/jasper/servlet/JspServletWrapper.java webapps/docs/changelog.xml

2011-06-03 Thread markt
Author: markt Date: Fri Jun 3 08:10:00 2011 New Revision: 1130935 URL: http://svn.apache.org/viewvc?rev=1130935&view=rev Log: Fix possible threading issue in JSP compilation when development mode is enabled Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat/tc6.0.x/trunk/STATUS.txt

DO NOT REPLY [Bug 48863] Log directory misconfiguration for class loaders

2011-06-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48863 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|

svn commit: r1130932 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/startup/ClassLoaderFactory.java webapps/docs/changelog.xml

2011-06-03 Thread markt
Author: markt Date: Fri Jun 3 08:01:35 2011 New Revision: 1130932 URL: http://svn.apache.org/viewvc?rev=1130932&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48863 Provide an warning if there is a problem with a class path entry but use debug level logging if it is expecte

DO NOT REPLY [Bug 50726] Jasper can generate uncompilable source code if genStringAsCharArray is turned on

2011-06-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50726 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1130919 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/jasper/compiler/Generator.java webapps/docs/changelog.xml

2011-06-03 Thread markt
Author: markt Date: Fri Jun 3 07:30:56 2011 New Revision: 1130919 URL: http://svn.apache.org/viewvc?rev=1130919&view=rev Log: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50726 Ensure that the use of the genStringAsCharArray does not result in String constants that are too long for v