https://issues.apache.org/bugzilla/show_bug.cgi?id=50744
--- Comment #9 from Konstantin Kolinko 2011-02-09
21:30:57 EST ---
Created an attachment (id=26630)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26630)
2011-02-11_tc55_50744_JSSESocketFactory.patch
(In reply to comment #8)
>
https://issues.apache.org/bugzilla/show_bug.cgi?id=50744
--- Comment #8 from Sridhar Murthy 2011-02-09 20:54:40 EST
---
Hi Konstantin:
If all the configuartions required for the Tomcat to start services on both
SSL port ( 8443) and non-SSL port (8080) are put in place in server.xml and
when T
https://issues.apache.org/bugzilla/show_bug.cgi?id=48717
David Rees changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Version|5.5.28
https://issues.apache.org/bugzilla/show_bug.cgi?id=50721
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
Author: markt
Date: Wed Feb 9 23:41:32 2011
New Revision: 1069170
URL: http://svn.apache.org/viewvc?rev=1069170&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50721
Correctly handle URL decoding where the URL ends in %nn.
Patch (for fix) provided by Christof Marti.
Additiona
Author: markt
Date: Wed Feb 9 23:13:00 2011
New Revision: 1069166
URL: http://svn.apache.org/viewvc?rev=1069166&view=rev
Log:
Ensure NamingResources follows correct lifecycle
Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
Modified: tomcat/trunk/java/org/apache/cat
https://issues.apache.org/bugzilla/show_bug.cgi?id=50748
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
https://issues.apache.org/bugzilla/show_bug.cgi?id=50748
Mark Thomas changed:
What|Removed |Added
CC||frank.schroe...@gmail.com
--- Commen
https://issues.apache.org/bugzilla/show_bug.cgi?id=50747
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
Author: markt
Date: Wed Feb 9 22:00:08 2011
New Revision: 1069135
URL: http://svn.apache.org/viewvc?rev=1069135&view=rev
Log:
The bug number changed
Modified:
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/
Author: markt
Date: Wed Feb 9 21:56:14 2011
New Revision: 1069131
URL: http://svn.apache.org/viewvc?rev=1069131&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50747
Allow the content length header to be set up to the point the response is
committed when a writer is used.
M
https://issues.apache.org/bugzilla/show_bug.cgi?id=50747
--- Comment #6 from Konstantin Kolinko 2011-02-09
16:54:08 EST ---
(In reply to comment #3)
> Tomcat could be a little smarter here.
For reference: I filed bug 50748 to deal with setContentLength() improvements.
(In reply to comment #4)
https://issues.apache.org/bugzilla/show_bug.cgi?id=50748
Summary: Ignoring setContentLength( ) when using writer is
incomplete
Product: Tomcat 7
Version: trunk
Platform: PC
OS/Version: Windows XP
Status: NEW
https://issues.apache.org/bugzilla/show_bug.cgi?id=50747
--- Comment #5 from Mark Thomas 2011-02-09 16:16:04 EST ---
You can't change the encoding once the writer has been obtained since the
encoding is used to create the writer.
--
Configure bugmail: https://issues.apache.org/bugzilla/userpref
https://issues.apache.org/bugzilla/show_bug.cgi?id=50747
--- Comment #4 from Frank Schroeder 2011-02-09
15:55:29 EST ---
Sure, I can try that. While you're at it you can also check the encoding as it
wasn't set as well. The content type was OK. The reason I had this code was
because of this:
Pr
https://issues.apache.org/bugzilla/show_bug.cgi?id=50747
--- Comment #3 from Mark Thomas 2011-02-09 15:48:04 EST ---
Tomcat could be a little smarter here.
We currently ignore a call to setContentLength() after a call to getWriter().
However, we only have to ignore the content length once bytes
https://issues.apache.org/bugzilla/show_bug.cgi?id=50747
--- Comment #2 from Konstantin Kolinko 2011-02-09
15:39:00 EST ---
> String data = "...";
> response.setCharacterEncoding("UTF-8");
> response.setContentLength(data.length());
> PrintWriter writer = response.getWriter();
The above code is
https://issues.apache.org/bugzilla/show_bug.cgi?id=50747
Frank Schroeder changed:
What|Removed |Added
OS/Version||All
--- Comment #1 from Frank Sc
Author: markt
Date: Wed Feb 9 19:50:37 2011
New Revision: 1069060
URL: http://svn.apache.org/viewvc?rev=1069060&view=rev
Log:
Correct the package name
Modified:
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomca
Author: markt
Date: Wed Feb 9 19:46:49 2011
New Revision: 1069056
URL: http://svn.apache.org/viewvc?rev=1069056&view=rev
Log:
Add further checks that LifecycleBase sub-classes are correctly changing state.
Modified:
tomcat/trunk/java/org/apache/catalina/connector/MapperListener.java
tomc
https://issues.apache.org/bugzilla/show_bug.cgi?id=50744
--- Comment #7 from Sridhar Murthy 2011-02-09 14:26:44 EST
---
Created an attachment (id=26629)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26629)
This server.xml works correctly for both SSL and non-SSL port for Tomcat 5.5.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50744
--- Comment #6 from Konstantin Kolinko 2011-02-09
14:23:42 EST ---
>From the log:
Feb 8, 2011 8:40:32 PM org.apache.coyote.http11.Http11BaseProtocol init
INFO: Initializing Coyote HTTP/1.1 on http-8080
Feb 8, 2011 8:40:34 PM org.apache.co
https://issues.apache.org/bugzilla/show_bug.cgi?id=50747
Summary: CometProcessor does not flush and close HTTP/1.0
requests
Product: Tomcat 7
Version: 7.0.8
Platform: PC
Status: NEW
Severity: normal
Prio
https://issues.apache.org/bugzilla/show_bug.cgi?id=50744
Sridhar Murthy changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|INVAL
https://issues.apache.org/bugzilla/show_bug.cgi?id=50744
--- Comment #4 from Sridhar Murthy 2011-02-09 14:02:44 EST
---
Created an attachment (id=26628)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26628)
Catalina Log
--
Configure bugmail: https://issues.apache.org/bugzilla/userp
Author: markt
Date: Wed Feb 9 19:01:20 2011
New Revision: 1069032
URL: http://svn.apache.org/viewvc?rev=1069032&view=rev
Log:
add some arrows to the diagram
Modified:
tomcat/trunk/java/org/apache/catalina/Lifecycle.java
Modified: tomcat/trunk/java/org/apache/catalina/Lifecycle.java
URL:
ht
https://issues.apache.org/bugzilla/show_bug.cgi?id=50744
Christopher Schultz changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
On 09/02/2011 11:32, Konstantin Kolinko wrote:
> 2011/2/9 Mark Thomas :
>> On 09/02/2011 09:14, Konstantin Kolinko wrote:
>>> 1) Browsing the code in o.a.c.startup.Embedded#stopInternal() I see
>>> the following two lines:
>>>
>>> fireLifecycleEvent(STOP_EVENT, null);
>>> setState(L
https://issues.apache.org/bugzilla/show_bug.cgi?id=50744
--- Comment #2 from Konstantin Kolinko 2011-02-09
13:26:54 EST ---
(In reply to comment #0)
> Catalina logs have some errors and I have attached the log to this BUG
> report).
There is no attachment. Without seeing the actual error it is
Author: markt
Date: Wed Feb 9 18:25:48 2011
New Revision: 1069016
URL: http://svn.apache.org/viewvc?rev=1069016&view=rev
Log:
Better comments
Modified:
tomcat/trunk/java/org/apache/catalina/util/LifecycleBase.java
Modified: tomcat/trunk/java/org/apache/catalina/util/LifecycleBase.java
URL:
I'm glad you commented, there should be no looping at all. It was a left over
from a previous proposal
fixed in r1068996
Filip
On 2/9/2011 2:35 AM, kkoli...@apache.org wrote:
Author: kkolinko
Date: Wed Feb 9 09:35:16 2011
New Revision: 1068808
URL: http://svn.apache.org/viewvc?rev=1068808&vi
Author: fhanik
Date: Wed Feb 9 17:47:13 2011
New Revision: 1068996
URL: http://svn.apache.org/viewvc?rev=1068996&view=rev
Log:
remove loop that should not be used at all.
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java
Modified: tomcat/trunk/java/org/apache/cata
https://issues.apache.org/bugzilla/show_bug.cgi?id=50667
--- Comment #13 from Filip Hanik 2011-02-09 12:40:16 EST ---
(In reply to comment #12)
> Hi Filip,
>
> I would have thought the second callback could be implemented in the same
> class
> is the (Extended)RpcCallback, but at any rate it's
Author: fhanik
Date: Wed Feb 9 17:39:24 2011
New Revision: 1068989
URL: http://svn.apache.org/viewvc?rev=1068989&view=rev
Log:
https://issues.apache.org/bugzilla/show_bug.cgi?id=50667
Move the callback outside try/catch to avoid duplicate callbacks
Modified:
tomcat/trunk/java/org/apache/cata
https://issues.apache.org/bugzilla/show_bug.cgi?id=50744
Sridhar Murthy changed:
What|Removed |Added
CC||murt...@us.ibm.com
--
Configure
https://issues.apache.org/bugzilla/show_bug.cgi?id=50744
--- Comment #1 from Sridhar Murthy 2011-02-09 10:23:33 EST
---
The download source for Tomcat 5.5.32 is:
http://archive.apache.org/dist/tomcat/tomcat-5/v5.5.32/bin/
The files that were downloaded are:
_1_)
apache-tomcat-5.5.32-compat.ta
https://issues.apache.org/bugzilla/show_bug.cgi?id=50744
Sridhar Murthy changed:
What|Removed |Added
Summary|When Tomcat was updated |When Tomcat was updated
https://issues.apache.org/bugzilla/show_bug.cgi?id=50744
Summary: When Tomcat was updated from version 5.5.27 to 5.5.32,
SSL support for Tomcat does not work.
Product: Tomcat 5
Version: 5.5.32
Platform: Other
OS/Version: AIX
+1
On Feb 8, 2011, at 8:22 AM, Jim Jagielski wrote:
> Retagged, rerolled and reuploaded... ;)
>
> On Feb 8, 2011, at 8:04 AM, Jim Jagielski wrote:
>
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional c
Author: markt
Date: Wed Feb 9 12:26:24 2011
New Revision: 1068862
URL: http://svn.apache.org/viewvc?rev=1068862&view=rev
Log:
Prevent duplicate event messages
Modified:
tomcat/trunk/java/org/apache/catalina/startup/Embedded.java
Modified: tomcat/trunk/java/org/apache/catalina/startup/Embedd
2011/2/9 Mark Thomas :
> On 09/02/2011 09:14, Konstantin Kolinko wrote:
>> 1) Browsing the code in o.a.c.startup.Embedded#stopInternal() I see
>> the following two lines:
>>
>> fireLifecycleEvent(STOP_EVENT, null);
>> setState(LifecycleState.STOPPING);
>>
>> Unless I miss something
On 09/02/2011 09:14, Konstantin Kolinko wrote:
> 1) Browsing the code in o.a.c.startup.Embedded#stopInternal() I see
> the following two lines:
>
> fireLifecycleEvent(STOP_EVENT, null);
> setState(LifecycleState.STOPPING);
>
> Unless I miss something it means that STOP_EVENT is fi
https://issues.apache.org/bugzilla/show_bug.cgi?id=50743
Summary: Cache results to speed up Checkstyle #build
Product: Tomcat 7
Version: trunk
Platform: All
OS/Version: All
Status: NEW
Severity: enhancement
Priority
https://issues.apache.org/bugzilla/show_bug.cgi?id=50667
--- Comment #12 from Olivier Costet 2011-02-09 04:59:37
EST ---
Hi Filip,
I would have thought the second callback could be implemented in the same class
is the (Extended)RpcCallback, but at any rate it's your call. I got what I
wanted ou
https://issues.apache.org/bugzilla/show_bug.cgi?id=50734
--- Comment #2 from violet...@apache.org 2011-02-09 04:42:50 EST ---
Created an attachment (id=26626)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26626)
400 Bad Request issue - patch proposal
Hi,
Patch is made based on Tomcat
https://issues.apache.org/bugzilla/show_bug.cgi?id=50738
--- Comment #6 from Martin Grotzke 2011-02-09
04:40:28 EST ---
I just overwrote destroyInternal and debugged/logged, but it seems to be not
called for me, neither on context reload nor during stop (CTRL-C).
Anyway, so I'll move initializa
Author: kkolinko
Date: Wed Feb 9 09:35:16 2011
New Revision: 1068808
URL: http://svn.apache.org/viewvc?rev=1068808&view=rev
Log:
Followup to r1068549 - add annotations.
I thought about moving ErrorHandler instance creation outside the retry loop,
but actually that is not needed: looping happens
https://issues.apache.org/bugzilla/show_bug.cgi?id=50738
--- Comment #5 from Konstantin Kolinko 2011-02-09
04:21:13 EST ---
(In reply to comment #4)
> That was working fine for tomcat6. Should initialization be moved to
> startInternal?
Another solution could be to move destruction into destroy
1) Browsing the code in o.a.c.startup.Embedded#stopInternal() I see
the following two lines:
fireLifecycleEvent(STOP_EVENT, null);
setState(LifecycleState.STOPPING);
Unless I miss something it means that STOP_EVENT is fired twice, once
by the fireLifecycleEvent() call and second t
https://issues.apache.org/bugzilla/show_bug.cgi?id=50738
--- Comment #4 from Martin Grotzke 2011-02-09
03:40:13 EST ---
As I'm doing my initialization in initInternal:
https://github.com/magro/memcached-session-manager/blob/tomcat7/core/src/main/java/de/javakaffee/web/msm/MemcachedBackupSession
Author: jfclere
Date: Wed Feb 9 08:25:51 2011
New Revision: 1068787
URL: http://svn.apache.org/viewvc?rev=1068787&view=rev
Log:
See
http://www.oracle.com/technetwork/topics/security/alert-cve-2010-4476-305811.html
Modified:
tomcat/site/trunk/docs/security-5.html
tomcat/site/trunk/docs/s
https://issues.apache.org/bugzilla/show_bug.cgi?id=50738
--- Comment #3 from Konstantin Kolinko 2011-02-09
03:10:55 EST ---
> how do I know that I need to invoke initInternal by myself
Why do you need to invoke it?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=ema
https://issues.apache.org/bugzilla/show_bug.cgi?id=39740
--- Comment #11 from Konstantin Kolinko 2011-02-09
03:07:24 EST ---
(In reply to comment #10)
> until the W3C finally declares ';' as the
> correct syntax, and not some obtuse footnote that contradicts their spec.
I think it never happens
https://issues.apache.org/bugzilla/show_bug.cgi?id=50738
--- Comment #2 from Martin Grotzke 2011-02-09
02:59:46 EST ---
For tomcat6 init was called on context reload (actually it's done in
StandardContext.start: if (!initialized) init();).
If it's intended that this behaviour is changed, then h
54 matches
Mail list logo