Re: RemoteIpValve advices

2011-01-25 Thread Henri Gomez
> I've got a very basic valve for now to handle this kind of X-Forwarded > situation : > > > public class ForwardedValve extends ValveBase { > >    public void invoke(Request paramRequest, Response paramResponse) >            throws IOException, ServletException { > >        String header = paramRe

DO NOT REPLY [Bug 50405] Null Pointer Exception at Coyote Adapter

2011-01-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50405 Miguel Hernandez changed: What|Removed |Added CC||migs...@gmail.com -- Configure

DO NOT REPLY [Bug 50405] Null Pointer Exception at Coyote Adapter

2011-01-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50405 Miguel Hernandez changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #3 from Miguel

DO NOT REPLY [Bug 50405] Null Pointer Exception at Coyote Adapter

2011-01-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50405 --- Comment #2 from Miguel Hernandez 2011-01-25 18:03:00 EST --- Created an attachment (id=26550) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26550) A simple test application that presents the error reported. A similar test

DO NOT REPLY [Bug 50650] Connector#setProperty(String, String) does not set explicit property values

2011-01-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50650 --- Comment #4 from Lon Binder 2011-01-25 17:50:30 EST --- In order to work around this for my situation (using OFBiz) I wrote a patch to their code that essentially does the same as IntrospectionUtils: it uses reflection to find the the a

DO NOT REPLY [Bug 50651] NPE in InternalNioOutputBuffer.recycle

2011-01-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50651 --- Comment #6 from Konstantin Kolinko 2011-01-25 17:12:53 EST --- (In reply to comment #4) Repeated calls to recycle() should succeed. Shouldn't they? Implementation of InternalNioOutputBuffer.recycle() was already broken in this sense ea

DO NOT REPLY [Bug 50651] NPE in InternalNioOutputBuffer.recycle

2011-01-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50651 --- Comment #5 from p...@mfglobal.com 2011-01-25 17:02:59 EST --- I was testing the sample code from http://www.ibm.com/developerworks/web/library/wa-cometjava/. Each time when the connection was closed, two END Comet events were received.

DO NOT REPLY [Bug 50650] Connector#setProperty(String, String) does not set explicit property values

2011-01-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50650 --- Comment #3 from Konstantin Kolinko 2011-01-25 16:49:42 EST --- > and I've already seen at least one major application (ofbiz) that expects > that to work That never worked. Why are they expecting something? > Most specifically, if t

DO NOT REPLY [Bug 50651] NPE in InternalNioOutputBuffer.recycle

2011-01-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50651 --- Comment #4 from Filip Hanik 2011-01-25 16:25:36 EST --- What I don't like about patches like this, is that they don't address the regression, simply mitigate it. If the problem has always existed, then fine, implement it. But if this pr

DO NOT REPLY [Bug 50650] Connector#setProperty(String, String) does not set explicit property values

2011-01-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50650 Lon Binder changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WONTFIX

svn commit: r1063426 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-01-25 Thread kkolinko
Author: kkolinko Date: Tue Jan 25 19:50:50 2011 New Revision: 1063426 URL: http://svn.apache.org/viewvc?rev=1063426&view=rev Log: proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?re

DO NOT REPLY [Bug 50651] NPE in InternalNioOutputBuffer.recycle

2011-01-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50651 --- Comment #3 from Konstantin Kolinko 2011-01-25 14:47:39 EST --- Created an attachment (id=26549) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26549) 2011-01-25_tc6_50651.patch Patch for 6.0.x. -- Configure bugmail: http

DO NOT REPLY [Bug 50651] NPE in InternalNioOutputBuffer.recycle

2011-01-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50651 Konstantin Kolinko changed: What|Removed |Added Severity|normal |major --- Comment #2 from Kon

DO NOT REPLY [Bug 50651] NPE in InternalNioOutputBuffer.recycle

2011-01-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50651 --- Comment #1 from Konstantin Kolinko 2011-01-25 13:07:00 EST --- I suspect that it is socket: calling InternalNioOutputBuffer.recycle() twice will fail with NPE, because socket is set to null on the first call. -- Configure bugmail: ht

DO NOT REPLY [Bug 50651] New: NPE in InternalNioOutputBuffer.recycle

2011-01-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50651 Summary: NPE in InternalNioOutputBuffer.recycle Product: Tomcat 6 Version: 6.0.30 Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: P2

DO NOT REPLY [Bug 50627] Bug in Tomcat Comet. Event CometEvent.EventType.END is not fired when connection closed.‏

2011-01-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50627 Mark Thomas changed: What|Removed |Added Severity|blocker |major --- Comment #1 from Mark Thoma

svn commit: r1063372 - /tomcat/trunk/webapps/docs/changelog.xml

2011-01-25 Thread markt
Author: markt Date: Tue Jan 25 17:33:45 2011 New Revision: 1063372 URL: http://svn.apache.org/viewvc?rev=1063372&view=rev Log: This change also fixed an open bug Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/vi

DO NOT REPLY [Bug 50650] Connector#setProperty(String, String) does not set explicit property values

2011-01-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50650 Konstantin Kolinko changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1063366 - in /tomcat/trunk: java/org/apache/coyote/http11/Http11NioProtocol.java java/org/apache/coyote/http11/LocalStrings.properties webapps/docs/changelog.xml

2011-01-25 Thread markt
Author: markt Date: Tue Jan 25 17:20:20 2011 New Revision: 1063366 URL: http://svn.apache.org/viewvc?rev=1063366&view=rev Log: Fix various odd behaviours seen with a debugger. Observed both multiple and zero (rather than 1) selection events for a single data receive event Modified: tomcat/tr

svn commit: r1063364 - in /tomcat/trunk: java/org/apache/coyote/http11/InternalNioInputBuffer.java webapps/docs/changelog.xml

2011-01-25 Thread markt
Author: markt Date: Tue Jan 25 17:15:33 2011 New Revision: 1063364 URL: http://svn.apache.org/viewvc?rev=1063364&view=rev Log: Ensure correct cycling if input filters Modified: tomcat/trunk/java/org/apache/coyote/http11/InternalNioInputBuffer.java tomcat/trunk/webapps/docs/changelog.xml

svn commit: r1063362 - in /tomcat/trunk: java/org/apache/catalina/connector/CoyoteAdapter.java webapps/docs/changelog.xml

2011-01-25 Thread markt
Author: markt Date: Tue Jan 25 17:12:22 2011 New Revision: 1063362 URL: http://svn.apache.org/viewvc?rev=1063362&view=rev Log: Prevent multiple Comet END events Modified: tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java tomcat/trunk/webapps/docs/changelog.xml Modified:

DO NOT REPLY [Bug 50650] Connector#setProperty(String, String) does not set explicit property values

2011-01-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50650 Lon Binder changed: What|Removed |Added CC||apa...@lonbinder.com OS/Versi

DO NOT REPLY [Bug 50650] New: Connector#setProperty(String, String) does not set explicit property values

2011-01-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50650 Summary: Connector#setProperty(String, String) does not set explicit property values Product: Tomcat 6 Version: 6.0.29 Platform: All Status: NEW Severity: c

DO NOT REPLY [Bug 50526] Clarify that JavaMail Session JNDI resource factory can accept any configuration attribute from JavaMail

2011-01-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50526 Konstantin Kolinko changed: What|Removed |Added Status|VERIFIED|CLOSED -- Configure bugmail:

DO NOT REPLY [Bug 50526] Clarify that JavaMail Session JNDI resource factory can accept any configuration attribute from JavaMail

2011-01-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50526 Christopher Schultz changed: What|Removed |Added Status|RESOLVED|VERIFIED -- Configure bugma

DO NOT REPLY [Bug 50648] RpcChannel improvements

2011-01-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50648 Olivier Costet changed: What|Removed |Added OS/Version|Linux |All -- Configure bugmail: https:

DO NOT REPLY [Bug 50648] RpcChannel improvements

2011-01-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50648 Olivier Costet changed: What|Removed |Added CC||ocos...@zenprise.com -- Configur

DO NOT REPLY [Bug 50648] New: RpcChannel improvements

2011-01-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50648 Summary: RpcChannel improvements Product: Tomcat 7 Version: 7.0.6 Platform: PC OS/Version: Linux Status: NEW Keywords: PatchAvailable Severity: enhancement

[Tomcat Wiki] Update of "SupportAndTraining" by Bhavik

2011-01-25 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "SupportAndTraining" page has been changed by Bhavik. http://wiki.apache.org/tomcat/SupportAndTraining?action=diff&rev1=30&rev2=31 --

svn commit: r1063257 - in /tomcat: tc6.0.x/trunk/webapps/docs/config/manager.xml trunk/webapps/docs/config/manager.xml

2011-01-25 Thread kkolinko
Author: kkolinko Date: Tue Jan 25 12:40:38 2011 New Revision: 1063257 URL: http://svn.apache.org/viewvc?rev=1063257&view=rev Log: Clarify what the units are when setting sessionIdLength property of a Manager. It was asked on users@ CTR: docs Modified: tomcat/tc6.0.x/trunk/webapps/docs/config

DO NOT REPLY [Bug 50646] Tribes ByteMessage will get corrupted if message size exceeds the underlying buffer size

2011-01-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50646 --- Comment #1 from Olivier Costet 2011-01-25 07:09:27 EST --- Created an attachment (id=26544) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26544) svn diff -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs

DO NOT REPLY [Bug 50646] New: Tribes ByteMessage will get corrupted if message size exceeds the underlying buffer size

2011-01-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50646 Summary: Tribes ByteMessage will get corrupted if message size exceeds the underlying buffer size Product: Tomcat 7 Version: 7.0.6 Platform: PC OS/Version: All

svn commit: r1063244 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2011-01-25 Thread markt
Author: markt Date: Tue Jan 25 12:05:14 2011 New Revision: 1063244 URL: http://svn.apache.org/viewvc?rev=1063244&view=rev Log: Remove old, commented out code Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioEndp