Re: Static reference to a Throwable causing ClassLoader leak

2010-12-11 Thread Konstantin Kolinko
2010/12/12 Konstantin Kolinko : > 2) I found a scenario when such a leak is caused by a field in > org.apache.jasper.compiler.JspDocumentParser. I will add an issue into > Bugzilla. https://issues.apache.org/bugzilla/show_bug.cgi?id=50460 Best regards, Konstantin Kolinko

DO NOT REPLY [Bug 50460] New: First access to a jspx page causes classloader leak in JspDocumentParser

2010-12-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50460 Summary: First access to a jspx page causes classloader leak in JspDocumentParser Product: Tomcat 6 Version: 6.0.29 Platform: PC OS/Version: Windows XP Status

Static reference to a Throwable causing ClassLoader leak

2010-12-11 Thread Konstantin Kolinko
Hi! I was reviewing the reproduction recipe for java bug 6916498 [1] and came to a conclusion that it is triggered by the following line in one of the classes (see my comment in [1] for details): public static final RuntimeException abort = new RuntimeException(); [1] "Class loader leak goes unr

Re: svn commit: r1044746 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

2010-12-11 Thread Sylvain Laurent
oops, I just forgot a dot and a new line... fixed in rev 1044747. On 12 déc. 2010, at 01:13, Mark Thomas wrote: > On 12/12/2010 00:10, slaur...@apache.org wrote: >> Author: slaurent >> Date: Sun Dec 12 00:10:39 2010 >> New Revision: 1044746 >> >> @@ -4862,10 +4862,10 @@ public class StandardCont

svn commit: r1044747 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

2010-12-11 Thread slaurent
Author: slaurent Date: Sun Dec 12 00:16:33 2010 New Revision: 1044747 URL: http://svn.apache.org/viewvc?rev=1044747&view=rev Log: bug 50459: StandardContext.bindThread() and unbindThread() are not symmetrical and not limited to current thread https://issues.apache.org/bugzilla/show_bug.cgi?id=50

Re: svn commit: r1044145 - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/tomcat/util/threads/ test/org/apache/tomcat/util/threads/

2010-12-11 Thread Sylvain Laurent
Good catch! Actually I think my commit revealed a current bug in tc 6 & 7 : https://issues.apache.org/bugzilla/show_bug.cgi?id=50459 I fixed it with http://svn.apache.org/viewvc?rev=1044746&view=rev . Now all tests pass (checked with "ant clean test"). Sylvain On 11 déc. 2010, at 21:34, Mark

Re: svn commit: r1044746 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

2010-12-11 Thread Mark Thomas
On 12/12/2010 00:10, slaur...@apache.org wrote: > Author: slaurent > Date: Sun Dec 12 00:10:39 2010 > New Revision: 1044746 > > @@ -4862,10 +4862,10 @@ public class StandardContext extends Con > if ((loader != null) && (loader instanceof Lifecycle)) > ((Lifecy

DO NOT REPLY [Bug 50459] StandardContext.bindThread() and unbindThread() are not symmetrical and not limited to current thread

2010-12-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50459 --- Comment #2 from Sylvain Laurent 2010-12-11 19:12:12 EST --- fix committed on trunk : http://svn.apache.org/viewvc?rev=1044746&view=rev -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are r

svn commit: r1044746 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

2010-12-11 Thread slaurent
Author: slaurent Date: Sun Dec 12 00:10:39 2010 New Revision: 1044746 URL: http://svn.apache.org/viewvc?rev=1044746&view=rev Log: bug 50459: StandardContext.bindThread() and unbindThread() are not symmetrical and not limited to current thread https://issues.apache.org/bugzilla/show_bug.cgi?id=50

DO NOT REPLY [Bug 50459] StandardContext.bindThread() and unbindThread() are not symmetrical and not limited to current thread

2010-12-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50459 --- Comment #1 from Sylvain Laurent 2010-12-11 19:09:33 EST --- oops, forgot the link to my initial commit that revealed the bug : http://svn.apache.org/viewvc?rev=1044145&view=rev -- Configure bugmail: https://issues.apache.org/bugzilla

DO NOT REPLY [Bug 50459] New: StandardContext.bindThread() and unbindThread() are not symmetrical and not limited to current thread

2010-12-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50459 Summary: StandardContext.bindThread() and unbindThread() are not symmetrical and not limited to current thread Product: Tomcat 7 Version: 7.0.5 Platform: All OS/Version:

svn commit: r1044731 - in /tomcat/trunk: res/checkstyle/ res/maven/ test/org/apache/tomcat/util/threads/

2010-12-11 Thread markt
Author: markt Date: Sat Dec 11 22:21:02 2010 New Revision: 1044731 URL: http://svn.apache.org/viewvc?rev=1044731&view=rev Log: TRy and sync up the deps in the POMs with what Checkstyle validates Removed: tomcat/trunk/test/org/apache/tomcat/util/threads/ Modified: tomcat/trunk/res/checksty

svn commit: r1044730 - in /tomcat/trunk/java/org/apache/catalina/tribes: membership/McastServiceImpl.java transport/nio/NioReceiver.java

2010-12-11 Thread markt
Author: markt Date: Sat Dec 11 22:20:10 2010 New Revision: 1044730 URL: http://svn.apache.org/viewvc?rev=1044730&view=rev Log: Tribes should only depend on JULI Modified: tomcat/trunk/java/org/apache/catalina/tribes/membership/McastServiceImpl.java tomcat/trunk/java/org/apache/catalina/t

svn commit: r1044729 - in /tomcat/trunk: java/org/apache/tomcat/jni/Library.java res/checkstyle/org-import-control.xml

2010-12-11 Thread markt
Author: markt Date: Sat Dec 11 21:48:22 2010 New Revision: 1044729 URL: http://svn.apache.org/viewvc?rev=1044729&view=rev Log: o.a.tomcat.jni should not have any external dependencies OK for o.a.naming to have dependencies Modified: tomcat/trunk/java/org/apache/tomcat/jni/Library.java tom

svn commit: r1044727 - in /tomcat/trunk: java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ res/checkstyle/

2010-12-11 Thread markt
Author: markt Date: Sat Dec 11 21:35:18 2010 New Revision: 1044727 URL: http://svn.apache.org/viewvc?rev=1044727&view=rev Log: o.a.tomcat.util.net should not depend on o.a.coyote Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProtocol.java tomcat/trunk/java/org/apache/coyote/ajp/

svn commit: r1044723 - in /tomcat/trunk: java/org/apache/tomcat/util/net/ java/org/apache/tomcat/util/net/jsse/ res/checkstyle/

2010-12-11 Thread markt
Author: markt Date: Sat Dec 11 21:14:45 2010 New Revision: 1044723 URL: http://svn.apache.org/viewvc?rev=1044723&view=rev Log: o.a.tomcat.util.net should not depend on o.a.catalina Added: tomcat/trunk/java/org/apache/tomcat/util/net/Constants.java (with props) Modified: tomcat/trunk/jav

svn commit: r1044716 - in /tomcat/trunk/res/checkstyle: javax-checkstyle.xml org-checkstyle.xml

2010-12-11 Thread markt
Author: markt Date: Sat Dec 11 20:58:28 2010 New Revision: 1044716 URL: http://svn.apache.org/viewvc?rev=1044716&view=rev Log: Get the checkstyle configs to play nicely with Ant and the Eclipse plug-in Modified: tomcat/trunk/res/checkstyle/javax-checkstyle.xml tomcat/trunk/res/checkstyle/

svn commit: r1044710 - in /tomcat/trunk: ./ res/checkstyle/

2010-12-11 Thread markt
Author: markt Date: Sat Dec 11 20:38:42 2010 New Revision: 1044710 URL: http://svn.apache.org/viewvc?rev=1044710&view=rev Log: Add import-control checks to Checkstyle (these found the recent dependency issues) Move checkstyle config to res/checkstyle to stop it cluttering up the root Added:

svn commit: r1044708 - /tomcat/trunk/java/javax/el/CompositeELResolver.java

2010-12-11 Thread markt
Author: markt Date: Sat Dec 11 20:36:29 2010 New Revision: 1044708 URL: http://svn.apache.org/viewvc?rev=1044708&view=rev Log: javax.el should not depend on javax.servlet.jsp.el Modified: tomcat/trunk/java/javax/el/CompositeELResolver.java Modified: tomcat/trunk/java/javax/el/CompositeELReso

Re: svn commit: r1044145 - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/tomcat/util/threads/ test/org/apache/tomcat/util/threads/

2010-12-11 Thread Mark Thomas
On 09/12/2010 22:11, slaur...@apache.org wrote: > Author: slaurent > Date: Thu Dec 9 22:11:27 2010 > New Revision: 1044145 > > URL: http://svn.apache.org/viewvc?rev=1044145&view=rev > Log: > bug 49159: Improve ThreadLocal memory leak clean-up > https://issues.apache.org/bugzilla/show_bug.cgi?id=

svn commit: r1044692 - in /tomcat/trunk/java/org/apache: catalina/core/AsyncContextImpl.java coyote/AsyncContextCallback.java coyote/AsyncStateMachine.java coyote/ajp/AbstractAjpProcessor.java coyote/

2010-12-11 Thread markt
Author: markt Date: Sat Dec 11 18:27:15 2010 New Revision: 1044692 URL: http://svn.apache.org/viewvc?rev=1044692&view=rev Log: Coyote should not depend on Catalina Added: tomcat/trunk/java/org/apache/coyote/AsyncContextCallback.java (with props) Modified: tomcat/trunk/java/org/apache/ca

DO NOT REPLY [Bug 50448] StandardSession.expire causes IllegalStateException: getCreationTime: Session already invalidated

2010-12-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50448 --- Comment #2 from Martin Grotzke 2010-12-11 08:13:04 EST --- Thanx for the fix, now all tests for memcached-session-manager are green! Happy now, looking forward to tomcat 7.0.6. Keep on the great work! -- Configure bugmail: https://is