2010/12/8 Sylvain Laurent :
>
> On 7 déc. 2010, at 17:35, Mark Thomas wrote:
>> +1. Line length is an area I am becoming increasingly happy to be
>> flexible. Aim for 80 but if 81 or 82 (or anything < ~90) makes the code
>> more readable then I'd be fine with it.
>
> As a rookie, I did not want to
Author: markt
Date: Wed Dec 8 01:31:51 2010
New Revision: 1043272
URL: http://svn.apache.org/viewvc?rev=1043272&view=rev
Log:
Remove unused code
Modified:
tomcat/trunk/java/org/apache/catalina/LifecycleEvent.java
tomcat/trunk/java/org/apache/catalina/authenticator/Constants.java
tomc
Author: markt
Date: Wed Dec 8 01:21:12 2010
New Revision: 1043269
URL: http://svn.apache.org/viewvc?rev=1043269&view=rev
Log:
Remove unused code
Modified:
tomcat/trunk/java/org/apache/catalina/ant/BaseRedirectorHelperTask.java
Modified:
tomcat/trunk/java/org/apache/catalina/ant/BaseRedirec
Author: markt
Date: Wed Dec 8 01:14:43 2010
New Revision: 1043265
URL: http://svn.apache.org/viewvc?rev=1043265&view=rev
Log:
Remove unused code.
Make spacing consistent.
Modified:
tomcat/trunk/java/org/apache/catalina/Globals.java
Modified: tomcat/trunk/java/org/apache/catalina/Globals.jav
Author: markt
Date: Wed Dec 8 01:12:03 2010
New Revision: 1043263
URL: http://svn.apache.org/viewvc?rev=1043263&view=rev
Log:
Jasper should not depend on Catalina
Re-use constants where possible
Fix a FindBugs niggle
Modified:
tomcat/trunk/java/org/apache/jasper/Constants.java
tomcat/tru
Author: markt
Date: Wed Dec 8 01:01:56 2010
New Revision: 1043260
URL: http://svn.apache.org/viewvc?rev=1043260&view=rev
Log:
Another Findbugs niggle
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/group/AbsoluteOrder.java
Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/
On 07/12/2010 22:22, Sylvain Laurent wrote:
>
> On 7 déc. 2010, at 17:35, Mark Thomas wrote:
>> +1. Line length is an area I am becoming increasingly happy to be
>> flexible. Aim for 80 but if 81 or 82 (or anything < ~90) makes the code
>> more readable then I'd be fine with it.
>
> As a rookie,
On 7 déc. 2010, at 17:35, Mark Thomas wrote:
> +1. Line length is an area I am becoming increasingly happy to be
> flexible. Aim for 80 but if 81 or 82 (or anything < ~90) makes the code
> more readable then I'd be fine with it.
As a rookie, I did not want to start bothering you with this, but si
On 07/12/2010 17:49, Sylvain Laurent wrote:
>
> On 7 déc. 2010, at 09:41, Rainer Jung wrote:
>>>
>>
>> Just in case Mark's remark a) wasn't clear: after building Tomcat
>> you can debug inside the sub directory output/build which contains
>> a full installation.
>
> I had understood Mark, but i
Author: markt
Date: Tue Dec 7 18:36:39 2010
New Revision: 1043157
URL: http://svn.apache.org/viewvc?rev=1043157&view=rev
Log:
Fix some FindBugs warnings - all unclosed streams. These could potentially lead
to locked files and maybe memory leaks.
Fix some other simple FindBugs/Eclipse warnings in
Author: markt
Date: Tue Dec 7 18:05:31 2010
New Revision: 1043153
URL: http://svn.apache.org/viewvc?rev=1043153&view=rev
Log:
Fix a couple of 'high priority' FindBugs warnings
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/membership/Membership.java
tomcat/trunk/java/org/apache/t
On 7 déc. 2010, at 09:41, Rainer Jung wrote:
>>
>
> Just in case Mark's remark a) wasn't clear: after building Tomcat you can
> debug inside the sub directory output/build which contains a full
> installation.
I had understood Mark, but it's not practical for debugging... I prefer to
debug t
On 07/12/2010 14:48, Konstantin Kolinko wrote:
> 2010/12/7 Mark Thomas :
>>
>> My preference is for operator before since I believe it aids readability.
>> YMMV.
>>
>>> So is operator after line wrapping really a tomcat standard?
>>
>> operator before line wrapping is the direction the code is head
Author: markt
Date: Tue Dec 7 15:43:37 2010
New Revision: 1043106
URL: http://svn.apache.org/viewvc?rev=1043106&view=rev
Log:
Add checkstyle rule for modifier order and fix remaining issues in current code
base
Modified:
tomcat/trunk/build.xml
tomcat/trunk/checkstyle.xml
tomcat/trun
Author: markt
Date: Tue Dec 7 15:42:32 2010
New Revision: 1043105
URL: http://svn.apache.org/viewvc?rev=1043105&view=rev
Log:
Fix modifier order in org.apache.catalina.*
Modified:
tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java
tomcat/trunk/java/org/apache/ca
Author: markt
Date: Tue Dec 7 15:40:49 2010
New Revision: 1043104
URL: http://svn.apache.org/viewvc?rev=1043104&view=rev
Log:
Fix modifier order in org.apache.naming.*
Modified:
tomcat/trunk/java/org/apache/naming/StringManager.java
tomcat/trunk/java/org/apache/naming/resources/ResourceA
Author: markt
Date: Tue Dec 7 15:40:06 2010
New Revision: 1043103
URL: http://svn.apache.org/viewvc?rev=1043103&view=rev
Log:
Fix modifier order in org.apache.tomcat.*
Modified:
tomcat/trunk/java/org/apache/tomcat/jni/Library.java
tomcat/trunk/java/org/apache/tomcat/util/IntrospectionUti
Author: markt
Date: Tue Dec 7 15:39:09 2010
New Revision: 1043101
URL: http://svn.apache.org/viewvc?rev=1043101&view=rev
Log:
Fix modifier order in org.apache.jasper.*
Modified:
tomcat/trunk/java/org/apache/jasper/compiler/ELFunctionMapper.java
tomcat/trunk/java/org/apache/jasper/compile
Author: markt
Date: Tue Dec 7 15:38:06 2010
New Revision: 1043099
URL: http://svn.apache.org/viewvc?rev=1043099&view=rev
Log:
Fix modifier order in org.apache.el.*
Modified:
tomcat/trunk/java/org/apache/el/lang/ELArithmetic.java
tomcat/trunk/java/org/apache/el/lang/ELSupport.java
tom
Author: markt
Date: Tue Dec 7 15:36:36 2010
New Revision: 1043098
URL: http://svn.apache.org/viewvc?rev=1043098&view=rev
Log:
Fix modifier order in javax.*
Modified:
tomcat/trunk/java/javax/el/ArrayELResolver.java
tomcat/trunk/java/javax/el/BeanELResolver.java
tomcat/trunk/java/javax
Am Montag, den 06.12.2010, 22:01 +0100 schrieb Sylvain Laurent:
> >
> >> +public void lifecycleEvent(LifecycleEvent event) {
> >> +try {
> >> +Lifecycle lifecycle = event.getLifecycle();
> >> +if (Lifecycle.AFTER_START_EVENT.equals(event.getType())
> >> +
> From: Konstantin Kolinko [mailto:knst.koli...@gmail.com]
> Subject: Re: svn commit: r1042786 - in /tomcat/trunk/java/org/apache:
> catalina/core/ catalina/loader/ tomcat/util/threads/
> If you have some "long string" that occupies all space up to position
> 79, forcing some operator after it to
2010/12/7 Mark Thomas :
>
> My preference is for operator before since I believe it aids readability.
> YMMV.
>
>> So is operator after line wrapping really a tomcat standard?
>
> operator before line wrapping is the direction the code is heading in and
> the direction I think it should continue to
Author: markt
Date: Tue Dec 7 14:01:21 2010
New Revision: 1043051
URL: http://svn.apache.org/viewvc?rev=1043051&view=rev
Log:
Another day, another check
Modified:
tomcat/trunk/checkstyle.xml
Modified: tomcat/trunk/checkstyle.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/checkstyle.xml
Author: markt
Date: Tue Dec 7 14:00:42 2010
New Revision: 1043050
URL: http://svn.apache.org/viewvc?rev=1043050&view=rev
Log:
Typo
Modified:
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs
Author: markt
Date: Tue Dec 7 13:59:47 2010
New Revision: 1043049
URL: http://svn.apache.org/viewvc?rev=1043049&view=rev
Log:
Proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1
Am Dienstag, den 07.12.2010, 13:28 + schrieb Mark Thomas:
> On 07/12/2010 12:29, Felix Schumacher wrote:
> > Am Montag, den 06.12.2010, 21:22 + schrieb Mark Thomas:
> >>> -log.error("Exception processing event " + event, e);
> >>> +String msg =
> >>> +
> From: Mark Thomas [mailto:ma...@apache.org]
> Subject: Re: svn commit: r1042786 - in /tomcat/trunk/java/org/apache:
> catalina/core/ catalina/loader/ tomcat/util/threads/
> My preference is for operator before since I believe it aids
> readability. YMMV.
Strongly agree. I've been programming
On 07/12/2010 13:28, Mark Thomas wrote:
On 07/12/2010 12:29, Felix Schumacher wrote:
Am Montag, den 06.12.2010, 21:22 + schrieb Mark Thomas:
That indenting is now misleading (it was fine before) and the operator
is still at the beginning of the line.
I just made a quick lookup for usage of
On 07/12/2010 12:29, Felix Schumacher wrote:
Am Montag, den 06.12.2010, 21:22 + schrieb Mark Thomas:
That indenting is now misleading (it was fine before) and the operator
is still at the beginning of the line.
I just made a quick lookup for usage of (&&) operator at the end of line
versus
https://issues.apache.org/bugzilla/show_bug.cgi?id=50339
--- Comment #5 from Frank 2010-12-07 07:40:27 EST ---
Yes, that seems to work.
Thanks a lot, guys!
Cheers,
Frank
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because
Am Montag, den 06.12.2010, 21:22 + schrieb Mark Thomas:
> On 06/12/2010 20:49, slaur...@apache.org wrote:
> > Author: slaurent
> > Date: Mon Dec 6 20:49:14 2010
> > New Revision: 1042786
> >
> > URL: http://svn.apache.org/viewvc?rev=1042786&view=rev
>
>
> > @@ -63,7 +72,7 @@ public class Th
Sorry i've try to delete it and post on users mailing list but maybe
something gone wrong.
markt-2 wrote:
>
> On 07/12/2010 10:28, pix_siro wrote:
>>
>> Hi all,
>> I'm working on Ubuntu 9.10 where I have installed Tomcat 7. I have a
>> problem
>> with following web.xml file: the program work fi
On 07/12/2010 10:28, pix_siro wrote:
Hi all,
I'm working on Ubuntu 9.10 where I have installed Tomcat 7. I have a problem
with following web.xml file: the program work fine but when I try to connect
to localhost:8080/OverEncrypt I can not show any page even if I set
index.jsp.
This question be
Hi all,
I'm working on Ubuntu 9.10 where I have installed Tomcat 7. I have a problem
with following web.xml file: the program work fine but when I try to connect
to localhost:8080/OverEncrypt I can not show any page even if I set
index.jsp.
The folder configuration is the following:
$CATALINA_HOM
On 06.12.2010 22:01, Sylvain Laurent wrote:
On 6 déc. 2010, at 01:09, Mark Thomas wrote:
On 05/12/2010 22:54, slaur...@apache.org wrote:
Modified:
tomcat/trunk/ (props changed)
tomcat/trunk/conf/ (props changed)
tomcat/trunk/webapps/(props changed)
-1 to all these changes
36 matches
Mail list logo
