Re: svn commit: r1028940 - in /tomcat/trunk/java/org/apache/jasper: EmbeddedServletOptions.java JspC.java Options.java compiler/JspRuntimeContext.java resources/LocalStrings.properties servlet/JspSer

2010-10-29 Thread Rainer Jung
On 30.10.2010 01:38, David Jencks wrote: Would you consider putting the time unit (seconds) in the param name or at least in_all_ the javadoc? Without documentation I would expect the natural time unit to be minutes. Done (Javadocs). I didn't want to make the parameter name even longer. Th

svn commit: r1028950 - in /tomcat/trunk/java/org/apache/jasper: EmbeddedServletOptions.java Options.java compiler/JspRuntimeContext.java

2010-10-29 Thread rjung
Author: rjung Date: Fri Oct 29 23:53:15 2010 New Revision: 1028950 URL: http://svn.apache.org/viewvc?rev=1028950&view=rev Log: Make sure, we mention the unit "seconds" for jspIdleTimeout everywhere. Modified: tomcat/trunk/java/org/apache/jasper/EmbeddedServletOptions.java tomcat/trunk/jav

Re: svn commit: r1028940 - in /tomcat/trunk/java/org/apache/jasper: EmbeddedServletOptions.java JspC.java Options.java compiler/JspRuntimeContext.java resources/LocalStrings.properties servlet/JspServ

2010-10-29 Thread David Jencks
Would you consider putting the time unit (seconds) in the param name or at least in _all_ the javadoc? Without documentation I would expect the natural time unit to be minutes. thanks david jencks On Oct 29, 2010, at 4:22 PM, rj...@apache.org wrote: > Author: rjung > Date: Fri Oct 29 23:22:35

svn commit: r1028944 - in /tomcat/trunk: conf/web.xml webapps/docs/changelog.xml webapps/docs/jasper-howto.xml

2010-10-29 Thread rjung
Author: rjung Date: Fri Oct 29 23:34:37 2010 New Revision: 1028944 URL: http://svn.apache.org/viewvc?rev=1028944&view=rev Log: Document jspIdleTimeout. Modified: tomcat/trunk/conf/web.xml tomcat/trunk/webapps/docs/changelog.xml tomcat/trunk/webapps/docs/jasper-howto.xml Modified: tom

svn commit: r1028940 - in /tomcat/trunk/java/org/apache/jasper: EmbeddedServletOptions.java JspC.java Options.java compiler/JspRuntimeContext.java resources/LocalStrings.properties servlet/JspServletW

2010-10-29 Thread rjung
Author: rjung Date: Fri Oct 29 23:22:35 2010 New Revision: 1028940 URL: http://svn.apache.org/viewvc?rev=1028940&view=rev Log: Add new JSP init parameter "jspIdleTimeout". If set > 0 (default -1), a background task will unload all JSPs being idle longer than this time in seconds. Modified: t

RE: Tomcat JDBC Pool and common-dbcp extra parameters

2010-10-29 Thread Caldarale, Charles R
> From: Henri Gomez [mailto:henri.go...@gmail.com] > Subject: Tomcat JDBC Pool and common-dbcp extra parameters > tomcat-dbcp is a copy of common-dbcp 1.3 and its documentation, > http://commons.apache.org/dbcp/configuration.html, indicate many > others parameters > Could they be used also in Re

svn commit: r1028939 - in /tomcat/trunk/java/org/apache/jasper: compiler/JspRuntimeContext.java servlet/JspServletWrapper.java

2010-10-29 Thread rjung
Author: rjung Date: Fri Oct 29 23:08:59 2010 New Revision: 1028939 URL: http://svn.apache.org/viewvc?rev=1028939&view=rev Log: We will no longer continuously update the jspQueue order. Instead only update each JSP once between background task runs. Changes to JspRuntimeContext: - Rename "ticket"

svn commit: r1028935 - in /tomcat/trunk/java/org/apache/jasper: compiler/JspRuntimeContext.java servlet/JspServletWrapper.java util/FastRemovalDequeue.java

2010-10-29 Thread rjung
Author: rjung Date: Fri Oct 29 22:44:52 2010 New Revision: 1028935 URL: http://svn.apache.org/viewvc?rev=1028935&view=rev Log: Changes to FastRemovalDequeue: - Make queue thread safe and remove external synchronisation - Provide maximal size to queue - Include size checking when adding entries - R

Tomcat JDBC Pool and common-dbcp extra parameters

2010-10-29 Thread Henri Gomez
Tomcat documentation about JDBC/Datasource (http://tomcat.apache.org/tomcat-6.0-doc/jndi-resources-howto.html) give various attributes for Datasource Factory like maxActive or maxWait. tomcat-dbcp is a copy of common-dbcp 1.3 and its documentation, http://commons.apache.org/dbcp/configuration.html

DO NOT REPLY [Bug 50185] New: [tribes] Logging improvement

2010-10-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50185 Summary: [tribes] Logging improvement Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Linux Status: NEW Severity: enhancement Priority: P2

DO NOT REPLY [Bug 50184] New: RpcChannel sends the answer without requesting an ACK

2010-10-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50184 Summary: RpcChannel sends the answer without requesting an ACK Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Solaris Status: NEW Severity: normal

DO NOT REPLY [Bug 50183] New: [Tribes] Bio Sender is not scheduling the task to the excecutors

2010-10-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50183 Summary: [Tribes] Bio Sender is not scheduling the task to the excecutors Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Linux Status: NEW

DO NOT REPLY [Bug 50182] Contributing back enhancements to CompressionFilter

2010-10-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50182 David Becker changed: What|Removed |Added CC||da...@sogeeky.net --- Comment #1 fr

DO NOT REPLY [Bug 50182] New: Contributing back enhancements to CompressionFilter

2010-10-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50182 Summary: Contributing back enhancements to CompressionFilter Product: Tomcat 6 Version: unspecified Platform: All OS/Version: All Status: NEW Severity: enhancement

svn commit: r1028863 - /tomcat/trunk/java/org/apache/jasper/compiler/JspRuntimeContext.java

2010-10-29 Thread rjung
Author: rjung Date: Fri Oct 29 17:54:27 2010 New Revision: 1028863 URL: http://svn.apache.org/viewvc?rev=1028863&view=rev Log: Simplify JSP limiter: - inline getJspForUnload It is only used privately and only in one place plus the code gets easier to understand. - remove compilation interval

svn commit: r1028862 - /tomcat/trunk/java/org/apache/jasper/servlet/JspServletWrapper.java

2010-10-29 Thread rjung
Author: rjung Date: Fri Oct 29 17:47:01 2010 New Revision: 1028862 URL: http://svn.apache.org/viewvc?rev=1028862&view=rev Log: Rearrange placement of JSP limter code in JSP servlet wrapper. Do everything in one place: - add to the queue if this is the first time and only then check for the size

svn commit: r1028861 - /tomcat/trunk/java/org/apache/jasper/util/FastRemovalDequeue.java

2010-10-29 Thread rjung
Author: rjung Date: Fri Oct 29 17:41:05 2010 New Revision: 1028861 URL: http://svn.apache.org/viewvc?rev=1028861&view=rev Log: Improve Jsp limiter: - Under high load entries removed from the jspQueue were already re-added via moveFirst by some other concurrent request, before the JspWrapper w

svn commit: r1028737 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

2010-10-29 Thread funkman
Author: funkman Date: Fri Oct 29 13:43:30 2010 New Revision: 1028737 URL: http://svn.apache.org/viewvc?rev=1028737&view=rev Log: for resourceOnlyServlets allow whitespace in the comma seperated list. Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Modified: tomcat/

Re: svn commit: r1028521 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/tomcat/util/http/mapper/ test/org/apache/tomca

2010-10-29 Thread Mark Thomas
On 29/10/2010 13:51, Tim Funk wrote: > Should we add trim()? (in case the user has a new line or spaces after > the ,) > > this.resourceOnlyServlets.add(servletName.trim()); Can't hurt. Go for it. Mark > > > -Tim > > Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java >

Re: svn commit: r1028521 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/tomcat/util/http/mapper/ test/org/apache/tomca

2010-10-29 Thread Tim Funk
Should we add trim()? (in case the user has a new line or spaces after the ,) this.resourceOnlyServlets.add(servletName.trim()); -Tim Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/Standar