I propose to replace the parallel arrays with a
ClassLoaderFactory.Repository(type, location) class and a
ClassLoaderFactory.RepositoryType enum.
(I know this is small fry, but just trying to get my feet under the
desk so to speak...)
Is the lack of such conventions now just a hangover from pre Ja
Author: mturk
Date: Wed Sep 29 05:48:37 2010
New Revision: 1002483
URL: http://svn.apache.org/viewvc?rev=1002483&view=rev
Log:
Update status with proposed small improvement
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/
Author: mturk
Date: Wed Sep 29 05:43:57 2010
New Revision: 1002481
URL: http://svn.apache.org/viewvc?rev=1002481&view=rev
Log:
Be consistent with CATALINA_PID quoting and always redirect all streams to
/dev/null cause we are interested only in return value
Modified:
tomcat/trunk/bin/catalina
https://issues.apache.org/bugzilla/show_bug.cgi?id=50001
--- Comment #10 from Wesley 2010-09-28 19:20:13 EDT
---
(In reply to comment #7)
> Actually thinking about it, they'll probably create diff issues as they're
> modified in the filesystem when they're changed in Eclipse, so backing them
>
https://issues.apache.org/bugzilla/show_bug.cgi?id=50001
--- Comment #9 from Wesley 2010-09-28 19:17:34 EDT
---
Created an attachment (id=26098)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26098)
Fixes the launch problems.
Please consider the attached patch for inclusion.
The at
Author: kkolinko
Revision: 1001718
Modified property: svn:log
Modified: svn:log at Tue Sep 28 23:16:41 2010
--
--- svn:log (original)
+++ svn:log Tue Sep 28 23:16:41 2010
@@ -0,0 +1,2 @@
+Corrected a typo
+s/vesion/version
https://issues.apache.org/bugzilla/show_bug.cgi?id=50001
Wesley changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|FIXED
https://issues.apache.org/bugzilla/show_bug.cgi?id=49796
Mark Thomas changed:
What|Removed |Added
Component|Native:Integration |Library
Version|6.0.29
https://issues.apache.org/bugzilla/show_bug.cgi?id=49795
Mark Thomas changed:
What|Removed |Added
Component|Native:Integration |Library
Version|6.0.29
Author: markt
Date: Tue Sep 28 21:39:33 2010
New Revision: 1002365
URL: http://svn.apache.org/viewvc?rev=1002365&view=rev
Log:
Update proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.tx
https://issues.apache.org/bugzilla/show_bug.cgi?id=49159
--- Comment #10 from sylvain.laur...@gmail.com 2010-09-28 17:34:48 EDT ---
Created an attachment (id=26097)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26097)
Patch for tomcat 7 to renew threads one by one with a delay without
Author: markt
Date: Tue Sep 28 21:30:27 2010
New Revision: 1002362
URL: http://svn.apache.org/viewvc?rev=1002362&view=rev
Log:
More review comments form mturk. Tighten up handling of ps output.
Modified:
tomcat/trunk/bin/catalina.sh
Modified: tomcat/trunk/bin/catalina.sh
URL:
http://svn.apa
Author: markt
Date: Tue Sep 28 21:20:06 2010
New Revision: 1002359
URL: http://svn.apache.org/viewvc?rev=1002359&view=rev
Log:
Respond to mturk's review. Make rm more robust. Avoid potential issues with
(...).
Modified:
tomcat/trunk/bin/catalina.sh
Modified: tomcat/trunk/bin/catalina.sh
UR
Author: markt
Date: Tue Sep 28 20:45:22 2010
New Revision: 1002350
URL: http://svn.apache.org/viewvc?rev=1002350&view=rev
Log:
Proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1
Author: markt
Date: Tue Sep 28 20:43:32 2010
New Revision: 1002349
URL: http://svn.apache.org/viewvc?rev=1002349&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49195
Avoid error message when shutting down Windows service when the shutdown port
is disabled.
Modified:
tom
On 28/09/2010 21:20, Wick Swain wrote:
> We have made a change to account for this in the JNDIRealm class. What would
> we have to do to have this considered for inclusion in the next version of
> Tomcat?
Create a Bugzilla entry and attach a patch in diff -u format. Ideally
against trunk. Against
It seems strange that all roles returned by the JNDIRealm’s getRoles()
include distinct names EXCEPT the nested roles (only common name of nested
roles are returned). My first reaction is that this is a bug that needs to
be fixed, but if it is not a bug it would be nice to be able to control
whethe
https://issues.apache.org/bugzilla/show_bug.cgi?id=50001
--- Comment #7 from Tim Whittington 2010-09-28 15:37:52 EDT
---
(In reply to comment #3)
> (In reply to comment #2)
> > Your patch seems to be broken (it seems to be missing files from your
> > description, and instead of deleting files it
2010/9/28 Mladen Turk :
> On 09/28/2010 08:16 PM, Konstantin Kolinko wrote:
>>
>> 2010/9/28 Mladen Turk:
>>>
>>> On 09/28/2010 07:24 PM, ma...@apache.org wrote:
Author: markt
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49665
+ Better handling for missing TLD files
On 09/28/2010 08:16 PM, Konstantin Kolinko wrote:
2010/9/28 Mladen Turk:
On 09/28/2010 07:24 PM, ma...@apache.org wrote:
Author: markt
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49665
+ Better handling for missing TLD files. Report JSP filename and
location.
+ http://svn.apach
On 09/28/2010 06:59 PM, ma...@apache.org wrote:
Author: markt
+PID="`cat "$CATALINA_PID"`"
+if ps -p $PID> /dev/null; then
+ echo "Tomcat appears to still be running with PID $PID. Start
aborted."
+ exit 1
if $CATALINA_PID points to the file that has invalid
2010/9/28 Mladen Turk :
> On 09/28/2010 07:24 PM, ma...@apache.org wrote:
>>
>> Author: markt
>> +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49665
>> + Better handling for missing TLD files. Report JSP filename and
>> location.
>> + http://svn.apache.org/viewvc?rev=1002274&view=rev
On 09/28/2010 07:24 PM, ma...@apache.org wrote:
Author: markt
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49665
+ Better handling for missing TLD files. Report JSP filename and location.
+ http://svn.apache.org/viewvc?rev=1002274&view=rev
+ +1: markt
+ -1:
Could you guys (mar
Author: mturk
Date: Tue Sep 28 17:46:18 2010
New Revision: 1002295
URL: http://svn.apache.org/viewvc?rev=1002295&view=rev
Log:
Comment on the proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/S
On 28.09.2010 19:11, Mark Thomas wrote:
On 28/09/2010 17:36, David Jencks wrote:
From what I hear the best advice is "use git, not svn". However that's
usually difficult at apache.
There are git mirrors for trunk and 6.0.x/trunk but that does rely on a
Tomcat committer also using git. Anyo
On 09/28/2010 06:59 PM, ma...@apache.org wrote:
Author: markt
Date: Tue Sep 28 16:59:54 2010
New Revision: 1002263
URL: http://svn.apache.org/viewvc?rev=1002263&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49728
Improve PID file handling, particularly when another process
https://issues.apache.org/bugzilla/show_bug.cgi?id=49665
--- Comment #4 from Mark Thomas 2010-09-28 13:24:25 EDT ---
Thanks for the patch. I have applied it to 7.0.x and it will be included in
7.0.3 onwards.
I have also proposed it for 6.0.x.
--
Configure bugmail: https://issues.apache.org/bug
Author: markt
Date: Tue Sep 28 17:24:24 2010
New Revision: 1002277
URL: http://svn.apache.org/viewvc?rev=1002277&view=rev
Log:
Proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1
Author: markt
Date: Tue Sep 28 17:23:05 2010
New Revision: 1002274
URL: http://svn.apache.org/viewvc?rev=1002274&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49665
Better handling for missing TLD files. Report JSP filename and location.
Modified:
tomcat/trunk/java/org/
On 28/09/2010 17:36, David Jencks wrote:
>
> From what I hear the best advice is "use git, not svn". However that's
> usually difficult at apache.
There are git mirrors for trunk and 6.0.x/trunk but that does rely on a
Tomcat committer also using git. Anyone?
I had high hopes for git, particul
Author: markt
Date: Tue Sep 28 17:06:02 2010
New Revision: 1002265
URL: http://svn.apache.org/viewvc?rev=1002265&view=rev
Log:
Proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1
Author: markt
Date: Tue Sep 28 17:02:33 2010
New Revision: 1002264
URL: http://svn.apache.org/viewvc?rev=1002264&view=rev
Log:
Update
Modified:
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/do
Author: markt
Date: Tue Sep 28 16:59:54 2010
New Revision: 1002263
URL: http://svn.apache.org/viewvc?rev=1002263&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49728
Improve PID file handling, particularly when another process creates it and
Tomcat is unable to write to the
2010/9/28 Wesley Acheson :
> HI All,
>
> I'm not actually sure how OT this is or if the question belongs here.
>
> This is semi duplicating some comments seen in a bug. However I think
> its useful for anyone trying to create future patches who is
> inexperienced like me, so I'm sort of double post
On Sep 28, 2010, at 7:23 AM, Wesley Acheson wrote:
> HI All,
>
> I'm not actually sure how OT this is or if the question belongs here.
>
> This is semi duplicating some comments seen in a bug. However I think
> its useful for anyone trying to create future patches who is
> inexperienced like me
I don't really run SVN from the command line. But yes I believe thats
been done via the eclipse plugin actually I think it called svn move.
On Tue, Sep 28, 2010 at 5:11 PM, Caldarale, Charles R
wrote:
>> From: Wesley Acheson [mailto:wesley.ache...@gmail.com]
>> Subject: [OT] Difficulty creating w
> From: Wesley Acheson [mailto:wesley.ache...@gmail.com]
> Subject: [OT] Difficulty creating working patch - renamed file.
> However as It hasn't got the new filename in SVN when
> that patch is applied it breaks.
Have you tried "svn add" to register the new (renamed) file in the .svn/entries
f
https://issues.apache.org/bugzilla/show_bug.cgi?id=49657
--- Comment #1 from Mark Thomas 2010-09-28 10:47:02 EDT ---
Fixed in trunk and will be included in 7.0.3 onwards.
It has also been proposed for backport to 6.0.x
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=
Author: markt
Date: Tue Sep 28 14:45:27 2010
New Revision: 1002188
URL: http://svn.apache.org/viewvc?rev=1002188&view=rev
Log:
Proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1
Author: markt
Date: Tue Sep 28 14:43:03 2010
New Revision: 1002185
URL: http://svn.apache.org/viewvc?rev=1002185&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49657
Correctly handle CGI executables with spaces in the name/path
Modified:
tomcat/trunk/java/org/apache/cata
https://issues.apache.org/bugzilla/show_bug.cgi?id=50019
--- Comment #1 from Gurkan Erdogdu 2010-09-28
10:40:12 EDT ---
Created an attachment (id=26096)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26096)
Test for the lookup
--
Configure bugmail: https://issues.apache.org/bugzill
https://issues.apache.org/bugzilla/show_bug.cgi?id=50019
Summary: Adding JNDI "lookup-name" support In XML and Resource
Annotations
Product: Tomcat 7
Version: trunk
Platform: PC
OS/Version: Linux
Status: NEW
HI All,
I'm not actually sure how OT this is or if the question belongs here.
This is semi duplicating some comments seen in a bug. However I think
its useful for anyone trying to create future patches who is
inexperienced like me, so I'm sort of double posting.
I'm trying to create a patch. How
https://issues.apache.org/bugzilla/show_bug.cgi?id=50001
--- Comment #6 from Wesley 2010-09-28 09:50:44 EDT
---
(In reply to comment #5)
> (In reply to comment #4)
> > Does anyone know how to fix a patch file like this? The info is all there
> > but
> > it appears to try to apply the wrong chan
https://issues.apache.org/bugzilla/show_bug.cgi?id=50001
--- Comment #5 from Sebb 2010-09-28 09:32:11 EDT ---
(In reply to comment #4)
> Does anyone know how to fix a patch file like this? The info is all there but
> it appears to try to apply the wrong changes.
I suggest you create a new patch
https://issues.apache.org/bugzilla/show_bug.cgi?id=50001
--- Comment #4 from Wesley 2010-09-28 08:27:17 EDT
---
(In reply to comment #2)
> Your patch seems to be broken (it seems to be missing files from your
> description, and instead of deleting files it's just emptying them).
>
I've checked
https://issues.apache.org/bugzilla/show_bug.cgi?id=49631
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
https://issues.apache.org/bugzilla/show_bug.cgi?id=49625
--- Comment #2 from Mark Thomas 2010-09-28 08:11:24 EDT ---
This has been fixed in trunk and will be included in 7.0.3 onwards.
The fix has been proposed for back-port to 6.0.x.
--
Configure bugmail: https://issues.apache.org/bugzilla/us
Author: markt
Date: Tue Sep 28 12:10:57 2010
New Revision: 1002135
URL: http://svn.apache.org/viewvc?rev=1002135&view=rev
Log:
Proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1
Author: markt
Date: Tue Sep 28 12:08:53 2010
New Revision: 1002133
URL: http://svn.apache.org/viewvc?rev=1002133&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49625
Ensure Vary header is set if response may be compressed rather than only
setting it if it is compressed.
Mod
Author: markt
Date: Tue Sep 28 11:56:23 2010
New Revision: 1002126
URL: http://svn.apache.org/viewvc?rev=1002126&view=rev
Log:
Proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1
https://issues.apache.org/bugzilla/show_bug.cgi?id=49497
--- Comment #1 from Mark Thomas 2010-09-28 07:53:16 EDT ---
Created an attachment (id=26094)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26094)
Proposed patch
--
Configure bugmail: https://issues.apache.org/bugzilla/userpre
Author: kkolinko
Date: Tue Sep 28 11:37:14 2010
New Revision: 1002120
URL: http://svn.apache.org/viewvc?rev=1002120&view=rev
Log:
Add license header
Modified:
tomcat/trunk/res/ide-support/eclipse/start-tomcat.launch
tomcat/trunk/res/ide-support/eclipse/stop-tomcat.launch
Modified: tomcat
On 28 September 2010 10:54, Tim Whittington wrote:
> Yeah saw that, but the patch was broken and this appears to work fine.
> I left the launch targets in place (Eclipse finds them anyway).
The .launch and .project files currently assume that the Eclipse
project is called "tomcat-7.0.x" which may
Author: mturk
Date: Tue Sep 28 10:36:15 2010
New Revision: 1002104
URL: http://svn.apache.org/viewvc?rev=1002104&view=rev
Log:
Update win32 makefile flags and add .rc to the nsapi_redirect
Modified:
tomcat/jk/trunk/native/apache-1.3/Makefile.vc
tomcat/jk/trunk/native/apache-2.0/Makefile.v
https://issues.apache.org/bugzilla/show_bug.cgi?id=50001
--- Comment #3 from Wesley 2010-09-28 06:33:29 EDT
---
(In reply to comment #2)
> Your patch seems to be broken (it seems to be missing files from your
> description, and instead of deleting files it's just emptying them).
>
> I've moved
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project tomcat-trunk-test contains errors.
The current state of this project is 'S
Author: mturk
Date: Tue Sep 28 10:05:00 2010
New Revision: 1002089
URL: http://svn.apache.org/viewvc?rev=1002089&view=rev
Log:
Fix win32 compilation
Modified:
tomcat/jk/trunk/native/common/jk_connect.c
Modified: tomcat/jk/trunk/native/common/jk_connect.c
URL:
http://svn.apache.org/viewvc/to
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project tomcat-trunk contains errors.
The current state of this project is 'Succes
Yeah saw that, but the patch was broken and this appears to work fine.
I left the launch targets in place (Eclipse finds them anyway).
cheers
tim
On Tue, Sep 28, 2010 at 10:41 PM, Wesley Acheson
wrote:
> On Tue, Sep 28, 2010 at 11:36 AM, wrote:
>> Author: timw
>> Date: Tue Sep 28 09:36:08 2010
https://issues.apache.org/bugzilla/show_bug.cgi?id=50001
Tim Whittington changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
Author: timw
Date: Tue Sep 28 09:46:24 2010
New Revision: 1002076
URL: http://svn.apache.org/viewvc?rev=1002076&view=rev
Log:
Adding some content to the getting involved overview to give new contributors
some guidance.
Modified:
tomcat/site/trunk/docs/getinvolved.html
tomcat/site/trunk/x
On Tue, Sep 28, 2010 at 11:36 AM, wrote:
> Author: timw
> Date: Tue Sep 28 09:36:08 2010
> New Revision: 1002073
>
> URL: http://svn.apache.org/viewvc?rev=1002073&view=rev
> Log:
> Moved all Eclipse specific files into res/ide-support/eclipse.
> Removed spaces from launch target filenames.
> Corr
Author: timw
Date: Tue Sep 28 09:36:08 2010
New Revision: 1002073
URL: http://svn.apache.org/viewvc?rev=1002073&view=rev
Log:
Moved all Eclipse specific files into res/ide-support/eclipse.
Removed spaces from launch target filenames.
Corrected launch targets to run in output/build instead of root
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project tomcat-trunk-validate has an issue affecting its community integration.
Th
Author: timw
Date: Tue Sep 28 09:28:30 2010
New Revision: 1002070
URL: http://svn.apache.org/viewvc?rev=1002070&view=rev
Log:
Adding myself to active devs list.
Modified:
tomcat/trunk/webapps/docs/developers.xml
Modified: tomcat/trunk/webapps/docs/developers.xml
URL:
http://svn.apache.org/v
66 matches
Mail list logo
