DO NOT REPLY [Bug 50018] New: Javadoc corrections

2010-09-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50018 Summary: Javadoc corrections Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: minor Priority: P2 Component:

DO NOT REPLY [Bug 50017] Make private immutable fields final

2010-09-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50017 --- Comment #1 from Sebb 2010-09-27 20:28:14 EDT --- Created an attachment (id=26091) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26091) Patch javax.servlet package -- Configure bugmail: https://issues.apache.org/bugzilla/u

DO NOT REPLY [Bug 50017] Make private immutable fields final

2010-09-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50017 Sebb changed: What|Removed |Added Attachment #26090|Patch java.el package |Patch javax.el package description|

DO NOT REPLY [Bug 50017] New: Make private immutable fields final

2010-09-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50017 Summary: Make private immutable fields final Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2

svn commit: r1001958 - /tomcat/trunk/webapps/docs/changelog.xml

2010-09-27 Thread markt
Author: markt Date: Mon Sep 27 23:09:54 2010 New Revision: 1001958 URL: http://svn.apache.org/viewvc?rev=1001958&view=rev Log: Update Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/do

DO NOT REPLY [Bug 49209] AccessControlException when undeploying application

2010-09-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49209 --- Comment #8 from Mark Thomas 2010-09-27 19:08:18 EDT --- Thanks for the patch. Fixed in trunk and proposed for 6.0.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail b

svn commit: r1001956 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-09-27 Thread markt
Author: markt Date: Mon Sep 27 23:08:03 2010 New Revision: 1001956 URL: http://svn.apache.org/viewvc?rev=1001956&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1

svn commit: r1001955 - /tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java

2010-09-27 Thread markt
Author: markt Date: Mon Sep 27 23:06:08 2010 New Revision: 1001955 URL: http://svn.apache.org/viewvc?rev=1001955&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49209 Prevent possible AccessControlException during undeployment when running with a security manager Patch provid

DO NOT REPLY [Bug 48827] Error validating empty tag that contains jsp:attribute in JSP documents in XML syntax

2010-09-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48827 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|

DO NOT REPLY [Bug 48644] Code should never ignore throwable

2010-09-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48644 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|

svn commit: r1001941 - /tomcat/trunk/webapps/docs/changelog.xml

2010-09-27 Thread markt
Author: markt Date: Mon Sep 27 22:31:03 2010 New Revision: 1001941 URL: http://svn.apache.org/viewvc?rev=1001941&view=rev Log: Update Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/do

svn commit: r1001939 - in /tomcat/trunk/java/org/apache/tomcat: jni/ util/digester/ util/http/fileupload/ util/http/fileupload/util/ util/net/

2010-09-27 Thread markt
Author: markt Date: Mon Sep 27 22:29:30 2010 New Revision: 1001939 URL: http://svn.apache.org/viewvc?rev=1001939&view=rev Log: Remaining fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644 Some Throwables must always be re-thrown Modified: tomcat/trunk/java/org/apache/tomcat/jni/

svn commit: r1001938 - in /tomcat/trunk/java/org/apache/naming: NamingService.java factory/ResourceFactory.java factory/webservices/ServiceRefFactory.java

2010-09-27 Thread markt
Author: markt Date: Mon Sep 27 22:22:02 2010 New Revision: 1001938 URL: http://svn.apache.org/viewvc?rev=1001938&view=rev Log: Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644 Some Throwables must always be re-thrown Modified: tomcat/trunk/java/org/apache/naming/Naming

svn commit: r1001934 - in /tomcat/trunk/java/org/apache/juli: ClassLoaderLogManager.java OneLineFormatter.java

2010-09-27 Thread markt
Author: markt Date: Mon Sep 27 22:17:30 2010 New Revision: 1001934 URL: http://svn.apache.org/viewvc?rev=1001934&view=rev Log: Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644 Some Throwables must always be re-thrown Modified: tomcat/trunk/java/org/apache/juli/ClassLoa

svn commit: r1001933 - in /tomcat/trunk/java/org/apache/jasper: compiler/ runtime/ servlet/

2010-09-27 Thread markt
Author: markt Date: Mon Sep 27 22:16:26 2010 New Revision: 1001933 URL: http://svn.apache.org/viewvc?rev=1001933&view=rev Log: Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644 Some Throwables must always be re-thrown Modified: tomcat/trunk/java/org/apache/jasper/compil

svn commit: r1001932 - in /tomcat/trunk/java/org/apache/coyote: ajp/ http11/

2010-09-27 Thread markt
Author: markt Date: Mon Sep 27 22:12:05 2010 New Revision: 1001932 URL: http://svn.apache.org/viewvc?rev=1001932&view=rev Log: Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644 Some Throwables must always be re-thrown Modified: tomcat/trunk/java/org/apache/coyote/ajp/Aj

svn commit: r1001923 - in /tomcat/trunk/java/org/apache/catalina: mbeans/ realm/ session/ startup/ tribes/membership/ tribes/transport/nio/ util/ valves/

2010-09-27 Thread markt
Author: markt Date: Mon Sep 27 22:01:45 2010 New Revision: 1001923 URL: http://svn.apache.org/viewvc?rev=1001923&view=rev Log: Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644 Some Throwables must always be re-thrown Modified: tomcat/trunk/java/org/apache/catalina/mbea

svn commit: r1001915 - in /tomcat/trunk/java/org/apache/catalina: deploy/ ha/authenticator/ ha/session/ loader/ manager/ manager/host/

2010-09-27 Thread markt
Author: markt Date: Mon Sep 27 21:32:25 2010 New Revision: 1001915 URL: http://svn.apache.org/viewvc?rev=1001915&view=rev Log: Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644 Some Throwables must always be re-thrown Modified: tomcat/trunk/java/org/apache/catalina/depl

Re: svn commit: r1001698 [1/2] - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/security/ java/org/apache/coyote/ java/org/apache/coyote/

2010-09-27 Thread David Jencks
I'd really appreciate your taking a look at the following issues before 7.0.3, in this order of priority. 49952 ServletContainerInitializer can't actually add listeners this is an obvious bug with a simple fix and a new testcase. 50015 dynamic servlet security incomplete and badly distributed

Re: Atomicity violation in removeAttribute

2010-09-27 Thread sebb
On 27 September 2010 21:34, Ohad Shacham wrote: > ConcurrentHashMap does not support null keys and entries. Did not check that. However, the attributes Map field is protected and not final, so it could in theory be replaced with a Map that allows dupes. That's perhaps another bug... --

DO NOT REPLY [Bug 50016] New: bad division of responsibility around isUserInRole and new Request login and logout methods

2010-09-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50016 Summary: bad division of responsibility around isUserInRole and new Request login and logout methods Product: Tomcat 7 Version: trunk Platform: PC Status: NEW

svn commit: r1001904 - in /tomcat/trunk/java/org/apache/catalina: authenticator/ connector/ core/

2010-09-27 Thread markt
Author: markt Date: Mon Sep 27 20:52:49 2010 New Revision: 1001904 URL: http://svn.apache.org/viewvc?rev=1001904&view=rev Log: Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644 Some Throwables must always be re-thrown Modified: tomcat/trunk/java/org/apache/catalina/auth

RE: Atomicity violation in removeAttribute

2010-09-27 Thread Caldarale, Charles R
> From: ohad.shac...@gmail.com [mailto:ohad.shac...@gmail.com] On Behalf Of > Ohad Shacham > Subject: Re: Atomicity violation in removeAttribute > I would use: > if (attributes.containsKey(name)) { > value = attributes.remove(name); > if (value == null) > return; > } > else { >

Re: Atomicity violation in removeAttribute

2010-09-27 Thread Ohad Shacham
> If get() cannot return null, then I think one can just use: > value = attributes.remove(name); > if (value == null) > return; > If it is important to distinguish null entries from missing entries, > then a different approach is needed - e.g. AtomicReference as > suggested elsewhere Concu

svn commit: r1001899 - in /tomcat/trunk/java/org/apache/catalina/ant: AbstractCatalinaTask.java ValidatorTask.java jmx/JMXAccessorQueryTask.java jmx/JMXAccessorTask.java

2010-09-27 Thread markt
Author: markt Date: Mon Sep 27 20:24:18 2010 New Revision: 1001899 URL: http://svn.apache.org/viewvc?rev=1001899&view=rev Log: Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644 Don't catch Throwable Modified: tomcat/trunk/java/org/apache/catalina/ant/AbstractCatalinaTas

DO NOT REPLY [Bug 50015] dynamic servlet security incomplete and badly distributed

2010-09-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50015 --- Comment #1 from david jencks 2010-09-27 16:24:07 EDT --- Created an attachment (id=26088) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26088) patch for improved dynamic servlet security implementations -- Configure bugm

DO NOT REPLY [Bug 50015] New: dynamic servlet security incomplete and badly distributed

2010-09-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50015 Summary: dynamic servlet security incomplete and badly distributed Product: Tomcat 7 Version: trunk Platform: PC Status: NEW Severity: normal Prio

DO NOT REPLY [Bug 49935] recursive tag calls don't work

2010-09-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49935 --- Comment #4 from Mark Thomas 2010-09-27 15:15:32 EDT --- This was previously fixed in 6.0.x. I back-ported the relevant patches to 5.5.x and they do fix the issue. The combined patch has been proposed for 5.5.x -- Configure bugmail: ht

svn commit: r1001880 - /tomcat/tc5.5.x/trunk/STATUS.txt

2010-09-27 Thread markt
Author: markt Date: Mon Sep 27 19:14:45 2010 New Revision: 1001880 URL: http://svn.apache.org/viewvc?rev=1001880&view=rev Log: Proposal Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=1

svn commit: r1001871 - /tomcat/tc5.5.x/trunk/jasper/src/share/org/apache/jasper/compiler/TagFileProcessor.java

2010-09-27 Thread markt
Author: markt Date: Mon Sep 27 18:55:29 2010 New Revision: 1001871 URL: http://svn.apache.org/viewvc?rev=1001871&view=rev Log: CTR. Tabs -> 8 spaces. No functional change. Modified: tomcat/tc5.5.x/trunk/jasper/src/share/org/apache/jasper/compiler/TagFileProcessor.java Modified: tomcat/tc5.

Re: svn commit: r1001698 [1/2] - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/security/ java/org/apache/coyote/ java/org/apache/coyote/

2010-09-27 Thread Mark Thomas
On 27/09/2010 13:16, Mark Thomas wrote: > On 27/09/2010 13:13, ma...@apache.org wrote: >> Author: markt >> Date: Mon Sep 27 12:13:32 2010 >> New Revision: 1001698 > >> The following work remains: >> - Testing all connectors (HTTP and AJP) with TCK + security manager and >> fixing whatever is brok

DO NOT REPLY [Bug 49811] [PATCH] Disable UrlRewriting

2010-09-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49811 --- Comment #14 from Wesley 2010-09-27 13:57:52 EDT --- (In reply to comment #13) > Created an attachment (id=26018) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26018) [details] > V3 with tabs fixed and parameter name on Con

DO NOT REPLY [Bug 50013] missing classes when running catalina ant tasks

2010-09-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50013 --- Comment #1 from sylvain.laur...@gmail.com 2010-09-27 13:17:40 EDT --- Created an attachment (id=26086) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26086) proposed patch Proposed patch, I added org/apache/tomcat/util/file/

DO NOT REPLY [Bug 50013] New: missing classes when running catalina ant tasks

2010-09-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50013 Summary: missing classes when running catalina ant tasks Product: Tomcat 7 Version: trunk Platform: PC Status: NEW Severity: normal Priority: P2 Component: J

Re: Atomicity violation in setAttribute

2010-09-27 Thread Ohad Shacham
Given that there is a violation, and the proposed solution is simpler, would you take it in the next release? Thanks, Ohad On Sun, Sep 26, 2010 at 10:42 PM, Tim Whittington wrote: > This is technically a race condition, but given the vague information > provided in ServletContextAttributeEvent

DO NOT REPLY [Bug 49979] SimpleDateFormat StringIndexOutOfBoundsException

2010-09-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49979 sosig...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Tomcat Wiki] Update of "TomcatHibernate" by SureshVayu gundla

2010-09-27 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "TomcatHibernate" page has been changed by SureshVayugundla. http://wiki.apache.org/tomcat/TomcatHibernate?action=diff&rev1=2&rev2=3

svn commit: r1001725 - in /tomcat/tc6.0.x/trunk: STATUS.txt build.properties.default webapps/docs/changelog.xml

2010-09-27 Thread markt
Author: markt Date: Mon Sep 27 13:08:24 2010 New Revision: 1001725 URL: http://svn.apache.org/viewvc?rev=1001725&view=rev Log: Update to pool 1.5.5 Modified: tomcat/tc6.0.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/build.properties.default tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

svn commit: r1001720 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java webapps/docs/changelog.xml

2010-09-27 Thread markt
Author: markt Date: Mon Sep 27 13:00:56 2010 New Revision: 1001720 URL: http://svn.apache.org/viewvc?rev=1001720&view=rev Log: When a cluster node disappears when using the backup manager, handle the failed ping message rather than propagating the exception (which just logs the stack trace but d

svn commit: r1001719 - /tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java

2010-09-27 Thread markt
Author: markt Date: Mon Sep 27 12:58:06 2010 New Revision: 1001719 URL: http://svn.apache.org/viewvc?rev=1001719&view=rev Log: Fix comment typo Modified: tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java Modified: tomcat/trunk/java/org/apache/catalina/tribes/tip

svn commit: r1001718 - /tomcat/trunk/build.properties.default

2010-09-27 Thread markt
Author: markt Date: Mon Sep 27 12:56:38 2010 New Revision: 1001718 URL: http://svn.apache.org/viewvc?rev=1001718&view=rev Log: (empty) Modified: tomcat/trunk/build.properties.default Modified: tomcat/trunk/build.properties.default URL: http://svn.apache.org/viewvc/tomcat/trunk/build.propert

svn commit: r1001717 - in /tomcat/tc6.0.x/trunk: STATUS.txt build.properties.default extras.xml webapps/docs/changelog.xml

2010-09-27 Thread markt
Author: markt Date: Mon Sep 27 12:55:18 2010 New Revision: 1001717 URL: http://svn.apache.org/viewvc?rev=1001717&view=rev Log: Enable the off-line building of the extras package Modified: tomcat/tc6.0.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/build.properties.default tomcat/tc6.0.x/trun

Re: svn commit: r1001698 [1/2] - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/security/ java/org/apache/coyote/ java/org/apache/coyote/

2010-09-27 Thread Mark Thomas
On 27/09/2010 13:13, ma...@apache.org wrote: > Author: markt > Date: Mon Sep 27 12:13:32 2010 > New Revision: 1001698 > The following work remains: > - Testing all connectors (HTTP and AJP) with TCK + security manager and > fixing whatever is broken Just as soon as I get this done, I plan to rol

DO NOT REPLY [Bug 49884] NullPointerException in org.apache.catalina.core.AsyncContextImpl.doInternalComplete

2010-09-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49884 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 49683] Separate keep-alive and connection timeout with APR/native connector

2010-09-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49683 Mark Thomas changed: What|Removed |Added Summary|Separate async, keep-alive, |Separate keep-alive and

Re: Atomicity violation in removeAttribute

2010-09-27 Thread sebb
On 26 September 2010 15:00, Ohad Shacham wrote: > Hi, > > > In addition to the behavior we experienced in function setAttribute. We also > experienced another atomicity violation in function removeAttribute. > > The following code is located at the beginning of function removeAttribute > at class

DO NOT REPLY [Bug 50001] Eclipse source files don't belong in project root.

2010-09-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50001 Rainer Jung changed: What|Removed |Added CC|dev@tomcat.apache.org | -- Configure bugmail: https://issu

Re: Atomicity violation in removeAttribute

2010-09-27 Thread Xie Xiaodong
Hello, I'd rather use the compareAndSet method in AtomicReference for this particular task. On Sun, Sep 26, 2010 at 4:00 PM, Ohad Shacham wrote: > Hi, > > > In addition to the behavior we experienced in function setAttribute. We > also > experienced another atomicity violation in function rem