Author: kfujino
Date: Mon Sep 27 01:40:53 2010
New Revision: 1001566
URL: http://svn.apache.org/viewvc?rev=1001566&view=rev
Log:
vote
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=100
On 26 September 2010 18:29, Mark Thomas wrote:
> On 26/09/2010 09:59, Rainer Jung wrote:
>> On 26.09.2010 10:23, bugzi...@apache.org wrote:
>>> https://issues.apache.org/bugzilla/show_bug.cgi?id=50001
>>>
>>> Tim Whittington changed:
>>>
>>> What |Removed |Added
Author: markt
Date: Mon Sep 27 00:17:26 2010
New Revision: 1001564
URL: http://svn.apache.org/viewvc?rev=1001564&view=rev
Log:
Change method name so it is easier to distinguish between async and comet
processing. No so important here since comet isn't supported, but need to
change it to align wi
On Mon, Sep 27, 2010 at 12:18 AM, David Jencks wrote:
>
> On Sep 26, 2010, at 11:08 AM, Wesley Acheson wrote:
>
>> Commiters, patch authors.
>>
>> Do you use an IDE to modify tomcat source code?
>>
>> If you do which one?
>
> IDEA
>>
>> Asking again in releation to bug 50001. Trying to see what id
Author: markt
Date: Sun Sep 26 22:58:38 2010
New Revision: 1001553
URL: http://svn.apache.org/viewvc?rev=1001553&view=rev
Log:
Remove some unused code.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
tomcat/trunk/java/org/apache/tomcat/util/net/NioSelectorPool
Author: markt
Date: Sun Sep 26 22:50:30 2010
New Revision: 1001552
URL: http://svn.apache.org/viewvc?rev=1001552&view=rev
Log:
More NPE avoidance.
Keep process methods aligned.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java
Modified: tomcat/trunk/java/org/apache/tomc
Author: markt
Date: Sun Sep 26 22:46:35 2010
New Revision: 1001548
URL: http://svn.apache.org/viewvc?rev=1001548&view=rev
Log:
Fix a handful of Eclipse warnings
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioE
Author: markt
Date: Sun Sep 26 22:38:14 2010
New Revision: 1001546
URL: http://svn.apache.org/viewvc?rev=1001546&view=rev
Log:
Since SocketStatus is always OPEN or TIMEOUT for BIO, remove the test.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java
Modified: tomcat/trunk
Author: markt
Date: Sun Sep 26 22:37:31 2010
New Revision: 1001545
URL: http://svn.apache.org/viewvc?rev=1001545&view=rev
Log:
Add some Javadoc.
Use SocketStatus.OPEN rather than STOP since the BIO connector treats them the
same way and it reduces code complexity. It also simplifies async re-fact
Author: markt
Date: Sun Sep 26 22:22:25 2010
New Revision: 1001538
URL: http://svn.apache.org/viewvc?rev=1001538&view=rev
Log:
Better Javadoc.
If endpoint is shutting down, return false so connection to client is closed
immediately.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/JIoE
On Sep 26, 2010, at 11:08 AM, Wesley Acheson wrote:
> Commiters, patch authors.
>
> Do you use an IDE to modify tomcat source code?
>
> If you do which one?
IDEA
>
> Asking again in releation to bug 50001. Trying to see what ide's
> should be supported.
My experience with IDE specific files
Author: markt
Date: Sun Sep 26 21:26:08 2010
New Revision: 1001525
URL: http://svn.apache.org/viewvc?rev=1001525&view=rev
Log:
Clean-up. Reduce whitespace, unnecessary comments
Modified:
tomcat/trunk/java/org/apache/coyote/http11/LocalStrings.properties
tomcat/trunk/java/org/apache/coyote
This is technically a race condition, but given the vague information
provided in ServletContextAttributeEvent (e.g. the inability to
differentiate adds vs replaces) I can't see it causing a real problem.
i.e. there's no atomicity in the interaction of an attribute listener
with the context, so a t
On Sun, Sep 26, 2010 at 10:26 PM, Pid wrote:
> On 26/09/2010 19:57, Mark Thomas wrote:
>> On 26/09/2010 19:47, Wesley Acheson wrote:
>>> Which is really nice. Its a big noise but its a big noise once.
>>
>> Which persists in the file's history making diffs that span the format
>> change almost imp
On 26/09/2010 19:57, Mark Thomas wrote:
> On 26/09/2010 19:47, Wesley Acheson wrote:
>> Which is really nice. Its a big noise but its a big noise once.
>
> Which persists in the file's history making diffs that span the format
> change almost impossible to decipher. Small gradual changes is the
>
https://issues.apache.org/bugzilla/show_bug.cgi?id=50001
Tim Whittington changed:
What|Removed |Added
AssignedTo|t...@apache.org |dev@tomcat.apache.org
--
Config
OK
Oh how I've missed working with Bugzilla...
tim
On Mon, Sep 27, 2010 at 6:29 AM, Mark Thomas wrote:
> On 26/09/2010 09:59, Rainer Jung wrote:
>> On 26.09.2010 10:23, bugzi...@apache.org wrote:
>>> https://issues.apache.org/bugzilla/show_bug.cgi?id=50001
>>>
>>> Tim Whittington changed:
>>>
>>
On 26/09/2010 19:47, Wesley Acheson wrote:
> Which is really nice. Its a big noise but its a big noise once.
Which persists in the file's history making diffs that span the format
change almost impossible to decipher. Small gradual changes is the
approach the project has taken to date.
Mark
On Sun, Sep 26, 2010 at 8:44 PM, Mark Thomas wrote:
> On 26/09/2010 19:38, Wesley Acheson wrote:
>> On Sun, Sep 26, 2010 at 8:13 PM, Mark Thomas wrote:
>>> On 26/09/2010 19:08, Wesley Acheson wrote:
Commiters, patch authors.
Do you use an IDE to modify tomcat source code?
>>>
>>> Y
On 26/09/2010 19:38, Wesley Acheson wrote:
> On Sun, Sep 26, 2010 at 8:13 PM, Mark Thomas wrote:
>> On 26/09/2010 19:08, Wesley Acheson wrote:
>>> Commiters, patch authors.
>>>
>>> Do you use an IDE to modify tomcat source code?
>>
>> Yes.
>>
>>> If you do which one?
>>
>> Eclipse for Java.
>
> R
On Sun, Sep 26, 2010 at 1:37 PM, sebb wrote:
> On 26 September 2010 10:00, Tim Whittington wrote:
>> Bah. Trying to convince Eclipse not to use tabs is proving tricky -
>> will be more vigilent..
>
> Hit me too amny times.
>
> The tabs setting for the XML editor is in a different place:
> Prefere
On Sun, Sep 26, 2010 at 8:13 PM, Mark Thomas wrote:
> On 26/09/2010 19:08, Wesley Acheson wrote:
>> Commiters, patch authors.
>>
>> Do you use an IDE to modify tomcat source code?
>
> Yes.
>
>> If you do which one?
>
> Eclipse for Java.
Really do you use the formatter for the code? If so we could
On 26/09/2010 19:08, Wesley Acheson wrote:
> Commiters, patch authors.
>
> Do you use an IDE to modify tomcat source code?
Yes.
> If you do which one?
Eclipse for Java.
Visual Studio (rarely) for C code.
Mark
-
To unsubscribe
Commiters, patch authors.
Do you use an IDE to modify tomcat source code?
If you do which one?
Asking again in releation to bug 50001. Trying to see what ide's
should be supported.
-
To unsubscribe, e-mail: dev-unsubscr...@tomc
On Sun, Sep 26, 2010 at 6:05 PM, Konstantin Kolinko
wrote:
> 2010/9/26 sebb :
>> On 26 September 2010 10:00, Tim Whittington wrote:
>>> Bah. Trying to convince Eclipse not to use tabs is proving tricky -
>>> will be more vigilent..
>>
>> Hit me too amny times.
>>
>> The tabs setting for the XML e
Author: markt
Date: Sun Sep 26 17:57:07 2010
New Revision: 1001485
URL: http://svn.apache.org/viewvc?rev=1001485&view=rev
Log:
Tab police
Modified:
tomcat/trunk/java/org/apache/coyote/ajp/Constants.java
Modified: tomcat/trunk/java/org/apache/coyote/ajp/Constants.java
URL:
http://svn.apache.
On 26/09/2010 09:59, Rainer Jung wrote:
> On 26.09.2010 10:23, bugzi...@apache.org wrote:
>> https://issues.apache.org/bugzilla/show_bug.cgi?id=50001
>>
>> Tim Whittington changed:
>>
>> What|Removed |Added
>>
> In this case, both threads will
> continue running the function with ?replaced? bit turned on and the oldValue
> of both thread will point to the same location. This means that the value of
> the first thread that did the put operation will not be treated as a value
> that was replaced.
>
> Cou
2010/9/26 sebb :
> On 26 September 2010 10:00, Tim Whittington wrote:
>> Bah. Trying to convince Eclipse not to use tabs is proving tricky -
>> will be more vigilent..
>
> Hit me too amny times.
>
> The tabs setting for the XML editor is in a different place:
> Preferences / XML / XML Files / Edit
On Sun, Sep 26, 2010 at 10:00:29PM +1300, Tim Whittington wrote:
> Bah. Trying to convince Eclipse not to use tabs is proving tricky -
> will be more vigilent..
Then, once you get it right, document it!
I think most settings like that can be done at a project level or
globally; if project level o
Hi,
In addition to the behavior we experienced in function setAttribute. We also
experienced another atomicity violation in function removeAttribute.
The following code is located at the beginning of function removeAttribute
at class ApplicationContext. This code fragment intends to check whethe
https://issues.apache.org/bugzilla/show_bug.cgi?id=50001
Chuck Caldarale changed:
What|Removed |Added
CC||dev@tomcat.apache.org
--
Config
Hi,
We are building a tool for detecting non atomic usages of concurrent
collections.
We analyzed Tomcat’s code using our tool and found the following behavior:
The following code is located at the beginning of function setAttribute at
class ApplicationContext. This code fragment intends t
https://issues.apache.org/bugzilla/show_bug.cgi?id=50003
--- Comment #1 from sylvain.laur...@gmail.com 2010-09-26 08:08:27 EDT ---
Created an attachment (id=26075)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26075)
proposed patch for tc7
proposed patch for tc7.
The problem does no
https://issues.apache.org/bugzilla/show_bug.cgi?id=50003
Summary: AbstractEndpoint.setMinSpareThreads calls
executor.setCorePoolSize with incorrect parameter
Product: Tomcat 7
Version: 7.0.2
Platform: All
OS/Version: All
On 26 September 2010 10:00, Tim Whittington wrote:
> Bah. Trying to convince Eclipse not to use tabs is proving tricky -
> will be more vigilent..
Hit me too amny times.
The tabs setting for the XML editor is in a different place:
Preferences / XML / XML Files / Editor / Indent using tabs/spaces
+---+
| Bugzilla Bug ID |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned
+---+
| Bugzilla Bug ID |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned
+---+
| Bugzilla Bug ID |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned
+---+
| Bugzilla Bug ID |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned
+---+
| Bugzilla Bug ID |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned
+---+
| Bugzilla Bug ID |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned
+---+
| Bugzilla Bug ID |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned
Bah. Trying to convince Eclipse not to use tabs is proving tricky -
will be more vigilent..
cheers
tim
On Sun, Sep 26, 2010 at 3:28 AM, wrote:
> Author: rjung
> Date: Sat Sep 25 14:28:36 2010
> New Revision: 1001216
>
> URL: http://svn.apache.org/viewvc?rev=1001216&view=rev
> Log:
> Please no t
On 26.09.2010 10:23, bugzi...@apache.org wrote:
https://issues.apache.org/bugzilla/show_bug.cgi?id=50001
Tim Whittington changed:
What|Removed |Added
AssignedTo|dev@tomcat
https://issues.apache.org/bugzilla/show_bug.cgi?id=50001
Tim Whittington changed:
What|Removed |Added
AssignedTo|dev@tomcat.apache.org |t...@apache.org
--
Configure bu
On Fri, Sep 24, 2010 at 6:49 AM, Wesley Acheson
wrote:
> On Thu, Sep 23, 2010 at 12:15 PM, wrote:
>> Author: timw
>> Date: Thu Sep 23 10:15:16 2010
>> New Revision: 1000392
>>
>> URL: http://svn.apache.org/viewvc?rev=1000392&view=rev
>> Log:
>> https://issues.apache.org/bugzilla/show_bug.cgi?id=
OK, will do.
I've just had a motherboard failure, so will be a couple of days
before I can get this patched up.
Any objections to the suggestion of an 'eclipse' or 'ide-eclipse'
target to pull the Eclipse files into the root directory?
cheers
tim
On Fri, Sep 24, 2010 at 6:47 AM, Rainer Jung wro
https://issues.apache.org/bugzilla/show_bug.cgi?id=49955
Tim Whittington changed:
What|Removed |Added
Status|REOPENED|RESOLVED
Resolution|
Author: timw
Date: Sun Sep 26 07:46:27 2010
New Revision: 1001383
URL: http://svn.apache.org/viewvc?rev=1001383&view=rev
Log:
Fixing Tomcat startup class in building instructions.
Modified:
tomcat/trunk/webapps/docs/building.xml
Modified: tomcat/trunk/webapps/docs/building.xml
URL:
http://s
On 25.09.2010 23:04, Mark Thomas wrote:
On 25/09/2010 13:33, Rainer Jung wrote:
The meta tag google-site-verification is included in our main
index.html. It is not in the authoritative svn copy.
Is there a reason for that?
If yes, please do also add it to the authoritative site copy in svn
(/t
51 matches
Mail list logo