For reference, the EE 6 platform spec explains that usually a new instance
should be returned on each lookup in section 5.2.4 page 67 "Sharing of
Environment Entries". The servlet 3.0 spec section 15.2.2 page 174 indicates
that this applies to servlet containers that are part of an EE
technolo
Hello,
I want to bring this question again.
Why do we change NamingEntry type from REFERENCE to ENTRY? I think that each
lookup must return a new instance. But in this case, it returns the same bound
object instance.
Let's says that we have a Servlet
MyServlet{
private @Resource(na
Author: markt
Date: Thu Sep 23 00:30:53 2010
New Revision: 1000284
URL: http://svn.apache.org/viewvc?rev=1000284&view=rev
Log:
Fix Javadoc warnings highlighted by buildbot
Modified:
tomcat/trunk/java/org/apache/catalina/mbeans/ContainerMBean.java
tomcat/trunk/java/org/apache/catalina/mbea
Author: markt
Date: Thu Sep 23 00:19:20 2010
New Revision: 1000283
URL: http://svn.apache.org/viewvc?rev=1000283&view=rev
Log:
Parameterize the APR location for the unit tests
Modified:
tomcat/trunk/build.xml
Modified: tomcat/trunk/build.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/bu
Author: markt
Date: Wed Sep 22 22:59:55 2010
New Revision: 1000269
URL: http://svn.apache.org/viewvc?rev=1000269&view=rev
Log:
Correctly define the ROOT context in unit tests
Modified:
tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java
tomcat/trunk/test/org/apache/catalina/connecto
Author: markt
Date: Wed Sep 22 20:04:32 2010
New Revision: 1000164
URL: http://svn.apache.org/viewvc?rev=1000164&view=rev
Log:
Add the missing onStartAsync event
Modified:
tomcat/trunk/java/org/apache/catalina/core/AsyncListenerWrapper.java
Modified: tomcat/trunk/java/org/apache/catalina/cor
https://issues.apache.org/bugzilla/show_bug.cgi?id=49979
Summary: SimpleDateFormat StringIndexOutOfBoundsException
Product: Tomcat 6
Version: 6.0.20
Platform: PC
OS/Version: Linux
Status: NEW
Severity: major
Priorit
https://issues.apache.org/bugzilla/show_bug.cgi?id=49978
Summary: WebappLoader throws exception if workDir already
exists (when unpackWARs=false)
Product: Tomcat 7
Version: trunk
Platform: PC
OS/Version: Linux
Statu
https://issues.apache.org/bugzilla/show_bug.cgi?id=49972
--- Comment #7 from Chuck Caldarale 2010-09-22
12:58:53 EDT ---
(In reply to comment #5)
> Also, there are problem with 64 bit variable currentDateGenerated
This is a problem (albeit a fairly minor one); technically, the field should be
m
https://issues.apache.org/bugzilla/show_bug.cgi?id=49972
--- Comment #6 from Chuck Caldarale 2010-09-22
12:53:46 EDT ---
(In reply to comment #4)
> > The simple fix is to just reverse these two lines:
> I afraid, it won't work.
> The compiler is free to reverse these lines back.
Not in this ca
https://issues.apache.org/bugzilla/show_bug.cgi?id=49972
--- Comment #5 from Sergey Vorobyev 2010-09-22
11:46:36 EDT ---
Also, there are problem with 64 bit variable currentDateGenerated
http://java.sun.com/docs/books/jls/third_edition/html/memory.html
quote:
For the purposes of the Java progra
2010/9/22 Caldarale, Charles R :
>> From: kkoli...@apache.org [mailto:kkoli...@apache.org]
>> Subject: svn commit: r103 - /tomcat/trunk/webapps/docs/logging.xml
>
>> @@ -62,12 +59,12 @@
>> Tomcat no longer uses localhost_log as the runtime
>> exception/stack trace log. These types
https://issues.apache.org/bugzilla/show_bug.cgi?id=49521
Mark Thomas changed:
What|Removed |Added
Component|Connectors |Connector:Coyote
Version|
Author: markt
Date: Wed Sep 22 15:03:28 2010
New Revision: 120
URL: http://svn.apache.org/viewvc?rev=120&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49521
- Disable scanning for a free port in Jk AJP/1.3 connector by default.
- Do not change maxPort field value
> From: kkoli...@apache.org [mailto:kkoli...@apache.org]
> Subject: svn commit: r103 - /tomcat/trunk/webapps/docs/logging.xml
> @@ -62,12 +59,12 @@
>Tomcat no longer uses localhost_log as the runtime
>exception/stack trace log. These types of error are usually thrown by
>
https://issues.apache.org/bugzilla/show_bug.cgi?id=49030
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
Author: markt
Date: Wed Sep 22 14:56:26 2010
New Revision: 114
URL: http://svn.apache.org/viewvc?rev=114&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49030
Failure of one connector should not leave some connectors started and some
ignored
Modified:
tomcat/tc6.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49972
--- Comment #4 from Kostya Serebryany
2010-09-22 10:53:58 EDT ---
>> The simple fix is to just reverse these two lines:
I afraid, it won't work.
The compiler is free to reverse these lines back.
(maybe not in this particular case, but ce
Author: kkolinko
Date: Wed Sep 22 14:48:53 2010
New Revision: 103
URL: http://svn.apache.org/viewvc?rev=103&view=rev
Log:
Improving the documentation for logging configuration in Apache Tomcat
Modified:
tomcat/trunk/webapps/docs/logging.xml
Modified: tomcat/trunk/webapps/docs/logging
Author: markt
Date: Wed Sep 22 14:47:16 2010
New Revision: 95
URL: http://svn.apache.org/viewvc?rev=95&view=rev
Log:
Fix typo
Modified:
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/do
Dear Wiki user,
You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change
notification.
The "TomcatOnMacOS" page has been changed by SorinSbarnea.
http://wiki.apache.org/tomcat/TomcatOnMacOS?action=diff&rev1=22&rev2=23
--
-
Author: mturk
Date: Wed Sep 22 14:38:58 2010
New Revision: 85
URL: http://svn.apache.org/viewvc?rev=85&view=rev
Log:
Add my persona to the @authors
Modified:
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apa
Author: mturk
Date: Wed Sep 22 14:36:59 2010
New Revision: 83
URL: http://svn.apache.org/viewvc?rev=83&view=rev
Log:
Backport the unlockAccept
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
tomcat/tc6.0.x/trunk/w
On 22/09/2010 07:21, Mark Thomas wrote:
> Looking at this some more, I wonder if JSP compilation with Ant is even
> possible without tools.jar? I'll do some testing...
It is, as long as ant-launcher.jar is in the lib directory. I've updated
the docs.
Mark
--
Author: markt
Date: Wed Sep 22 14:34:23 2010
New Revision: 80
URL: http://svn.apache.org/viewvc?rev=80&view=rev
Log:
Need ant-launcher.jar to compile JSPs with Ant rather than ECJ
Modified:
tomcat/trunk/webapps/docs/jasper-howto.xml
Modified: tomcat/trunk/webapps/docs/jasper-howto.xm
Author: mturk
Date: Wed Sep 22 14:34:13 2010
New Revision: 79
URL: http://svn.apache.org/viewvc?rev=79&view=rev
Log:
Mark the proposed patch for backport
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.
Author: markt
Date: Wed Sep 22 14:33:25 2010
New Revision: 78
URL: http://svn.apache.org/viewvc?rev=78&view=rev
Log:
Need ant-launcher.jar to compile JSPs with Ant rather than ECJ
Modified:
tomcat/tc6.0.x/trunk/webapps/docs/jasper-howto.xml
Modified: tomcat/tc6.0.x/trunk/webapps/docs
Author: mturk
Date: Wed Sep 22 14:29:07 2010
New Revision: 76
URL: http://svn.apache.org/viewvc?rev=76&view=rev
Log:
Use *modern* types of nsis install/uninstall icons
Modified:
tomcat/trunk/res/main.ico
tomcat/trunk/res/uninst.ico
Modified: tomcat/trunk/res/main.ico
URL:
http:/
Author: mturk
Date: Wed Sep 22 14:22:48 2010
New Revision: 72
URL: http://svn.apache.org/viewvc?rev=72&view=rev
Log:
Add connector wait for shutdown to changelog
Modified:
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apach
Author: markt
Date: Wed Sep 22 14:22:00 2010
New Revision: 70
URL: http://svn.apache.org/viewvc?rev=70&view=rev
Log:
Delete reference to option that was previously removed.
Modified:
tomcat/tc6.0.x/trunk/webapps/docs/jasper-howto.xml
Modified: tomcat/tc6.0.x/trunk/webapps/docs/jasper
On 22/09/2010 07:16, Mark Thomas wrote:
> On 22/09/2010 07:11, Konstantin Kolinko wrote:
>>> --- tomcat/tc6.0.x/trunk/webapps/docs/jasper-howto.xml (original)
>>> +++ tomcat/tc6.0.x/trunk/webapps/docs/jasper-howto.xml Wed Sep 22 13:43:53
>>> 2010
>>> @@ -192,7 +192,7 @@ tens of JARs. On fast serve
https://issues.apache.org/bugzilla/show_bug.cgi?id=49972
--- Comment #3 from Chuck Caldarale 2010-09-22
10:20:36 EDT ---
(In reply to comment #2)
> It looks scarier than that.
> In short, see
> http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html
Not all double-checked lockin
Author: markt
Date: Wed Sep 22 14:18:48 2010
New Revision: 66
URL: http://svn.apache.org/viewvc?rev=66&view=rev
Log:
Delete reference to option that was previously removed.
Modified:
tomcat/trunk/webapps/docs/jasper-howto.xml
Modified: tomcat/trunk/webapps/docs/jasper-howto.xml
URL:
On 22/09/2010 07:11, Konstantin Kolinko wrote:
>> --- tomcat/tc6.0.x/trunk/webapps/docs/jasper-howto.xml (original)
>> +++ tomcat/tc6.0.x/trunk/webapps/docs/jasper-howto.xml Wed Sep 22 13:43:53
>> 2010
>> @@ -192,7 +192,7 @@ tens of JARs. On fast servers, this will
>> for even large JSP pages.
>
Author: mturk
Date: Wed Sep 22 14:15:54 2010
New Revision: 63
URL: http://svn.apache.org/viewvc?rev=63&view=rev
Log:
Add ASL header
Modified:
tomcat/jk/trunk/native/iis/pcre/libpcre.def
tomcat/jk/trunk/native/iis/pcre/libpcreposix.def
Modified: tomcat/jk/trunk/native/iis/pcre/lib
Author: mturk
Date: Wed Sep 22 14:15:15 2010
New Revision: 61
URL: http://svn.apache.org/viewvc?rev=61&view=rev
Log:
Add ASL header
Modified:
tomcat/jk/trunk/native/iis/isapi.def
Modified: tomcat/jk/trunk/native/iis/isapi.def
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/
Author: markt
Date: Wed Sep 22 14:12:26 2010
New Revision: 58
URL: http://svn.apache.org/viewvc?rev=58&view=rev
Log:
Vote
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=58&
> --- tomcat/tc6.0.x/trunk/webapps/docs/jasper-howto.xml (original)
> +++ tomcat/tc6.0.x/trunk/webapps/docs/jasper-howto.xml Wed Sep 22 13:43:53
> 2010
> @@ -192,7 +192,7 @@ tens of JARs. On fast servers, this will
> for even large JSP pages.
>
> Apache Ant, which was used in previous Tomcat re
Author: mturk
Date: Wed Sep 22 14:11:11 2010
New Revision: 56
URL: http://svn.apache.org/viewvc?rev=56&view=rev
Log:
Trim trailing spaces. No functional change
Modified:
tomcat/jk/trunk/native/iis/jk_isapi_plugin.c
Modified: tomcat/jk/trunk/native/iis/jk_isapi_plugin.c
URL:
http://s
Author: mturk
Date: Wed Sep 22 14:10:04 2010
New Revision: 54
URL: http://svn.apache.org/viewvc?rev=54&view=rev
Log:
Cast a vote
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=
Author: markt
Date: Wed Sep 22 13:57:12 2010
New Revision: 50
URL: http://svn.apache.org/viewvc?rev=50&view=rev
Log:
Fix a possible NPE when a parallel request invalidates the session before the
current request has a chance to send the replication message.
Modified:
tomcat/tc6.0.x/tr
https://issues.apache.org/bugzilla/show_bug.cgi?id=49972
--- Comment #2 from konstantin.s.serebry...@gmail.com 2010-09-22 09:56:49 EDT
---
It looks scarier than that.
In short, see
http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html
Case1:
Thread1 executes:
long no
Author: markt
Date: Wed Sep 22 13:51:54 2010
New Revision: 46
URL: http://svn.apache.org/viewvc?rev=46&view=rev
Log:
Vote
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=46&
Author: markt
Date: Wed Sep 22 13:48:58 2010
New Revision: 45
URL: http://svn.apache.org/viewvc?rev=45&view=rev
Log:
Provide better web application state information via JMX. A limited back-port
of http://svn.apache.org/viewvc?rev=992245&view=rev that could be extended to
other component
Author: kkolinko
Date: Wed Sep 22 13:44:12 2010
New Revision: 42
URL: http://svn.apache.org/viewvc?rev=42&view=rev
Log:
add release date for 5.5.31
Modified:
tomcat/tc5.5.x/trunk/container/webapps/docs/changelog.xml
Modified: tomcat/tc5.5.x/trunk/container/webapps/docs/changelog.xml
Author: markt
Date: Wed Sep 22 13:43:53 2010
New Revision: 41
URL: http://svn.apache.org/viewvc?rev=41&view=rev
Log:
Switch to using the Eclipse compiler JAR directly rather than creating it from
the larger JDT download.
Removed:
tomcat/tc6.0.x/trunk/res/META-INF/jasper-jdt.jar.licen
Author: markt
Date: Wed Sep 22 13:33:14 2010
New Revision: 37
URL: http://svn.apache.org/viewvc?rev=37&view=rev
Log:
Remove applied patch
Modified:
tomcat/tc5.5.x/trunk/STATUS.txt
Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS
Author: markt
Date: Wed Sep 22 13:32:05 2010
New Revision: 36
URL: http://svn.apache.org/viewvc?rev=36&view=rev
Log:
Ensure POM files have correct line endings in source distributions. (rjung's
patch)
Modified:
tomcat/tc5.5.x/trunk/build/build.xml
tomcat/tc5.5.x/trunk/container/w
Author: markt
Date: Wed Sep 22 13:23:35 2010
New Revision: 33
URL: http://svn.apache.org/viewvc?rev=33&view=rev
Log:
Vote
Modified:
tomcat/tc5.5.x/trunk/STATUS.txt
Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=33&
Author: kkolinko
Date: Wed Sep 22 13:15:46 2010
New Revision: 29
URL: http://svn.apache.org/viewvc?rev=29&view=rev
Log:
add release date for 7.0.2 beta,
from announcement on tomcat.apache.org
Modified:
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/webapps/docs/change
https://issues.apache.org/bugzilla/show_bug.cgi?id=49972
konstantin.s.serebry...@gmail.com changed:
What|Removed |Added
CC||konstantin.s.ser
https://issues.apache.org/bugzilla/show_bug.cgi?id=49942
Sergey Vorobyev changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
https://issues.apache.org/bugzilla/show_bug.cgi?id=49102
--- Comment #2 from Tim Whittington 2010-09-22 07:02:17 EDT
---
We can protect these by converting to enums, but the lookup is about 3 times
slower (although .005ns vs 0.014ns is splitting hairs ;).
--
Configure bugmail: https://issues.a
https://issues.apache.org/bugzilla/show_bug.cgi?id=49972
--- Comment #1 from Sebb 2010-09-22 06:53:24 EDT ---
The currentDateGenerated field is read outside the synch. block, and is not
volatile.
So if one thread calls getCurrentDate() and updates the field, another thread
calling getCurrentDate
https://issues.apache.org/bugzilla/show_bug.cgi?id=48925
Tim Whittington changed:
What|Removed |Added
Status|NEW |NEEDINFO
--
Configure bugmail:
https://issues.apache.org/bugzilla/show_bug.cgi?id=42119
Tim Whittington changed:
What|Removed |Added
CC||nig...@forwardcomputers.co.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49960
Tim Whittington changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
https://issues.apache.org/bugzilla/show_bug.cgi?id=49972
Sergey Vorobyev changed:
What|Removed |Added
CC||sergeyvorob...@google.com
https://issues.apache.org/bugzilla/show_bug.cgi?id=49972
Summary: Double-check idiom. Possible data-race.
Product: Tomcat 6
Version: 6.0.29
Platform: PC
Status: NEW
Severity: normal
Priority: P2
Component: Manager
59 matches
Mail list logo