AprEndpoint Runnable->Thread fixes

2010-09-02 Thread Mladen Turk
Hi, I changed the Poller, Sendfile and Acceptor classes to extend the Thread instead just implement Runnable. Now, that was the easy hack cause we really don't need to extend the Thread behavior for those classes so might no be an optimal solution. In essence we need to wait on each of those th

svn commit: r992211 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2010-09-02 Thread mturk
Author: mturk Date: Fri Sep 3 05:27:24 2010 New Revision: 992211 URL: http://svn.apache.org/viewvc?rev=992211&view=rev Log: Join poller and sendfile threads on destroy. This requires to change the Poller and Sendile to Thread instead Runnable for simplicity. Modified: tomcat/trunk/java/org/

svn commit: r992208 - in /tomcat/native/trunk/native/src: network.c pool.c

2010-09-02 Thread mturk
Author: mturk Date: Fri Sep 3 05:22:07 2010 New Revision: 992208 URL: http://svn.apache.org/viewvc?rev=992208&view=rev Log: Don't destroy pools explicitly if we are inside apr_terminate call Modified: tomcat/native/trunk/native/src/network.c tomcat/native/trunk/native/src/pool.c Modifie

svn commit: r992200 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2010-09-02 Thread mturk
Author: mturk Date: Fri Sep 3 04:36:46 2010 New Revision: 992200 URL: http://svn.apache.org/viewvc?rev=992200&view=rev Log: Make sure we exit the thread if not running. Otherwise the thread will block in run until the VM shuts down Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprE

svn commit: r992199 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2010-09-02 Thread mturk
Author: mturk Date: Fri Sep 3 04:26:23 2010 New Revision: 992199 URL: http://svn.apache.org/viewvc?rev=992199&view=rev Log: Store the Acceptor instances in the array like we do for other threads Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Modified: tomcat/trunk/j

svn commit: r992194 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2010-09-02 Thread mturk
Author: mturk Date: Fri Sep 3 04:09:25 2010 New Revision: 992194 URL: http://svn.apache.org/viewvc?rev=992194&view=rev Log: Trim trailing spaces. No functional change Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/util/n

DO NOT REPLY [Bug 49871] New: http 404 status error

2010-09-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49871 Summary: http 404 status error Product: Tomcat 6 Version: 6.0.24 Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Compon

DO NOT REPLY [Bug 49869] New: Javadoc for WebAppClassLoader constructor has copy/paste error

2010-09-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49869 Summary: Javadoc for WebAppClassLoader constructor has copy/paste error Product: Tomcat 7 Version: 7.0.0 Platform: PC Status: NEW Severity: normal

Voting for issues.

2010-09-02 Thread Wesley Acheson
I understand that the Apache voting system is a bit odd. For enhancement requests though is there no way for users to vote for the features that they would like. (Which is different to you as devs voting on whether to apply a patch or not). I'm pretty sure that's a normal bugzilla feature but I hav

DO NOT REPLY [Bug 49868] New: refactor BeanELResolver.java invoke()

2010-09-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49868 Summary: refactor BeanELResolver.java invoke() Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: minor Priority: P2

DO NOT REPLY [Bug 49867] New: default library location into the project tree

2010-09-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49867 Summary: default library location into the project tree Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: minor Prior

svn commit: r992018 - /tomcat/trunk/java/org/apache/catalina/startup/CatalinaProperties.java

2010-09-02 Thread rjung
Author: rjung Date: Thu Sep 2 16:52:48 2010 New Revision: 992018 URL: http://svn.apache.org/viewvc?rev=992018&view=rev Log: BZ 49865: ExceptionUtils throw NoClassDefFoundError during startup. Add TODO markers. Modified: tomcat/trunk/java/org/apache/catalina/startup/CatalinaProperties.java M

DO NOT REPLY [Bug 49865] New: ExceptionUtils throw NoClassDefFoundError during startup

2010-09-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49865 Summary: ExceptionUtils throw NoClassDefFoundError during startup Product: Tomcat 7 Version: trunk Platform: All OS/Version: All Status: NEW Severit

DO NOT REPLY [Bug 48967] Externalize Strings "catalina.base" and "catalina.home"

2010-09-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48967 Rainer Jung changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r991965 - in /tomcat/trunk/java/org/apache/catalina: core/StandardEngine.java startup/ContextConfig.java

2010-09-02 Thread rjung
Author: rjung Date: Thu Sep 2 15:02:52 2010 New Revision: 991965 URL: http://svn.apache.org/viewvc?rev=991965&view=rev Log: Followup to r991959. Forgot the two classes. Modified: tomcat/trunk/java/org/apache/catalina/core/StandardEngine.java tomcat/trunk/java/org/apache/catalina/startup

svn commit: r991959 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/ha/deploy/ java/org/apache/catalina/manage

2010-09-02 Thread rjung
Author: rjung Date: Thu Sep 2 14:52:11 2010 New Revision: 991959 URL: http://svn.apache.org/viewvc?rev=991959&view=rev Log: BZ 48967: Replace strings "catalina.base" and "catalina.home" by globally defined constants. Patch provided by Marc Guillemot. Modified: tomcat/trunk/java/org/apache/c

svn commit: r991915 - /tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java

2010-09-02 Thread markt
Author: markt Date: Thu Sep 2 12:36:23 2010 New Revision: 991915 URL: http://svn.apache.org/viewvc?rev=991915&view=rev Log: Fix warnings Modified: tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java Modified: tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java URL: http

svn commit: r991867 - in /tomcat/trunk/webapps/docs: changelog.xml index.xml

2010-09-02 Thread markt
Author: markt Date: Thu Sep 2 09:08:46 2010 New Revision: 991867 URL: http://svn.apache.org/viewvc?rev=991867&view=rev Log: Update the Servlet, JSP & EL javadoc links and add spec links. Modified: tomcat/trunk/webapps/docs/changelog.xml tomcat/trunk/webapps/docs/index.xml Modified: tomc

DO NOT REPLY [Bug 49861] New: Log format of RMI ports can be improved, remove ","

2010-09-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49861 Summary: Log format of RMI ports can be improved, remove "," Product: Tomcat 6 Version: 6.0.29 Platform: PC OS/Version: Linux Status: NEW Severity: minor Prio

svn commit: r991842 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

2010-09-02 Thread markt
Author: markt Date: Thu Sep 2 08:01:20 2010 New Revision: 991842 URL: http://svn.apache.org/viewvc?rev=991842&view=rev Log: Add a comment as a reminder Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Modified: tomcat/trunk/java/org/apache/catalina/core/StandardCont

svn commit: r991840 - /tomcat/tc5.5.x/trunk/container/webapps/docs/cluster-howto.xml

2010-09-02 Thread markt
Author: markt Date: Thu Sep 2 07:57:23 2010 New Revision: 991840 URL: http://svn.apache.org/viewvc?rev=991840&view=rev Log: Remove setting distributable on the Context from the docs. It gets lost on webapp reload() e.g. when triggered from the manager app. Modified: tomcat/tc5.5.x/trunk/con

svn commit: r991839 - in /tomcat/tc6.0.x/trunk: ./ webapps/docs/cluster-howto.xml

2010-09-02 Thread markt
Author: markt Date: Thu Sep 2 07:56:26 2010 New Revision: 991839 URL: http://svn.apache.org/viewvc?rev=991839&view=rev Log: Remove setting distributable on the Context from the docs. It gets lost on webapp reload() e.g. when triggered from the manager app. Modified: tomcat/tc6.0.x/trunk/

svn commit: r991837 - /tomcat/trunk/webapps/docs/cluster-howto.xml

2010-09-02 Thread markt
Author: markt Date: Thu Sep 2 07:55:11 2010 New Revision: 991837 URL: http://svn.apache.org/viewvc?rev=991837&view=rev Log: Remove setting distributable on the Context from the docs. It gets lost on webapp reload() e.g. when triggered from the manager app. Modified: tomcat/trunk/webapps/doc