New joiner's question - mocking for unit tests

2010-07-22 Thread Alexander Shirkov
Hello all I have quick question: Is there mocking framework in project? Writing dummies for unit tests is quite useless and boring thing. Plus it¹s filling codebase with ³noise². I have some experience with: JMock - http://www.jmock.org/ EasyMock - http://easymock.org/ Mockito (my favourite) - h

DO NOT REPLY [Bug 49165] Enhancement - Allow %{TIME_FORMAT}t As Configuration for AccessLogValve

2010-07-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49165 --- Comment #6 from Alexander Shirkov 2010-07-22 22:38:38 EDT --- (In reply to comment #5) > 1. It uses a mix of tabs and spaces for indenting. Only spaces should be used. Done. > 2. Log messages should use the StringManager to provide i1

DO NOT REPLY [Bug 49343] AbstractReplicatedMap is not removed from channel.

2010-07-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49343 Keiichi Fujino changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r966937 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java webapps/docs/changelog.xml

2010-07-22 Thread kfujino
Author: kfujino Date: Fri Jul 23 02:34:51 2010 New Revision: 966937 URL: http://svn.apache.org/viewvc?rev=966937&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49343 When ChannelException is thrown, remove listener from channel. Modified: tomcat/tc6.0.x/trunk/STATUS.txt

svn commit: r966910 - /tomcat/tc5.5.x/trunk/STATUS.txt

2010-07-22 Thread rjung
Author: rjung Date: Fri Jul 23 00:04:21 2010 New Revision: 966910 URL: http://svn.apache.org/viewvc?rev=966910&view=rev Log: Vote, comment. Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?r

svn commit: r966908 - in /tomcat/tc5.5.x/trunk: ./ build/ connectors/http11/src/test/ container/catalina/src/share/org/apache/catalina/valves/ container/webapps/docs/ container/webapps/jmxremote/WEB-I

2010-07-22 Thread rjung
Author: rjung Date: Thu Jul 22 23:57:08 2010 New Revision: 966908 URL: http://svn.apache.org/viewvc?rev=966908&view=rev Log: Add svn:executable property to some script files and remove it from non-executable files. Modified: tomcat/tc5.5.x/trunk/STATUS.txt tomcat/tc5.5.x/trunk/build/sign.

DO NOT REPLY [Bug 49567] when starting a new thread from a startAsync Runnable, an infinite amount of doPosts is generated

2010-07-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49567 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r966883 - in /tomcat/trunk/java/javax/el: ArrayELResolver.java ListELResolver.java MapELResolver.java PropertyNotFoundException.java ResourceBundleELResolver.java

2010-07-22 Thread markt
Author: markt Date: Thu Jul 22 22:35:32 2010 New Revision: 966883 URL: http://svn.apache.org/viewvc?rev=966883&view=rev Log: Tab police: javax.el Thanks to Checkstyle Modified: tomcat/trunk/java/javax/el/ArrayELResolver.java tomcat/trunk/java/javax/el/ListELResolver.java tomcat/trunk/

DO NOT REPLY [Bug 49268] Use checkstyle to enforce common code style

2010-07-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49268 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r966882 - in /tomcat/trunk: build.properties.default build.xml checkstyle.xml webapps/docs/changelog.xml

2010-07-22 Thread markt
Author: markt Date: Thu Jul 22 22:31:30 2010 New Revision: 966882 URL: http://svn.apache.org/viewvc?rev=966882&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49268 Add necessary plumbing to enable Checkstyle The config file is deliberately empty. The check will be uncommented

svn commit: r966868 - /tomcat/tc5.5.x/trunk/STATUS.txt

2010-07-22 Thread markt
Author: markt Date: Thu Jul 22 21:47:33 2010 New Revision: 966868 URL: http://svn.apache.org/viewvc?rev=966868&view=rev Log: Vote Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=966868&

svn commit: r966867 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-07-22 Thread markt
Author: markt Date: Thu Jul 22 21:45:31 2010 New Revision: 966867 URL: http://svn.apache.org/viewvc?rev=966867&view=rev Log: Vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=966867&

svn commit: r966865 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-07-22 Thread markt
Author: markt Date: Thu Jul 22 21:38:09 2010 New Revision: 966865 URL: http://svn.apache.org/viewvc?rev=966865&view=rev Log: Add additional patch to address feedback. Remove jfclere's vote as the patch is now different. Vote. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x

svn commit: r966864 - /tomcat/trunk/java/org/apache/jasper/compiler/ELFunctionMapper.java

2010-07-22 Thread markt
Author: markt Date: Thu Jul 22 21:36:55 2010 New Revision: 966864 URL: http://svn.apache.org/viewvc?rev=966864&view=rev Log: Use specific imports Modified: tomcat/trunk/java/org/apache/jasper/compiler/ELFunctionMapper.java Modified: tomcat/trunk/java/org/apache/jasper/compiler/ELFunctionMapp

svn commit: r966863 - /tomcat/trunk/java/org/apache/jasper/compiler/ELFunctionMapper.java

2010-07-22 Thread markt
Author: markt Date: Thu Jul 22 21:36:11 2010 New Revision: 966863 URL: http://svn.apache.org/viewvc?rev=966863&view=rev Log: Fix regression in previous fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=49555 Use TCCL to load webapp classes Modified: tomcat/trunk/java/org/apache/jasp

svn commit: r966862 - /tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java

2010-07-22 Thread markt
Author: markt Date: Thu Jul 22 21:29:42 2010 New Revision: 966862 URL: http://svn.apache.org/viewvc?rev=966862&view=rev Log: Fix copy/paste error Modified: tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java Modified: tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.j

svn commit: r966750 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/loader/WebappClassLoader.java webapps/docs/changelog.xml

2010-07-22 Thread markt
Author: markt Date: Thu Jul 22 17:02:32 2010 New Revision: 966750 URL: http://svn.apache.org/viewvc?rev=966750&view=rev Log: Return a copy of the URL being used from the webapp class loader, not the original. Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat/tc6.0.x/trunk/STATUS.t

svn commit: r966745 - /tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java

2010-07-22 Thread markt
Author: markt Date: Thu Jul 22 16:58:26 2010 New Revision: 966745 URL: http://svn.apache.org/viewvc?rev=966745&view=rev Log: Fix some Eclipse warnings, remove some implemented TODOs Modified: tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java Modified: tomcat/trunk/java/org/apa

svn commit: r966744 - /tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java

2010-07-22 Thread markt
Author: markt Date: Thu Jul 22 16:56:32 2010 New Revision: 966744 URL: http://svn.apache.org/viewvc?rev=966744&view=rev Log: Implement some Servlet 3 TODOs Modified: tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java Modified: tomcat/trunk/java/org/apache/catalina/core/AsyncCon

svn commit: r966735 - in /tomcat/trunk/java/org/apache/catalina: ./ core/ startup/ util/

2010-07-22 Thread markt
Author: markt Date: Thu Jul 22 16:32:11 2010 New Revision: 966735 URL: http://svn.apache.org/viewvc?rev=966735&view=rev Log: Extend Lifecycle state machine so global listeners can start before everything else without impacting the context and TLD config listeners Modified: tomcat/trunk/java/

DO NOT REPLY [Bug 49637] Spam

2010-07-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49637 Rainer Jung changed: What|Removed |Added Component|Integration |Catalina Platform|Sun

DO NOT REPLY [Bug 49487] Spam

2010-07-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49487 Rainer Jung changed: What|Removed |Added Component|mod_jk |Common Summary|Angosso Si

DO NOT REPLY [Bug 49613] Request.getAttributeNames() slows down some applications

2010-07-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49613 --- Comment #7 from Mark Thomas 2010-07-22 10:38:43 EDT --- Thanks for the patch. It has been applied to 7.0.x and will be in 7.0.1 onwards. It has been proposed for 6.0.x. -- Configure bugmail: https://issues.apache.org/bugzilla/userpr

svn commit: r966693 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-07-22 Thread markt
Author: markt Date: Thu Jul 22 14:37:38 2010 New Revision: 966693 URL: http://svn.apache.org/viewvc?rev=966693&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=966

svn commit: r966692 - in /tomcat/trunk: java/org/apache/catalina/connector/Request.java webapps/docs/changelog.xml

2010-07-22 Thread markt
Author: markt Date: Thu Jul 22 14:36:15 2010 New Revision: 966692 URL: http://svn.apache.org/viewvc?rev=966692&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49613 Improve performance for multiple calls to Request.getAttributeNames() when using SSL. Patch provided by Sampo S

Re: DO NOT REPLY [Bug 49637] request for AJP command line client

2010-07-22 Thread Rainer Jung
On 22.07.2010 15:49, Henri Gomez wrote: An AJP command line 'client', could be a somewhat good idea :) Sure, this is already tracked via issue https://issues.apache.org/bugzilla/show_bug.cgi?id=47242 The one I referred to had pure Spam content, apart from the title of the issue. Regards,

Re: DO NOT REPLY [Bug 49637] request for AJP command line client

2010-07-22 Thread Rainer Jung
On 22.07.2010 15:49, Mark Thomas wrote: On 22/07/2010 14:44, Rainer Jung wrote: This is a SPAM issue. Is there a way to remove it and possibly block the user? A second SPAM issue by the same reporter is https://issues.apache.org/bugzilla/show_bug.cgi?id=49487 No other issues reported by this a

svn commit: r966684 - /tomcat/trunk/java/org/apache/catalina/connector/Request.java

2010-07-22 Thread markt
Author: markt Date: Thu Jul 22 14:27:20 2010 New Revision: 966684 URL: http://svn.apache.org/viewvc?rev=966684&view=rev Log: Remove some TODOs that have been implemented Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java Modified: tomcat/trunk/java/org/apache/catalina/con

Re: [RESULT] [VOTE] Release build 6.0.29

2010-07-22 Thread Yoav Shapira
On Thu, Jul 22, 2010 at 4:56 AM, jean-frederic clere wrote: > On 07/19/2010 06:33 PM, jean-frederic clere wrote: >> The candidates binaries are available here: >> http://people.apache.org/~jfclere/tomcat-6/v6.0.29/ >> >> According to the release process, the 6.0.29 build corresponding to the >> ta

Re: DO NOT REPLY [Bug 49637] request for AJP command line client

2010-07-22 Thread Henri Gomez
An AJP command line 'client', could be a somewhat good idea :) > 2010/7/22 Rainer Jung : > This is a SPAM issue. Is there a way to remove it and possibly block the > user? A second SPAM issue by the same reporter is > > https://issues.apache.org/bugzilla/show_bug.cgi?id=49487 > > No other issues r

Re: DO NOT REPLY [Bug 49637] request for AJP command line client

2010-07-22 Thread Mark Thomas
On 22/07/2010 14:44, Rainer Jung wrote: > This is a SPAM issue. Is there a way to remove it and possibly block the > user? A second SPAM issue by the same reporter is > > https://issues.apache.org/bugzilla/show_bug.cgi?id=49487 > > No other issues reported by this account. Already blocked. Ther

Re: DO NOT REPLY [Bug 49637] request for AJP command line client

2010-07-22 Thread Rainer Jung
This is a SPAM issue. Is there a way to remove it and possibly block the user? A second SPAM issue by the same reporter is https://issues.apache.org/bugzilla/show_bug.cgi?id=49487 No other issues reported by this account. Regards, Rainer --

DO NOT REPLY [Bug 49600] Bad exception thrown by ProxyDirContext.lookup

2010-07-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49600 --- Comment #4 from Mark Thomas 2010-07-22 09:42:03 EDT --- No, I didn't write the original code but I trust that Remy had a good reason for this particular optimisation. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.

Re: svn commit: r966613 - in /tomcat/trunk: build.xml test/org/apache/catalina/startup/TestTomcatSSL.java test/org/apache/catalina/startup/TomcatBaseTest.java webapps/docs/changelog.xml

2010-07-22 Thread Mladen Turk
On 07/22/2010 02:22 PM, Mark Thomas wrote: On 22/07/2010 13:18, ma...@apache.org wrote: Author: markt Date: Thu Jul 22 12:18:59 2010 New Revision: 966613 URL: http://svn.apache.org/viewvc?rev=966613&view=rev Log: Run all unit tests will all connectors When I enable this for the APR connector

Re: svn commit: r966613 - in /tomcat/trunk: build.xml test/org/apache/catalina/startup/TestTomcatSSL.java test/org/apache/catalina/startup/TomcatBaseTest.java webapps/docs/changelog.xml

2010-07-22 Thread Mark Thomas
On 22/07/2010 13:18, ma...@apache.org wrote: > Author: markt > Date: Thu Jul 22 12:18:59 2010 > New Revision: 966613 > > URL: http://svn.apache.org/viewvc?rev=966613&view=rev > Log: > Run all unit tests will all connectors When I enable this for the APR connector it always crashes the JVM on shut

svn commit: r966613 - in /tomcat/trunk: build.xml test/org/apache/catalina/startup/TestTomcatSSL.java test/org/apache/catalina/startup/TomcatBaseTest.java webapps/docs/changelog.xml

2010-07-22 Thread markt
Author: markt Date: Thu Jul 22 12:18:59 2010 New Revision: 966613 URL: http://svn.apache.org/viewvc?rev=966613&view=rev Log: Run all unit tests will all connectors Modified: tomcat/trunk/build.xml tomcat/trunk/test/org/apache/catalina/startup/TestTomcatSSL.java tomcat/trunk/test/org/a

svn commit: r966607 - /tomcat/tc6.0.x/trunk/NOTICE

2010-07-22 Thread kkolinko
Author: kkolinko Date: Thu Jul 22 12:05:52 2010 New Revision: 966607 URL: http://svn.apache.org/viewvc?rev=966607&view=rev Log: correct a typo in NOTICE file CTR Modified: tomcat/tc6.0.x/trunk/NOTICE Modified: tomcat/tc6.0.x/trunk/NOTICE URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trun

svn commit: r966597 - /tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

2010-07-22 Thread jfclere
Author: jfclere Date: Thu Jul 22 11:53:23 2010 New Revision: 966597 URL: http://svn.apache.org/viewvc?rev=966597&view=rev Log: Add the release date. Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org

svn commit: r966596 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2010-07-22 Thread markt
Author: markt Date: Thu Jul 22 11:51:00 2010 New Revision: 966596 URL: http://svn.apache.org/viewvc?rev=966596&view=rev Log: Poll time and wait are both in milliseconds Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/util/

Re: svn commit: r966586 - in /tomcat/site/trunk: docs/whichversion.html xdocs/whichversion.xml

2010-07-22 Thread Konstantin Kolinko
2010/7/22 : > Author: kkolinko > Date: Thu Jul 22 11:29:09 2010 > New Revision: 966586 > > URL: http://svn.apache.org/viewvc?rev=966586&view=rev > Log: > update whichversion.html > > Modified: >    tomcat/site/trunk/docs/whichversion.html >    tomcat/site/trunk/xdocs/whichversion.xml > > -  6.0.28

svn commit: r966591 - /tomcat/site/trunk/docs/whichversion.html

2010-07-22 Thread jfclere
Author: jfclere Date: Thu Jul 22 11:36:53 2010 New Revision: 966591 URL: http://svn.apache.org/viewvc?rev=966591&view=rev Log: Release 6.0.29 Modified: tomcat/site/trunk/docs/whichversion.html Modified: tomcat/site/trunk/docs/whichversion.html URL: http://svn.apache.org/viewvc/tomcat/site/t

svn commit: r966586 - in /tomcat/site/trunk: docs/whichversion.html xdocs/whichversion.xml

2010-07-22 Thread kkolinko
Author: kkolinko Date: Thu Jul 22 11:29:09 2010 New Revision: 966586 URL: http://svn.apache.org/viewvc?rev=966586&view=rev Log: update whichversion.html Modified: tomcat/site/trunk/docs/whichversion.html tomcat/site/trunk/xdocs/whichversion.xml Modified: tomcat/site/trunk/docs/whichversi

svn commit: r966579 - /tomcat/tc5.5.x/trunk/STATUS.txt

2010-07-22 Thread kkolinko
Author: kkolinko Date: Thu Jul 22 11:15:20 2010 New Revision: 966579 URL: http://svn.apache.org/viewvc?rev=966579&view=rev Log: Propose a backport Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATU

svn commit: r966573 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-07-22 Thread kkolinko
Author: kkolinko Date: Thu Jul 22 10:56:38 2010 New Revision: 966573 URL: http://svn.apache.org/viewvc?rev=966573&view=rev Log: vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=9665

svn commit: r966570 - /tomcat/trunk/java/org/apache/catalina/core/StandardEngine.java

2010-07-22 Thread markt
Author: markt Date: Thu Jul 22 10:43:43 2010 New Revision: 966570 URL: http://svn.apache.org/viewvc?rev=966570&view=rev Log: Fix possible NPE Modified: tomcat/trunk/java/org/apache/catalina/core/StandardEngine.java Modified: tomcat/trunk/java/org/apache/catalina/core/StandardEngine.java URL:

svn commit: r966567 - in /tomcat/site/trunk: docs/download-60.html docs/index.html docs/oldnews.html xdocs/download-60.xml xdocs/index.xml xdocs/oldnews.xml

2010-07-22 Thread jfclere
Author: jfclere Date: Thu Jul 22 10:32:38 2010 New Revision: 966567 URL: http://svn.apache.org/viewvc?rev=966567&view=rev Log: Release 6.0.29 Modified: tomcat/site/trunk/docs/download-60.html tomcat/site/trunk/docs/index.html tomcat/site/trunk/docs/oldnews.html tomcat/site/trunk/x

DO NOT REPLY [Bug 49637] request for AJP command line client

2010-07-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49637 Roger Mbiama Assogo changed: What|Removed |Added Keywords||PatchAvailable S

DO NOT REPLY [Bug 49637] New: request for AJP command line client

2010-07-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49637 Summary: request for AJP command line client Product: Tomcat 7 Version: trunk Platform: Sun OS/Version: Linux Status: NEW Severity: major Priority: P2

svn commit: r966548 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/coyote/http11/ test/org/apache/catalina/core/ webapps/docs/

2010-07-22 Thread markt
Author: markt Date: Thu Jul 22 09:12:18 2010 New Revision: 966548 URL: http://svn.apache.org/viewvc?rev=966548&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49567 Better handling of calls to complete() from a separate thread. There are still a handful of TODOs around this wh

[RESULT] [VOTE] Release build 6.0.29

2010-07-22 Thread jean-frederic clere
On 07/19/2010 06:33 PM, jean-frederic clere wrote: > The candidates binaries are available here: > http://people.apache.org/~jfclere/tomcat-6/v6.0.29/ > > According to the release process, the 6.0.29 build corresponding to the > tag TOMCAT_6_0_29 is: > [ ] Broken > [ ] Alpha > [ ] Beta > [X] Stabl