DO NOT REPLY [Bug 49241] DataSourceFactory.parsePoolProperties() doesn't look for "suspectTimeout"

2010-05-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49241 --- Comment #1 from Matt Passell 2010-05-01 21:03:50 EDT --- I'm already working on a fix for this. I'll try to add in any other missing properties I notice. I'll attach a patch when it's done. -- Configure bugmail: https://issues.apac

DO NOT REPLY [Bug 49241] New: DataSourceFactory.parsePoolProperties() doesn't look for "suspectTimeout"

2010-05-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49241 Summary: DataSourceFactory.parsePoolProperties() doesn't look for "suspectTimeout" Product: Tomcat 7 Version: trunk Platform: All OS/Version: All Status: NEW

Re: svn commit: r940089 - in /tomcat/trunk/java/org/apache/catalina/loader: LocalStrings.properties WebappLoader.java

2010-05-01 Thread Sylvain Laurent
I think that this commit broke the ability to stop and start a context. When I start it after having stopped it, I get a LifecycleException: An invalid Lifecycle transition was attempted ([before_start]) for component [WebappLoader[/testWeb]] in state [DESTROYED] Sylvain On 1 mai 2010, at 19:

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-05-01 Thread Kevan Miller
On May 1, 2010, at 7:25 AM, Mark Thomas wrote: > > Thanks for the review. My bad. I saw we are using EPL for the JDT > compiler and assumed we'd be fine for this to. I'll see what I can do to > work around it or get the license changed. No problem. The issue seems to have originated in BCEL...

svn commit: r940089 - in /tomcat/trunk/java/org/apache/catalina/loader: LocalStrings.properties WebappLoader.java

2010-05-01 Thread markt
Author: markt Date: Sat May 1 17:44:26 2010 New Revision: 940089 URL: http://svn.apache.org/viewvc?rev=940089&view=rev Log: Remove the controller - MBean registration will always happen in init()/destroy() after Lifecycle refactoring Fix a handful of Eclipse/FindBugs warnings Modified: tomc

Re: svn commit: r940038 - in /tomcat/trunk/java/org/apache/catalina/startup: Catalina.java LocalStrings.properties

2010-05-01 Thread Mark Thomas
On 01/05/2010 17:18, Konstantin Kolinko wrote: > 2010/5/1 Mark Thomas : >> On 01/05/2010 16:15, Konstantin Kolinko wrote: >>> 2010/5/1 : >>> Why are you removing the above try/catch? >> >> It was added to catch LifecycleException when I made Catalina implement >> Lifecycle. When I removed that int

Re: svn commit: r940038 - in /tomcat/trunk/java/org/apache/catalina/startup: Catalina.java LocalStrings.properties

2010-05-01 Thread Konstantin Kolinko
2010/5/1 Mark Thomas : > On 01/05/2010 16:15, Konstantin Kolinko wrote: >> 2010/5/1  : >> Why are you removing the above try/catch? > > It was added to catch LifecycleException when I made Catalina implement > Lifecycle. When I removed that interface, I changed this to Exception > but I could have

svn commit: r940068 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-05-01 Thread kkolinko
Author: kkolinko Date: Sat May 1 16:14:42 2010 New Revision: 940068 URL: http://svn.apache.org/viewvc?rev=940068&view=rev Log: proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=

svn commit: r940064 - in /tomcat/trunk/java/org/apache/catalina/startup: Catalina.java LocalStrings.properties

2010-05-01 Thread kkolinko
Author: kkolinko Date: Sat May 1 16:00:29 2010 New Revision: 940064 URL: http://svn.apache.org/viewvc?rev=940064&view=rev Log: Log any unexpected errors that might occur during server shutdown from the shutdown hook, and do not forget to shutdown (read: flush) the logging subsystem. Modified:

svn commit: r940057 - /tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java

2010-05-01 Thread markt
Author: markt Date: Sat May 1 15:44:33 2010 New Revision: 940057 URL: http://svn.apache.org/viewvc?rev=940057&view=rev Log: Make md volatile to be sure there are no threading issues Modified: tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java Modified: tomcat/trunk/java/org/apache/c

svn commit: r940056 - /tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java

2010-05-01 Thread markt
Author: markt Date: Sat May 1 15:41:46 2010 New Revision: 940056 URL: http://svn.apache.org/viewvc?rev=940056&view=rev Log: I can't see any reason why a Realm shouldn't be re-startable by default. Individual Realms can always override this. Modified: tomcat/trunk/java/org/apache/catalina/re

Re: svn commit: r940038 - in /tomcat/trunk/java/org/apache/catalina/startup: Catalina.java LocalStrings.properties

2010-05-01 Thread Mark Thomas
On 01/05/2010 16:15, Konstantin Kolinko wrote: > 2010/5/1 : >> Author: markt >> Date: Sat May 1 14:26:50 2010 >> New Revision: 940038 >> >> URL: http://svn.apache.org/viewvc?rev=940038&view=rev >> Log: >> Minor clean-up having reviewed the diff between current code and the code >> prior to the L

DO NOT REPLY [Bug 49092] util.IntrospectionUtils.PATH_SEPARATOR should be final

2010-05-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49092 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|

svn commit: r940055 - /tomcat/trunk/test/org/apache/catalina/tribes/demos/IntrospectionUtils.java

2010-05-01 Thread markt
Author: markt Date: Sat May 1 15:20:31 2010 New Revision: 940055 URL: http://svn.apache.org/viewvc?rev=940055&view=rev Log: Another fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=49092 Make constant final Modified: tomcat/trunk/test/org/apache/catalina/tribes/demos/IntrospectionU

DO NOT REPLY [Bug 49234] JMX Descriptor Modifications

2010-05-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49234 --- Comment #1 from Mark Thomas 2010-05-01 11:16:58 EDT --- username and password are meant to be read/write, otherwise looks good. Please update your patch and I'll apply it. -- Configure bugmail: https://issues.apache.org/bugzilla/userp

Re: svn commit: r940038 - in /tomcat/trunk/java/org/apache/catalina/startup: Catalina.java LocalStrings.properties

2010-05-01 Thread Konstantin Kolinko
2010/5/1 : > Author: markt > Date: Sat May  1 14:26:50 2010 > New Revision: 940038 > > URL: http://svn.apache.org/viewvc?rev=940038&view=rev > Log: > Minor clean-up having reviewed the diff between current code and the code > prior to the Lifecycle re-factoring > > @@ -780,11 +780,7 @@ public cl

DO NOT REPLY [Bug 49240] Error thrown during detection of ServletContainerInitializer's

2010-05-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49240 Pid changed: What|Removed |Added Attachment #25387|0 |1 is obsolete|

svn commit: r940038 - in /tomcat/trunk/java/org/apache/catalina/startup: Catalina.java LocalStrings.properties

2010-05-01 Thread markt
Author: markt Date: Sat May 1 14:26:50 2010 New Revision: 940038 URL: http://svn.apache.org/viewvc?rev=940038&view=rev Log: Minor clean-up having reviewed the diff between current code and the code prior to the Lifecycle re-factoring Modified: tomcat/trunk/java/org/apache/catalina/startup/C

svn commit: r940036 - /tomcat/trunk/java/org/apache/catalina/startup/Catalina.java

2010-05-01 Thread markt
Author: markt Date: Sat May 1 14:18:05 2010 New Revision: 940036 URL: http://svn.apache.org/viewvc?rev=940036&view=rev Log: Get the shutdown hook working again. Now LifecycleBase uses synchronized methods, Catalina can't extend it else the shutdown hook can't function. Modified: tomcat/trun

svn commit: r940034 - /tomcat/trunk/java/org/apache/catalina/Lifecycle.java

2010-05-01 Thread markt
Author: markt Date: Sat May 1 14:12:34 2010 New Revision: 940034 URL: http://svn.apache.org/viewvc?rev=940034&view=rev Log: Clarify Modified: tomcat/trunk/java/org/apache/catalina/Lifecycle.java Modified: tomcat/trunk/java/org/apache/catalina/Lifecycle.java URL: http://svn.apache.org/viewv

svn commit: r940031 - in /tomcat/trunk/java/org/apache/catalina: core/StandardService.java startup/Catalina.java startup/Embedded.java

2010-05-01 Thread markt
Author: markt Date: Sat May 1 14:08:47 2010 New Revision: 940031 URL: http://svn.apache.org/viewvc?rev=940031&view=rev Log: Clean up start code. Catalina no longer implements Service. The model is now: Bootstrap sorts out the class loaders, Catalina does the remaining plumbing and holds a refer

svn commit: r940012 - /tomcat/trunk/java/org/apache/catalina/Lifecycle.java

2010-05-01 Thread markt
Author: markt Date: Sat May 1 13:43:03 2010 New Revision: 940012 URL: http://svn.apache.org/viewvc?rev=940012&view=rev Log: Document must destroy state Modified: tomcat/trunk/java/org/apache/catalina/Lifecycle.java Modified: tomcat/trunk/java/org/apache/catalina/Lifecycle.java URL: http://

DO NOT REPLY [Bug 49218] Fix support for META-INF/resources

2010-05-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49218 --- Comment #5 from Konstantin Kolinko 2010-05-01 08:13:02 EDT --- (In reply to comment #4) TestStandardContextResources calling resourceF.jsp in r939650 checks for wrong value. It should look for "resourceF.jsp in resources.jar". Besides

DO NOT REPLY [Bug 49240] Error thrown during detection of ServletContainerInitializer's

2010-05-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49240 --- Comment #1 from Pid 2010-05-01 08:02:44 EDT --- Created an attachment (id=25387) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25387) Fixes thrown Error during ServletContainerInitializer's return if an exception is thrown

svn commit: r939985 - /tomcat/trunk/test/org/apache/catalina/startup/DuplicateMappingParamServlet.java

2010-05-01 Thread kkolinko
Author: kkolinko Date: Sat May 1 11:59:54 2010 New Revision: 939985 URL: http://svn.apache.org/viewvc?rev=939985&view=rev Log: Fix wrapped and thus broken $Id$. Use $Revision$ instead, because it is shorter. Modified: tomcat/trunk/test/org/apache/catalina/startup/DuplicateMappingParamServle

[RESULT] [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-05-01 Thread Mark Thomas
A little later than it should have been. The result of this vote was broken due to a number of licensing issues. RC2 will follow once these have been resolved. Mark On 14/04/2010 11:34, Mark Thomas wrote: > All, > > After the experience of the recent 6.0.x releases, I wanted to try an > alternat

DO NOT REPLY [Bug 49240] New: Error thrown during detection of ServletContainerInitializer's

2010-05-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49240 Summary: Error thrown during detection of ServletContainerInitializer's Product: Tomcat 7 Version: unspecified Platform: All OS/Version: All Status: NEW

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-05-01 Thread Mark Thomas
On 30/04/2010 23:37, Kevan Miller wrote: > > On Apr 14, 2010, at 5:41 PM, Mark Thomas wrote: > >> On 14/04/2010 21:31, Mark Thomas wrote: >>> On 14/04/2010 21:06, sebb wrote: 2 files in BCEL have IBM headers; these headers are presumably OK, but the NOTICE file probably needs to mention

svn commit: r939972 - in /tomcat/site/trunk: docs/whichversion.html xdocs/whichversion.xml

2010-05-01 Thread kkolinko
Author: kkolinko Date: Sat May 1 10:46:59 2010 New Revision: 939972 URL: http://svn.apache.org/viewvc?rev=939972&view=rev Log: TC 4.1 runs on JDK 1.3 and later, needs 1.4 to build a release /tomcat/archive/tc4.1.x/tags/TOMCAT_4_1_40/container/RUNNING.txt TC 3.2 README says to use JDK 1.1 or later

[g...@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2010-05-01 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test has an issue affecting its community integration. This i