Re: svn commit: r937325 - in /tomcat/trunk/java/org/apache: catalina/ha/session/DeltaManager.java el/lang/ExpressionBuilder.java

2010-04-28 Thread Peter Roßbach
Add to my ToDo list :-) Peter Am 29.04.2010 um 01:09 schrieb Mark Thomas: .. and also we can optimized the "for"-statement to for(Valve valve: valves) { if(valve instanceof ReplicationValve) { replicationValve = (ReplicationValve)valve ; break; } } Not without changing when the debug messag

Re: svn commit: r939143 - /tomcat/trunk/webapps/docs/changelog.xml

2010-04-28 Thread Peter Roßbach
+1 for that! Makes life easier... Peter Am 29.04.2010 um 02:36 schrieb ma...@apache.org: Author: markt Date: Thu Apr 29 00:36:35 2010 New Revision: 939143 URL: http://svn.apache.org/viewvc?rev=939143&view=rev Log: It isn't practical to list every single commit that implemented Servlet 3.0.

svn commit: r939212 - in /tomcat/trunk: java/org/apache/catalina/startup/ test/org/apache/catalina/startup/

2010-04-28 Thread pero
Author: pero Date: Thu Apr 29 06:37:20 2010 New Revision: 939212 URL: http://svn.apache.org/viewvc?rev=939212&view=rev Log: Fix my IDE and use spaces. - No functional change Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java tomcat/trunk/test/org/apache/catalina/s

Re: GSOC 2010

2010-04-28 Thread buddhika chamith
Hi Mark, Just wanted some suggestions on the approach I would take. Currently I am examining mbean details by the plan which is based on Tomcat pacakages. What I normally do is to look at the mbeans descriptor and check in the described mbeans whether all the required attributes and methods are pr

Re: Access logging for requests rejected by CoyoteAdaptor

2010-04-28 Thread Jason Brittain
Interesting. 1. sounds wrong to me because it would end up being an implementation just like the existing AccessLogValve, but not one that the Tomcat administrator configures? Or, maybe each connector would/could own its own AccessLogValve instance? And, an admin can configure it like this if th

Re: svn commit: r939114 - in /tomcat/trunk: java/org/apache/catalina/startup/ test/org/apache/catalina/startup/

2010-04-28 Thread Mark Thomas
On 28/04/2010 17:16, p...@apache.org wrote: Author: pero Date: Wed Apr 28 22:16:49 2010 New Revision: 939114 Peter. Please fix your IDE. It should be using spaces, not tabs. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomc

svn commit: r939143 - /tomcat/trunk/webapps/docs/changelog.xml

2010-04-28 Thread markt
Author: markt Date: Thu Apr 29 00:36:35 2010 New Revision: 939143 URL: http://svn.apache.org/viewvc?rev=939143&view=rev Log: It isn't practical to list every single commit that implemented Servlet 3.0. Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/chan

DO NOT REPLY [Bug 49205] context path has first character removed on deploy of war file causing failed deployment

2010-04-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49205 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 49197] ServletRequest/HttpSession is not visible in custom realm

2010-04-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49197 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

Access logging for requests rejected by CoyoteAdaptor

2010-04-28 Thread Mark Thomas
This was prompted by [1]. For a number of mal-formed requests, the CoyoteAdaptor will reject them before they reach the access log valve. There is currently no means of logging these rejected requests in Tomcat. There are obvious use cases for logging these requests in one form or another. As

DO NOT REPLY [Bug 49181] Exception thrown incorrectly when dynamically adding a Listener

2010-04-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49181 --- Comment #7 from Mark Thomas 2010-04-28 20:06:10 EDT --- As I catch up on e-mail, I think Konstantin has ID'd the correct interpretation here. To quote Konstantin: a) Before we start calling ServletContextListener.contextInitialized() a

Re: svn commit: r938363 - /tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java

2010-04-28 Thread Mark Thomas
On 27/04/2010 05:19, Konstantin Kolinko wrote: -if (t instanceof ServletContextListener) { -// TODO SERVLET3 - also need to check caller? spec isn't clear +if (t instanceof HttpSessionListener +|| t instanceof ServletContextListener) { +// T

Re: .classpath and .project in src distribution (was: svn commit: r937993)

2010-04-28 Thread Mark Thomas
On 27/04/2010 08:40, Peter Roßbach wrote: The current setup of the .project and .classpath files works good for many years. I think it was helpfull for user of the src distribution, also use the correct eclipse setup. I agree these are a useful starting point however, there are many legitimate

Re: Need advice to notify StandardExecutor when a webapp is stopped

2010-04-28 Thread Mark Thomas
On 27/04/2010 15:57, Sylvain Laurent wrote: Do you mean one declared in server.xml ? or have the StandardThreadExecutor register itself as a LifeCycleListener ? In the latter case, my problem is how do I get a reference to StandardContext instances from the StandardThreadExecutor ? I'm not s

Re: Tomcat 7, Valve -> Filter conversion, and container-managed authentication/authorization

2010-04-28 Thread David Jencks
On Apr 28, 2010, at 4:14 PM, Pid wrote: > On 28/04/2010 23:40, David Jencks wrote: >> I'd be curious how many of the features in securityfilter can be done with >> servlet 3 (which includes the ability for an app to programatically force a >> login) and jaspic (jsr 196) which provides for plugg

Re: GSOC 2010

2010-04-28 Thread Mark Thomas
On 26/04/2010 20:12, buddhika chamith wrote: Hi All, I am glad to announce that my proposal titled "Enhancing JMX Descriptors in Apache Tomcat" has been accepted for this year's GSOC program. Congratulations. We are now in the community bonding period so this is your opportunity to ask any q

DO NOT REPLY [Bug 49181] Exception thrown incorrectly when dynamically adding a Listener

2010-04-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49181 --- Comment #6 from Mark Thomas 2010-04-28 19:15:49 EDT --- The wording is ambiguous to me. My instinct is to lean towards the current implementation as the correct interpretation but I'll wait for Filip or Remy who are on the EG to comment

Re: Tomcat 7, Valve -> Filter conversion, and container-managed authentication/authorization

2010-04-28 Thread Pid
On 28/04/2010 23:40, David Jencks wrote: > I'd be curious how many of the features in securityfilter can be done with > servlet 3 (which includes the ability for an app to programatically force a > login) and jaspic (jsr 196) which provides for pluggable authentication > dialogs between client a

Re: svn commit: r937325 - in /tomcat/trunk/java/org/apache: catalina/ha/session/DeltaManager.java el/lang/ExpressionBuilder.java

2010-04-28 Thread Mark Thomas
On 26/04/2010 06:00, Peter Roßbach wrote: HI Mark, your are right! But then we can use: CatalinaCluster cluster = getCluster() ; if(cluster != null) { Valve[] valves = cluster.getValves(); Done. .. and also we can optimized the "for"-statement to for(Valve valve: valves) { if(valve instanc

svn commit: r939130 - /tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java

2010-04-28 Thread markt
Author: markt Date: Wed Apr 28 23:07:43 2010 New Revision: 939130 URL: http://svn.apache.org/viewvc?rev=939130&view=rev Log: Follow up on pero's review comments. Modified: tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java Modified: tomcat/trunk/java/org/apache/catalina/ha/se

Re: Tomcat 7, Valve -> Filter conversion, and container-managed authentication/authorization

2010-04-28 Thread David Jencks
I'd be curious how many of the features in securityfilter can be done with servlet 3 (which includes the ability for an app to programatically force a login) and jaspic (jsr 196) which provides for pluggable authentication dialogs between client and server (to overly simplify it). It looks to m

svn commit: r939115 - /tomcat/trunk/webapps/docs/changelog.xml

2010-04-28 Thread pero
Author: pero Date: Wed Apr 28 22:18:24 2010 New Revision: 939115 URL: http://svn.apache.org/viewvc?rev=939115&view=rev Log: web.xml and fragments overwrite annotation parameters (s. Servlet API Sepc Nov 2009 Section 8.2.3.3 pages 80-84) not yet complete -- filter support is missing! Modified:

svn commit: r939114 - in /tomcat/trunk: java/org/apache/catalina/startup/ test/org/apache/catalina/startup/

2010-04-28 Thread pero
Author: pero Date: Wed Apr 28 22:16:49 2010 New Revision: 939114 URL: http://svn.apache.org/viewvc?rev=939114&view=rev Log: web.xml and fragments overwrite annotation parameters (s. Servlet API Sepc Nov 2009 Section 8.2.3.3 pages 80-84) not yet complete -- filter support is missing! Added:

Tomcat 7 ; Servlet API question - Spec 8.2.3 overwrite WebServlet annotation parameter

2010-04-28 Thread Peter Roßbach
Hi, I have read the servlet 3.0 spec and play around with some simple examples. I setup a very simple annotated servlet: == package annotation; import java.io.IOException; import java.io.PrintWriter; import javax.servlet.ServletException; import javax.servlet.annotation.WebInitParam; impor

svn propchange: r939050 - svn:log

2010-04-28 Thread kkolinko
Author: kkolinko Revision: 939050 Modified property: svn:log Modified: svn:log at Wed Apr 28 18:54:23 2010 -- --- svn:log (original) +++ svn:log Wed Apr 28 18:54:23 2010 @@ -1 +1 @@ -Implement support for running the tests

svn commit: r939050 - in /tomcat/trunk: build.xml test/org/apache/catalina/startup/TestTomcat.java test/org/apache/catalina/startup/TestTomcatSSL.java test/org/apache/catalina/startup/TomcatBaseTest.j

2010-04-28 Thread kkolinko
Author: kkolinko Date: Wed Apr 28 18:49:11 2010 New Revision: 939050 URL: http://svn.apache.org/viewvc?rev=939050&view=rev Log: Implement support for running the tests when the build output directory non-default value. Modified: tomcat/trunk/build.xml tomcat/trunk/test/org/apache/catalin

Tomcat 7, Valve -> Filter conversion, and container-managed authentication/authorization

2010-04-28 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 All, Hello, I'm Chris Schultz, the maintainer of the securityfilter project (http://securityfilter.sourceforge.net/) and active member of the tomcat-user mailing list. I've been loosely following the plans for Tomcat 7 and was interested to see that

DO NOT REPLY [Bug 49213] New: Manager application doesn't work in security mode

2010-04-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49213 Summary: Manager application doesn't work in security mode Product: Tomcat 6 Version: 6.0.26 Platform: All OS/Version: All Status: NEW Severity: normal Priori

DO NOT REPLY [Bug 49207] Filter name not set when dynamically added

2010-04-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49207 Konstantin Kolinko changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r939001 - /tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterRegistration.java

2010-04-28 Thread kkolinko
Author: kkolinko Date: Wed Apr 28 16:21:32 2010 New Revision: 939001 URL: http://svn.apache.org/viewvc?rev=939001&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49207 FilterMap#filterName was null when it was configured dynamically with addMappingForUrlPatterns() Patch provi

DO NOT REPLY [Bug 48358] JSP-unloading reloaded

2010-04-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48358 --- Comment #10 from Isabel Drost 2010-04-28 10:55:51 EDT --- Another Thanks goes to Christian Lorenz for helping me understand the Tomcat sources and integrate the changes. -- Configure bugmail: https://issues.apache.org/bugzilla/userpr

DO NOT REPLY [Bug 49212] New: Example application lacks a permission in -security mode

2010-04-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49212 Summary: Example application lacks a permission in -security mode Product: Tomcat 6 Version: 6.0.26 Platform: All OS/Version: All Status: NEW Severi

DO NOT REPLY [Bug 49159] Improve ThreadLocal memory leak clean-up

2010-04-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49159 --- Comment #2 from Mark Thomas 2010-04-28 08:23:05 EDT --- It shouldn't clean all thread locals after each request, it should clean all thread locals loaded by a web application. If the cleaning breaks apps or frameworks then those apps/f

DO NOT REPLY [Bug 49209] AccessControlException when undeploying application

2010-04-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49209 Konstantin Kolinko changed: What|Removed |Added Status|NEW |NEEDINFO OS/Version|

DO NOT REPLY [Bug 49209] New: AccessControlException when undeploying application

2010-04-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49209 Summary: AccessControlException when undeploying application Product: Tomcat 6 Version: 6.0.26 Platform: PC Status: NEW Severity: normal Priority: P2 Compone

Re: svn commit: r937975 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

2010-04-28 Thread Pid
On 28/04/2010 10:03, Konstantin Kolinko wrote: > 2010/4/28 Pid : >> On 28/04/2010 03:29, Ivan wrote: >>> I still get the java.lang.ArrayIndexOutOfBoundsException, i think that it >>> should be >> >> What causes the ArrayIndexOutOfBoundsException? I was testing >> dynamically adding a Filter after

DO NOT REPLY [Bug 49207] Filter name not set when dynamically added

2010-04-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49207 --- Comment #1 from Pid 2010-04-28 05:41:40 EDT --- Created an attachment (id=25365) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25365) Set filter name -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?

DO NOT REPLY [Bug 49207] New: Filter name not set when dynamically added

2010-04-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49207 Summary: Filter name not set when dynamically added Product: Tomcat 7 Version: trunk Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2

svn commit: r938829 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

2010-04-28 Thread kkolinko
Author: kkolinko Date: Wed Apr 28 09:08:52 2010 New Revision: 938829 URL: http://svn.apache.org/viewvc?rev=938829&view=rev Log: Mark StandardContext#aliases as private, because there is a getter method. Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Modified: tomca

Re: svn commit: r937975 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

2010-04-28 Thread Konstantin Kolinko
2010/4/28 Pid : > On 28/04/2010 03:29, Ivan wrote: >> I still get the java.lang.ArrayIndexOutOfBoundsException, i think that it >> should be > > What causes the ArrayIndexOutOfBoundsException?  I was testing > dynamically adding a Filter after that change, (inside a > ServletContextListener.context

[Tomcat Wiki] Update of "PoweredBy" by MarioKleinsasser

2010-04-28 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "PoweredBy" page has been changed by MarioKleinsasser. http://wiki.apache.org/tomcat/PoweredBy?action=diff&rev1=255&rev2=256 -- {{

Re: svn commit: r937975 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

2010-04-28 Thread Pid
On 28/04/2010 03:29, Ivan wrote: > I still get the java.lang.ArrayIndexOutOfBoundsException, i think that it > should be What causes the ArrayIndexOutOfBoundsException? I was testing dynamically adding a Filter after that change, (inside a ServletContextListener.contextInitialized() method), and

svn commit: r938814 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

2010-04-28 Thread kkolinko
Author: kkolinko Date: Wed Apr 28 08:21:32 2010 New Revision: 938814 URL: http://svn.apache.org/viewvc?rev=938814&view=rev Log: Use a helper class to manage the filter mappings. Fix ArrayIndexOutOfBoundsException in addFilterMapBefore as reported in re: r937975 thread. Modified: tomcat/trunk