Re: Coding Guidelines, encodings, keywords

2009-05-22 Thread Leon Rosenberg
On Fri, May 22, 2009 at 4:12 PM, Filip Hanik - Dev Lists wrote: > Leon Rosenberg wrote: >> >> 2009/5/22 Filip Hanik - Dev Lists : >> >>> >>> Konstantin Kolinko wrote: >>> Hi, all! Are there any Coding Guidelines that we ought to follow, or is our project on our own there?

svn commit: r777631 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-05-22 Thread markt
Author: markt Date: Fri May 22 17:33:57 2009 New Revision: 777631 URL: http://svn.apache.org/viewvc?rev=777631&view=rev Log: Votes Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=777631

svn commit: r777625 - /tomcat/trunk/dist.xml

2009-05-22 Thread markt
Author: markt Date: Fri May 22 17:27:37 2009 New Revision: 777625 URL: http://svn.apache.org/viewvc?rev=777625&view=rev Log: Fix copyright. Patch by kkolinko. Modified: tomcat/trunk/dist.xml Modified: tomcat/trunk/dist.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/dist.xml?rev=777625&r

DO NOT REPLY [Bug 47086] Tomcat6 64-bit service wrapper should be included in a Tomcat distribution

2009-05-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47086 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r777624 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt dist.xml res/jvm.ini res/tomcat.nsi webapps/docs/changelog.xml

2009-05-22 Thread markt
Author: markt Date: Fri May 22 17:21:43 2009 New Revision: 777624 URL: http://svn.apache.org/viewvc?rev=777624&view=rev Log: Include 64-bit service binaries in distro. Add 64-bit support to the installer. Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat/tc6.0.x/trunk/STATUS.txt

DO NOT REPLY [Bug 47243] Tomcat 6 is not running as a service on vista.

2009-05-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47243 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 47046] Shutdown does not unregister all MBeans

2009-05-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47046 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r777611 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/connector/MapperListener.java java/org/apache/catalina/mbeans/MBeanUtils.java java/org/apache/catalina/mbeans/Ser

2009-05-22 Thread markt
Author: markt Date: Fri May 22 16:41:15 2009 New Revision: 777611 URL: http://svn.apache.org/viewvc?rev=777611&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47046 Deregister all MBeans when the server is stopped Modified: tomcat/tc6.0.x/trunk/ (props changed) tom

DO NOT REPLY [Bug 47243] New: Tomcat 6 is not running as a service on vista.

2009-05-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47243 Summary: Tomcat 6 is not running as a service on vista. Product: Tomcat 6 Version: 6.0.18 Platform: PC OS/Version: Windows Vista Status: NEW Severity: normal

Re: svn commit: r776390 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-05-22 Thread Mark Thomas
kkoli...@apache.org wrote: > Author: kkolinko > Date: Tue May 19 17:35:21 2009 > New Revision: 776390 > > URL: http://svn.apache.org/viewvc?rev=776390&view=rev > Log: > vote > > Modified: > tomcat/tc6.0.x/trunk/STATUS.txt > > Modified: tomcat/tc6.0.x/trunk/STATUS.txt > URL: > http://svn.apa

Re: svn commit: r776137 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-05-22 Thread Mark Thomas
kkoli...@apache.org wrote: > @@ -161,6 +161,7 @@ >http://people.apache.org/~markt/patches/2009-04-20-native2ascii-es.patch > (Spanish) >http://people.apache.org/~markt/patches/2009-04-20-native2ascii-fr.patch > (French) >+1: markt > + +0: kkolinko: should not be needed, as old and ne

DO NOT REPLY [Bug 42390] JSP compilation error with nested tagfile tags with variables with "AT_BEGIN" scope

2009-05-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=42390 --- Comment #5 from Mark Thomas 2009-05-22 08:46:30 PST --- Patch has been reverted for more testing. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: -

svn commit: r777586 - in /tomcat: current/tc5.5.x/STATUS.txt tc6.0.x/trunk/STATUS.txt trunk/java/org/apache/jasper/compiler/ScriptingVariabler.java

2009-05-22 Thread markt
Author: markt Date: Fri May 22 15:46:17 2009 New Revision: 777586 URL: http://svn.apache.org/viewvc?rev=777586&view=rev Log: Revert patch for 42390. More tetsing required. Modified: tomcat/current/tc5.5.x/STATUS.txt tomcat/tc6.0.x/trunk/STATUS.txt tomcat/trunk/java/org/apache/jasper/c

Re: svn commit: r776128 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-05-22 Thread Mark Thomas
kkoli...@apache.org wrote: > Author: kkolinko > Date: Mon May 18 23:08:57 2009 > New Revision: 776128 > > URL: http://svn.apache.org/viewvc?rev=776128&view=rev > Log: > veto and proposal > > Modified: > tomcat/tc6.0.x/trunk/STATUS.txt > > Modified: tomcat/tc6.0.x/trunk/STATUS.txt > URL: > h

svn commit: r777585 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-05-22 Thread markt
Author: markt Date: Fri May 22 15:41:25 2009 New Revision: 777585 URL: http://svn.apache.org/viewvc?rev=777585&view=rev Log: Add the JavaDoc fix and assume pero won't object to a doc change. Feel free to change your vote if you don't like the javadoc bit. Modified: tomcat/tc6.0.x/trunk/STATU

svn commit: r777576 - /tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java

2009-05-22 Thread markt
Author: markt Date: Fri May 22 15:30:30 2009 New Revision: 777576 URL: http://svn.apache.org/viewvc?rev=777576&view=rev Log: Fix JavaDoc aspects of bug 46985. Based on kkolinko's proposed patch. Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java Modified: tomcat/trunk/

DO NOT REPLY [Bug 46967] ManagerBase.setRandomFile error handling fix

2009-05-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46967 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r777567 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/session/ManagerBase.java webapps/docs/changelog.xml

2009-05-22 Thread markt
Author: markt Date: Fri May 22 15:14:45 2009 New Revision: 777567 URL: http://svn.apache.org/viewvc?rev=777567&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46967 Better handling of errors when trying to use Manager.randomFile Based on a patch by Kirk Wolf Also make behaviou

[Tomcat Wiki] Update of "FAQ/Connectors" by markt

2009-05-22 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The following page has been changed by markt: http://wiki.apache.org/tomcat/FAQ/Connectors The comment on the change is: Don't recommend mod_jk2 ---

[Tomcat Wiki] Update of "FAQ/Connectors" by ChristopherSchultz

2009-05-22 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The following page has been changed by ChristopherSchultz: http://wiki.apache.org/tomcat/FAQ/Connectors The comment on the change is: Added notes about Tomcat static file performance, j

DO NOT REPLY [Bug 46908] tomcat-users.xml has invalid encoding "cp1252" when using endorsed library xercesImpl.jar

2009-05-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46908 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r777556 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/catalina/realm/ java/org/apache/catalina/users/ webapps/docs/

2009-05-22 Thread markt
Author: markt Date: Fri May 22 14:59:34 2009 New Revision: 777556 URL: http://svn.apache.org/viewvc?rev=777556&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46908 Try and support java encoding names when using an xml parser provided via the endorsed mechanism Modified:

svn commit: r777554 - in /tomcat/tc6.0.x/trunk: ./ conf/ java/org/apache/catalina/security/ java/org/apache/catalina/util/ java/org/apache/jasper/el/ java/org/apache/jasper/runtime/ webapps/docs/

2009-05-22 Thread markt
Author: markt Date: Fri May 22 14:54:32 2009 New Revision: 777554 URL: http://svn.apache.org/viewvc?rev=777554&view=rev Log: Port security manager fixes from trunk. JSP TCK now passes when running under a SecurityManager. Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat/tc6.0.x/t

Re: Mutable public fields in Tomcat 6 code

2009-05-22 Thread sebb
On 21/05/2009, Filip Hanik - Dev Lists wrote: > sebb wrote: > > > There are quite a lot of public mutable static fields in the current > > Tomcat6 codebase. > > > > Such fields can allow malicious or accidental changes to occur, so > > should be avoided as far as possible. > > [And if a class has

Re: [VOTE] Release build 6.0.20

2009-05-22 Thread Rainer Jung
On 22.05.2009 15:45, Mark Thomas wrote: > 2. i18n resources are still corrupted. There is a patch already in the > STATUS file to fix this. Was an issue in 6.0.18 so this is a bug that > has not been fixed rather than a regression. But only for the tarball source distribution, right? I checked som

DO NOT REPLY [Bug 47242] request for AJP command line client

2009-05-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47242 --- Comment #1 from Sebb 2009-05-22 07:31:20 PST --- Apache JMeter has an AJP/1.3 Sampler which uses the Tomcat mod_jk protocol, see: http://jakarta.apache.org/jmeter/usermanual/component_reference.html#HTTP_Request That might perhap

DO NOT REPLY [Bug 47242] New: request for AJP command line client

2009-05-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47242 Summary: request for AJP command line client Product: Tomcat 6 Version: unspecified Platform: All OS/Version: Linux Status: NEW Severity: enhancement Priority

Re: Coding Guidelines, encodings, keywords

2009-05-22 Thread Filip Hanik - Dev Lists
Leon Rosenberg wrote: 2009/5/22 Filip Hanik - Dev Lists : Konstantin Kolinko wrote: Hi, all! Are there any Coding Guidelines that we ought to follow, or is our project on our own there? spaces instead of tabs :) Wow, "Are there really people out there who still use spac

Re: [VOTE] Release build 6.0.20

2009-05-22 Thread Mark Thomas
Remy Maucherat wrote: > The candidates binaries are available here: > http://people.apache.org/~remm/tomcat-6/v6.0.20/ > > According to the release process, the 6.0.20 tag is: > [ ] Broken > [ ] Alpha > [ ] Beta > [X] Stable > > Rémy Observations -src.tar.gz - hashes match, key in WOT (more sigs

Re: [VOTE] Release build 6.0.20

2009-05-22 Thread Jim Jagielski
Just clarification: The tgz is broken. Assuming that is fixed, I see no problems and the actual *codebase* is [X] Stable On May 20, 2009, at 12:36 PM, Jim Jagielski wrote: [X] Broken On May 20, 2009, at 11:50 AM, sebb wrote: extras/catalina-ws.jar does not have a NOTICE or a LICENSE file.

Re: svn commit: r775792 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-05-22 Thread Mark Thomas
kkoli...@apache.org wrote: > Modified: tomcat/tc6.0.x/trunk/STATUS.txt > URL: > http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=775792&r1=775791&r2=775792&view=diff > == > --- tomcat/tc6.0.x/trunk/STATUS.t

svn commit: r777470 - /tomcat/trunk/java/org/apache/jasper/el/ELResolverImpl.java

2009-05-22 Thread markt
Author: markt Date: Fri May 22 11:15:43 2009 New Revision: 777470 URL: http://svn.apache.org/viewvc?rev=777470&view=rev Log: Removed some casts. Patch suggested by kkolinko Modified: tomcat/trunk/java/org/apache/jasper/el/ELResolverImpl.java Modified: tomcat/trunk/java/org/apache/jasper/el/E

svn commit: r777467 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-05-22 Thread markt
Author: markt Date: Fri May 22 10:52:28 2009 New Revision: 777467 URL: http://svn.apache.org/viewvc?rev=777467&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=777

svn commit: r777466 - /tomcat/trunk/dist.xml

2009-05-22 Thread markt
Author: markt Date: Fri May 22 10:50:56 2009 New Revision: 777466 URL: http://svn.apache.org/viewvc?rev=777466&view=rev Log: Stop build process adding extra blank line to end of files in .tar.gz src distro - missed a few in previous commit Modified: tomcat/trunk/dist.xml Modified: tomcat/tr

svn commit: r777464 - /tomcat/trunk/dist.xml

2009-05-22 Thread markt
Author: markt Date: Fri May 22 10:47:36 2009 New Revision: 777464 URL: http://svn.apache.org/viewvc?rev=777464&view=rev Log: Stop build process adding extra blank line to end of files in .tar.gz src distro Modified: tomcat/trunk/dist.xml Modified: tomcat/trunk/dist.xml URL: http://svn.apach

Re: [VOTE] Release build 6.0.20

2009-05-22 Thread Tim Funk
Remy Maucherat wrote: The candidates binaries are available here: http://people.apache.org/~remm/tomcat-6/v6.0.20/ According to the release process, the 6.0.20 tag is: [ ] Broken [ ] Alpha [ ] Beta [X] Stable - To unsubscribe

Re: Coding Guidelines, encodings, keywords

2009-05-22 Thread Mark Thomas
Leon Rosenberg wrote: > 2009/5/22 Filip Hanik - Dev Lists : >> Konstantin Kolinko wrote: >>> Hi, all! >>> >>> Are there any Coding Guidelines that we ought to follow, >>> or is our project on our own there? >>> >> spaces instead of tabs :) > > Wow, > "Are there really people out there who still us

Re: svn commit: r777247 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/SimpleCoordinator.java

2009-05-22 Thread Rainer Jung
On 22.05.2009 03:59, William A. Rowe, Jr. wrote: > Filip Hanik - Dev Lists wrote: >> sebb wrote: >>> There's also a suggested set on the Apache site, see: >>> >>> http://www.apache.org/dev/version-control.html#https-svn-config >>> >> that's exactly my point, everytime I just onto a new machine,

Re: Coding Guidelines, encodings, keywords

2009-05-22 Thread Leon Rosenberg
2009/5/22 Filip Hanik - Dev Lists : > Konstantin Kolinko wrote: >> >> Hi, all! >> >> Are there any Coding Guidelines that we ought to follow, >> or is our project on our own there? >> > > spaces instead of tabs :) Wow, "Are there really people out there who still use spaces? " seems so. Without of

Re: Coding Guidelines, encodings, keywords

2009-05-22 Thread Mark Thomas
Konstantin Kolinko wrote: > Hi, all! > > Are there any Coding Guidelines that we ought to follow, > or is our project on our own there? > > I am interested in clarifying the following question: > What is the character encoding for our sources. I always worked on the basis it is ISO-8859-1. > Ou

DO NOT REPLY [Bug 47240] catalina.bat typo when setting java.security.policy

2009-05-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47240 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|