DO NOT REPLY [Bug 46384] Due to missing synchronization, a member may disappear permanent.

2009-04-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46384 --- Comment #3 from Filip Hanik 2009-04-16 20:58:18 PST --- (In reply to comment #1) > Created an attachment (id=23501) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23501) [details] > Patch to fix this issue > > The atta

RE: compile tomcat on windows environment ?

2009-04-16 Thread Anas Ahmed
Now it is OK i have compiled it successfully. what is the next ? -try to solve bugs or to get familiar with some APIs that Tomcat uses? how to know that some bugs is simple? what is the most important API that make me familiar with tomcat? thanks > > Mark Thomas wrote: > > Anas Ahmed wrot

Re: Difference b/w org.apache.tomcat.util.modeler.BaseModelMBean and org.apache.catalina.mbeans.ConnectorMBean

2009-04-16 Thread Ashish Jain
Is there no one in the community who has answer to this Question??? On Thu, Apr 16, 2009 at 5:24 PM, Ashish Jain wrote: > Hi dev's, > I am a newbie and recently started looking on to tomcat code. I am trying > to change the maxThreads attribute through Jconsole which seems to be > exposed by

Re: svn commit: r765764 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-04-16 Thread Remy Maucherat
On Thu, 2009-04-16 at 23:09 +0100, Mark Thomas wrote: > Having now read Roy's comment on 39727 I'm leaning towards reverting > this patch and seeing what is possible following the Transfer-Encoding > route. I'll sleep on it in case a better idea occurs to me and come back > to this tomorrow. If yo

DO NOT REPLY [Bug 46384] Due to missing synchronization, a member may disappear permanent.

2009-04-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46384 --- Comment #2 from Sebb 2009-04-16 15:55:45 PST --- Might be an idea to make the field "memebrshipMutex" (sic) final, as otherwise the synchronisation is not guaranteed to work. -- Configure bugmail: https://issues.apache.org/bugzil

Re: svn commit: r765764 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-04-16 Thread Mark Thomas
r...@apache.org wrote: > + 0: remm (zzz) :) > * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47013 > @@ -258,12 +260,13 @@ >http://svn.apache.org/viewvc?rev=764985&view=rev >http://svn.apache.org/viewvc?rev=764997&view=rev >+1: markt > + -0: remm: Why should this be backp

DO NOT REPLY [Bug 46252] Tomcat access log doesn't support Unicode

2009-04-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46252 Mark Thomas changed: What|Removed |Added Severity|normal |enhancement --- Comment #1 from

DO NOT REPLY [Bug 46538] ETag must differ between compressed and uncompressed resource versions

2009-04-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46538 --- Comment #7 from Remy Maucherat 2009-04-16 14:35:15 PST --- Well, that does not sound very smart (and I had read that on the httpd bug, sigh ...). But overall, I do think the patch is bad (see status file). -- Configure bugmail:

svn commit: r765766 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-04-16 Thread remm
Author: remm Date: Thu Apr 16 21:27:16 2009 New Revision: 765766 URL: http://svn.apache.org/viewvc?rev=765766&view=rev Log: - Votes part 2. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?r

svn commit: r765764 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-04-16 Thread remm
Author: remm Date: Thu Apr 16 21:24:19 2009 New Revision: 765764 URL: http://svn.apache.org/viewvc?rev=765764&view=rev Log: - Votes. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=7657

DO NOT REPLY [Bug 46538] ETag must differ between compressed and uncompressed resource versions

2009-04-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46538 --- Comment #6 from Mark Thomas 2009-04-16 14:16:56 PST --- The I suggest you read section 14.19 of RFC 2616 that makes it quite clear ETags are per variant not per resource. -- Configure bugmail: https://issues.apache.org/bugzilla/u

DO NOT REPLY [Bug 46538] ETag must differ between compressed and uncompressed resource versions

2009-04-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46538 --- Comment #5 from Remy Maucherat 2009-04-16 13:57:58 PST --- I disagree with this. Regardless on what happens with the transport, the entity does not change once it is decoded. -1 for this "fix". -- Configure bugmail: https://issu

svn commit: r765758 - /tomcat/current/tc5.5.x/STATUS.txt

2009-04-16 Thread markt
Author: markt Date: Thu Apr 16 20:51:08 2009 New Revision: 765758 URL: http://svn.apache.org/viewvc?rev=765758&view=rev Log: Propose fix for 46384 Modified: tomcat/current/tc5.5.x/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x

DO NOT REPLY [Bug 46384] Due to missing synchronization, a member may disappear permanent.

2009-04-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46384 --- Comment #1 from Mark Thomas 2009-04-16 13:49:55 PST --- Created an attachment (id=23501) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23501) Patch to fix this issue The attached patch should fix this although I haven

DO NOT REPLY [Bug 47032] /status/all fails if using PersistentManager

2009-04-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47032 --- Comment #1 from Mark Thomas 2009-04-16 13:09:00 PST --- I have proposed the same fix for 5.5.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: ---

svn commit: r765740 - /tomcat/current/tc5.5.x/STATUS.txt

2009-04-16 Thread markt
Author: markt Date: Thu Apr 16 20:08:48 2009 New Revision: 765740 URL: http://svn.apache.org/viewvc?rev=765740&view=rev Log: Propose fix for 47032 Modified: tomcat/current/tc5.5.x/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x

DO NOT REPLY [Bug 46950] SSL renegotiation does not occur when resource with CLIENT-CERT auth is requested

2009-04-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46950 --- Comment #7 from Mark Thomas 2009-04-16 12:37:33 PST --- This is going to require a change to the APR/native connector. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving thi

DO NOT REPLY [Bug 46538] ETag must differ between compressed and uncompressed resource versions

2009-04-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46538 --- Comment #4 from Mark Thomas 2009-04-16 12:34:10 PST --- Thanks for the patch. I have applied a modified version of it to trunk that also extended it to the NIO and APR connectors. The extended patch has been proposed for 6.0.x -

svn commit: r765728 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-04-16 Thread markt
Author: markt Date: Thu Apr 16 19:33:24 2009 New Revision: 765728 URL: http://svn.apache.org/viewvc?rev=765728&view=rev Log: propose fix for 46538 Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATU

svn commit: r765727 - in /tomcat/trunk/java/org/apache/coyote/http11: Constants.java Http11AprProcessor.java Http11NioProcessor.java Http11Processor.java

2009-04-16 Thread markt
Author: markt Date: Thu Apr 16 19:31:57 2009 New Revision: 765727 URL: http://svn.apache.org/viewvc?rev=765727&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46538 ETag must vary between compressed and uncompressed versions. Based on a patch by Oliver Schoett Modified: t

svn commit: r765695 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11NioProcessor.java Http11NioProtocol.java

2009-04-16 Thread markt
Author: markt Date: Thu Apr 16 17:28:48 2009 New Revision: 765695 URL: http://svn.apache.org/viewvc?rev=765695&view=rev Log: Drop unused fields Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java M

svn commit: r765667 - /tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml

2009-04-16 Thread rjung
Author: rjung Date: Thu Apr 16 15:34:20 2009 New Revision: 765667 URL: http://svn.apache.org/viewvc?rev=765667&view=rev Log: Add all disclosed CVEs for mod_jk to changelog. Modified: tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml Modified: tomcat/connectors/trunk/jk/xdocs/misce

DO NOT REPLY [Bug 37929] invalidated session causes pageContext methods to fail

2009-04-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=37929 --- Comment #8 from Mark Thomas 2009-04-16 08:22:44 PST --- Thanks for the report and the research. This has been fixed in trunk and proposed for 6.0.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email

svn commit: r765664 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-04-16 Thread markt
Author: markt Date: Thu Apr 16 15:22:41 2009 New Revision: 765664 URL: http://svn.apache.org/viewvc?rev=765664&view=rev Log: Propose fix for 37929 Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATU

DO NOT REPLY [Bug 46907] Jasper with log4j in web-app classpath and debug level enabled prevents reading HTTP POST stream from JSP

2009-04-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46907 --- Comment #9 from Mark Thomas 2009-04-16 08:21:16 PST --- It will depend what the patch looks like. Create a patch and one of us will take a look. If the patch is OK, we'll propose it for 5.5.x. -- Configure bugmail: https://issues

DO NOT REPLY [Bug 46907] Jasper with log4j in web-app classpath and debug level enabled prevents reading HTTP POST stream from JSP

2009-04-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46907 --- Comment #8 from Kirk True 2009-04-16 08:18:00 PST --- I was able to reproduce this with 5.5.26 (the OP's stated version) and 5.5.27 (the current latest 5.5.x version). However, versions 6.0.0-alpha through to 6.0.18 (the current l

svn commit: r765662 - /tomcat/trunk/java/org/apache/jasper/runtime/PageContextImpl.java

2009-04-16 Thread markt
Author: markt Date: Thu Apr 16 15:16:43 2009 New Revision: 765662 URL: http://svn.apache.org/viewvc?rev=765662&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=37929 by restoring r357410 that was lost in r379417 Modified: tomcat/trunk/java/org/apache/jasper/runtime/PageCo

svn commit: r765658 - in /tomcat/trunk/java: javax/servlet/jsp/el/ELException.java org/apache/jasper/runtime/PageContextImpl.java

2009-04-16 Thread markt
Author: markt Date: Thu Apr 16 14:57:40 2009 New Revision: 765658 URL: http://svn.apache.org/viewvc?rev=765658&view=rev Log: Clean up some deprecated code Modified: tomcat/trunk/java/javax/servlet/jsp/el/ELException.java tomcat/trunk/java/org/apache/jasper/runtime/PageContextImpl.java Mo

svn commit: r765655 - /tomcat/trunk/java/javax/servlet/jsp/el/ELException.java

2009-04-16 Thread markt
Author: markt Date: Thu Apr 16 14:52:07 2009 New Revision: 765655 URL: http://svn.apache.org/viewvc?rev=765655&view=rev Log: Fix formatting before I make some other changes Modified: tomcat/trunk/java/javax/servlet/jsp/el/ELException.java Modified: tomcat/trunk/java/javax/servlet/jsp/el/ELEx

Re: Any way to fix bug 46950 without a change to tcnative?

2009-04-16 Thread Remy Maucherat
On Thu, 2009-04-16 at 11:38 +0100, Mark Thomas wrote: > Thanks for the confirmation. The request is already read and buffered. > We 'just' need to renegotiation to require an SSL cert. > > I'll try and take a look at this but I'll probably need some help with > the C code. First step will be to ge

Difference b/w org.apache.tomcat.util.modeler.BaseModelMBean and org.apache.catalina.mbeans.ConnectorMBean

2009-04-16 Thread Ashish Jain
Hi dev's, I am a newbie and recently started looking on to tomcat code. I am trying to change the maxThreads attribute through Jconsole which seems to be exposed by BaseModelMBean as well as ConnectorMBean. Changing the value in one reflects the changes in other as well and vice versa. My question

Re: Any way to fix bug 46950 without a change to tcnative?

2009-04-16 Thread Mark Thomas
William A. Rowe, Jr. wrote: > William A. Rowe, Jr. wrote: >> Mark Thomas wrote: >>> Folks, >>> >>> I have been looking at bug 46950 [1]. Everything is fine with the BIO >>> connector but with APR the renegotiation fails to trigger a request for >>> the user's certificate. I assume that this is beca

svn commit: r765561 - /tomcat/current/tc5.5.x/STATUS.txt

2009-04-16 Thread markt
Author: markt Date: Thu Apr 16 10:33:00 2009 New Revision: 765561 URL: http://svn.apache.org/viewvc?rev=765561&view=rev Log: Split patches as requested by jfclere jfclere: I took the liberty of changing your -1 to +1 for the port less httpOnly as per your comment. Obviously, feel free to revert t

DO NOT REPLY [Bug 46597] Not all cookie changes in 6.0.x branch have been ported to 5.5.x

2009-04-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46597 Mark Thomas changed: What|Removed |Added Attachment #23421|0 |1 is obsolete|

DO NOT REPLY [Bug 44382] Need to add support for HTTPOnly session cookie parameter

2009-04-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44382 Mark Thomas changed: What|Removed |Added Attachment #21736|0 |1 is obsolete|

svn commit: r765558 - /tomcat/trunk/java/org/apache/catalina/startup/Embedded.java

2009-04-16 Thread markt
Author: markt Date: Thu Apr 16 10:08:39 2009 New Revision: 765558 URL: http://svn.apache.org/viewvc?rev=765558&view=rev Log: Remove unnecessary tests Modified: tomcat/trunk/java/org/apache/catalina/startup/Embedded.java Modified: tomcat/trunk/java/org/apache/catalina/startup/Embedded.java UR

svn commit: r765555 - /tomcat/trunk/java/org/apache/catalina/startup/ClassLoaderFactory.java

2009-04-16 Thread markt
Author: markt Date: Thu Apr 16 10:07:07 2009 New Revision: 76 URL: http://svn.apache.org/viewvc?rev=76&view=rev Log: Remove unused method that introduced an additional parameter that was then ignored. Modified: tomcat/trunk/java/org/apache/catalina/startup/ClassLoaderFactory.java Mo

DO NOT REPLY [Bug 45255] support disable jsessionid from url against session fixation attacks

2009-04-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45255 Richard Neish changed: What|Removed |Added CC||richa...@richardneish.org --

DO NOT REPLY [Bug 46597] Not all cookie changes in 6.0.x branch have been ported to 5.5.x

2009-04-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46597 --- Comment #5 from jfclere 2009-04-16 02:40:48 PST --- I think the HttpOnly in the patch is a new feature it should go in another error report. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ---

svn commit: r765533 - /tomcat/current/tc5.5.x/STATUS.txt

2009-04-16 Thread jfclere
Author: jfclere Date: Thu Apr 16 09:17:58 2009 New Revision: 765533 URL: http://svn.apache.org/viewvc?rev=765533&view=rev Log: Remove mine and vote Mark one. Well I don't want the HttpOnly in the same patch because that is a new feature. Modified: tomcat/current/tc5.5.x/STATUS.txt Modified:

Re: Need Support

2009-04-16 Thread Mark Thomas
Hemant Garg - Futech wrote: > Then how it is possible can you please tell me? This thread belongs on the users list, not on the dev list. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands

RE: Need Support

2009-04-16 Thread Hemant Garg - Futech
Then how it is possible can you please tell me? -Original Message- From: sura [mailto:suranjit...@yahoo.com] Sent: Thursday, April 16, 2009 10:41 AM To: Tomcat Developers List Subject: Re: Need Support Directly You can't http://www.theserverside.net/news/thread.tss?thread_id=34139