Re: svn commit: r763726 - in /tomcat/trunk/java/org/apache/catalina/ha/backend: HeartbeatListener.java MultiCastSender.java Proxy.java Sender.java TcpSender.java

jean-frederic clere wrote: It requires some new code in httpd-trunk to work... sounds like you're reinventing the wheel in tomcat trunk to avoid code in httpd trunk :) I'm fine either way, I just wanted to notify you of work that probably already does everything you are trying to do, and some m

Re: svn commit: r763298 - in /tomcat/trunk/java/org/apache/catalina: core/StandardContext.java core/StandardHost.java tribes/membership/Membership.java util/InstanceSupport.java util/LifecycleSupport.

Filip Hanik - Dev Lists wrote: I'm generally against this find bugs 'may be bugs' issues. is there an actual bug here? It's generally making the code "better". What do you object to about it? - To unsubscribe, e-mail: dev-unsu

Re: svn commit: r763298 - in /tomcat/trunk/java/org/apache/catalina: core/StandardContext.java core/StandardHost.java tribes/membership/Membership.java util/InstanceSupport.java util/LifecycleSupport.

I'm generally against this find bugs 'may be bugs' issues. is there an actual bug here? Filip ma...@apache.org wrote: Author: markt Date: Wed Apr 8 16:08:42 2009 New Revision: 763298 URL: http://svn.apache.org/viewvc?rev=763298&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi

DO NOT REPLY [Bug 46597] Not all cookie changes in 6.0.x branch have been ported to 5.5.x

https://issues.apache.org/bugzilla/show_bug.cgi?id=46597 --- Comment #4 from David Lewis 2009-04-09 09:55:15 PST --- I look forward to this patch being integrated into the next Tomcat 5.5.x. Until our organization migrates to Java 6/Tomcat 6, we are "stuck" using Tomcat 5.5.25 due to cookie

Re: svn commit: r763726 - in /tomcat/trunk/java/org/apache/catalina/ha/backend: HeartbeatListener.java MultiCastSender.java Proxy.java Sender.java TcpSender.java

It requires some new code in httpd-trunk to work... Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r763726 - in /tomcat/trunk/java/org/apache/catalina/ha/backend: HeartbeatListener.java MultiCastSender.java Proxy.java Sender.java TcpSender.java

Author: jfclere Date: Thu Apr 9 16:32:04 2009 New Revision: 763726 URL: http://svn.apache.org/viewvc?rev=763726&view=rev Log: Add the Tcp code... Still need the code in httpd-trunk to test it. Added: tomcat/trunk/java/org/apache/catalina/ha/backend/Proxy.java tomcat/trunk/java/org/apache

svn commit: r763723 - /tomcat/trunk/java/org/apache/tomcat/util/IntrospectionUtils.java

Author: markt Date: Thu Apr 9 16:20:23 2009 New Revision: 763723 URL: http://svn.apache.org/viewvc?rev=763723&view=rev Log: Drop some unused methods Modified: tomcat/trunk/java/org/apache/tomcat/util/IntrospectionUtils.java Modified: tomcat/trunk/java/org/apache/tomcat/util/IntrospectionUti

DO NOT REPLY [Bug 42390] JSP compilation error with nested tagfile tags with variables with "AT_BEGIN" scope

https://issues.apache.org/bugzilla/show_bug.cgi?id=42390 --- Comment #4 from Mark Thomas 2009-04-09 09:15:08 PST --- Again, many thanks for the patch. It has been applied to trunk and proposed for 6.0.x and 5.5.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=e

svn commit: r763720 - in /tomcat: current/tc5.5.x/STATUS.txt tc6.0.x/trunk/STATUS.txt

Author: markt Date: Thu Apr 9 16:15:07 2009 New Revision: 763720 URL: http://svn.apache.org/viewvc?rev=763720&view=rev Log: Propose fix for 42390 Modified: tomcat/current/tc5.5.x/STATUS.txt tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apac

svn commit: r763717 - /tomcat/trunk/java/org/apache/jasper/compiler/ScriptingVariabler.java

Author: markt Date: Thu Apr 9 16:13:00 2009 New Revision: 763717 URL: http://svn.apache.org/viewvc?rev=763717&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42390 Correct JSP compilation error with nested tagfile tags with variables with "AT_BEGIN" scope Patch provided by K

svn commit: r763707 - in /tomcat: current/tc5.5.x/STATUS.txt tc6.0.x/trunk/STATUS.txt

Author: markt Date: Thu Apr 9 15:47:49 2009 New Revision: 763707 URL: http://svn.apache.org/viewvc?rev=763707&view=rev Log: Propose patch for 42579 Modified: tomcat/current/tc5.5.x/STATUS.txt tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.ap

svn commit: r763706 - /tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java

Author: markt Date: Thu Apr 9 15:45:30 2009 New Revision: 763706 URL: http://svn.apache.org/viewvc?rev=763706&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42579 Handle both relative and absolute search results Patch provided by Brandon DuRette Modified: tomcat/trunk/j

DO NOT REPLY [Bug 42707] add host alias using jmx doesn't take affect until restart

https://issues.apache.org/bugzilla/show_bug.cgi?id=42707 --- Comment #7 from Mark Thomas 2009-04-09 08:23:38 PST --- I've proposed backporting the fix to 5.5.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because:

svn commit: r763693 - /tomcat/current/tc5.5.x/STATUS.txt

Author: markt Date: Thu Apr 9 15:23:27 2009 New Revision: 763693 URL: http://svn.apache.org/viewvc?rev=763693&view=rev Log: Propose backport to fix 42707 Modified: tomcat/current/tc5.5.x/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current

Re: svn commit: r763585 - /tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java

On Thu, 2009-04-09 at 14:37 +0100, Mark Thomas wrote: > This broke with > http://svn.apache.org/viewvc?view=rev&revision=703017 > for org.apache.coyote.ajp.AjpProtocol but I suspect no-one ever tested > it until today when I swapped AJP implementations for trunk. > > I'm open to fixing it a differ

DO NOT REPLY [Bug 46354] LIMIT_BUFFER setting causes arraycopy errors

https://issues.apache.org/bugzilla/show_bug.cgi?id=46354 --- Comment #7 from Mark Thomas 2009-04-09 08:14:22 PST --- Many thanks for the test case and patch, as well as your efforts in tracking this one down. The patch has been applied to trunk and proposed for 6.0.x and 5.5.x -- Configur

svn commit: r763684 - in /tomcat: current/tc5.5.x/STATUS.txt tc6.0.x/trunk/STATUS.txt

Author: markt Date: Thu Apr 9 15:14:00 2009 New Revision: 763684 URL: http://svn.apache.org/viewvc?rev=763684&view=rev Log: Propose fix for 46354 Modified: tomcat/current/tc5.5.x/STATUS.txt tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apac

svn commit: r763681 - /tomcat/trunk/java/org/apache/jasper/runtime/BodyContentImpl.java

Author: markt Date: Thu Apr 9 15:11:46 2009 New Revision: 763681 URL: http://svn.apache.org/viewvc?rev=763681&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46354 ArrayIndexOutOfBoundsException when using org.apache.jasper.runtime.BodyContentImpl.LIMIT_BUFFER=true Pathc pro

DO NOT REPLY [Bug 42950] ConcurrentModificationException on Shutdown

https://issues.apache.org/bugzilla/show_bug.cgi?id=42950 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|

DO NOT REPLY [Bug 45737] AcessControlException when using security manager: juli can't read logging.properties

https://issues.apache.org/bugzilla/show_bug.cgi?id=45737 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r763658 - in /tomcat: current/tc5.5.x/STATUS.txt tc6.0.x/trunk/STATUS.txt

Author: markt Date: Thu Apr 9 14:03:30 2009 New Revision: 763658 URL: http://svn.apache.org/viewvc?rev=763658&view=rev Log: Propose fix for 46984 Modified: tomcat/current/tc5.5.x/STATUS.txt tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apac

DO NOT REPLY [Bug 46984] Server incorrectly reports a 501 error on bad method name. Should report 400 error.

https://issues.apache.org/bugzilla/show_bug.cgi?id=46984 --- Comment #1 from Mark Thomas 2009-04-09 07:03:21 PST --- This has been fixed in trunk and proposed for 6.0.x and 5.5.x. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving thi

svn commit: r763654 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java Http11NioProcessor.java Http11Processor.java InternalAprInputBuffer.java InternalInputBuffer.java Internal

Author: markt Date: Thu Apr 9 13:54:05 2009 New Revision: 763654 URL: http://svn.apache.org/viewvc?rev=763654&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46984 CR & LF in middle of method name should cause a 400 So client sees 400, stop processing the request once we know

Re: svn commit: r763585 - /tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java

Remy Maucherat wrote: > On Thu, 2009-04-09 at 10:20 +, ma...@apache.org wrote: >> Author: markt >> Date: Thu Apr 9 10:20:36 2009 >> New Revision: 763585 >> >> URL: http://svn.apache.org/viewvc?rev=763585&view=rev >> Log: >> Java uses 0 rather than -1 for infinite socket timeout > > But the va

Re: svn commit: r763585 - /tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java

On Thu, 2009-04-09 at 10:20 +, ma...@apache.org wrote: > Author: markt > Date: Thu Apr 9 10:20:36 2009 > New Revision: 763585 > > URL: http://svn.apache.org/viewvc?rev=763585&view=rev > Log: > Java uses 0 rather than -1 for infinite socket timeout But the value is never used if <= 0, so what

svn commit: r763635 - in /tomcat/trunk/java/org/apache/catalina/ha/backend: HeartbeatListener.java MultiCastSender.java Sender.java

Author: jfclere Date: Thu Apr 9 13:00:21 2009 New Revision: 763635 URL: http://svn.apache.org/viewvc?rev=763635&view=rev Log: Move the multi logic to MultiCastSender with the idea to TCP sockets and a list of proxy too. Added: tomcat/trunk/java/org/apache/catalina/ha/backend/MultiCastSender.

DO NOT REPLY [Bug 46961] org.apache.catalina.loader.WebappClassLoader throws exception related to Java 6 Bug 6434149

https://issues.apache.org/bugzilla/show_bug.cgi?id=46961 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r763632 - /tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java

Author: markt Date: Thu Apr 9 12:55:49 2009 New Revision: 763632 URL: http://svn.apache.org/viewvc?rev=763632&view=rev Log: Remove accidental whitespace Modified: tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java Modified: tomcat/trunk/java/org/apache/catalina/loader/Webap

svn commit: r763630 - /tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java

Author: markt Date: Thu Apr 9 12:54:09 2009 New Revision: 763630 URL: http://svn.apache.org/viewvc?rev=763630&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46961 Avoid tripping over http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6434149 Modified: tomcat/trunk/java/

DO NOT REPLY [Bug 46909] error

https://issues.apache.org/bugzilla/show_bug.cgi?id=46909 --- Comment #1 from Mark Thomas 2009-04-09 04:48:42 PST --- Note that the ';' is expected in some circumstances. Eg: type="application/x-java-applet;version=1.5.0" That said, the ';' should really only be present if there is a followi

svn commit: r763613 - in /tomcat: current/tc5.5.x/STATUS.txt tc6.0.x/trunk/STATUS.txt

Author: markt Date: Thu Apr 9 11:48:36 2009 New Revision: 763613 URL: http://svn.apache.org/viewvc?rev=763613&view=rev Log: Propose fix for 46909 Modified: tomcat/current/tc5.5.x/STATUS.txt tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apac

svn commit: r763611 - /tomcat/trunk/java/org/apache/jasper/compiler/Generator.java

Author: markt Date: Thu Apr 9 11:46:13 2009 New Revision: 763611 URL: http://svn.apache.org/viewvc?rev=763611&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46909 The ';' should really only be used if there is a following parameter Modified: tomcat/trunk/java/org/apache

DO NOT REPLY [Bug 46903] STRICT_SERVLET_COMPLIANCE="false" doesn't turn off all checks

https://issues.apache.org/bugzilla/show_bug.cgi?id=46903 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 46907] Jasper with log4j in web-app classpath and debug level enabled prevents reading HTTP POST stream from JSP

https://issues.apache.org/bugzilla/show_bug.cgi?id=46907 --- Comment #7 from IzhikovNikolay 2009-04-09 04:12:48 PST --- Ok. I take a look. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assi

DO NOT REPLY [Bug 46770] Headers are send duplicate

https://issues.apache.org/bugzilla/show_bug.cgi?id=46770 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 46597] Not all cookie changes in 6.0.x branch have been ported to 5.5.x

https://issues.apache.org/bugzilla/show_bug.cgi?id=46597 --- Comment #3 from Mark Thomas 2009-04-09 04:11:06 PST --- The patch has been proposed for 5.5.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- Y

DO NOT REPLY [Bug 46562] Reader not closed

https://issues.apache.org/bugzilla/show_bug.cgi?id=46562 Mark Thomas changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #8 from Mark Tho

svn commit: r763602 - /tomcat/current/tc5.5.x/STATUS.txt

Author: markt Date: Thu Apr 9 11:09:10 2009 New Revision: 763602 URL: http://svn.apache.org/viewvc?rev=763602&view=rev Log: Propose patch Modified: tomcat/current/tc5.5.x/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.

svn commit: r763601 - /tomcat/tc6.0.x/trunk/STATUS.txt

Author: markt Date: Thu Apr 9 11:09:00 2009 New Revision: 763601 URL: http://svn.apache.org/viewvc?rev=763601&view=rev Log: Propose patch Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?re

svn commit: r763599 - /tomcat/trunk/java/org/apache/catalina/ssi/SSIServlet.java

Author: markt Date: Thu Apr 9 11:06:34 2009 New Revision: 763599 URL: http://svn.apache.org/viewvc?rev=763599&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46562 Close the reader when we are done Modified: tomcat/trunk/java/org/apache/catalina/ssi/SSIServlet.java Modi

DO NOT REPLY [Bug 46552] Could there be a logging for requests exceeding maxHttpHeaderSize

https://issues.apache.org/bugzilla/show_bug.cgi?id=46552 --- Comment #1 from Mark Thomas 2009-04-09 04:01:42 PST --- This is essentially the same as bug 46125. I have proposed a backport of the same fix for 5.5.x. This will: - ensure a 400 response is issued rather than the current 200 - log

svn commit: r763598 - /tomcat/current/tc5.5.x/STATUS.txt

Author: markt Date: Thu Apr 9 11:01:38 2009 New Revision: 763598 URL: http://svn.apache.org/viewvc?rev=763598&view=rev Log: Propose patch Modified: tomcat/current/tc5.5.x/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.

svn commit: r763590 - in /tomcat/trunk/java/org/apache/tomcat/util: net/ threads/

Author: markt Date: Thu Apr 9 10:37:36 2009 New Revision: 763590 URL: http://svn.apache.org/viewvc?rev=763590&view=rev Log: Remove old thread pool code Removed: tomcat/trunk/java/org/apache/tomcat/util/net/LeaderFollowerWorkerThread.java tomcat/trunk/java/org/apache/tomcat/util/net/Maste

svn commit: r763588 - /tomcat/trunk/java/org/apache/jk/

Author: markt Date: Thu Apr 9 10:27:01 2009 New Revision: 763588 URL: http://svn.apache.org/viewvc?rev=763588&view=rev Log: Remove the org.apache.jk package as per discussion on dev list. Do this early in Tomcat 7 development to increase chances of identifying any issues with org.apache.coyoye.

svn commit: r763585 - /tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java

Author: markt Date: Thu Apr 9 10:20:36 2009 New Revision: 763585 URL: http://svn.apache.org/viewvc?rev=763585&view=rev Log: Java uses 0 rather than -1 for infinite socket timeout Modified: tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java Modified: tomcat/trunk/java/org/apache/t

svn commit: r763581 - in /tomcat/trunk/webapps/docs/config: ajp.xml http.xml

Author: markt Date: Thu Apr 9 09:53:34 2009 New Revision: 763581 URL: http://svn.apache.org/viewvc?rev=763581&view=rev Log: Update the docs for the protocol attribute Modified: tomcat/trunk/webapps/docs/config/ajp.xml tomcat/trunk/webapps/docs/config/http.xml Modified: tomcat/trunk/weba

svn commit: r763580 - in /tomcat/trunk/java/org/apache/catalina: connector/Connector.java startup/Embedded.java

Author: markt Date: Thu Apr 9 09:49:34 2009 New Revision: 763580 URL: http://svn.apache.org/viewvc?rev=763580&view=rev Log: Switch to org.apache.coyote.ajp.AjpProtocol rather than org.apache.jk.server.JkCoyoteHandler Modified: tomcat/trunk/java/org/apache/catalina/connector/Connector.java

DO NOT REPLY [Bug 46999] change scope in ThreadPoolExecutor

https://issues.apache.org/bugzilla/show_bug.cgi?id=46999 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 46998] small fix to TaskThreadFactory

https://issues.apache.org/bugzilla/show_bug.cgi?id=46998 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r763567 - /tomcat/trunk/java/org/apache/tomcat/util/threads/TaskThreadFactory.java

Author: markt Date: Thu Apr 9 09:14:40 2009 New Revision: 763567 URL: http://svn.apache.org/viewvc?rev=763567&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46998 Reduce scope Patch provided by Jens Kapitza Modified: tomcat/trunk/java/org/apache/tomcat/util/threads/Task

DO NOT REPLY [Bug 46997] small fix to TaskQueue

https://issues.apache.org/bugzilla/show_bug.cgi?id=46997 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r763566 - /tomcat/trunk/java/org/apache/tomcat/util/threads/TaskQueue.java

Author: markt Date: Thu Apr 9 09:13:28 2009 New Revision: 763566 URL: http://svn.apache.org/viewvc?rev=763566&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46997 Code clean up Patch provided by Jens Kapitza Modified: tomcat/trunk/java/org/apache/tomcat/util/threads/Ta

DO NOT REPLY [Bug 46991] "Bytes received " problem

https://issues.apache.org/bugzilla/show_bug.cgi?id=46991 --- Comment #4 from huangfeng 2009-04-09 02:11:27 PST --- Thanks ! -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bu

DO NOT REPLY [Bug 47005] Does not render pages on native Japanese windows server 2003

https://issues.apache.org/bugzilla/show_bug.cgi?id=47005 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 45852] conf/tomcat-users.xml has invalid encoding "cp932".

https://issues.apache.org/bugzilla/show_bug.cgi?id=45852 Mark Thomas changed: What|Removed |Added CC||jwex...@mail.usa.com --- Comment

DO NOT REPLY [Bug 46991] "Bytes received " problem

https://issues.apache.org/bugzilla/show_bug.cgi?id=46991 --- Comment #3 from Mark Thomas 2009-04-09 01:51:44 PST --- It will probably be in 6.0.20 but that depends on a) it getting the 3 +1 votes to be back-ported and b) there being a 6.0.20 release. Given that 6.0.19 is still in progress 6.

DO NOT REPLY [Bug 46933] Using Java 1.5 in StringManager

https://issues.apache.org/bugzilla/show_bug.cgi?id=46933 Mark Thomas changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

svn commit: r763562 - in /tomcat/site/trunk: docs/lists.html xdocs/lists.xml

Author: markt Date: Thu Apr 9 08:42:21 2009 New Revision: 763562 URL: http://svn.apache.org/viewvc?rev=763562&view=rev Log: Make it clear you have to subscribe first, advice on how to avoid spam and some other minor tweaks. Modified: tomcat/site/trunk/docs/lists.html tomcat/site/trunk/x