No need to validate entry is null in ProxyDirContext.

2008-09-27 Thread 侯占斌
hi,all. In the ProxyDirContext class, the lookupCache method is described below: public CacheEntry lookupCache(String name) { CacheEntry entry = cacheLookup(name); if (entry == null) { the line 1378 in ProxyDirContext entry = new CacheEntry();

svn commit: r699756 - /tomcat/connectors/branches/other/jk_isapi_plugin_chunked/jk/native/iis/jk_isapi_plugin.c

2008-09-27 Thread rjung
Author: rjung Date: Sat Sep 27 16:17:52 2008 New Revision: 699756 URL: http://svn.apache.org/viewvc?rev=699756&view=rev Log: Last part of chunked response support. Although the change looks big, when chunked encoding is disabled, apart from cosmetic changes the normal code path is the same. To te

DO NOT REPLY [Bug 45906] Fix ResourceAttributes ETag handling

2008-09-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45906 --- Comment #1 from Chris Hubick <[EMAIL PROTECTED]> 2008-09-27 15:55:00 PST --- Sorry, this may be a dup of bug 45735, but provides more extensive cleanups. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab

DO NOT REPLY [Bug 45735] Updated ResourceAttributes.getETag

2008-09-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45735 Chris Hubick <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED

DO NOT REPLY [Bug 45906] New: Fix ResourceAttributes ETag handling

2008-09-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45906 Summary: Fix ResourceAttributes ETag handling Product: Tomcat 6 Version: unspecified Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2

svn commit: r699727 - /tomcat/connectors/branches/other/jk_isapi_plugin_chunked/jk/native/iis/jk_isapi_plugin.c

2008-09-27 Thread rjung
Author: rjung Date: Sat Sep 27 12:50:29 2008 New Revision: 699727 URL: http://svn.apache.org/viewvc?rev=699727&view=rev Log: Part 2 of chunked encoding: Further preparations but do not actually chunk. - Add enable_chunked_encoding config property - Add done() method. Implementation needs to be

svn commit: r699718 - /tomcat/connectors/branches/other/jk_isapi_plugin_chunked/jk/native/iis/jk_isapi_plugin.c

2008-09-27 Thread rjung
Author: rjung Date: Sat Sep 27 11:56:45 2008 New Revision: 699718 URL: http://svn.apache.org/viewvc?rev=699718&view=rev Log: Replace get_auth() by get_iis_info(): - Retrieve Major and minor version of IIS if possible and debug log it during startup - Use existing get_registry_config_number() he

svn commit: r699715 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-09-27 Thread markt
Author: markt Date: Sat Sep 27 11:44:24 2008 New Revision: 699715 URL: http://svn.apache.org/viewvc?rev=699715&view=rev Log: Propose another fix from Find Bugs Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.

svn commit: r699714 - /tomcat/trunk/java/org/apache/catalina/ssi/ResponseIncludeWrapper.java

2008-09-27 Thread markt
Author: markt Date: Sat Sep 27 11:34:06 2008 New Revision: 699714 URL: http://svn.apache.org/viewvc?rev=699714&view=rev Log: Fix date format issue reported by Find Bugs. Modified: tomcat/trunk/java/org/apache/catalina/ssi/ResponseIncludeWrapper.java Modified: tomcat/trunk/java/org/apache/cat

svn commit: r699713 - in /tomcat/trunk/java/org/apache: catalina/connector/ catalina/manager/ jasper/compiler/ tomcat/bayeux/request/ tomcat/util/modeler/

2008-09-27 Thread markt
Author: markt Date: Sat Sep 27 11:32:56 2008 New Revision: 699713 URL: http://svn.apache.org/viewvc?rev=699713&view=rev Log: Remove unused code reported by Find Bugs / Eclipse. No functional change. Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java tomcat/trunk/java/o

svn commit: r699709 - /tomcat/connectors/branches/other/jk_isapi_plugin_chunked/jk/native/iis/jk_isapi_plugin.c

2008-09-27 Thread rjung
Author: rjung Date: Sat Sep 27 11:15:29 2008 New Revision: 699709 URL: http://svn.apache.org/viewvc?rev=699709&view=rev Log: It is always is_inited here, since in the non inited case we already leave the function unconditionally above. Modified: tomcat/connectors/branches/other/jk_isapi_plug

svn commit: r699698 - /tomcat/connectors/branches/other/jk_isapi_plugin_chunked/jk/native/iis/jk_isapi_plugin.c

2008-09-27 Thread rjung
Author: rjung Date: Sat Sep 27 10:37:57 2008 New Revision: 699698 URL: http://svn.apache.org/viewvc?rev=699698&view=rev Log: Don't return error codes from GetLastError in init_jk, since JK_TRUE or JK_FALSE is expected. We shouldn't fail if watchdog thread could not be created, to keep behaviour c

svn commit: r699697 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-09-27 Thread remm
Author: remm Date: Sat Sep 27 10:36:18 2008 New Revision: 699697 URL: http://svn.apache.org/viewvc?rev=699697&view=rev Log: - Votes. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=6996

svn commit: r699695 - /tomcat/connectors/branches/other/jk_isapi_plugin_chunked/jk/native/iis/jk_isapi_plugin.c

2008-09-27 Thread rjung
Author: rjung Date: Sat Sep 27 10:28:15 2008 New Revision: 699695 URL: http://svn.apache.org/viewvc?rev=699695&view=rev Log: I assume it should have been an "or" instead of "and". We don't need it anyways, because not is_inited is enough reason for failure, and if not is_mapread, the code above s

svn commit: r699693 - /tomcat/connectors/branches/other/jk_isapi_plugin_chunked/jk/native/iis/jk_isapi_plugin.c

2008-09-27 Thread rjung
Author: rjung Date: Sat Sep 27 10:23:02 2008 New Revision: 699693 URL: http://svn.apache.org/viewvc?rev=699693&view=rev Log: Part 1 of chunked encoding preparation: Mostly trivial things. - Add CRLF constant define instead of crlf char array - Add "HTTP_" constant define - Add a few comments - Wh

Re: svn commit: r699523 - in /tomcat/trunk: java/org/apache/catalina/mbeans/ webapps/docs/config/

2008-09-27 Thread Remy Maucherat
On Fri, 2008-09-26 at 22:20 +, [EMAIL PROTECTED] wrote: > Author: markt > Date: Fri Sep 26 15:20:51 2008 > New Revision: 699523 > > URL: http://svn.apache.org/viewvc?rev=699523&view=rev > Log: > Add a new listener that enables the JMX ports to be fixed. This makes using > jconsole etc through

svn commit: r699680 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-09-27 Thread markt
Author: markt Date: Sat Sep 27 09:23:48 2008 New Revision: 699680 URL: http://svn.apache.org/viewvc?rev=699680&view=rev Log: Propose the Find Bugs fixes Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk

svn commit: r699678 - /tomcat/connectors/branches/other/jk_isapi_plugin_chunked/

2008-09-27 Thread rjung
Author: rjung Date: Sat Sep 27 09:16:19 2008 New Revision: 699678 URL: http://svn.apache.org/viewvc?rev=699678&view=rev Log: Branch for inclusion of the chunked encoding patch - will probably merge to trunk soon Added: tomcat/connectors/branches/other/jk_isapi_plugin_chunked/ - copied

RE: Findbugs results when run against Tomcat6

2008-09-27 Thread Jim Manico
This is really helpful info, Mark. I'd like to get my hands on an account there, too. If all else fails try emailing [EMAIL PROTECTED] - or maybe we could getsome other vendor to donate their product and/or time -Original Message- From: Mark Thomas <[EMAIL PROTECTED]> Sent: Saturday,

svn commit: r699646 - /tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java

2008-09-27 Thread markt
Author: markt Date: Sat Sep 27 06:45:27 2008 New Revision: 699646 URL: http://svn.apache.org/viewvc?rev=699646&view=rev Log: Fix string comp bugs reported by Find Bugs Modified: tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java Modified: tomcat/trunk/java/org/apache/tomcat/util

svn commit: r699645 - /tomcat/trunk/java/org/apache/juli/logging/LogFactory.java

2008-09-27 Thread markt
Author: markt Date: Sat Sep 27 06:42:43 2008 New Revision: 699645 URL: http://svn.apache.org/viewvc?rev=699645&view=rev Log: Fix cast error reported by Find Bugs Modified: tomcat/trunk/java/org/apache/juli/logging/LogFactory.java Modified: tomcat/trunk/java/org/apache/juli/logging/LogFactory

svn commit: r699644 - /tomcat/trunk/java/org/apache/jasper/xmlparser/ASCIIReader.java

2008-09-27 Thread markt
Author: markt Date: Sat Sep 27 06:41:53 2008 New Revision: 699644 URL: http://svn.apache.org/viewvc?rev=699644&view=rev Log: Fix signed/unsigned conversion reported by Find Bugs Modified: tomcat/trunk/java/org/apache/jasper/xmlparser/ASCIIReader.java Modified: tomcat/trunk/java/org/apache/ja

svn commit: r699635 - /tomcat/trunk/java/org/apache/catalina/ssi/SSIMediator.java

2008-09-27 Thread markt
Author: markt Date: Sat Sep 27 06:12:07 2008 New Revision: 699635 URL: http://svn.apache.org/viewvc?rev=699635&view=rev Log: Fix HTML decoding bug reported by Find Bugs Modified: tomcat/trunk/java/org/apache/catalina/ssi/SSIMediator.java Modified: tomcat/trunk/java/org/apache/catalina/ssi/SS

svn commit: r699634 - /tomcat/trunk/java/org/apache/catalina/ha/deploy/WarWatcher.java

2008-09-27 Thread markt
Author: markt Date: Sat Sep 27 06:10:29 2008 New Revision: 699634 URL: http://svn.apache.org/viewvc?rev=699634&view=rev Log: Fix minor memory leak found by find bugs. Modified: tomcat/trunk/java/org/apache/catalina/ha/deploy/WarWatcher.java Modified: tomcat/trunk/java/org/apache/catalina/ha/

svn commit: r699633 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

2008-09-27 Thread markt
Author: markt Date: Sat Sep 27 06:09:48 2008 New Revision: 699633 URL: http://svn.apache.org/viewvc?rev=699633&view=rev Log: Fix serialisation issues reported by find bugs Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Modified: tomcat/trunk/java/org/apache/catalin

Re: Findbugs results when run against Tomcat6

2008-09-27 Thread Mark Thomas
Jim Manico wrote: > Findbugs does a real bad job of findings real security bugs - I would > recommend running the codebase against Fortify + include the new Cigital > rulepack. > > Or take a look at the results of the Fortify Open Source Analysis project > > https://opensource.fortify.com/teamser

Re: Findbugs results when run against Tomcat6

2008-09-27 Thread Leon Rosenberg
Hello sebb, just out of curiosity, could you setup a webpage with your results or make them available via email or download ? Leon On Sat, Sep 27, 2008 at 12:00 AM, sebb <[EMAIL PROTECTED]> wrote: > Just out of curiosity, I ran Findbugs 1.3.5 on Tomcat 6.0.18. The > default settings generated so