svn commit: r647346 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-04-11 Thread markt
Author: markt Date: Fri Apr 11 16:08:44 2008 New Revision: 647346 URL: http://svn.apache.org/viewvc?rev=647346&view=rev Log: Propose fix. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev

svn commit: r647345 - /tomcat/trunk/java/org/apache/catalina/startup/TldConfig.java

2008-04-11 Thread markt
Author: markt Date: Fri Apr 11 16:07:10 2008 New Revision: 647345 URL: http://svn.apache.org/viewvc?rev=647345&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44380 Don't bother scanning non-file URLs for TLDs. Patch provided by Florent BENOIT Modified: tomcat/trunk/java/

svn commit: r647344 - /tomcat/trunk/java/org/apache/catalina/startup/TldConfig.java

2008-04-11 Thread markt
Author: markt Date: Fri Apr 11 16:00:55 2008 New Revision: 647344 URL: http://svn.apache.org/viewvc?rev=647344&view=rev Log: Code clean up. Java5 and remove unused code. No functional change. Modified: tomcat/trunk/java/org/apache/catalina/startup/TldConfig.java Modified: tomcat/trunk/java/o

svn commit: r647340 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-04-11 Thread markt
Author: markt Date: Fri Apr 11 15:39:50 2008 New Revision: 647340 URL: http://svn.apache.org/viewvc?rev=647340&view=rev Log: Propose fix Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=

DO NOT REPLY [Bug 44389] Cleanup of org.apache.naming.resources. CacheEntry resources (memory leak)

2008-04-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44389 --- Comment #2 from Mark Thomas <[EMAIL PROTECTED]> 2008-04-11 15:36:54 PST --- Testing with YourKit confirms that making the nested class static fixed the leak. Thanks for the analysis. The fix has been applied to trunk and proposed

svn commit: r647339 - /tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java

2008-04-11 Thread markt
Author: markt Date: Fri Apr 11 15:34:45 2008 New Revision: 647339 URL: http://svn.apache.org/viewvc?rev=647339&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44389 Make nested class static so it doesn't hold a reference to the ApplciationContext instance. Modified: tomc

svn commit: r647327 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-04-11 Thread remm
Author: remm Date: Fri Apr 11 14:43:02 2008 New Revision: 647327 URL: http://svn.apache.org/viewvc?rev=647327&view=rev Log: - Votes. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=6473

DO NOT REPLY [Bug 44391] SSI handling of escaped characters broken

2008-04-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44391 --- Comment #1 from Mark Thomas <[EMAIL PROTECTED]> 2008-04-11 14:25:54 PST --- Your proposed patch isn't quire right. For example, you have to know if the previous character is escaped or not if you have two \ in a row. I have committ

svn commit: r647319 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-04-11 Thread markt
Author: markt Date: Fri Apr 11 14:27:28 2008 New Revision: 647319 URL: http://svn.apache.org/viewvc?rev=647319&view=rev Log: Propose fix Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=

svn commit: r647316 - /tomcat/trunk/java/org/apache/catalina/ssi/SSIProcessor.java

2008-04-11 Thread markt
Author: markt Date: Fri Apr 11 14:25:59 2008 New Revision: 647316 URL: http://svn.apache.org/viewvc?rev=647316&view=rev Log: Fix bug44391. Handling of escaped characters was incorrect. Modified: tomcat/trunk/java/org/apache/catalina/ssi/SSIProcessor.java Modified: tomcat/trunk/java/org/apach

DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.

2008-04-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 --- Comment #46 from Mark Thomas <[EMAIL PROTECTED]> 2008-04-11 14:06:49 PST --- OK. That light up ahead might actually be the end of the tunnel rather than yet another train. I believe that all necessary patches to fix all issues ide

svn commit: r647309 - /tomcat/current/tc5.5.x/STATUS.txt

2008-04-11 Thread markt
Author: markt Date: Fri Apr 11 14:06:34 2008 New Revision: 647309 URL: http://svn.apache.org/viewvc?rev=647309&view=rev Log: Propose additional patches for 44494 Modified: tomcat/current/tc5.5.x/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/

svn commit: r647308 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-04-11 Thread markt
Author: markt Date: Fri Apr 11 14:05:45 2008 New Revision: 647308 URL: http://svn.apache.org/viewvc?rev=647308&view=rev Log: Another patch. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?r

svn commit: r647307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-04-11 Thread markt
Author: markt Date: Fri Apr 11 14:02:41 2008 New Revision: 647307 URL: http://svn.apache.org/viewvc?rev=647307&view=rev Log: Fix for garbage test in bug 44494. Patch provided by Suzuki Yuichiro. Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java Modified: tomcat/trunk/j

svn commit: r647306 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-04-11 Thread markt
Author: markt Date: Fri Apr 11 13:55:00 2008 New Revision: 647306 URL: http://svn.apache.org/viewvc?rev=647306&view=rev Log: Propose a patch. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt

svn commit: r647304 - /tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java

2008-04-11 Thread markt
Author: markt Date: Fri Apr 11 13:52:10 2008 New Revision: 647304 URL: http://svn.apache.org/viewvc?rev=647304&view=rev Log: Re-instate Rainer's code that fixes the 44494 test case for read with maxHttpHeaderSize > 8192. Modified: tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.j

DO NOT REPLY [Bug 44392] HTML entities not resolved in SSI filter

2008-04-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44392 --- Comment #1 from Mark Thomas <[EMAIL PROTECTED]> 2008-04-11 13:11:57 PST --- This has been fixed in trunk and proposed for 6.0.x. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are rec

svn commit: r647296 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-04-11 Thread markt
Author: markt Date: Fri Apr 11 13:14:13 2008 New Revision: 647296 URL: http://svn.apache.org/viewvc?rev=647296&view=rev Log: These have been applied. As Filip notes, another issue has come to light so expect more 44494 related fixes. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomca

svn commit: r647295 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/InputBuffer.java

2008-04-11 Thread markt
Author: markt Date: Fri Apr 11 13:13:09 2008 New Revision: 647295 URL: http://svn.apache.org/viewvc?rev=647295&view=rev Log: Fix for another issue uncovered by bug 44494. This is the fix for mark/reset. Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/InputBuffer.java Modifi

svn commit: r647294 - /tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/buf/CharChunk.java

2008-04-11 Thread markt
Author: markt Date: Fri Apr 11 13:11:58 2008 New Revision: 647294 URL: http://svn.apache.org/viewvc?rev=647294&view=rev Log: Fix for another issue uncovered by bug 44494. This is Remy's fix for the re-sizing. Modified: tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/buf/CharChunk.java Modi

svn commit: r647291 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-04-11 Thread markt
Author: markt Date: Fri Apr 11 13:09:41 2008 New Revision: 647291 URL: http://svn.apache.org/viewvc?rev=647291&view=rev Log: Propose fix. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev

svn commit: r647289 - in /tomcat/trunk/java/org/apache/catalina/ssi: SSIEcho.java SSIMediator.java

2008-04-11 Thread markt
Author: markt Date: Fri Apr 11 13:07:26 2008 New Revision: 647289 URL: http://svn.apache.org/viewvc?rev=647289&view=rev Log: Fix bug 44392. HTML entities not resolved in SSI. Modified: tomcat/trunk/java/org/apache/catalina/ssi/SSIEcho.java tomcat/trunk/java/org/apache/catalina/ssi/SSIMedi

DO NOT REPLY [Bug 42518] Intermittent 404

2008-04-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=42518 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |NEEDINFO ---

DO NOT REPLY [Bug 43753] JkEnvVar and Limit of content length HTTP request POST

2008-04-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43753 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEEDINFO|RESOLVED

DO NOT REPLY [Bug 44809] New: Improve AprLifecycleListener Error Messages

2008-04-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44809 Summary: Improve AprLifecycleListener Error Messages Product: Tomcat 6 Version: unspecified Platform: PC OS/Version: Linux Status: NEW Keywords: PatchAvailable

DO NOT REPLY [Bug 44804] JVM Crash: SIGSEGV Java HotSpot(TM) Server VM (1.6 .0_03-b05 mixed mode)

2008-04-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44804 --- Comment #4 from Remy Maucherat <[EMAIL PROTECTED]> 2008-04-11 08:42:09 PST --- This is an asynchronous read. You cannot do that, unless you make sure the servlet execution is still going on (and even then, it is not actually allowe

DO NOT REPLY [Bug 44804] JVM Crash: SIGSEGV Java HotSpot(TM) Server VM (1.6 .0_03-b05 mixed mode)

2008-04-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44804 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |NEEDINFO ---

DO NOT REPLY [Bug 44804] JVM Crash: SIGSEGV Java HotSpot(TM) Server VM (1.6 .0_03-b05 mixed mode)

2008-04-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44804 Naveen <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED]

Re: Question about Tomcat memory leaks

2008-04-11 Thread Costin Manolache
Well, if the _server machine_ is running out of memory - I think Yourkit/Jprofiler or most java options won't help. Just make sure you do have the -Xmx option in tomcat - and it's reasonable ( less than 1/2 of total RAM I would guess ). Java is very good at using -Xmx for the heap - I never seen i

Re: Question about Tomcat memory leaks

2008-04-11 Thread Henri Gomez
Yourkit is free for 15 days :) 2008/4/11, Henri Gomez <[EMAIL PROTECTED]>: > you could activate jmxremove to track it in real time via JConsole : > > Add these to JAVA_OPTS : > > -Dcom.sun.management.jmxremote.port=8090 > -Dcom.sun.management.jmxremote=true > -Dcom.sun.management.jmxremote.aut

Re: Question about Tomcat memory leaks

2008-04-11 Thread Henri Gomez
you could activate jmxremove to track it in real time via JConsole : Add these to JAVA_OPTS : -Dcom.sun.management.jmxremote.port=8090 -Dcom.sun.management.jmxremote=true -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.ssl=false -Djava.awt.headless=true Also comm

Re: Question about Tomcat memory leaks

2008-04-11 Thread Mark Thomas
Guenter Knauf wrote: Hi all, I've a prob with a Tomcat application. This is an app which was bought by a customer which I work for. The app runs on a plain WinXP box with nothing else installed on it but only the Tomcat servive + MySQL server. The app is used through the standalone http connect

Question about Tomcat memory leaks

2008-04-11 Thread Guenter Knauf
Hi all, I've a prob with a Tomcat application. This is an app which was bought by a customer which I work for. The app runs on a plain WinXP box with nothing else installed on it but only the Tomcat servive + MySQL server. The app is used through the standalone http connector; Tomcat version is 5

svn commit: r647085 - in /tomcat/connectors/trunk/jk: native/common/jk_lb_worker.c native/common/jk_lb_worker.h native/common/jk_shm.h xdocs/miscellaneous/changelog.xml

2008-04-11 Thread mturk
Author: mturk Date: Fri Apr 11 02:13:07 2008 New Revision: 647085 URL: http://svn.apache.org/viewvc?rev=647085&view=rev Log: Fix lb node in-error setting (see changelog) Modified: tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c tomcat/connectors/trunk/jk/native/common/jk_lb_worker

Re: JNDIRealm

2008-04-11 Thread Mark Thomas
[EMAIL PROTECTED] wrote: Brandon DuRette schrieb: As I said in my mail (27 Feb 2008 to bug 42579) JNDIRealm is hardly useable with (Windows Server 2003) Active Directory Domains -- except for very small / trivial cases. After a long history of frustrations, I solved all the Tomcat+AD-issues by

Re: JNDIRealm connection pooling

2008-04-11 Thread Mark Thomas
Brandon DuRette wrote: 1. I could not find a corresponding case in the bug database in either the 5.5 or 6.0 builds. Since this is an issue in both, should I open it in both? If not, does anyone care which one the issue is filed against? No really, but if there is a choice 6.0 2.

RE: JNDIRealm

2008-04-11 Thread albrecht
Brandon DuRette schrieb: > While trying to track down an issue with logins taking a very long time, I > just discovered in the 5.5.26 source code/Javadoc for JNDIRealm (likewise in > the 6.0 documentation) that there's a big bold TODO to support connection > pooling in the JNDIRealm. I think this

svn commit: r647068 - /tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c

2008-04-11 Thread mturk
Author: mturk Date: Fri Apr 11 00:03:21 2008 New Revision: 647068 URL: http://svn.apache.org/viewvc?rev=647068&view=rev Log: Don't log ajp_connection_tcp_send_message failure as ERROR. This can be part of normal operation caused by cping/cpong. We are later logging that either as INFO in handle_