Re: [dev] dwm: XKeycodeToKeysym deprecated patch

2012-10-25 Thread Andrew Hills
The call to XkbKeycodeToKeysym always returns zero for me when I run dwm through RealVNC, probably because it sucks. Attached is the patch against tip (reverting 737cf52cd031) for others forced to run dwm on shitty systems. --Andrew Hills dwm-keycode-to-keysym-vnc-fix.patch Description: Binary d

Re: [dev] dwm: XKeycodeToKeysym deprecated patch

2012-06-23 Thread Anselm R Garbe
On 16 May 2012 03:41, James Turner wrote: > XKeycodeToKeysym was deprecated on 2011-10-10 [0]. The included patch > updates dwm.c to use XkbKeycodeToKeysym instead. > > [0] > http://cgit.freedesktop.org/xorg/lib/libX11/commit/include/X11?id=f2651e03f3295a453a2965c3749bc8b6e66f1c09 Thanks, applied

Re: [dev] dwm: XKeycodeToKeysym deprecated patch

2012-05-16 Thread Kurt H Maier
On Wed, May 16, 2012 at 07:42:07PM +0300, Ivan Kanakarakis wrote: > are you an Ubuntu user ? no, i am an adult.

Re: [dev] dwm: XKeycodeToKeysym deprecated patch

2012-05-16 Thread Ivan Kanakarakis
On 16 May 2012 16:06, Kurt H Maier wrote: > On Wed, May 16, 2012 at 03:34:25PM +0300, Ivan Kanakarakis wrote: > > XKeycodeToKeysym returns faulty results in some cases/layouts. > > Thanks, this is the sort of information I was looking for. > > are you an Ubuntu user ? -- *Ivan c00kiemon5ter V K

Re: [dev] dwm: XKeycodeToKeysym deprecated patch

2012-05-16 Thread Kurt H Maier
On Wed, May 16, 2012 at 03:34:25PM +0300, Ivan Kanakarakis wrote: > XKeycodeToKeysym returns faulty results in some cases/layouts. Thanks, this is the sort of information I was looking for.

Re: [dev] dwm: XKeycodeToKeysym deprecated patch

2012-05-16 Thread Ivan Kanakarakis
XKeycodeToKeysym returns faulty results in some cases/layouts. [0] Here is the original bug report [1] Here is the deprecation proposal [2] And the changelog linking to [0] [0]: https://bugs.freedesktop.org/show_bug.cgi?id=25732 [1]: https://bugs.freedesktop.org/show_bug.cgi?id=5349 [2]: htt

Re: [dev] dwm: XKeycodeToKeysym deprecated patch

2012-05-16 Thread Kurt H Maier
On Wed, May 16, 2012 at 01:12:58PM +0100, Rob wrote: > You were arguing that it's bad because it's the "latest" mandate. No, I'm arguing that it's bad because it introduces more shit, and nobody has yet been able to explain what benefit that cost brings. > I call subtle trolling I call terrible

Re: [dev] dwm: XKeycodeToKeysym deprecated patch

2012-05-16 Thread Rob
On 16 May 2012 02:58, Kurt H Maier wrote: > On Tue, May 15, 2012 at 09:52:10PM -0400, James Turner wrote: >> >> XKBlib.h has been around since 1993 is an extra header file really that >> bad? > > Are you arguing that it's good code because it's old code? You were arguing that it's bad because it'

Re: [dev] dwm: XKeycodeToKeysym deprecated patch

2012-05-15 Thread James Turner
On Tue, May 15, 2012 at 09:58:43PM -0400, Kurt H Maier wrote: > On Tue, May 15, 2012 at 09:52:10PM -0400, James Turner wrote: > > > > XKBlib.h has been around since 1993 is an extra header file really that > > bad? > > Are you arguing that it's good code because it's old code? > Nope, I'm not a

Re: [dev] dwm: XKeycodeToKeysym deprecated patch

2012-05-15 Thread Kurt H Maier
On Tue, May 15, 2012 at 09:52:10PM -0400, James Turner wrote: > > XKBlib.h has been around since 1993 is an extra header file really that > bad? Are you arguing that it's good code because it's old code?

Re: [dev] dwm: XKeycodeToKeysym deprecated patch

2012-05-15 Thread James Turner
On Tue, May 15, 2012 at 09:48:51PM -0400, Kurt H Maier wrote: > On Tue, May 15, 2012 at 09:41:46PM -0400, James Turner wrote: > > XKeycodeToKeysym was deprecated on 2011-10-10 [0]. The included patch > > updates dwm.c to use XkbKeycodeToKeysym instead. > > > Is there any benefit to this other tha

Re: [dev] dwm: XKeycodeToKeysym deprecated patch

2012-05-15 Thread Kurt H Maier
On Tue, May 15, 2012 at 09:41:46PM -0400, James Turner wrote: > XKeycodeToKeysym was deprecated on 2011-10-10 [0]. The included patch > updates dwm.c to use XkbKeycodeToKeysym instead. Is there any benefit to this other than introducing xkb as a dependency? We don't all run dwm on the latest free

Re: [dev] dwm: XKeycodeToKeysym deprecated patch

2012-05-15 Thread Lee Fallat
Just what I've been waiting for. Thanks! On Tue, May 15, 2012 at 9:41 PM, James Turner wrote: > XKeycodeToKeysym was deprecated on 2011-10-10 [0]. The included patch > updates dwm.c to use XkbKeycodeToKeysym instead. > > [0] > > http://cgit.freedesktop.org/xorg/lib/libX11/commit/include/X11?id=f

[dev] dwm: XKeycodeToKeysym deprecated patch

2012-05-15 Thread James Turner
XKeycodeToKeysym was deprecated on 2011-10-10 [0]. The included patch updates dwm.c to use XkbKeycodeToKeysym instead. [0] http://cgit.freedesktop.org/xorg/lib/libX11/commit/include/X11?id=f2651e03f3295a453a2965c3749bc8b6e66f1c09 -- James Turner ja...@calminferno.net diff -r 48309b14abb9 dwm.c -