Re: [dev] Potential bug in st fallback font code

2015-03-13 Thread Alexander S.
2015-03-11 2:00 GMT+03:00 Eric Pruitt : > First, you say thanks for reporting the issue: Don't try to argue with Christoph, please. His words are rarely the reason for why he's pissed off, but most often are the rationalization he invented on the fly to make his opinions appear objective and justif

Re: [dev] Potential bug in st fallback font code

2015-03-12 Thread FRIGN
On Tue, 10 Mar 2015 06:39:49 +0100 Christoph Lohmann <2...@r-36.net> wrote: > Maybe it’s time to move to pango to not have to > deal with that bug reports anymore. As much as I love hating pango, it's also the only library I know of which handles assembled characters properly. One has to wonder h

Re: [dev] Potential bug in st fallback font code

2015-03-10 Thread Eric Pruitt
First, you say thanks for reporting the issue: On Mon, Mar 09, 2015 at 11:17:23PM +0100, Christoph Lohmann wrote: > Thanks for reporting this. > > Sincerely, > Christoph Lohmann Then you complain that I should send a patch with the bug: On Tue, Mar 10, 2015 at 06:39:49AM +0100, Christoph Lohmann

Re: [dev] Potential bug in st fallback font code

2015-03-10 Thread Christoph Lohmann
Greetings. On Tue, 10 Mar 2015 21:19:53 +0100 Greg Reagle wrote: > On Tue, Mar 10, 2015 at 06:39:49AM +0100, Christoph Lohmann wrote: > > Why are you throwing half‐baked bug reports at me without doing any de‐ > > bugging on your own? First of all, this is suckless: Bug reports have to > > be o

Re: [dev] Potential bug in st fallback font code

2015-03-10 Thread Eric Pruitt
On Tue, Mar 10, 2015 at 07:02:12PM +0100, FRIGN wrote: > As much as I love hating pango, it's also the only > library I know of which handles assembled characters > properly. Actually, Xft handles combining characters just fine. With my dwm / libsl Xft patch, combined character sequences render pe

Re: [dev] Potential bug in st fallback font code

2015-03-10 Thread Greg Reagle
On Tue, Mar 10, 2015 at 06:39:49AM +0100, Christoph Lohmann wrote: > Why are you throwing half‐baked bug reports at me without doing any de‐ > bugging on your own? First of all, this is suckless: Bug reports have to > be opened with a patch attached. Second: Don’t reply to yourself if you > don’t

Re: [dev] Potential bug in st fallback font code

2015-03-10 Thread Nick
Quoth Connor Lane Smith: > I note that, had Eric not taken the time to post details of this bug > to the mailing list, we wouldn't have known about it, and the bug > would have lingered on. But apparently that's preferable. See no evil, > hear no evil! Sh! Christoph has his police everywh

Re: [dev] Potential bug in st fallback font code

2015-03-10 Thread Connor Lane Smith
Hi, I had a quick glance at Christoph's patch. An excerpt: + /* We got a default font for a not found glyph. */ + if(!charexists && frc[i].flags == frcflags \ + && unicodep == unicodep) { I invite you to contemplat

Re: [dev] Potential bug in st fallback font code

2015-03-09 Thread Eric Pruitt
On Tue, Mar 10, 2015 at 06:39:49AM +0100, Christoph Lohmann wrote: > Why are you throwing half‐baked bug reports at me without doing any de‐ > bugging on your own? Sometimes, I don't have time to or feel like putting forth the effort to debug code someone else broke. But going forward, I will thi

Re: [dev] Potential bug in st fallback font code

2015-03-09 Thread Christoph Lohmann
Greetings. On Tue, 10 Mar 2015 06:39:49 +0100 Eric Pruitt wrote: > On Mon, Mar 09, 2015 at 11:17:23PM +0100, Christoph Lohmann wrote: > > The returned pattern are no duplicates and can’t be compared. I pushed a > > change to st to store the unicode long too of the glyph. This prevents > > the

Re: [dev] Potential bug in st fallback font code

2015-03-09 Thread Eric Pruitt
On Mon, Mar 09, 2015 at 08:05:41PM -0700, Eric Pruitt wrote: > I think your patch is buggy as I have noticed two strange behaviours. I > recompiled st, launched my music player, and I had some Japanese > characters that have normally rendered fine for me render as rectangles. I just noticed someth

Re: [dev] Potential bug in st fallback font code

2015-03-09 Thread Eric Pruitt
On Mon, Mar 09, 2015 at 08:09:32PM -0700, Eric Pruitt wrote: > And as luck would happen, the same thing just occurred again, twice, but > I still haven't figured out how to _consistently_ reproduce the problem. > I'm reverting your changes in my local copy, but if you commit a fix and > want me to

Re: [dev] Potential bug in st fallback font code

2015-03-09 Thread Eric Pruitt
On Mon, Mar 09, 2015 at 08:05:41PM -0700, Eric Pruitt wrote: > Unfortunately, I can't seem to reproduce the problem, [...] And as luck would happen, the same thing just occurred again, twice, but I still haven't figured out how to _consistently_ reproduce the problem. I'm reverting your changes in

Re: [dev] Potential bug in st fallback font code

2015-03-09 Thread Eric Pruitt
On Mon, Mar 09, 2015 at 11:17:23PM +0100, Christoph Lohmann wrote: > The returned pattern are no duplicates and can’t be compared. I pushed a > change to st to store the unicode long too of the glyph. This prevents > the code from reloading the default font used to display the missing > glyph

Re: [dev] Potential bug in st fallback font code

2015-03-09 Thread Christoph Lohmann
Greetings. On Mon, 09 Mar 2015 23:17:23 +0100 Eric Pruitt wrote: > First off, I'm not sure what's proper etiquette around here for posting > a public email that is somewhat directed toward a specific person, so > mea culpa if CC'ing that person is the wrong approach. I will read the mailinglist.

Re: [dev] Potential bug in st fallback font code

2015-02-21 Thread FRIGN
On Sat, 21 Feb 2015 07:32:54 -0800 Eric Pruitt wrote: > In my dwm patch, I worked around this problem by creating a proper font > structure from the fallback search result and then calling XftCharExists > on the codepoint to actually verify that the fallback font contains the > character I want.

Re: [dev] Potential bug in st fallback font code

2015-02-21 Thread Eric Pruitt
On Sat, Feb 21, 2015 at 03:00:05PM +0100, FRIGN wrote: > I must admit that I personally am not happy with the font-cache in st. > For each character drawn, it is checked if it is in the current fontset. > If not, some fontconfig-magic happens in the background, selecting a > font which contains the

Re: [dev] Potential bug in st fallback font code

2015-02-21 Thread FRIGN
On Fri, 20 Feb 2015 19:53:04 -0800 Eric Pruitt wrote: Hi Eric, > First off, I'm not sure what's proper etiquette around here for posting > a public email that is somewhat directed toward a specific person, so > mea culpa if CC'ing that person is the wrong approach. it bugs me when people send a

[dev] Potential bug in st fallback font code

2015-02-20 Thread Eric Pruitt
First off, I'm not sure what's proper etiquette around here for posting a public email that is somewhat directed toward a specific person, so mea culpa if CC'ing that person is the wrong approach. While implementing Unicode support for dwm with Xft, I discovered an issue with my code and realized