Re: [dev] Decouple build system from program settings

2014-12-05 Thread Anselm R Garbe
On 5 December 2014 at 12:12, FRIGN wrote: > So just for the sake of consistency, given the two colours are a > program property, it should be in config.h (even if it is only 2 > lines, who cares? There's not going to be a binary change and especially > no difference after the CPP-vomit). Exactly.

Re: [dev] Decouple build system from program settings

2014-12-05 Thread FRIGN
On Fri, 5 Dec 2014 12:06:05 +0100 "Dmitrij D. Czarkoff" wrote: > So I expect people to read config.mk. It would be my second direction after config.h (if you are used to the suckless style) > This was my initial thought, but config.def.h with 2 lines doesn't seem > sane. Although it is saner t

Re: [dev] Decouple build system from program settings

2014-12-05 Thread Dmitrij D. Czarkoff
FRIGN said: > This is just wrong. Or do you expect people to dig > in the code to change the colours? No. Dmitrij D. Czarkoff said: > diff --git a/config.mk b/config.mk ... > # On *BSD remove -DHAVE_SHADOW_H from CPPFLAGS and add -DHAVE_BSD_AUTH > # On OpenBSD and Darwin remove -lcrypt from LIB

Re: [dev] Decouple build system from program settings

2014-12-05 Thread FRIGN
On Fri, 5 Dec 2014 11:54:00 +0100 "Dmitrij D. Czarkoff" wrote: > diff --git a/slock.c b/slock.c > index d281965..1ddc35b 100644 > --- a/slock.c > +++ b/slock.c > @@ -1,4 +1,3 @@ > - > /* See LICENSE file for license details. */ > #define _XOPEN_SOURCE 500 > #if HAVE_SHADOW_H > @@ -23,6 +22,9 @