[dev] [st] cleanup

2011-08-04 Thread anonymous
Little cleanup patch. diff -r e64c97268f1a st.c --- a/st.c Thu Jun 09 18:25:56 2011 +0200 +++ b/st.c Thu Aug 04 19:44:02 2011 +0300 @@ -523,8 +523,7 @@ xev.selection = xsre->selection; xev.target = xsre->target; xev.time = xsre->time; - /* reject */ - x

Re: [dev] [st] cleanup patch

2011-04-28 Thread Michael Farnbach
Unfortunately scrolling in tmux is broken for me. But that said, I do like the idea of having that feature controlled by tmux, or tee into a file even. On Wed, Apr 27, 2011 at 4:29 AM, Hiltjo Posthuma wrote: > This is a pretty off-topic question, but I wonder will st implement > text-scrolling ev

Re: [dev] [st] cleanup patch

2011-04-27 Thread Hiltjo Posthuma
This is a pretty off-topic question, but I wonder will st implement text-scrolling eventually ? This and the performance is one of the few reasons I'm still using xterm, but I'm hoping to replace it with st :) (Im aware running st with tmux provides text-scrolling I guess, but having it without mi

Re: [dev] [st] cleanup patch

2011-04-26 Thread Connor Lane Smith
Hi, One thing I've noticed which slows down st massively is the font declarations in config.def.h. st attempts to find the set of all fonts which match the given pattern, which is pretty damn slow. It really ought to default to a specific font, like dwm does with terminus, and if that fails fall b

Re: [dev] [st] cleanup patch

2011-04-26 Thread Aurélien Aptel
On Tue, Apr 26, 2011 at 10:23 PM, anonymous wrote: > GLYPH_DIRTY is not used at all. It used to be, it was removed to simplify the code >  drawregion is called only from draw, so and bmotion. > screen is refreshed every time.  This is really slow: try to start > Midnight Commander in st and ux

Re: [dev] [st] cleanup patch

2011-04-26 Thread anonymous
GLYPH_DIRTY is not used at all. drawregion is called only from draw, so screen is refreshed every time. This is really slow: try to start Midnight Commander in st and uxterm and compare.

Re: [dev] [st] cleanup patch

2011-04-26 Thread Aurélien Aptel
On Tue, Apr 26, 2011 at 5:13 PM, anonymous wrote: > It would be also nice to remove debugging code from st.c: oops, it shouldn't be there sorry. Applied some of the cleanup.

Re: [dev] [st] cleanup patch

2011-04-26 Thread Hiltjo Posthuma
On Tue, Apr 26, 2011 at 5:13 PM, anonymous wrote: > It would be also nice to remove debugging code from st.c: > I concur. Imho the code within #ifdef DEBUG should also be removed.

Re: [dev] [st] cleanup patch

2011-04-26 Thread anonymous
It would be also nice to remove debugging code from st.c: void ttywrite(const char *s, size_t n) { {size_t nn; for(nn = 0; nn < n; nn++) dump(s[nn]); }

Re: [dev] [st] cleanup patch

2011-04-26 Thread anonymous
There is a problem with old code commented out with #ifdef: % CFLAGS=-DDEBUG make st build options: CFLAGS = -DDEBUG -std=c99 -pedantic -Wall -Os -I. -I/usr/include -I/usr/X11R6/include -DVERSION="0.1.1" LDFLAGS = -s -L/usr/lib -lc -L/usr/X11R6/lib -lX11 -lutil CC = cc CC st.c st.c: In fu

[dev] [st] cleanup patch

2011-04-23 Thread anonymous
Whitespace fixes and small changes in brelease(): code for selecting word is no longer executed when you triple-click. diff -r 2a6ed7b26469 st.c --- a/st.c Fri Apr 22 00:42:58 2011 +0200 +++ b/st.c Sat Apr 23 15:36:45 2011 +0400 @@ -363,11 +363,11 @@ utf8size(char *s) { unsigned