Re: [dev] [st] Shift Tab does not work

2012-12-13 Thread Christoph Lohmann
Greetings. On Thu, 13 Dec 2012 20:46:11 +0100 "Benjamin R. Haskell" wrote: > On Thu, 13 Dec 2012, Roberto E. Vargas Caballero wrote: > > >> Looking in the repository I can see that the commit 16ccf (Fix tab > >> key) inserted this code, and I have tested that is such commit it was > >> workin

Re: [dev] [st] Shift Tab does not work

2012-12-13 Thread Roberto E. Vargas Caballero
> But, it's error-prone to have two places to keep track of what keys > get mapped. So, I fixed this for myself a while ago by removing > mappedkeys entirely. Patch attached. I agree with you that it is error-prone, but if we remove it then each time a key is pressed it is necessary look up in

Re: [dev] [st] Shift Tab does not work

2012-12-13 Thread Benjamin R. Haskell
On Thu, 13 Dec 2012, Roberto E. Vargas Caballero wrote: Looking in the repository I can see that the commit 16ccf (Fix tab key) inserted this code, and I have tested that is such commit it was working, so we have a regression. I am going try now a bisection and try locate which commit broken t

Re: [dev] [st] Shift Tab does not work

2012-12-13 Thread Roberto E. Vargas Caballero
> Looking in the repository I can see that the commit 16ccf (Fix tab key) > inserted this code, and I have tested that is such commit it was working, so > we have a regression. I am going try now a bisection and try locate which > commit broken this key. The bisect indicates that the commit which

Re: [dev] [st] Shift Tab does not work

2012-12-13 Thread Roberto E. Vargas Caballero
On Thu, Dec 13, 2012 at 10:49:22AM +0200, Edgaras wrote: > I use Vim, and there you can cycle forward through completion using "Tab" and > backward using "Shift+Tab", this does not work in st, but it works in xterm. I > tested against tip. Using xev I see that X server sends ISO_Left_Tab event, an

[dev] [st] Shift Tab does not work

2012-12-13 Thread Edgaras
I use Vim, and there you can cycle forward through completion using "Tab" and backward using "Shift+Tab", this does not work in st, but it works in xterm. I tested against tip. Though I guess there is some interesting stuff going on with this, since in general it seems tab sends ^I and thus you ca