Re: [dev] [st] Flow control support

2015-04-19 Thread Roberto E. Vargas Caballero
The control flow is necessary in a terminal because you have two asynchronous process, one in the terminal and another in the computer, comunicate between them through a serial line using buffers in every side. When one of this buffer is full, then it must signal to the other process because in ot

Re: [dev] [st] Flow control support

2015-04-19 Thread Alex Pilon
> Your patch makes st echo STOP and START signals. It is just wrong. If > the other end says 'STOP', st should stop sending and buffer what it is > going to send. It is already done in the kernel so we should not worry > about it even if the other end is a real terminal and user pastes a huge > buf

Re: [dev] [st] Flow control support

2015-04-19 Thread noname
On Sun, Apr 19, 2015 at 02:52:18PM -0400, Alex Pilon wrote: > On Sun, Apr 19, 2015 at 02:36:35PM -0300, Amadeus Folego wrote: > > Alex, you just posted the diffstat, not the patch itself. > > I know. I was only proving a point about it being small and trying to > reduce the noise, though moot now.

Re: [dev] [st] Flow control support

2015-04-19 Thread Alex Pilon
> On Sun, Apr 19, 2015 at 01:05:50PM -0400, Alex Pilon wrote: > > Is there much appetite for flow control support in > > what-shall-we-call-it—‘mainline’? > > > > I occasionally have a use for it, but would rather not further feature > > creep into what everybody else uses without darn good reason.

Re: [dev] [st] Flow control support

2015-04-19 Thread noname
On Sun, Apr 19, 2015 at 01:05:50PM -0400, Alex Pilon wrote: > Is there much appetite for flow control support in > what-shall-we-call-it—‘mainline’? > > I occasionally have a use for it, but would rather not further feature > creep into what everybody else uses without darn good reason. How do yo

Re: [dev] [st] Flow control support

2015-04-19 Thread Alex Pilon
On Sun, Apr 19, 2015 at 02:36:35PM -0300, Amadeus Folego wrote: > Alex, you just posted the diffstat, not the patch itself. I know. I was only proving a point about it being small and trying to reduce the noise, though moot now. Should have attached it in the first place. Made it shorter now too.

Re: [dev] [st] Flow control support

2015-04-19 Thread Amadeus Folego
Alex, you just posted the diffstat, not the patch itself.

[dev] [st] Flow control support

2015-04-19 Thread Alex Pilon
Is there much appetite for flow control support in what-shall-we-call-it—‘mainline’? I occasionally have a use for it, but would rather not further feature creep into what everybody else uses without darn good reason. It's tiny anyway. commit db60d9e32c91f5c209b7df1290bd3a9c7a3cfdfe Auth