Re: [dev] [dwm] with SIGCHLD commit, dwm cannot launch dmenu_extended.

2023-04-09 Thread Hiltjo Posthuma
On Sat, Apr 08, 2023 at 11:02:56PM +0200, Storkman wrote: > On Sat, Apr 08, 2023 at 04:28:15PM +0200, p...@mailbox.org wrote: > > Hello everyone, > > > > I bind keyboard shortcut to launch dmenu_extended[1] in dwm, what works > > flawlessly before the `Use sigaction(SA_NOCLDWAIT) for SIGCHLD > > h

Re: [dev] [dwm] with SIGCHLD commit, dwm cannot launch dmenu_extended.

2023-04-08 Thread pfx
Voila, one single line of change make dmenu_extended_run launch again! git diff dwm.c diff --git a/dwm.c b/dwm.c index c2bd871..f8f83f8 100644 --- a/dwm.c +++ b/dwm.c @@ -1653,6 +1653,7 @@ spawn(const Arg *arg) if (dpy) close

Re: [dev] [dwm] with SIGCHLD commit, dwm cannot launch dmenu_extended.

2023-04-08 Thread pfx
On 08.04.23 23:43, Страхиња Радић wrote: > On 23/04/08 07:24PM, p...@mailbox.org wrote: > > static const char *dmenu_extend[] = { "dmenu_extended_run", NULL }; > > How about: > > > > (Try changing your > > > dmenu_extended keybind to something else and see if that works or not). > I tried t

Re: [dev] [dwm] with SIGCHLD commit, dwm cannot launch dmenu_extended.

2023-04-08 Thread Storkman
On Sat, Apr 08, 2023 at 04:28:15PM +0200, p...@mailbox.org wrote: > Hello everyone, > > I bind keyboard shortcut to launch dmenu_extended[1] in dwm, what works > flawlessly before the `Use sigaction(SA_NOCLDWAIT) for SIGCHLD > handling` [1] commit, since dmenu_extended does not change anything her

Re: [dev] [dwm] with SIGCHLD commit, dwm cannot launch dmenu_extended.

2023-04-08 Thread Страхиња Радић
On 23/04/08 07:24PM, p...@mailbox.org wrote: > static const char *dmenu_extend[] = { "dmenu_extended_run", NULL }; How about: > > (Try changing your > > dmenu_extended keybind to something else and see if that works or not). 1. What happens if you use: static const char *dmenu_exten

Re: [dev] [dwm] with SIGCHLD commit, dwm cannot launch dmenu_extended.

2023-04-08 Thread pfx
I built dwm based on https://aur.archlinux.org/packages/dwm-git > diff config.h src/dwm/config.def.h > 62d61 > < static const char *dmenu_extend[] = { "dmenu_extended_run", NULL }; > 67d65 > < { MODKEY, XK_o, spawn, {.v = > dmenu_extend } }, in config.h in

Re: [dev] [dwm] with SIGCHLD commit, dwm cannot launch dmenu_extended.

2023-04-08 Thread Hiltjo Posthuma
On Sat, Apr 08, 2023 at 07:24:07PM +0200, p...@mailbox.org wrote: > - patch is disabled > - `dwm 2> ~/dwm.log` shows nothing > > define command as > > static const char *dmenu_extend[] = { "dmenu_extended_run", NULL }; > > bind the command to a keyboard shortcut > > static Key keys[] =

Re: [dev] [dwm] with SIGCHLD commit, dwm cannot launch dmenu_extended.

2023-04-08 Thread pfx
- patch is disabled - `dwm 2> ~/dwm.log` shows nothing define command as static const char *dmenu_extend[] = { "dmenu_extended_run", NULL }; bind the command to a keyboard shortcut static Key keys[] = { MODKEY, XK_o, spawn, {.v = dmenu_extend

Re: [dev] [dwm] with SIGCHLD commit, dwm cannot launch dmenu_extended.

2023-04-08 Thread NRK
Hi, On Sat, Apr 08, 2023 at 04:28:15PM +0200, p...@mailbox.org wrote: > I bind keyboard shortcut to launch dmenu_extended[1] in dwm, what works > flawlessly before the `Use sigaction(SA_NOCLDWAIT) for SIGCHLD > handling` [1] commit, since dmenu_extended does not change anything here, > is this a r

[dev] [dwm] with SIGCHLD commit, dwm cannot launch dmenu_extended.

2023-04-08 Thread pfx
Hello everyone, I bind keyboard shortcut to launch dmenu_extended[1] in dwm, what works flawlessly before the `Use sigaction(SA_NOCLDWAIT) for SIGCHLD handling` [1] commit, since dmenu_extended does not change anything here, is this a regression or bug introduced with this commit or dmenu_extended