On Mon, Apr 25, 2022 at 05:38:35PM +0100, Chris Down wrote:
> Hiltjo Posthuma writes:
> > Whats the similar issue exactly? Does this issue also happen when bisecting
> > the
> > same commit (so its a also regression)?
>
> For 8806b6e23793 ("manage: propertynotify: Reduce cost of unused size
> hin
Ethan Marshall writes:
Completely fixed. All affected windows now behave as they did before the
patch - so, problem solved on my end.
Thanks for all your help Chris.
Excellent, thanks for getting back. I've submitted it as a proper patch.
Completely fixed. All affected windows now behave as they did before the
patch - so, problem solved on my end.
Thanks for all your help Chris.
Ethan
Hiltjo Posthuma writes:
Whats the similar issue exactly? Does this issue also happen when bisecting the
same commit (so its a also regression)?
For 8806b6e23793 ("manage: propertynotify: Reduce cost of unused size hints"),
the issue is that c->isfixed may not be set early, which might affect w
* Hiltjo Posthuma [2022-04-25 18:13]:
On Mon, Apr 25, 2022 at 04:00:21PM +0200, Jochen Sprickerhof wrote:
Hi Chris,
* Chris Down [2022-04-25 14:47]:
> I'm still unable to reproduce the issue, but I am curious, does this fix
> things? :-)
>
> diff --git a/dwm.c b/dwm.c
> index 0fc328a..f2a10c0
On Mon, Apr 25, 2022 at 04:00:21PM +0200, Jochen Sprickerhof wrote:
> Hi Chris,
>
> * Chris Down [2022-04-25 14:47]:
> > I'm still unable to reproduce the issue, but I am curious, does this fix
> > things? :-)
> >
> > diff --git a/dwm.c b/dwm.c
> > index 0fc328a..f2a10c0 100644
> > --- a/dwm.c
>
Hi Chris,
* Chris Down [2022-04-25 14:47]:
I'm still unable to reproduce the issue, but I am curious, does this
fix things? :-)
diff --git a/dwm.c b/dwm.c
index 0fc328a..f2a10c0 100644
--- a/dwm.c
+++ b/dwm.c
@@ -1061,6 +1061,7 @@ manage(Window w, XWindowAttributes *wa)
XSetWindowBord
Hi Ethan,
I'm still unable to reproduce the issue, but I am curious, does this fix
things? :-)
diff --git a/dwm.c b/dwm.c
index 0fc328a..f2a10c0 100644
--- a/dwm.c
+++ b/dwm.c
@@ -1061,6 +1061,7 @@ manage(Window w, XWindowAttributes *wa)
XSetWindowBorder(dpy, w, scheme[SchemeNorm][ColB
Just re-ran the bisection and got 8806b6e on both stock dwm and my
build. Reverting this commit fixes this change in both. Reverting
bece862 has no change in either, so I would assume we can eliminate that
commit as the issue.
Could this be related to the handling of fixed-size windows? I was unde
On Sat Apr 23, 2022 at 4:28 AM EDT, Chris Down wrote:
> Sebastian LaVine writes:
> >I believe this is known unintended behavior from the patch. I reverted it on
> >my personal branch.
>
> It looks like you reverted commit bece862a0fc4 ("manage: For
> isfloating/oldstate check/set, ensure trans cl
Sebastian LaVine writes:
I believe this is known unintended behavior from the patch. I reverted it on my
personal branch.
It looks like you reverted commit bece862a0fc4 ("manage: For
isfloating/oldstate check/set, ensure trans client actually exists"), not this
commit, right?[0]
In which c
Hi Ethan,
Just checking, are you sure this bisects to 8806b6e23793 ("manage:
propertynotify: Reduce cost of unused size hints")? I saw this issue prior to
making this patch and bisected to bece862a0fc4 ("manage: For
isfloating/oldstate check/set, ensure trans client actually exists"). I
repor
On Sat, Apr 23, 2022 at 12:39:28AM +0100, Ethan Marshall wrote:
> Hi all,
>
> I recently noticed that certain dialog windows (such as the Chromium
> system printing dialog and gpg-askpass popups) were being managed as
> tiled windows, rather than floating. This changed recently, so I
> bisected do
I believe this is known unintended behavior from the patch. I reverted it on my
personal branch.
Original Message
From: Ethan Marshall
Sent: April 22, 2022 11:39:28 PM UTC
To: dev@suckless.org
Subject: [dev] [dwm] possible regression in 8806b6e
Hi all,
I recently noticed
Hi all,
I recently noticed that certain dialog windows (such as the Chromium
system printing dialog and gpg-askpass popups) were being managed as
tiled windows, rather than floating. This changed recently, so I
bisected down to this commit:
8806b6e2379372900e3d9e0bf6604bc7f727350b is the first ba
15 matches
Mail list logo
