Re: [dev] [dmenu] Potential bug in dmenu Ctrl+Enter handling

2015-04-12 Thread Eric Pruitt
On Sun, Apr 12, 2015 at 06:32:13PM +, non...@inventati.org wrote: > The code that actually prints something is > puts((sel && !(ev->state & ShiftMask)) ? sel->text : text); Yeah, I saw that line, but the conditional I mentioned determines whether or not the program actually terminates. The w

Re: [dev] [dmenu] Potential bug in dmenu Ctrl+Enter handling

2015-04-12 Thread noname
On Sun, Apr 12, 2015 at 11:18:02AM -0700, Eric Pruitt wrote: > While looking at the dmenu source code to make a patch for it, I noticed > this conditional on line 371: "if(!(ev->state & ControlMask))". It looks > as though pressing Ctrl+(Shift)+Enter is supposed to print the current > selection to

[dev] [dmenu] Potential bug in dmenu Ctrl+Enter handling

2015-04-12 Thread Eric Pruitt
While looking at the dmenu source code to make a patch for it, I noticed this conditional on line 371: "if(!(ev->state & ControlMask))". It looks as though pressing Ctrl+(Shift)+Enter is supposed to print the current selection to stdout without terminating dmenu, but pressing Ctrl+(Shift)+Enter doe