From: "Roberto E. Vargas Caballero"
The commit b78c5085f72 changed the st behaviour enabling BCE capability,
that means erase regions using background color. Problem comes when you
clear a region with a selection, because in this case the real mode of the
Glyph is not the value of term.line[y][x]
2013/4/24 Roberto E. Vargas Caballero :
>
> I can not see your patch, I only can see you send twice the same patch,
> maybe did you mistake the second mail?
>
Yeah, sorry, accidentally sent the same patch two times. Now it should
be correct, I think.
> Too late -- I already sent almost that exact patch :P.
> Yes, I think this is the right thing to do, because st currently
> clears selection on putting character inside it. So, changing a
> characted with tclearregion() should clear it as well.
I can not see your patch, I only can see you sen
> We can test it in tclearregion in this form:
>
>
>
> for(y = y1; y <= y2; y++) {
> term.dirty[y] = 1;
> for(x = x1; x <= x2; x++) {
> if(selected(y, x))
> selclear(NULL);
> term.li
2013/4/24 Roberto E. Vargas Caballero :
> You are talking here about our Selection data structure, and you are right,
> if we mark it as not enabled (sel.bx = -1), all the problem will be fixed,
> and maybe in a cleaner way.
> We can test it in tclearregion in this form:
>
>
>
> for(y = y1;
> Maybe the behavior is wrong - but if the problem is that it is
> _still selected_ (i.e. hilight goes away when you select something
> else), it's not something that can be solved with anything to do
> with visual attributes only.
> That was why I was asking for clarification whether it is _still
2013/4/24 Random832 :
> On 04/23/2013 05:27 PM, Roberto E. Vargas Caballero wrote:
>>
>> It is very confusing see a hightlight blank line, that really is selecting
>> the previous content of the line. If the selecting mark keeps in the
>> screen
>> it is only some garbage in it. If you can find oth
On 04/23/2013 05:27 PM, Roberto E. Vargas Caballero wrote:
It is very confusing see a hightlight blank line, that really is selecting
the previous content of the line. If the selecting mark keeps in the screen
it is only some garbage in it. If you can find other terminal emulator with
this behavi
On Tue, Apr 23, 2013 at 05:12:47PM -0400, random...@fastmail.us wrote:
> On Tue, Apr 23, 2013, at 17:05, Roberto E. Vargas Caballero wrote:
> >
>
> What _exactly_ is the behavior you are observing? Are you sure it's not
> _actually_ staying selected, rather than simply drawing that way?
Did you se
On Tue, Apr 23, 2013, at 17:05, Roberto E. Vargas Caballero wrote:
>
What _exactly_ is the behavior you are observing? Are you sure it's not
_actually_ staying selected, rather than simply drawing that way?
If you click the mouse somewhere else, does the original selection go
away, or does it st
> That's not true. Only the attribute passed to xdraws() is altered - the
> real attribute stored in the character cell is left alone.
>
> Line 3189 new = term.line[y][x]; makes a _copy_ of
> the Glyph structure, and line 3191 only modifies the copy, not the
> original.
You
On Tue, Apr 23, 2013, at 16:21, Roberto E. Vargas Caballero wrote:
> In drawregion you have:
>
> 3172 bool ena_sel = sel.bx != -1;
> 3173
> 3174 if(sel.alt ^ IS_SET(MODE_ALTSCREEN))
> 3175 ena_sel = 0;
> ...
> 3190 if(ena_sel && *(new.c) && s
On Tue, Apr 23, 2013 at 03:38:32PM -0400, random...@fastmail.us wrote:
> On Tue, Apr 23, 2013, at 14:34, Roberto E. Vargas Caballero wrote:
> > From: "Roberto E. Vargas Caballero"
> >
> > The commit b78c5085f72 changed the st behaviour enabling BCE capability,
> > that means erase regions using ba
On Tue, Apr 23, 2013, at 14:34, Roberto E. Vargas Caballero wrote:
> From: "Roberto E. Vargas Caballero"
>
> The commit b78c5085f72 changed the st behaviour enabling BCE capability,
> that means erase regions using background color. Problem comes when you
> clear a region with a selection, becaus
Greetings.
On Tue, 23 Apr 2013 20:36:52 +0200 "Roberto E. Vargas Caballero"
wrote:
> From: "Roberto E. Vargas Caballero"
>
> The commit b78c5085f72 changed the st behaviour enabling BCE capability,
> that means erase regions using background color. Problem comes when you
> clear a region with
From: "Roberto E. Vargas Caballero"
The commit b78c5085f72 changed the st behaviour enabling BCE capability,
that means erase regions using background color. Problem comes when you
clear a region with a selection, because in this case the real mode of the
Glyph is not the value of term.line[y][x]
16 matches
Mail list logo
