Re: [dev] [PATCH] Check for presence of SHELL environment variable

2015-01-29 Thread Christoph Lohmann
On Thu, 06 Nov 2014 19:18:32 +0100 k...@shike2.com wrote: > > >> HOME must hold the value of the user's home directory, if this > >> value is not the value of /etc/passwd then you have an error > >> in your configuration. The same can be said about SHELL. You > >> can change your shell selection u

Re: [dev] [PATCH] Check for presence of SHELL environment variable

2014-11-10 Thread k0ga
>> I did a quick survey of a number of other terminal emulators: tmux, >> xterm, GNU screen, rxvt and dvtm all check the SHELL environment >> variable. Checking SHELL is expected behaviour, and it's a useful one at >> that. >> >> Eric > > Checking SHELL is common behaviour and any user setting S

Re: [dev] [PATCH] Check for presence of SHELL environment variable

2014-11-09 Thread koneu
Hi, Eric Pruitt wrote: > On Mon, Nov 03, 2014 at 11:33:17AM +0100, k...@shike2.com wrote: > > I would like to listen the opinion of other suckless developers about > > this point. What do you think guys? > > It's been nearly two weeks since I originally submitted this, and I > don't think anyone

Re: [dev] [PATCH] Check for presence of SHELL environment variable

2014-11-09 Thread Eric Pruitt
On Mon, Nov 03, 2014 at 11:33:17AM +0100, k...@shike2.com wrote: > I would like to listen the opinion of other suckless developers about > this point. What do you think guys? It's been nearly two weeks since I originally submitted this, and I don't think anyone else cares. I'm going to repeat myse

Re: [dev] [PATCH] Check for presence of SHELL environment variable

2014-11-03 Thread k0ga
>> HOME must hold the value of the user's home directory, if this >> value is not the value of /etc/passwd then you have an error >> in your configuration. The same can be said about SHELL. You >> can change your shell selection using chsh. > > I don't agree with your interpretation of the POSIX

Re: [dev] [PATCH] Check for presence of SHELL environment variable

2014-10-29 Thread Eric Pruitt
On Wed, Oct 29, 2014 at 09:52:14PM +0100, k...@shike2.com wrote: > I read this sentence as 'SHELL variable must hold always the value of > the user preferred command in the /etc/passwd file, and any program > that create a session must be aware of setting it from /etc/passwd'. > The sentence doesn'

Re: [dev] [PATCH] Check for presence of SHELL environment variable

2014-10-29 Thread k0ga
Hi, > - POSIX states the SHELL environment variable "... shall represent a > pathname of the user's preferred command language interpreter." As Well, this is a really complex topic. First because in this sentence is not specified what is 'user's preferred command language interpreter'. I read

[dev] [PATCH] Check for presence of SHELL environment variable

2014-10-28 Thread Eric Pruitt
- POSIX states the SHELL environment variable "... shall represent a pathname of the user's preferred command language interpreter." As such, st should check for its presence when deciding what shell to use; just as HOME can be defined to override one's passwd-defined home directory, a use