Re: [dev] [website] [proposal] Add suckless logo and minor style change

2015-02-01 Thread Matthias Rabault
That looks nice. FRIGN a écrit : >Good evening, > >looking at suckless.org, it's almost too bad the well-designed >suckless-'S' only exists as a favicon. >The motivation to bring the logo in more prominently is that >people remember images even better than names, and getting >attention in regard

Re: [dev] [vis] [PATCH] Set tabwidth and expandtab in config.def.h

2015-01-04 Thread Matthias Rabault
On Sun, Jan 04, 2015 at 06:52:00PM +0100, Marc André Tanner wrote: > On Sun, Jan 04, 2015 at 06:22:00PM +0100, Silvan Jegen wrote: > > On Sun, Jan 04, 2015 at 06:12:00PM +0100, Matthias Rabault wrote: > > > Thanks for the patch, I'll check it out this evening (can't y

Re: [dev] [vis] [PATCH] Set tabwidth and expandtab in config.def.h

2015-01-04 Thread Matthias Rabault
I like your idea of passing a pointer to the config struct, that's cleaner and if new options are created, we only add them to the config structure without adding new arguments to editor_new(). Silvan Jegen a écrit : >On Sun, Jan 04, 2015 at 06:12:00PM +0100, Matthias Rabault wrote: &

Re: [dev] [vis] [PATCH] Set tabwidth and expandtab in config.def.h

2015-01-04 Thread Matthias Rabault
Thanks for the patch, I'll check it out this evening (can't yet, I'm using my phone). What I was thinking of was adding code in main() that alters the Editor structure according to config.def.h defines, just before calling the main loop. I'm trying that tonight, but what do you think of that ?

Re: [dev] [vis] [PATCH] Set tabwidth and expandtab in config.def.h

2015-01-04 Thread Matthias Rabault
I see your point and I agree. I didn't think of that, so I'll have to think of another way to do that, which doesn't change the prototype. Thanks for the insight ! Dimitris Papastamos a écrit : >> -Editor *editor_new(int width, int height) { >> +Editor *editor_new(int width, int height, int ta

Re: [dev] [vis] [PATCH] Set tabwidth and expandtab in config.def.h

2015-01-04 Thread Matthias Rabault
Oops ... The empty line removal was an accident. As to yesterday's blunder, I knew how to use the preprocessor, I was only tired and did everything too fast ... Silvan Jegen a écrit : >Heyhey > >On Sun, Jan 4, 2015 at 4:42 PM, Matthias Rabault > wrote: >> I submitted a

[dev] [vis] [PATCH] Set tabwidth and expandtab in config.def.h

2015-01-04 Thread Matthias Rabault
Hello, I submitted a patch yesterday so that expandtab and tabwidth are set in config.def.h, but it was complete shit. Discard the other one. This one should be much better. I had to add arguments to editor_new(). Sorry for yesterday's shitty patch. --- config.def.h | 3 +++ editor.c | 6 +++

Re: [dev][vis] Set tabwidth and expandtab in config.h

2015-01-03 Thread Matthias Rabault
ng, I overlooked that, sorry. If you want me to split it and resubmit, I can do it. FRIGN a écrit : >On Sat, 3 Jan 2015 22:41:19 +0100 >Matthias Rabault wrote: > >> The two values were previously supplied as "magic constants". > >Well, apart from this idea, what&#x

[dev][vis] Set tabwidth and expandtab in config.h

2015-01-03 Thread Matthias Rabault
The two values were previously supplied as "magic constants". Signed-off-by: Matthias Rabault This raises another problem with the includes. I had to put some of the definitions in vis.h, but in turn that made gcc complain that there were functions declared in vis.h but not defin