Re: [dev] [surf][bug] bug in pipe communication to extension

2020-10-17 Thread Jochen Sprickerhof
Hi Jona, * Jona Ackerschott [2020-10-17 09:53]: To reproduce this bug, execute mainline surf without patches, go to 'google.com' (Exactly this, combinations of 'http(s)' or 'www' added to this can change the behaviour) and then to 'twitter.com' (Again extactly this). These sites are just one ex

Re: [dev] [surf][bug] bug in pipe communication to extension

2020-10-17 Thread Jona Ackerschott
Hello Hiltjo, So i found the specific problem present in the code, it works as follows: Wenn surf gets started, it sets up the two communication pipes, the surf web extension gets initialized and 'initwebextensions' in surf.c gets called. This function sends the numbers for the two file descriptor

Re: [dev] [surf][bug] bug in pipe communication to extension

2020-10-17 Thread Jona Ackerschott
Hello Hiltjo, > Where is the patch? Sorry, see the appendix of this mail. First let me say that i never worked with the codebase of surf before. I realised that my previous understanding of this bug seems to be partially wrong, so this patch works, but i don't know why exactly. My idea to avoid t

Re: [dev] [surf][bug] bug in pipe communication to extension

2020-10-17 Thread Hiltjo Posthuma
On Sat, Oct 17, 2020 at 09:53:47AM +0200, Jona Ackerschott wrote: > Dear suckless community, > Hi Jona, > There seems to be a bug in surf, in the 'readpipe' function in surf.c. > The pipes for communication with the web extension are being closed > there in the switch statement, which is problem

[dev] [surf][bug] bug in pipe communication to extension

2020-10-17 Thread Jona Ackerschott
Dear suckless community, There seems to be a bug in surf, in the 'readpipe' function in surf.c. The pipes for communication with the web extension are being closed there in the switch statement, which is problematic, because this function is called every time the web extension is initialized. Thi