Re: [dev] [st] bitmap font and chscale 1< line drawing bug

2016-09-07 Thread lemon
On Wed, Sep 07, 2016 at 09:39:08PM -0700, Eric Pruitt wrote: > Even if you don't debug and / or fix the problem, at least post the > offending commit, and I will take a look. I was able to fix it the problem by rolling back part of commit 528241aa3835e2f1f052abeeaf891737712955a0 and all of 0e48a1

Re: [dev] Shell style guide

2016-09-07 Thread Martin Kühne
As with read's -r flag, use <<'EOF' unless silly/potentially devastating side effects are desired. cheers! mar77i

Re: [dev] [st] bitmap font and chscale 1< line drawing bug

2016-09-07 Thread Eric Pruitt
On Wed, Sep 07, 2016 at 09:20:39PM -0700, le...@bitmessage.ch wrote: > This did not happen in st-0.6. Okay I'll check out git-bisect and see if > I can figure it out. I'll submit a patch or pull request if I find a > solution. Thanks. Even if you don't debug and / or fix the problem, at least post

Re: [dev] [st] bitmap font and chscale 1< line drawing bug

2016-09-07 Thread lemon
On Wed, Sep 07, 2016 at 06:02:53PM -0700, Eric Pruitt wrote: > On Wed, Sep 07, 2016 at 06:01:48PM -0700, Eric Pruitt wrote: > > On Wed, Sep 07, 2016 at 05:51:49PM -0700, le...@bitmessage.ch wrote: > > > After moving to st-0.7, I am experiencing a bug with line drawing. When > > > using a bitmap fon

Re: [dev] Shell style guide

2016-09-07 Thread Marc Collin
What people here think of heredoc? cat << EOF 1st line 2nd line 3rd line 4th line EOF OR echo "1st line" echo "2nd line" echo "3rd line" echo "4th line" OR printf "1st line\n" printf"2nd line\n" printf"3rd line\n" printf"4th line\n" On Wed, Sep 7, 2016 at 6:46 PM, Tiago Natel de Moura wrote

Re: [dev] [st] bitmap font and chscale 1< line drawing bug

2016-09-07 Thread Eric Pruitt
On Wed, Sep 07, 2016 at 06:01:48PM -0700, Eric Pruitt wrote: > On Wed, Sep 07, 2016 at 05:51:49PM -0700, le...@bitmessage.ch wrote: > > After moving to st-0.7, I am experiencing a bug with line drawing. When > > using a bitmap font (eg terminus) and a chscale=1.2 in config.h, every > > vertical lin

Re: [dev] [st] bitmap font and chscale 1< line drawing bug

2016-09-07 Thread Eric Pruitt
On Wed, Sep 07, 2016 at 05:51:49PM -0700, le...@bitmessage.ch wrote: > After moving to st-0.7, I am experiencing a bug with line drawing. When > using a bitmap font (eg terminus) and a chscale=1.2 in config.h, every > vertical line has gaps in it (ex tree or tmux). This persists for different > bi

[dev] [st] bitmap font and chscale 1< line drawing bug

2016-09-07 Thread lemon
After moving to st-0.7, I am experiencing a bug with line drawing. When using a bitmap font (eg terminus) and a chscale=1.2 in config.h, every vertical line has gaps in it (ex tree or tmux). This persists for different bitmap fonts but goes away when chscale is set to 1.0. gcc version 5.4.0 (CRU

Re: [dev] Shell style guide

2016-09-07 Thread Tiago Natel de Moura
Good compilation of best practices. That's one of the causes I created nash[1], a shell with sane defaults. 1. https://github.com/NeowayLabs/nash -- []'s i4k

Re: [dev] Shell style guide

2016-09-07 Thread Adrian Grigore
Thanks! On Thu, Sep 8, 2016 at 12:29 AM, Evan Gates wrote: > On Wed, Sep 7, 2016 at 2:11 PM, Adrian Grigore > wrote: >> Rendering was just an example, I doubt a shell script would be rendering. >> >> Example of camelCase I find ok is here: >> https://raw.githubusercontent.com/adriangrigore/boots

Re: [dev] Shell style guide

2016-09-07 Thread Evan Gates
On Wed, Sep 7, 2016 at 2:11 PM, Adrian Grigore wrote: > Rendering was just an example, I doubt a shell script would be rendering. > > Example of camelCase I find ok is here: > https://raw.githubusercontent.com/adriangrigore/bootstrap/master/bootstrap > > Be free to critique the script, but note th

Re: [dev] Shell style guide

2016-09-07 Thread Adrian Grigore
Rendering was just an example, I doubt a shell script would be rendering. Example of camelCase I find ok is here: https://raw.githubusercontent.com/adriangrigore/bootstrap/master/bootstrap Be free to critique the script, but note that I'm new to the whole UNIX/C scene so learning as I go (if I di

Re: [dev] Shell style guide

2016-09-07 Thread Charlie Kester
On Wed 07 Sep 2016 at 11:43:48 PDT Adrian Grigore wrote: Tbh, I'm nor a big fan of camelCase either, but when dealing with names composed of multiple words, it looks cleaner to me. renderimage vs renderImage It's mostly a matter of taste. But as someone whose tastes were formed by the naming

Re: [dev] Shell style guide

2016-09-07 Thread Adrian Grigore
Tbh, I'm nor a big fan of camelCase either, but when dealing with names composed of multiple words, it looks cleaner to me. renderimage vs renderImage On Wed, Sep 7, 2016 at 8:21 PM, Adrian Grigore wrote: > Tbh, I'm nor a big fan of camelCase either, but when dealing with names > composed of mul

Re: [dev] Shell style guide

2016-09-07 Thread Antenore Gatta
On Tue, 6 Sep 2016 11:35:35 -0700 Evan Gates wrote: > suckless.org projects have traditionally been small amounts of pure C. > The code tends towards simplicity and correctness. I value this and > have learned much over the past years from reading and contributing to > various projects. > > The

Re: [dev] Shell style guide

2016-09-07 Thread Antenore Gatta
On Wed, 7 Sep 2016 03:23:55 +0300 Adrian Grigore wrote: > What do you think of camelCase names for functions/variables? For me it's important being consistent, at least on a project level (across projects would be the best). I personally dislike camelCase but are good to save columns. -- ---

Re: [dev] Shell style guide

2016-09-07 Thread Greg Reagle
On Tue, Sep 6, 2016, at 08:23 PM, Adrian Grigore wrote: > What do you think of camelCase names for functions/variables? Fine with me. I don't have a_strong_preference forEitherStyle.