Re: [dev] [bug] slock gets red before submitting pass

2016-01-27 Thread David Phillips
On Wed, Jan 27, 2016 at 11:31:04PM +0100, FRIGN wrote: > On Thu, 28 Jan 2016 11:26:48 +1300 > David Phillips wrote: > > Hey David, > > > You have reminded me, however, that one regret I have since implementing > > this behaviour is that pressing a modifier key (especially the shift key) > > will

[dev] [PATCH 2/2] diff: changes edits are grouped automatically since we do not recognise substitution

2016-01-27 Thread maandree
Signed-off-by: Mattias Andrée --- diff.c | 50 +++--- 1 file changed, 15 insertions(+), 35 deletions(-) diff --git a/diff.c b/diff.c index 27ad8cf..cd0166c 100644 --- a/diff.c +++ b/diff.c @@ -107,9 +107,9 @@ diff2(char **a, char **b, size_t an, size_t

[dev] [PATCH 1/2] diff: remove printf-macro, fshut reports the potential error

2016-01-27 Thread maandree
Signed-off-by: Mattias Andrée --- diff.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/diff.c b/diff.c index b6da7b9..27ad8cf 100644 --- a/diff.c +++ b/diff.c @@ -10,8 +10,6 @@ #define END_OF_PATH 127 -#define printf(...) do {if (printf(__VA_ARGS__) < 0) perror("printf"), exit(EXI

Re: [dev] [bug] slock gets red before submitting pass

2016-01-27 Thread FRIGN
On Thu, 28 Jan 2016 11:26:48 +1300 David Phillips wrote: Hey David, > You have reminded me, however, that one regret I have since implementing > this behaviour is that pressing a modifier key (especially the shift key) > will turn the screen red, since a keypress has occurred and the password >

Re: [dev] [bug] slock gets red before submitting pass

2016-01-27 Thread David Phillips
On Wed, Jan 27, 2016 at 05:16:55PM +0100, FRIGN wrote: > On Wed, 27 Jan 2016 13:58:56 -0200 > Brad Luther wrote: > > Hey Brad, > > > I think I found a bug on slock. > > No this is not a bug. > > > If you're typing your password and gets a char wrong, you go and > > delete the char, then contin

Re: [dev] [sbase] diff

2016-01-27 Thread Mattias Andrée
Nice, I did not know about that. I have removed the macro in my branch, I will submitted when other suggestions have been implemented, assuming any are suggested. Perhaps I should describe how the program works (although it is very simple.) The documents are compared just like of they were words,

Re: [dev] [sbase] diff

2016-01-27 Thread FRIGN
On Wed, 27 Jan 2016 20:18:17 +0100 Mattias Andrée wrote: Hey Mattias, thanks for your patch. I haven't looked at it in-depth, but would like to advise you instead of using this macro-beast: > +#define printf(...) do {if (printf(__VA_ARGS__) < 0) perror("printf"), > exit(EXIT_FAILURE); } whil

[dev] [PATCH] diff: optimisations

2016-01-27 Thread maandree
Signed-off-by: Mattias Andrée --- diff.c | 48 1 file changed, 20 insertions(+), 28 deletions(-) diff --git a/diff.c b/diff.c index 21f9849..b6da7b9 100644 --- a/diff.c +++ b/diff.c @@ -4,6 +4,7 @@ #include #include #include +#include #i

Re: [dev] [bug] slock gets red before submitting pass

2016-01-27 Thread Markus Teich
Brad Luther wrote: > But if the behavior for Markus is different, then his slock is bugged :) Heyho Brad, nope, I just have the failonclear set to false in config.h. Then the empty input state only turns red after a failed attempt. Otherwise it always is red except right after starting slock. And

Re: [dev] [bug] slock gets red before submitting pass

2016-01-27 Thread FRIGN
On Wed, 27 Jan 2016 19:28:37 -0200 Brad Luther wrote: Hey Brad, > So the screen: > --- turns blue when any key is pressed > --- turns red when a failed password is entered OR an entire buffer is deleted > Following this logic, then it really isn't a bug. you can describe it like this: The scree

Re: [dev] [bug] slock gets red before submitting pass

2016-01-27 Thread Brad Luther
But if the behavior for Markus is different, then his slock is bugged :) I am on git HEAD, yes. Try updating and see if that fixes it. Thanks. On Wed, Jan 27, 2016 at 7:28 PM, Brad Luther wrote: > So the screen: > --- turns blue when any key is pressed > --- turns red when a failed password is e

Re: [dev] [bug] slock gets red before submitting pass

2016-01-27 Thread Brad Luther
So the screen: --- turns blue when any key is pressed --- turns red when a failed password is entered OR an entire buffer is deleted Following this logic, then it really isn't a bug. Thanks. On Wed, Jan 27, 2016 at 2:16 PM, FRIGN wrote: > On Wed, 27 Jan 2016 13:58:56 -0200 > Brad Luther wrote

[dev] [sbase] diff

2016-01-27 Thread Mattias Andrée
The beginning of an implementation of diff. It only does the bare essentials, and it is not usable implemention of diff yet. Signed-off-by: Mattias Andrée --- LICENSE | 1 + Makefile | 1 + diff.c | 207 +++ 3 files changed, 209

Re: [dev] [bug] slock gets red before submitting pass

2016-01-27 Thread FRIGN
On Wed, 27 Jan 2016 13:58:56 -0200 Brad Luther wrote: Hey Brad, > I think I found a bug on slock. No this is not a bug. > If you're typing your password and gets a char wrong, you go and > delete the char, then continue to type the pass and 'enter' to unlock > the screen. All good, screen is b

Re: [dev] [bug] slock gets red before submitting pass

2016-01-27 Thread Markus Teich
Brad Luther wrote: > If you're typing your password and gets a char wrong, you go and delete the > char, then continue to type the pass and 'enter' to unlock the screen. All > good, screen is blue all the time. Unless... you get the first char wrong. If > you mistype the first char of your passwor

[dev] [bug] slock gets red before submitting pass

2016-01-27 Thread Brad Luther
Hello. I think I found a bug on slock. If you're typing your password and gets a char wrong, you go and delete the char, then continue to type the pass and 'enter' to unlock the screen. All good, screen is blue all the time. Unless... you get the first char wrong. If you mistype the first char of