Re: [dev] Re: Bug in join.c

2015-12-14 Thread Mattias Andrée
On Mon, 14 Dec 2015 13:07:48 -0500 Random832 wrote: > Mattias Andrée writes: > > I think this patch should be included. But I don't see > > how it is of substance. It will never occur with two's > > complement or ones' complement. Only, signed magnitude > > representatiion. Any sensible C compil

[dev] Re: st: keys and infocmp

2015-12-14 Thread Random832
Greg Reagle writes: > Hello. If there are any man pages or articles or FAQs about this topic > that would be good to read, please refer to them. > > Running Xubuntu 12.04 and the latest st on a ThinkPad laptop, these are > the results I get, correlated with the results of infocmp. I got the > o

Re: [dev] st: keys and infocmp

2015-12-14 Thread Greg Reagle
On 12/14/2015 01:05 PM, Greg Reagle wrote: Running Xubuntu 12.04 and the latest st on a ThinkPad laptop, these are Sorry, that's Xubuntu 14.04.

[dev] Re: Bug in join.c

2015-12-14 Thread Random832
Mattias Andrée writes: > I think this patch should be included. But I don't see > how it is of substance. It will never occur with two's > complement or ones' complement. Only, signed magnitude > representatiion. Any sensible C compiler for POSIX > systems will only use two's complement; otherwise

[dev] st: keys and infocmp

2015-12-14 Thread Greg Reagle
Hello. If there are any man pages or articles or FAQs about this topic that would be good to read, please refer to them. Running Xubuntu 12.04 and the latest st on a ThinkPad laptop, these are the results I get, correlated with the results of infocmp. I got the output from the keys by running c

Re: [dev] Bug in join.c

2015-12-14 Thread Mattias Andrée
On Mon, 14 Dec 2015 12:49:04 -0500 Random832 wrote: > I was going through sbase checking with -Wall -Wextra > -pedantic -Werror, and among a bunch of noise errors > relating to signed/unsigned comparisons, I found one with > actual substance: the result of getline is being > converted to size_t b

[dev] Bug in join.c

2015-12-14 Thread Random832
I was going through sbase checking with -Wall -Wextra -pedantic -Werror, and among a bunch of noise errors relating to signed/unsigned comparisons, I found one with actual substance: the result of getline is being converted to size_t before comparing to -1 to check for error. diff --git a/join.c b