Re: [dev] dwm: drw_draw does too much

2015-11-28 Thread Markus Teich
David Kennedy wrote: > However, this new function still needs to know three things: > > 1. The font to use > 2. The text to be rendered > 3. The length in bytes of the utf8 encoded string > > No. 2 is easy. No. 1 and 3 are all tangled up in drw_text. So, before calls to > drw_text and TEXTW can b

RE: [dev] dwm: drw_draw does too much

2015-11-28 Thread David Kennedy
> I agree, but keep in mind drw_text also handles fallback fonts, so it > calculates the width for it if needed. My point exactly. Unwinding this function is incredibly difficult. All I've managed so far (aside from fixing other patches) is to simplify drw_font_getexts. Instead of that, there is

Re: [dev] dwm: drw_draw does too much

2015-11-28 Thread Hiltjo Posthuma
On Fri, Nov 27, 2015 at 8:18 PM, David Kennedy wrote: > ... snip ... > > In other words, before calling drw_text (which needs to know the width of the > thing to be drawn) on line 739, we call drw_text with no parameters on line > 733 to get the width of the thing to be drawn. > > I think it wou