Re: [dev] [PATCH] [slock] rework setting window color

2015-05-11 Thread Markus Teich
Dimitris Papastamos wrote: > On Fri, May 08, 2015 at 06:13:21PM +0200, Markus Teich wrote: > > + color = len ? INPUT : (failure || failonclear ? FAILED > > : INIT); > > I would split this condition out. Looks good for the rest. Heyho, I think it is pretty readable for a neste

Re: [dev] [PATCH] [slock] rework setting window color

2015-05-11 Thread Dimitris Papastamos
On Fri, May 08, 2015 at 06:13:21PM +0200, Markus Teich wrote: > + color = len ? INPUT : (failure || failonclear ? FAILED > : INIT); I would split this condition out. Looks good for the rest.

Re: [dev] [dwm] [PATCH] support _NET_SUPPORTING_WM_CHECK

2015-05-11 Thread Jason Woofenden
On 2015-05-11 09:47AM, Martti Kühne wrote: > Is this one for the wiki or mainline? I don't think it would get used (much) on the wiki, since it doesn't create a user-visible feature. My hope is that it'll make some software behave better under dwm, though I only did enough research to find out th

Re: [dev] [dwm] [PATCH] support _NET_SUPPORTING_WM_CHECK

2015-05-11 Thread Martti Kühne
On Wed, May 6, 2015 at 10:25 PM, Jason Woofenden wrote: > As documented here: > http://standards.freedesktop.org/wm-spec/wm-spec-1.3.html#idm140130317670464 > --- > > I developed this in the hopes that it would fix issues with feh running > fullscreen. It didn't help with that (feh using the inna