Re: [dev] [libsl] [PATCH 3/4] drw: fixup drw_rect function

Eric Pruitt wrote: > You changed brace styles in this chunk. Heyho, yest, this is intended. Since I will be going over all the code in libsl, my plan is to adapt it to the guide alongside the non-style-changes, so people won't get confused as much with the git history. If the maintainer doesn't l

Re: [dev] [libsl] [PATCH 3/4] drw: fixup drw_rect function

On Tue, Apr 21, 2015 at 11:37:49PM +0200, Markus Teich wrote: > -drw_rect(Drw *drw, int x, int y, unsigned int w, unsigned int h, int filled, > int empty, int invert) { > - int dx; > - > - if(!drw || !drw->fontcount || !drw->scheme) > +drw_rect(Drw *drw, int x, int y, unsigned int w, unsig

Re: [dev] [surf] [PATCH] Simplify eval arg handling

Actually, scratch this, I have no idea why I had this in my queue. Sorry for the noise. Cheers Jochen signature.asc Description: Digital signature

Re: [dev] [surf] [PATCH] Simplify eval arg handling

This is making my brain hurt, but I'm pretty sure this change dereferences arg->v one fewer times. Does arg->v point directly to a string, or to a pointer to a string? -- Jason On 2015-04-22 05:30PM, Jochen Sprickerhof wrote: > --- > surf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(

Re: [dev] [surf] [PATCH] Make strictssl Bool

* Eric Pruitt [2015-04-22 08:50]: > On Wed, Apr 22, 2015 at 05:34:45PM +0200, Jochen Sprickerhof wrote: > > -static char *strictssl = FALSE; /* Refuse untrusted SSL connections */ > > +static Bool strictssl = FALSE; /* Refuse untrusted SSL connections */ > > If you're changing the type

Re: [dev] [surf] [PATCH] Make strictssl Bool

On Wed, Apr 22, 2015 at 05:34:45PM +0200, Jochen Sprickerhof wrote: > -static char *strictssl = FALSE; /* Refuse untrusted SSL connections */ > +static Bool strictssl = FALSE; /* Refuse untrusted SSL connections */ If you're changing the type, you should probably replace "FALSE" with "f

[dev] [surf] [PATCH] Make strictssl Bool

--- config.def.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config.def.h b/config.def.h index a1ab211..1eb9566 100644 --- a/config.def.h +++ b/config.def.h @@ -19,7 +19,7 @@ static char *cookiefile = "~/.surf/cookies.txt"; static char *cookiepolicies = "Aa@"; /* A: ac

[dev] [surf] [PATCH] Simplify eval arg handling

--- surf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/surf.c b/surf.c index 87c10ef..75fa5db 100644 --- a/surf.c +++ b/surf.c @@ -1314,7 +1314,7 @@ static void eval(Client *c, const Arg *arg) { WebKitWebFrame *frame = webkit_web_view_get_main_frame(c->view);

[dev] [st] [PATCH] Fix sigchld

Only wait for termination of the shell. --- st.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/st.c b/st.c index 0204b2e..1615609 100644 --- a/st.c +++ b/st.c @@ -1245,10 +1245,14 @@ execsh(void) { void sigchld(int a) { int stat, ret; + pid_t p; -

Re: [dev] [st PATCH 1/3] xloadcols: remove cp variable

> On Apr 22, 2015, at 1:05 AM, Roberto E. Vargas Caballero > wrote: > > mihail.zenkov: >> IMHO in this particular case index version much better for reading and >> understanding. > > So, you think that is more understable: > > XftColorFree(xw.dpy, xw.vis, xw.cmap, &dc.col[i]); I believ

[dev] [st] [PATCH] Clarify calculation precedence for '&' and '?'

Signed-off-by: Daniel Martí --- st.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/st.c b/st.c index d5bf8f1..57cb052 100644 --- a/st.c +++ b/st.c @@ -859,9 +859,9 @@ mousereport(XEvent *e) { } if(!IS_SET(MODE_MOUSEX10)) { - button += (s

[dev] [st] [PATCH] Use %u for uint

Signed-off-by: Daniel Martí --- st.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/st.c b/st.c index 0204b2e..d5bf8f1 100644 --- a/st.c +++ b/st.c @@ -1746,7 +1746,7 @@ tdefcolor(int *attr, int *npar, int l) { b = attr[*npar + 4]; *npar += 4;

[dev] [st] [PATCH] len assignment is never used

Signed-off-by: Daniel Martí --- st.c | 1 - 1 file changed, 1 deletion(-) diff --git a/st.c b/st.c index 57cb052..6f236ec 100644 --- a/st.c +++ b/st.c @@ -864,7 +864,6 @@ mousereport(XEvent *e) { + ((state & ControlMask) ? 16 : 0); } - len = 0; if(

Re: [dev] [st] [PATCH] Replace close and dup with dup2.

On Wed, Apr 22, 2015 at 09:28:10AM +0200, Roberto E. Vargas Caballero wrote: > We don't have any opportunity of having a race condition, so there is > no reason to use dup2 instead of dup. So I wil keep the current > version. Matter of style maybe. It's still annoying to have noise in the build.

Re: [dev] [st] [PATCH] Optimize memory footprint of line buffers

> Another solution would be to allow people to typedef the color index > type used by Glyph in config.h, and move the definitions for Glyph, > TCursor and Term below where config.h is included in st.c? > > That way, it makes it easy to customize it for a low memory profile. Here's another patch t

Re: [dev] [st utf8 3/4] Change internal character representation.

On Tue, Apr 21, 2015 at 09:28:38PM +, noname wrote: > typedef struct { > - char c[UTF_SIZ]; /* character code */ > - ushort mode; /* attribute flags */ > - uint32_t fg; /* foreground */ > - uint32_t bg; /* background */ > + long u; /* character code *

Re: [dev] [st] [PATCH] Optimize memory footprint of line buffers

On Tue, Apr 21, 2015 at 07:03:57PM +0200, Roberto E. Vargas Caballero wrote: Sorry, I didn't realize it was possible to use colors above 256, neglected to see it in config.def.h. My bad. > Maybe, a solution can be modify colorname to: > > 63 static const char *colorname[256] = { > > and fo

Re: [dev] [st] [PATCH] Replace close and dup with dup2.

We don't have any opportunity of having a race condition, so there is no reason to use dup2 instead of dup. So I wil keep the current version.

Re: [dev] [st PATCH 1/3] xloadcols: remove cp variable

mihail.zenkov: > IMHO in this particular case index version much better for reading and > understanding. So, you think that is more understable: XftColorFree(xw.dpy, xw.vis, xw.cmap, &dc.col[i]); than XftColorFree(xw.dpy, xw.vis, xw.cmap, cp); Sorry, but I don't agree. The for