Applied. Thanks.
Hi,
> - Color *cp;
>
> if(loaded) {
> - for (cp = dc.col; cp < dc.col + LEN(dc.col); ++cp)
> - XftColorFree(xw.dpy, xw.vis, xw.cmap, cp);
> + for (i = 0; i < LEN(dc.col); i++)
> + XftColorFree(xw.dpy, xw.vis, xw.cmap, &dc
Applied, thanks.
On Sun, Apr 19, 2015 at 12:28:05PM -0400, Wolfgang Corcoran-Mathe wrote:
> I've added a manpage and applied all of FRIGN and Hiltjo's style
> changes.
Thanks, applied!
> same as uint_fast32_t. uint_least32_t is 4 bytes almost always. int is
> not an option as it may be 2 bytes long.
Not in Posix. Posix forces int to be at least 32 bits. Although the terminal
emulation part is mostly portable, so I think is better don't relay on this
point.
Regards,
On Mon, Apr 20, 2015 at 09:53:38AM +0200, Martti Kühne wrote:
> Are we discussing something for which #include does not
> leave any questions open? int32_t, int_fast32_t or int_least32_t would
> probably be the solution here?
We probably want to replace long with uint_least32_t for character
repr
Are we discussing something for which #include does not
leave any questions open? int32_t, int_fast32_t or int_least32_t would
probably be the solution here?
Is there any problem with using stdint.h in general that I'm not aware of?
cheers!
mar77i
> I do not think changing 'long' to 'wchar_t' is a good idea because
> 'wchar_t' has undefined size and long is at least 32-bit long.
Yeah ,it is true. And not only this, the ISO interface in incredible
wrong, and it makes impossible some of the operations we do in
st, so I already discarded to us
> - memset(term.trantbl, sizeof(term.trantbl), CS_USA);
> + memset(term.trantbl, CS_USA, sizeof(term.trantbl));
Uppss, good catch. Applied.
Applied, thanks.
Applied, thanks.
Applied with minor changes in the comments.
I will not apply this patch. To use int or bool is something that depend
of the taste of everyone, and in st both are admited (mainly because
X uses bool data type, because in other case I think the style guide
should forbid them). There are some cases where it is better to use int
instead of bool,
> - drawtimeout.tv_nsec = (1000/xfps) * 1E6;
> + drawtimeout.tv_nsec = 10 / xfps;
I like the patch, but not the comment. In the original code there is no
floating point calculation at all; the division is integer, but is true
that there is accuary lost. Maybe the be
14 matches
Mail list logo
