Could someone with commit privileges please review the dmenu patches I
sent within the last week? Links to the archives:
- http://lists.suckless.org/dev/0109/26286.html
- http://lists.suckless.org/dev/0109/26290.html
- http://lists.suckless.org/dev/0109/26299.html
Eric
Dimitris,
Quoth Dimitris Papastamos on Fri, Apr 17 2015 13:50 +0100:
Excellent work!
High praise. Thanks to you and the other sbase devs for setting a
great example. I've learned a lot from your work.
Please provide a manpage and document any implementation details
there. Also fix any outsta
Hiltjo,
Great suggestions. Thank you for taking the time to look through the
code and to write all of that.
Quoth Hiltjo Posthuma on Fri, Apr 17 2015 11:33 +0200:
- To makeline() you can add an argument of the line and use the
returned value from getline(). This way strlen is not needed.
getlin
FRIGN,
Thanks very much for your comments and praise! I'll make the changes
you've suggested.
Quoth FRIGN on Fri, Apr 17 2015 11:14 +0200:
- At file opening in main, use else if rather than else { if }
I actually stole the fopen code from sbase's cmp under the
assumption that this was the pre
On Thu, Apr 16, 2015 at 06:20:40PM -0400, Wolfgang Corcoran-Mathe wrote:
> Hello,
>
> I have made an attempt at join(1). I hope it is worth a look.
>
> See NOTES for some points on which this implementation differs from
> other joins. The handling of -a | -v when used with -o is an issue.
Excell
On Fri, Apr 17, 2015 at 12:20 AM, Wolfgang Corcoran-Mathe
wrote:
> Hello,
>
> I have made an attempt at join(1). I hope it is worth a look.
>
> See NOTES for some points on which this implementation differs from
> other joins. The handling of -a | -v when used with -o is an issue.
>
> Comments are
On Thu, 16 Apr 2015 18:20:40 -0400
Wolfgang Corcoran-Mathe wrote:
Hey Wolfgang,
> I have made an attempt at join(1). I hope it is worth a look.
>
> See NOTES for some points on which this implementation differs from
> other joins. The handling of -a | -v when used with -o is an issue.
>
> Comm
