Re: [dev] [st] [PATCH] Correct shift amount on MODE_INSERT in tputc()

2015-01-30 Thread Rian Hunter
On Fri, Jan 30, 2015 at 08:14:59PM +0100, FRIGN wrote: > On Fri, 30 Jan 2015 09:53:41 -0800 > Rian Hunter wrote: > > I'd really appreciate it if there were a longer comment detailing how > > word wrap, auto newline insertion, and overflow handling are supposed to be > > handled in st. > > Hehe, a

Re: [dev] [st] [PATCH] Correct shift amount on MODE_INSERT in tputc()

2015-01-30 Thread FRIGN
On Fri, 30 Jan 2015 09:53:41 -0800 Rian Hunter wrote: > Thanks for the feedback everyone. Glad to contribute, st is literally the only > sane freely available graphical terminal emulator in existence. Agreed. > The original code still looks a bit fishy to me. It looks like there could be > a s

Re: [dev] [st] [PATCH] Correct shift amount on MODE_INSERT in tputc()

2015-01-30 Thread FRIGN
On Fri, 30 Jan 2015 09:25:51 + Dimitris Papastamos wrote: > Inlining the patch has the added benefit that you can easily inline > review it. It seems more reasonable. Inline review is also possible with attached patches. I know of at least 3 clients (including sylpheed, which I'm using), wh

Re: [dev] [st] [PATCH] Correct shift amount on MODE_INSERT in tputc()

2015-01-30 Thread Rian Hunter
On Fri, Jan 30, 2015 at 12:19:18PM +0100, k...@shike2.com wrote: > > On Fri, Jan 30, 2015 at 12:41 AM, FRIGN wrote: > >> On Thu, 29 Jan 2015 15:08:39 -0800 > >> Rian Hunter wrote: > >> > >>> When MODE_INSERT is set we'd shift characters on the same > >>> line forward before inserting our characte

Re: [dev] [st] [PATCH] Correct shift amount on MODE_INSERT in tputc()

2015-01-30 Thread k0ga
> On Fri, Jan 30, 2015 at 12:41 AM, FRIGN wrote: >> On Thu, 29 Jan 2015 15:08:39 -0800 >> Rian Hunter wrote: >> >>> When MODE_INSERT is set we'd shift characters on the same >>> line forward before inserting our character in tputc(). >>> This did not account for wide characters where width != 1.

Re: [dev] [st] [PATCH] Correct shift amount on MODE_INSERT in tputc()

2015-01-30 Thread Dimitris Papastamos
On Fri, Jan 30, 2015 at 10:22:08AM +0100, Silvan Jegen wrote: > > However, next time, please attach the patches > > instead of inserting them so people with insane > > mail clients can easily access them without hassle. > > I don't think we should encourage this behavior on this list. > Shouldn't

Re: [dev] [st] [PATCH] Correct shift amount on MODE_INSERT in tputc()

2015-01-30 Thread Silvan Jegen
On Fri, Jan 30, 2015 at 12:41 AM, FRIGN wrote: > On Thu, 29 Jan 2015 15:08:39 -0800 > Rian Hunter wrote: > >> When MODE_INSERT is set we'd shift characters on the same >> line forward before inserting our character in tputc(). >> This did not account for wide characters where width != 1. >> This