Re: [dev] [PATCH] [sbase] Use utflen in cols(1)

2014-12-05 Thread Robert Ransom
On 12/5/14, Brandon Mulcahy wrote: > On Fri, Dec 05, 2014 at 10:39:49PM +, Dimitris Papastamos wrote: >> On Fri, Dec 05, 2014 at 02:18:03PM -0800, Robert Ransom wrote: >> > On 12/5/14, Brandon Mulcahy wrote: >> > > -It does not handle non-ASCII UTF-8 runes >> > > -or TAB characters correctly.

Re: [dev] [PATCH] [sbase] Use utflen in cols(1)

2014-12-05 Thread Brandon Mulcahy
On Fri, Dec 05, 2014 at 10:39:49PM +, Dimitris Papastamos wrote: > On Fri, Dec 05, 2014 at 02:18:03PM -0800, Robert Ransom wrote: > > On 12/5/14, Brandon Mulcahy wrote: > > > -It does not handle non-ASCII UTF-8 runes > > > -or TAB characters correctly. > > > +It does not handle TAB characters

Re: [dev] [PATCH] [sbase] Use utflen in cols(1)

2014-12-05 Thread Brandon Mulcahy
On Fri, Dec 05, 2014 at 10:39:49PM +, Dimitris Papastamos wrote: > On Fri, Dec 05, 2014 at 02:18:03PM -0800, Robert Ransom wrote: > > On 12/5/14, Brandon Mulcahy wrote: > > > -It does not handle non-ASCII UTF-8 runes > > > -or TAB characters correctly. > > > +It does not handle TAB characters

Re: [dev] [PATCH] [sbase] Use utflen in cols(1)

2014-12-05 Thread Dimitris Papastamos
On Fri, Dec 05, 2014 at 02:18:03PM -0800, Robert Ransom wrote: > On 12/5/14, Brandon Mulcahy wrote: > > --- > > cols.1 | 3 +-- > > cols.c | 14 +- > > 2 files changed, 10 insertions(+), 7 deletions(-) > > > > diff --git a/cols.1 b/cols.1 > > index 8f15cb3..5383e47 100644 > > --- a/c

Re: [dev] [PATCH] [sbase] Use utflen in cols(1)

2014-12-05 Thread Robert Ransom
On 12/5/14, Brandon Mulcahy wrote: > --- > cols.1 | 3 +-- > cols.c | 14 +- > 2 files changed, 10 insertions(+), 7 deletions(-) > > diff --git a/cols.1 b/cols.1 > index 8f15cb3..5383e47 100644 > --- a/cols.1 > +++ b/cols.1 > @@ -27,8 +27,7 @@ This implementation of > .B cols > ass

Re: [dev] [PATCH] [sbase] Use utflen in cols(1)

2014-12-05 Thread Dimitris Papastamos
Thanks, applied!

[dev] [PATCH] [sbase] Use utflen in cols(1)

2014-12-05 Thread Brandon Mulcahy
--- cols.1 | 3 +-- cols.c | 14 +- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/cols.1 b/cols.1 index 8f15cb3..5383e47 100644 --- a/cols.1 +++ b/cols.1 @@ -27,8 +27,7 @@ This implementation of .B cols assumes that every byte is a character which takes up one col

[dev] [slock] [PATCH] Move program configuration to config.def.h (previous mail did not arrive)

2014-12-05 Thread Dimitris Papastamos
>From 7769d9917d21277e0aabbb849995a4626dbdf319 Mon Sep 17 00:00:00 2001 From: sin Date: Fri, 5 Dec 2014 12:13:49 + Subject: [PATCH] Move program configuration to config.def.h --- Makefile | 8 ++-- config.def.h | 2 ++ config.mk| 2 +- slock.c | 2 ++ 4 files changed, 11 in

[dev] [slock] [PATCH] Move program configuration to config.def.h

2014-12-05 Thread Dimitris Papastamos
>From 7769d9917d21277e0aabbb849995a4626dbdf319 Mon Sep 17 00:00:00 2001 From: sin Date: Fri, 5 Dec 2014 12:13:49 + Subject: [PATCH] Move program configuration to config.def.h --- Makefile | 8 ++-- config.def.h | 2 ++ config.mk| 2 +- slock.c | 2 ++ 4 files changed, 11 in

Re: [dev] Decouple build system from program settings

2014-12-05 Thread Anselm R Garbe
On 5 December 2014 at 12:12, FRIGN wrote: > So just for the sake of consistency, given the two colours are a > program property, it should be in config.h (even if it is only 2 > lines, who cares? There's not going to be a binary change and especially > no difference after the CPP-vomit). Exactly.

Re: [dev] Decouple build system from program settings

2014-12-05 Thread FRIGN
On Fri, 5 Dec 2014 12:06:05 +0100 "Dmitrij D. Czarkoff" wrote: > So I expect people to read config.mk. It would be my second direction after config.h (if you are used to the suckless style) > This was my initial thought, but config.def.h with 2 lines doesn't seem > sane. Although it is saner t

Re: [dev] Decouple build system from program settings

2014-12-05 Thread Dmitrij D. Czarkoff
FRIGN said: > This is just wrong. Or do you expect people to dig > in the code to change the colours? No. Dmitrij D. Czarkoff said: > diff --git a/config.mk b/config.mk ... > # On *BSD remove -DHAVE_SHADOW_H from CPPFLAGS and add -DHAVE_BSD_AUTH > # On OpenBSD and Darwin remove -lcrypt from LIB

Re: [dev] Decouple build system from program settings

2014-12-05 Thread FRIGN
On Fri, 5 Dec 2014 11:54:00 +0100 "Dmitrij D. Czarkoff" wrote: > diff --git a/slock.c b/slock.c > index d281965..1ddc35b 100644 > --- a/slock.c > +++ b/slock.c > @@ -1,4 +1,3 @@ > - > /* See LICENSE file for license details. */ > #define _XOPEN_SOURCE 500 > #if HAVE_SHADOW_H > @@ -23,6 +22,9 @

[dev]

2014-12-05 Thread Dmitrij D. Czarkoff
>From 8cbd13d15492fb428b08fb2e298be2cada224e07 Mon Sep 17 00:00:00 2001 From: "Dmitrij D. Czarkoff" Date: Fri, 5 Dec 2014 11:05:28 +0100 Subject: [PATCH 1/2] Remove .hgtags --- .hgtags | 10 -- 1 file changed, 10 deletions(-) delete mode 100644 .hgtags diff --git a/.hgtags b/.hgtags de

[dev]

2014-12-05 Thread Dmitrij D. Czarkoff
>From eb5d7870f800a201b23c5e96c4a2b2fac9848b80 Mon Sep 17 00:00:00 2001 From: "Dmitrij D. Czarkoff" Date: Fri, 5 Dec 2014 11:08:12 +0100 Subject: [PATCH 2/2] Decouple build system from program settings --- config.mk | 3 ++- slock.c | 4 +++- 2 files changed, 5 insertions(+), 2 deletions(-) d