Re: [dev] [st] will global-less changes be wanted upstream?

2014-08-16 Thread Steven Degutis
> What is the point? > One obvious cons is that it will bloat the code, make it less readable. First of all, I would not agree that it would bloat the code or make it less readable. In fact I think it will increase readability, as object structure and hierarchy will be more readily apparent. Plus,

Re: [dev] [st] will global-less changes be wanted upstream?

2014-08-16 Thread Steven Degutis
> What were the changes that were specific to the port to OS X? This > particular change doesn't seem related to porting. You're right, this change isn't related to the port. As I'm doing my port, I'm changing existing code structure as I go along to make porting it a little easier (since AppKit

Re: [dev] [st] will global-less changes be wanted upstream?

2014-08-16 Thread Dimitris Papastamos
On Sat, Aug 16, 2014 at 04:51:27PM -0500, Steven Degutis wrote: > I'm making progress on my port of st to OS X, and one of the changes > I'm making is to get rid of globals, turning most of them into fields > on Term, and making all the functions that use them take Term* as an > argument. It's a ve

Re: [dev] [st] will global-less changes be wanted upstream?

2014-08-16 Thread q
On Sat, Aug 16, 2014 at 04:51:27PM -0500, Steven Degutis wrote: > I'm making progress on my port of st to OS X, and one of the changes > I'm making is to get rid of globals, turning most of them into fields > on Term, and making all the functions that use them take Term* as an > argument. It's a ve

[dev] [st] will global-less changes be wanted upstream?

2014-08-16 Thread Steven Degutis
I'm making progress on my port of st to OS X, and one of the changes I'm making is to get rid of globals, turning most of them into fields on Term, and making all the functions that use them take Term* as an argument. It's a very minimal change, still very compatible with the original st. Are these