Re: [dev] [st] [PATCH] Explicit cast in CEIL macro

2014-06-21 Thread FRIGN
On Sat, 21 Jun 2014 19:08:49 +0200 FRIGN wrote: > Just pull in math.h ffs! > It's part of the standard library, so basically nothing is lost both > for dynamically linked programs and statically linked ones. Okay, so I pulled it in using ceilf and the binary-size changed: 180514 Bytes -> 180581

Re: [dev] [st] [PATCH] Explicit cast in CEIL macro

2014-06-21 Thread FRIGN
On Sat, 21 Jun 2014 11:59:27 -0500 Eric Pruitt wrote: > I have no problem with it, and that's what I would normally do, but > there seems to be a lot of obsession of SLOC numbers in suckless > projects, so I didn't want to pull in the math library for a single > function. Just pull in math.h ffs

Re: [dev] [st] [PATCH] Explicit cast in CEIL macro

2014-06-21 Thread Eric Pruitt
On Sat, Jun 21, 2014 at 04:56:14PM +0200, Jakob Kramer wrote: > What's the problem with ceil(3)? It is C89. I have no problem with it, and that's what I would normally do, but there seems to be a lot of obsession of SLOC numbers in suckless projects, so I didn't want to pull in the math library f

Re: [dev] [st] [PATCH] Explicit cast in CEIL macro

2014-06-21 Thread Jakob Kramer
Am 21.06.2014 16:05, schrieb Eric Pruitt: On Sat, Jun 21, 2014 at 09:58:16AM +0200, Roberto E. Vargas Caballero wrote: I do not understand why CEIL should return an integer value. From my point of view it should return a value of any type that is the ceil of the parameter. Can you explain a bit

Re: [dev] [st] [PATCH] Explicit cast in CEIL macro

2014-06-21 Thread Eric Pruitt
On Sat, Jun 21, 2014 at 09:58:16AM +0200, Roberto E. Vargas Caballero wrote: > I do not understand why CEIL should return an integer value. From my > point of view it should return a value of any type that is the ceil > of the parameter. Can you explain a bit better why you think result > must be i

[dev] [PATCH] Remove dead code.

2014-06-21 Thread Markus Teich
If (nclients == 0), then also (c < 0 || c >= nclients), so the two lines cannot be reached. --- Heyho, from the three lines of context in the diff it may not be clear. There is an if(c < 0 || c >= nclients) { drawbar(); XSync(dpy, False); return; } in front of it. --Ma

Re: [dev] [tabbed] [PATCH] Clear urgency hint on sel == c

2014-06-21 Thread Markus Teich
Peter Hofmann wrote: > just a small patch to clear the urgency hint if sel == c. See the commit > message on how this can happen. Heyho Peter, indeed I did not catch this case when implementing the urgency patch. Looks good to me. --Markus

Re: [dev] [st] [PATCH] Fix typo in config.def.h

2014-06-21 Thread Roberto E. Vargas Caballero
> While you’re at it, line 140: > > - * Be careful with the order of the definitons because st searchs in > + * Be careful with the order of the definitions because st searches in I will apply the first patch with this addition. -- Roberto E. Vargas Caballero

Re: [dev] [st] [PATCH] update size hints on zoom

2014-06-21 Thread Roberto E. Vargas Caballero
> On font zooming (i.e. xzoom()), window size hints are not updated. This > patch does that. Applied, thanks! -- Roberto E. Vargas Caballero

Re: [dev] [st] [PATCH] Explicit cast in CEIL macro

2014-06-21 Thread Roberto E. Vargas Caballero
On Wed, Jun 18, 2014 at 09:09:19AM -0500, Eric Pruitt wrote: > This patch ads explicit casting for the result of the CEIL macro. Since > the only place it's currently used for assignments is with variables > declared as ints, this shouldn't result in any change in behaviour in > the existing code,